2022-06-01 version for pricesheets and operations API #22240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jayati-tehri Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-06 | package-2022-06(ffdda27) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
The top-level resource 'PriceSheetResultV2' does not have list by subscription operation, please add it. Location: Microsoft.Consumption/stable/2022-06-01/consumption.pricesheets.operations.json#L207 |
RPC-Get-V1-05 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Consumption/stable/2022-06-01/consumption.pricesheets.operations.json#L262 |
|
| The response of operation:'PriceSheets_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Consumption/stable/2022-06-01/consumption.pricesheets.operations.json#L38 |
||
| The response of operation:'PriceSheets_GetByBillingPeriod' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Consumption/stable/2022-06-01/consumption.pricesheets.operations.json#L101 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Consumption/stable/2022-06-01/consumption.pricesheets.operations.json#L393 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/consumption/resource-manager/readme.md tag: specification/consumption/resource-manager/readme.md#tag-package-2022-06 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi, @jayati-tehri, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @jayati-tehri your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
jayati-tehri
removed
the
WaitForARMFeedback
AzureRestAPISpecReview
added
CI-FixRequiredOnFailure
WaitForARMFeedback
|
Hi @jayati-tehri, Your PR has some issues. Please fix the CI sequentially by following the order of
|
raosuhas
reviewed
Jan 19, 2023
...urce-manager/Microsoft.Consumption/stable/2022-06-01/consumption.pricesheets.operations.json
Outdated
Show resolved
Hide resolved
raosuhas
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@msyyc , can you review the potential breaking change to python sdk? |
weidongxu-microsoft
requested changes
Feb 15, 2023
|
The operationId change looks good to me now, @weidongxu-microsoft how do you think ? |
weidongxu-microsoft
approved these changes
Feb 15, 2023
|
Personally I don't like However since this is likely only Java, I removed my change request. |
raych1
approved these changes
Feb 16, 2023
This was referenced Feb 16, 2023
mehulviby
added a commit
that referenced
this pull request
Feb 23, 2023
This reverts commit 207d396.
ArcturusZhang
pushed a commit
that referenced
this pull request
Feb 27, 2023
aviyerMSFT
pushed a commit
to aviyerMSFT/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2023
* initial commit * version update changes * update readme * fix * fixing duplicate definitions and schema names * fixing schematics error * swagger lint error fix * fixing operation response schema * removing duplicate errors * changing duplicate tags * changing duplicate operation id * operation id fix * changing opertion id * moving input file ordering --------- Co-authored-by: Mehul Yesminkumar <mehuly@microsoft.com>
aviyerMSFT
pushed a commit
to aviyerMSFT/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2023
…22240)" (Azure#22780) This reverts commit 207d396.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.