Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Publish private branch 'oravital-update--dev-security-Microsoft.Security-2022-01-01-preview' #22288

Conversation

oravital7
Copy link
Member

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@oravital7
Copy link
Member Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/10392

@openapi-workflow-bot
Copy link

Hi, @oravital7 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 24, 2023

    Swagger Validation Report

    ️❌BreakingChange: 20 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    governanceAssignments.json 2022-01-01-preview(e50b20a) 2022-01-01-preview(main)
    governanceRules.json 2022-01-01-preview(e50b20a) 2022-01-01-preview(main)
    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Security/governanceRules' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Security/governanceRules/{ruleId}' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L76:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/securityConnectors/{securityConnectorName}/providers/Microsoft.Security/governanceRules' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L195:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/securityConnectors/{securityConnectorName}/providers/Microsoft.Security/governanceRules/{ruleId}' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L240:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Security/governanceRules' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L390:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Security/governanceRules/{ruleId}' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L429:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Security/governanceRules/{ruleId}/execute' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L558:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/securityConnectors/{securityConnectorName}/providers/Microsoft.Security/governanceRules/{ruleId}/execute' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L607:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Security/governanceRules/{ruleId}/execute' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L662:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Security/governanceRules/{ruleId}/operationResults/{operationId}' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L711:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/securityConnectors/{securityConnectorName}/providers/Microsoft.Security/governanceRules/{ruleId}/operationResults/{operationId}' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L762:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Security/governanceRules/{ruleId}/operationResults/{operationId}' removed or restructured?
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L819:5
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SecurityConnectorName' removed or renamed?
    New: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L669:3
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L1195:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ManagementGroupId' removed or renamed?
    New: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L669:3
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L1195:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupName' removed or renamed?
    New: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L669:3
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L1195:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionId' removed or renamed?
    New: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L669:3
    Old: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L1195:3
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L37:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L82:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L232:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Security/preview/2022-01-01-preview/governanceRules.json#L287:5
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.0.0) new version base version
    package-composite-v3 package-composite-v3(e50b20a) package-composite-v3(main)
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/security/resource-manager/readme.md
    tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 24, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/security/armsecurity - 0.10.0
    +	Function `*ConnectorGovernanceRuleClient.NewListPager` has been removed
    +	Function `*ConnectorGovernanceRulesClient.CreateOrUpdate` has been removed
    +	Function `*ConnectorGovernanceRulesClient.Delete` has been removed
    +	Function `*ConnectorGovernanceRulesClient.Get` has been removed
    +	Function `*GovernanceRuleClient.NewListPager` has been removed
    +	Function `*GovernanceRulesClient.BeginRuleIDExecuteSingleSecurityConnector` has been removed
    +	Function `*GovernanceRulesClient.BeginRuleIDExecuteSingleSubscription` has been removed
    +	Function `*GovernanceRulesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, GovernanceRule, *GovernanceRulesClientCreateOrUpdateOptions)` to `(context.Context, string, string, GovernanceRule, *GovernanceRulesClientCreateOrUpdateOptions)`
    +	Function `*GovernanceRulesClient.Get` parameter(s) have been changed from `(context.Context, string, *GovernanceRulesClientGetOptions)` to `(context.Context, string, string, *GovernanceRulesClientGetOptions)`
    +	Function `NewConnectorGovernanceRuleClient` has been removed
    +	Function `NewConnectorGovernanceRulesClient` has been removed
    -	Function `NewGovernanceRulesClient` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, string, azcore.TokenCredential, *arm.ClientOptions)`
    +	Function `NewGovernanceRuleClient` has been removed
    +	Function `NewGovernanceRulesClient` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(azcore.TokenCredential, *arm.ClientOptions)`
    -	Operation `*ConnectorGovernanceRulesClient.Delete` has been changed to LRO, use `*ConnectorGovernanceRulesClient.BeginDelete` instead.
    +	Operation `*GovernanceRulesClient.Delete` has been changed to LRO, use `*GovernanceRulesClient.BeginDelete` instead.
    +	Struct `ConnectorGovernanceRuleClientListResponse` has been removed
    +	Struct `ConnectorGovernanceRuleClient` has been removed
    +	Struct `ConnectorGovernanceRulesClient` has been removed
    +	Struct `GovernanceRuleClientListResponse` has been removed
    +	Struct `GovernanceRuleClient` has been removed
    +	Struct `GovernanceRulesClientRuleIDExecuteSingleSecurityConnectorResponse` has been removed
    +	Struct `GovernanceRulesClientRuleIDExecuteSingleSubscriptionResponse` has been removed
    +	Type of `AADSolutionProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `AlertEntity.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `AlertPropertiesSupportingEvidence.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `AlertSimulatorBundlesRequestProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `AlertSimulatorRequestProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `ApplicationProperties.ConditionSets` has been changed from `[]interface{}` to `[]any`
    +	Type of `AscLocation.Properties` has been changed from `interface{}` to `any`
    +	Type of `AtaSolutionProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `CefSolutionProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `DefenderForServersAwsOfferingMdeAutoProvisioning.Configuration` has been changed from `interface{}` to `any`
    +	Type of `DefenderForServersGcpOfferingMdeAutoProvisioning.Configuration` has been changed from `interface{}` to `any`
    +	Type of `ErrorAdditionalInfo.Info` has been changed from `interface{}` to `any`
    +	Type of `ExternalSecuritySolutionProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `GovernanceRuleProperties.ConditionSets` has been changed from `[]interface{}` to `[]any`
    +	Type of `IngestionSetting.Properties` has been changed from `interface{}` to `any`
    +	Type of `ScopeElement.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    +	Type of `TaskParameters.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
    azure-sdk-for-python-track2 - track2_azure-mgmt-security - 3.0.0
    +	Operation GovernanceRulesOperations.create_or_update has a new required parameter scope
    +	Operation GovernanceRulesOperations.get has a new required parameter scope
    +	Removed operation GovernanceRulesOperations.begin_rule_id_execute_single_security_connector
    +	Removed operation GovernanceRulesOperations.begin_rule_id_execute_single_subscription
    +	Removed operation group GovernanceRuleOperations
    +	Removed operation group SecurityConnectorGovernanceRuleOperations
    +	Removed operation group SecurityConnectorGovernanceRulesExecuteStatusOperations
    +	Removed operation group SecurityConnectorGovernanceRulesOperations
    +	Removed operation group SubscriptionGovernanceRulesExecuteStatusOperations
    +	Renamed operation GovernanceRulesOperations.delete to GovernanceRulesOperations.begin_delete
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 9eb9c45. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.SecurityCenter [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9eb9c45. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/security/armsecurity [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `NewGovernanceRulesClient` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(azcore.TokenCredential, *arm.ClientOptions)`
      info	[Changelog] - Function `*GovernanceRulesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, GovernanceRule, *GovernanceRulesClientCreateOrUpdateOptions)` to `(context.Context, string, string, GovernanceRule, *GovernanceRulesClientCreateOrUpdateOptions)`
      info	[Changelog] - Function `*GovernanceRulesClient.Get` parameter(s) have been changed from `(context.Context, string, *GovernanceRulesClientGetOptions)` to `(context.Context, string, string, *GovernanceRulesClientGetOptions)`
      info	[Changelog] - Type of `AADSolutionProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `AlertEntity.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `AlertPropertiesSupportingEvidence.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `AlertSimulatorBundlesRequestProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `AlertSimulatorRequestProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `ApplicationProperties.ConditionSets` has been changed from `[]interface{}` to `[]any`
      info	[Changelog] - Type of `AscLocation.Properties` has been changed from `interface{}` to `any`
      info	[Changelog] - Type of `AtaSolutionProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `CefSolutionProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `DefenderForServersAwsOfferingMdeAutoProvisioning.Configuration` has been changed from `interface{}` to `any`
      info	[Changelog] - Type of `DefenderForServersGcpOfferingMdeAutoProvisioning.Configuration` has been changed from `interface{}` to `any`
      info	[Changelog] - Type of `ErrorAdditionalInfo.Info` has been changed from `interface{}` to `any`
      info	[Changelog] - Type of `ExternalSecuritySolutionProperties.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `GovernanceRuleProperties.ConditionSets` has been changed from `[]interface{}` to `[]any`
      info	[Changelog] - Type of `IngestionSetting.Properties` has been changed from `interface{}` to `any`
      info	[Changelog] - Type of `ScopeElement.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Type of `TaskParameters.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
      info	[Changelog] - Function `NewConnectorGovernanceRuleClient` has been removed
      info	[Changelog] - Function `*ConnectorGovernanceRuleClient.NewListPager` has been removed
      info	[Changelog] - Function `NewConnectorGovernanceRulesClient` has been removed
      info	[Changelog] - Function `*ConnectorGovernanceRulesClient.CreateOrUpdate` has been removed
      info	[Changelog] - Function `*ConnectorGovernanceRulesClient.Delete` has been removed
      info	[Changelog] - Function `*ConnectorGovernanceRulesClient.Get` has been removed
      info	[Changelog] - Function `NewConnectorGovernanceRulesExecuteStatusClient` has been removed
      info	[Changelog] - Function `*ConnectorGovernanceRulesExecuteStatusClient.BeginGet` has been removed
      info	[Changelog] - Function `NewGovernanceRuleClient` has been removed
      info	[Changelog] - Function `*GovernanceRuleClient.NewListPager` has been removed
      info	[Changelog] - Function `*GovernanceRulesClient.BeginRuleIDExecuteSingleSecurityConnector` has been removed
      info	[Changelog] - Function `*GovernanceRulesClient.BeginRuleIDExecuteSingleSubscription` has been removed
      info	[Changelog] - Function `NewSubscriptionGovernanceRulesExecuteStatusClient` has been removed
      info	[Changelog] - Function `*SubscriptionGovernanceRulesExecuteStatusClient.BeginGet` has been removed
      info	[Changelog] - Operation `*GovernanceRulesClient.Delete` has been changed to LRO, use `*GovernanceRulesClient.BeginDelete` instead.
      info	[Changelog] - Struct `ConnectorGovernanceRuleClient` has been removed
      info	[Changelog] - Struct `ConnectorGovernanceRuleClientListResponse` has been removed
      info	[Changelog] - Struct `ConnectorGovernanceRulesClient` has been removed
      info	[Changelog] - Struct `ConnectorGovernanceRulesExecuteStatusClient` has been removed
      info	[Changelog] - Struct `ConnectorGovernanceRulesExecuteStatusClientGetResponse` has been removed
      info	[Changelog] - Struct `ExecuteRuleStatus` has been removed
      info	[Changelog] - Struct `GovernanceRuleClient` has been removed
      info	[Changelog] - Struct `GovernanceRuleClientListResponse` has been removed
      info	[Changelog] - Struct `GovernanceRulesClientRuleIDExecuteSingleSecurityConnectorResponse` has been removed
      info	[Changelog] - Struct `GovernanceRulesClientRuleIDExecuteSingleSubscriptionResponse` has been removed
      info	[Changelog] - Struct `SubscriptionGovernanceRulesExecuteStatusClient` has been removed
      info	[Changelog] - Struct `SubscriptionGovernanceRulesExecuteStatusClientGetResponse` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New type alias `OperationResult` with values `OperationResultCanceled`, `OperationResultFailed`, `OperationResultSucceeded`
      info	[Changelog] - New function `NewAPICollectionClient(string, azcore.TokenCredential, *arm.ClientOptions) (*APICollectionClient, error)`
      info	[Changelog] - New function `*APICollectionClient.Get(context.Context, string, string, string, *APICollectionClientGetOptions) (APICollectionClientGetResponse, error)`
      info	[Changelog] - New function `*APICollectionClient.NewListPager(string, string, *APICollectionClientListOptions) *runtime.Pager[APICollectionClientListResponse]`
      info	[Changelog] - New function `NewAPICollectionOffboardingClient(string, azcore.TokenCredential, *arm.ClientOptions) (*APICollectionOffboardingClient, error)`
      info	[Changelog] - New function `*APICollectionOffboardingClient.Delete(context.Context, string, string, string, *APICollectionOffboardingClientDeleteOptions) (APICollectionOffboardingClientDeleteResponse, error)`
      info	[Changelog] - New function `NewAPICollectionOnboardingClient(string, azcore.TokenCredential, *arm.ClientOptions) (*APICollectionOnboardingClient, error)`
      info	[Changelog] - New function `*APICollectionOnboardingClient.Create(context.Context, string, string, string, *APICollectionOnboardingClientCreateOptions) (APICollectionOnboardingClientCreateResponse, error)`
      info	[Changelog] - New function `*GovernanceRulesClient.BeginExecute(context.Context, string, string, *GovernanceRulesClientBeginExecuteOptions) (*runtime.Poller[GovernanceRulesClientExecuteResponse], error)`
      info	[Changelog] - New function `*GovernanceRulesClient.NewListPager(string, *GovernanceRulesClientListOptions) *runtime.Pager[GovernanceRulesClientListResponse]`
      info	[Changelog] - New function `*GovernanceRulesClient.OperationResults(context.Context, string, string, string, *GovernanceRulesClientOperationResultsOptions) (GovernanceRulesClientOperationResultsResponse, error)`
      info	[Changelog] - New struct `APICollectionClient`
      info	[Changelog] - New struct `APICollectionClientListResponse`
      info	[Changelog] - New struct `APICollectionOffboardingClient`
      info	[Changelog] - New struct `APICollectionOnboardingClient`
      info	[Changelog] - New struct `APICollectionProperties`
      info	[Changelog] - New struct `APICollectionResponse`
      info	[Changelog] - New struct `APICollectionResponseList`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponse`
      info	[Changelog] - New struct `GovernanceRuleMetadata`
      info	[Changelog] - New struct `GovernanceRulesClientExecuteResponse`
      info	[Changelog] - New struct `GovernanceRulesClientListResponse`
      info	[Changelog] - New struct `OperationResultAutoGenerated`
      info	[Changelog] - New field `ExcludedScopes` in struct `GovernanceRuleProperties`
      info	[Changelog] - New field `IncludeMemberScopes` in struct `GovernanceRuleProperties`
      info	[Changelog] - New field `Metadata` in struct `GovernanceRuleProperties`
      info	[Changelog] - New field `TenantID` in struct `GovernanceRuleProperties`
      info	[Changelog]
      info	[Changelog] Total 59 breaking change(s), 41 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9eb9c45. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.3.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.3.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.3.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-security [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation GovernanceRulesOperations.begin_execute
      info	[Changelog]   - Added operation GovernanceRulesOperations.list
      info	[Changelog]   - Added operation GovernanceRulesOperations.operation_results
      info	[Changelog]   - Model GovernanceRule has a new parameter excluded_scopes
      info	[Changelog]   - Model GovernanceRule has a new parameter include_member_scopes
      info	[Changelog]   - Model GovernanceRule has a new parameter metadata
      info	[Changelog]   - Model GovernanceRule has a new parameter tenant_id
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Operation GovernanceRulesOperations.create_or_update has a new required parameter scope
      info	[Changelog]   - Operation GovernanceRulesOperations.get has a new required parameter scope
      info	[Changelog]   - Removed operation GovernanceRulesOperations.begin_rule_id_execute_single_security_connector
      info	[Changelog]   - Removed operation GovernanceRulesOperations.begin_rule_id_execute_single_subscription
      info	[Changelog]   - Removed operation group GovernanceRuleOperations
      info	[Changelog]   - Removed operation group SecurityConnectorGovernanceRuleOperations
      info	[Changelog]   - Removed operation group SecurityConnectorGovernanceRulesExecuteStatusOperations
      info	[Changelog]   - Removed operation group SecurityConnectorGovernanceRulesOperations
      info	[Changelog]   - Removed operation group SubscriptionGovernanceRulesExecuteStatusOperations
      info	[Changelog]   - Renamed operation GovernanceRulesOperations.delete to GovernanceRulesOperations.begin_delete
    ️❌ azure-sdk-for-js failed [Detail]
    • Code Generator Failed [Logs]Release - Generate from 9eb9c45. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] [ERROR] An error occurred while generating codes for readme file: "specification/security/resource-manager/readme.md":
      cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/security/resource-manager/readme.md --use=@autorest/typescript@6.0.0-rc.5
      cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
      cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
      cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/security/resource-manager/readme.md --use=@autorest/typescript@6.0.0-rc.5
      cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:861:11)
      cmderr	[automation_generate.sh] [ERROR]     at Object.execSync (node:child_process:932:15)
      cmderr	[automation_generate.sh] [ERROR]     at Object.<anonymous> (/opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:39:33)
      cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
      cmderr	[automation_generate.sh] [ERROR]     at /opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:115:75
      cmderr	[automation_generate.sh] [ERROR]     at new Promise (<anonymous>)
      cmderr	[automation_generate.sh] [ERROR]     at Object.__awaiter (/opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:111:16)
      cmderr	[automation_generate.sh] [ERROR]     at Object.generateMgmt (/opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:20:20)
      cmderr	[automation_generate.sh] [ERROR]     at /opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/autoGenerateInPipeline.js:43:34"
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs]Release - Generate from 9eb9c45. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • security/resource-manager [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 9eb9c45. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.security [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 24, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/security/armsecurity https://apiview.dev/Assemblies/Review/2a1795db8c9d41fb8595817af5f99bb5
    Java azure-resourcemanager-security https://apiview.dev/Assemblies/Review/512f7354e1e74a05a534e50fde1d018f

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels Jan 24, 2023
    @openapi-workflow-bot
    Copy link

    Hi @oravital7, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @ruowan ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 24, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 24, 2023
    @ruowan ruowan merged commit 9eb9c45 into main Jan 24, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants