-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-Sentinel-2023-02-01-preview #22305
Conversation
…w/2022-12-01-preview to version 2023-02-01-preview
Hi, @anat-gilenson Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
AlertRules.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
AlertRules.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
AutomationRules.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
AutomationRules.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
Bookmarks.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
Bookmarks.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
Enrichment.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
Entities.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
EntityQueries.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
EntityQueryTemplates.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
FileImports.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
Incidents.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
Incidents.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
Metadata.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
OfficeConsents.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
OnboardingStates.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
OnboardingStates.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
Recommendations.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
SecurityMLAnalyticsSettings.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
SecurityMLAnalyticsSettings.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
Settings.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
SourceControls.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
ThreatIntelligence.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
ThreatIntelligence.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
Watchlists.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
Watchlists.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
AlertTypes.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
AlertTypes.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
EntityTypes.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
EntityTypes.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
IncidentTypes.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
IncidentTypes.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
RelationTypes.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
ThreatIntelligenceTypes.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
dataConnectors.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
operations.json | 2023-02-01-preview(77ecbab) | 2022-11-01(main) |
operations.json | 2023-02-01-preview(77ecbab) | 2022-12-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1025 - RequiredStatusChange |
The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L1576:7 Old: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L1072:7 |
1025 - RequiredStatusChange |
The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L1237:7 Old: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L995:7 |
1025 - RequiredStatusChange |
The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.SecurityInsights/preview/2023-02-01-preview/Watchlists.json#L481:7 Old: Microsoft.SecurityInsights/stable/2022-11-01/Watchlists.json#L469:7 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. New: Microsoft.SecurityInsights/preview/2023-02-01-preview/ThreatIntelligence.json#L49:9 Old: Microsoft.SecurityInsights/stable/2022-11-01/ThreatIntelligence.json#L49:9 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
1026 - TypeChanged |
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-preview-2023-02 | package-preview-2023-02(77ecbab) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌
SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
PoliCheck: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
|
Click detail for error messages. Exception contact vsswagger@microsoft.com or https://aka.ms/swaggersupport. |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @anat-gilenson, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi, @anat-gilenson, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
* Add triggeredAnalyticsRuleRuns API * fix examples path * run prettier * fix lint * fix prettier * Update readme.md * draft * draft * fixing comments * fixing nit and param name * adding requires * fixing idention * Update TriggeredAnalyticsRuleRuns.json adding location header * Update TriggeredAnalyticsRuleRuns.json closing headers * Update TriggeredAnalyticsRuleRuns.json fixing warnings * Update TriggeredAnalyticsRuleRuns.json fixing lint warnings pt 2 * Update TriggeredAnalyticsRuleRuns.json fixing flatten position --------- Co-authored-by: Rotemdvir1 <rotemdvir@microsoft.com> Co-authored-by: Rotemdvir1 <95570648+Rotemdvir1@users.noreply.github.com>
* MTP data connector- filter alerts by provider * validations
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Approve the breaking change directly because they are approved in version 2022-12-01-preview |
Please note all PRs to this branch have already been reviewed and approved by Swagger team and ARM. No need for addition ARM review.