Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-Sentinel-2023-02-01-preview #22305

Merged
merged 6 commits into from
Feb 6, 2023

Conversation

anat-gilenson
Copy link
Contributor

Please note all PRs to this branch have already been reviewed and approved by Swagger team and ARM. No need for addition ARM review.

@openapi-workflow-bot
Copy link

Hi, @anat-gilenson Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 124 Errors, 10 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    AlertRules.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    AlertRules.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    AutomationRules.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    AutomationRules.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    Bookmarks.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    Bookmarks.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    Enrichment.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    Entities.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    EntityQueries.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    EntityQueryTemplates.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    FileImports.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    Incidents.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    Incidents.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    Metadata.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    OfficeConsents.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    OnboardingStates.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    OnboardingStates.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    Recommendations.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    SecurityMLAnalyticsSettings.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    SecurityMLAnalyticsSettings.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    Settings.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    SourceControls.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    ThreatIntelligence.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    ThreatIntelligence.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    Watchlists.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    Watchlists.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    AlertTypes.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    AlertTypes.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    EntityTypes.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    EntityTypes.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    IncidentTypes.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    IncidentTypes.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    RelationTypes.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    ThreatIntelligenceTypes.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    dataConnectors.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)
    operations.json 2023-02-01-preview(77ecbab) 2022-11-01(main)
    operations.json 2023-02-01-preview(77ecbab) 2022-12-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L1576:7
    Old: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L1072:7
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L1237:7
    Old: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L995:7
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.SecurityInsights/preview/2023-02-01-preview/Watchlists.json#L481:7
    Old: Microsoft.SecurityInsights/stable/2022-11-01/Watchlists.json#L469:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.SecurityInsights/preview/2023-02-01-preview/ThreatIntelligence.json#L49:9
    Old: Microsoft.SecurityInsights/stable/2022-11-01/ThreatIntelligence.json#L49:9
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    Old: stable/2022-11-01/common/EntityTypes.json#L2272:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-02 package-preview-2023-02(77ecbab) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    DeleteResponseBodyEmpty The delete response body must be empty.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L148
    DeleteResponseBodyEmpty The delete response body must be empty.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L154
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L1227
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L1243
    GetCollectionResponseSchema The response in the GET collection operation 'BookmarkRelations_List' does not match the response definition in the individual GET operation 'BookmarkRelations_Get' .
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Bookmarks.json#L222
    ResourceNameRestriction The resource name parameter 'relationName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Bookmarks.json#L331
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Bookmarks.json#L538
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Bookmarks.json#L566
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2280
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2292
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2304
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2316
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2336
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2712
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2724
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2820
    GetCollectionResponseSchema The response in the GET collection operation 'EntitiesRelations_List' does not match the response definition in the individual GET operation 'EntityRelations_GetRelation' .
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Entities.json#L376
    ResourceNameRestriction The resource name parameter 'relationName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Entities.json#L437
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Entities.json#L751
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Entities.json#L804
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Entities.json#L1204
    XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/EntityQueries.json#L484
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/EntityQueryTemplates.json#L234
    XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/EntityQueryTemplates.json#L292
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/FileImports.json#L213
    GetCollectionResponseSchema The response in the GET collection operation 'IncidentRelations_List' does not match the response definition in the individual GET operation 'IncidentRelations_Get' .
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Incidents.json#L634
    ResourceNameRestriction The resource name parameter 'relationName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Incidents.json#L698
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Incidents.json#L1245
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Incidents.json#L1332
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/Incidents.json#L1547
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌PoliCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    Click detail for error messages. Exception contact vsswagger@microsoft.com or https://aka.ms/swaggersupport.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-js - @azure/arm-securityinsight - Approved - 1.0.0-beta.7
    +	Operation Incidents.createTeam has a new signature
    +	Removed Enum KnownEnum13
    +	Type of parameter actionType of interface AutomationRuleAction is changed from "ModifyProperties" | "RunPlaybook" to "AddIncidentTask" | "ModifyProperties" | "RunPlaybook"
    +	Type of parameter additionalData of interface AccountEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface AzureResourceEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface CloudApplicationEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface DnsEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface EntityCommonProperties is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface EntityEdges is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface FileEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface FileHashEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface HostEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface HuntingBookmark is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface IoTDeviceEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface IpEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface MailClusterEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface MailMessageEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface MailboxEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface MalwareEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface NicEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface ProcessEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface RegistryKeyEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface RegistryValueEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface SecurityAlert is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface SecurityGroupEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface SubmissionMailEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface UrlEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter kind of interface DataConnectorsCheckRequirements is changed from "AzureActiveDirectory" | "AzureAdvancedThreatProtection" | "AzureSecurityCenter" | "AmazonWebServicesCloudTrail" | "AmazonWebServicesS3" | "Dynamics365" | "MicrosoftCloudAppSecurity" | "MicrosoftDefenderAdvancedThreatProtection" | "MicrosoftThreatIntelligence" | "MicrosoftThreatProtection" | "OfficeATP" | "OfficeIRM" | "Office365Project" | "OfficePowerBI" | "ThreatIntelligence" | "ThreatIntelligenceTaxii" | "IOT" to "AzureActiveDirectory" | "AzureAdvancedThreatProtection" | "AzureSecurityCenter" | "AmazonWebServicesCloudTrail" | "AmazonWebServicesS3" | "Dynamics365" | "MicrosoftCloudAppSecurity" | "MicrosoftDefenderAdvancedThreatProtection" | "MicrosoftThreatIntelligence" | "MicrosoftThreatProtection" | "OfficeATP" | "OfficeIRM" | "MicrosoftPurviewInformationProtection" | "Office365Project" | "OfficePowerBI" | "ThreatIntelligence" | "ThreatIntelligenceTaxii" | "IOT"
    +	Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum14
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b817685. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group AlertRuleOperations
      info	[Changelog]   - Added operation group GetTriggeredAnalyticsRuleRunsOperations
      info	[Changelog]   - Added operation group TriggeredAnalyticsRuleRunOperations
      info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
      info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
      info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b817685. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-securityinsight [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface CloudApplicationEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter kind of interface DataConnectorsCheckRequirements is changed from "AzureActiveDirectory" | "AzureAdvancedThreatProtection" | "AzureSecurityCenter" | "AmazonWebServicesCloudTrail" | "AmazonWebServicesS3" | "Dynamics365" | "MicrosoftCloudAppSecurity" | "MicrosoftDefenderAdvancedThreatProtection" | "MicrosoftThreatIntelligence" | "MicrosoftThreatProtection" | "OfficeATP" | "OfficeIRM" | "Office365Project" | "OfficePowerBI" | "ThreatIntelligence" | "ThreatIntelligenceTaxii" | "IOT" to "AzureActiveDirectory" | "AzureAdvancedThreatProtection" | "AzureSecurityCenter" | "AmazonWebServicesCloudTrail" | "AmazonWebServicesS3" | "Dynamics365" | "MicrosoftCloudAppSecurity" | "MicrosoftDefenderAdvancedThreatProtection" | "MicrosoftThreatIntelligence" | "MicrosoftThreatProtection" | "OfficeATP" | "OfficeIRM" | "MicrosoftPurviewInformationProtection" | "Office365Project" | "OfficePowerBI" | "ThreatIntelligence" | "ThreatIntelligenceTaxii" | "IOT"
      info	[Changelog]   - Type of parameter additionalData of interface DnsEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum14
      info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Removed Enum KnownEnum13
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs]Release - Generate from b817685. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • securityinsights/resource-manager [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from b817685. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.securityinsights [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-securityinsights Create ApiView failed. Please ask PR assignee for help
    .Net Azure.ResourceManager.SecurityInsights Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-securityinsight Create ApiView failed. Please ask PR assignee for help

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version resource-manager labels Jan 25, 2023
    @openapi-workflow-bot
    Copy link

    Hi @anat-gilenson, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi, @anat-gilenson, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    * Add triggeredAnalyticsRuleRuns API
    
    * fix examples path
    
    * run prettier
    
    * fix lint
    
    * fix prettier
    
    * Update readme.md
    
    * draft
    
    * draft
    
    * fixing comments
    
    * fixing nit and param name
    
    * adding requires
    
    * fixing idention
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    adding location header
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    closing headers
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    fixing warnings
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    fixing lint warnings pt 2
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    fixing flatten position
    
    ---------
    
    Co-authored-by: Rotemdvir1 <rotemdvir@microsoft.com>
    Co-authored-by: Rotemdvir1 <95570648+Rotemdvir1@users.noreply.github.com>
    * MTP data connector- filter alerts by provider
    
    * validations
    @anat-gilenson
    Copy link
    Contributor Author

    /azp run

    @anat-gilenson anat-gilenson marked this pull request as ready for review February 5, 2023 14:21
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Feb 5, 2023
    @dw511214992
    Copy link
    Member

    Approve the breaking change directly because they are approved in version 2022-12-01-preview

    @dw511214992 dw511214992 added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 6, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-JavaScript ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-JavaScript CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants