Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operation name #22319

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix operation name #22319

merged 1 commit into from
Jan 26, 2023

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Jan 26, 2023

No description provided.

@openapi-workflow-bot
Copy link

Hi, @lmazuel Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    @ghost ghost added the Cognitive Services label Jan 26, 2023
    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @lmazuel lmazuel marked this pull request as ready for review January 26, 2023 01:24
    @lmazuel lmazuel merged commit 14f11ca into feature/cognitiveservices/openai-cadl Jan 26, 2023
    @lmazuel lmazuel deleted the fix_operation_name_openai branch January 26, 2023 01:25
    lmazuel added a commit that referenced this pull request Feb 3, 2023
    @lmazuel @tjprescott
    @glharper @jpalvarezl @johanste @MaryGao @m-nash @trrwilson
    OpenAI Preview (#22364)
    270d3cd 
    * Initial commit.

* Commit OpenAI inference cadl files.

* use non-deprecated service decorator

* Fixes to main

* Reverted changes

* use latest cadl to sync with vs code properly

* cadl compilation works for authoring (but it is correct?)

* Cleaned up routes and model for Inference REST CADL spec

* Added cadl-output to .gitignore file and removed error response

* Implemented polymorphic return for endpoint

* enable Files_Import as non-standard operation, use standard operation names

* Authoring CADL now emits openAPI schema almost identical to current Authoring schema

* Empty model used for polymorphic expectation in embedding endpoint

* Renamed models to match convention

* Renamed completions related models

* Adjusted comment for embeddings body types

* Split up models.cadl into completions and embeddings files

* Renamed models

* Refactored model names

* Removed redundants bits of model names

* added headers

* Added header to correct model

* break up monolithic routes and model cadl files

* add namespace to all models

* Removed gitIgnore file and changed files to not have domain related namespaces

* Finished embeddings endpoint and verified against source json

* Verified round trip for swagger

* Almost done with security types

* Configured correctly OAth2

* Add Auth and OAuth2 to service (thanks Jose!)

* Add auth and OAuth to openapi json

* Review comments

* Review comments

* camel casing

* add versionedDependency

* better versioning

* Added the apiview emitter to OpenAI.Inference endpoints

* PR feedback for Inference endpoints

* Feature/cognitiveservices/openai cadl (#21574)

* Added openai specific list API op template.

* Simplified OAI authoring cadl

* update package versions, correct camelCase warning in common

* remove commented out models, changed AcceptedResponse to CreatedResponse

* Reverted completion to use snake_casing and removed the Response and Request namespaces

* reverted to snake_casing and removed Request namespace for embeddings

* Added missing namespace declaration in embeddings

* Updated dependencies and enabled csharp emitter for Inference

* use string literals for now as enum value types (TypeDiscriminatorKnownValues) not supported in csharp emitter

* Add TODO to TypeDiscriminatorKnownValues def

* More specific route operation names, use snake casing for all model fields

* Added more options to csharp emitter

* Simplify OpenAI inferrence models and use core (#21609)

* Simplify OpenAI inferrence models and use core

* Simplified and corrected Cadl type usage for OpenAI.Inference

* Fix camel case issues.

Co-authored-by: tjprescott <trpresco@microsoft.com>

* Upgrade Cadl file to 0.38 for OpenAI.Authoring service  (#22104)

* Upgrade Cadl file to 0.38

* Upgrade the package.json file and relevant cadl decorator

* Embedding in Azure do not support integer (#22091)

* Fix auth in OpenAI CADL (#22191)

* Change aliases to models, renamed model Embedding to EmbeddingItem to avoid conflicts, and Completion types

* Changed prompt into string[][]

* update package name (#22312)

* Archboard feedback (#22315)

* Archboard feedback

* Disable stream for now

* Rename to options

* Fix operation name (#22319)

* Feature/openai add missing usage (#22337)

* add new API version and usage field on completions and embeddings

* typo

* Added docs for Usage classes in completions and embeddings

* Added versioning mark for new usage model

* Added disambiguation for names and removed unnecessary versioning decorator

* Removed unused version bump

* Removed unused version from enum

* Removed wrong annotation

---------

Co-authored-by: Jose Alvarez <josealvar@microsoft.com>

* Update main.cadl (#22362)

* Embeddings model and field documentation and fix to models (#22368)

* Moved usage to the response object of embeddings and added some basic documentation to models and fields

* Fixed typo

* Update specification/cognitiveservices/OpenAI.Inference/models/embeddings.create.cadl

---------

Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>

* Removing Model from model name and removing unnecessary aliases (#22390)

* updated deps and added visibility decorator to deploymentId (#22417)

* Made CompletionsOptions.model optional again

* Removing ...Models namespace in the C# classes (#22449)

* AOAI: fix CompletionsUsage model (#22439)

---------

Co-authored-by: tjprescott <trpresco@microsoft.com>
Co-authored-by: Glenn Harper <glharper@microsoft.com>
Co-authored-by: Jose Alvarez <josealvar@microsoft.com>
Co-authored-by: Glenn Harper <64209257+glharper@users.noreply.github.com>
Co-authored-by: Johan Stenberg (MSFT) <johan.stenberg@microsoft.com>
Co-authored-by: Mary Gao <yanmeigao1210@gmail.com>
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com>
Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @yangyuan yangyuan Awaiting requested review from yangyuan

    Assignees
    No one assigned
    Labels
    Cognitive Services
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @lmazuel