Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync authType and containerUri in BlobService From DataFactory To Synapse #22404

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

tsaiggo
Copy link
Contributor

@tsaiggo tsaiggo commented Feb 1, 2023

Sync authType and containerUri in BlobService From DataFactory To Synapse

Add containerUri and authType in Blob Connector to Synapse

@openapi-workflow-bot
Copy link

Hi, @tsaiggo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2023

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    LinkedService.json 2020-12-01(a6e5a56) 2020-12-01(main)
    Rule Message
    1045 - AddedOptionalProperty The new version has a new optional property 'authenticationType' that was not found in the old version.
    New: stable/2020-12-01/entityTypes/LinkedService.json#L134:7
    Old: stable/2020-12-01/entityTypes/LinkedService.json#L134:7
    1045 - AddedOptionalProperty The new version has a new optional property 'containerUri' that was not found in the old version.
    New: stable/2020-12-01/entityTypes/LinkedService.json#L134:7
    Old: stable/2020-12-01/entityTypes/LinkedService.json#L134:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-artifacts-2020-12-01 package-artifacts-2020-12-01(a6e5a56) package-artifacts-2020-12-01(main)
    package-artifacts-composite-v1 package-artifacts-composite-v1(a6e5a56) package-artifacts-composite-v1(main)
    package-artifacts-composite-v6 package-artifacts-composite-v6(a6e5a56) package-artifacts-composite-v6(main)
    package-artifacts-composite-v5 package-artifacts-composite-v5(a6e5a56) package-artifacts-composite-v5(main)
    package-artifacts-composite-v4 package-artifacts-composite-v4(a6e5a56) package-artifacts-composite-v4(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L38
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L50
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L50
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L50
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L50
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L50
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L70
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L70
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L70
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L70
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L70
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L90
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L90
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L90
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L90
    ⚠️ AdditionalPropertiesAndProperties Don't specify additionalProperties as a sibling of properties.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L90
    ⚠️ SchemaNamesConvention Schema name should be Pascal case.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L200
    ⚠️ SchemaNamesConvention Schema name should be Pascal case.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L200
    ⚠️ SchemaNamesConvention Schema name should be Pascal case.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L200
    ⚠️ SchemaNamesConvention Schema name should be Pascal case.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L200
    ⚠️ SchemaNamesConvention Schema name should be Pascal case.
    Location: stable/2020-12-01/entityTypes/LinkedService.json#L200
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2023

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @ghost ghost added the Synapses label Feb 1, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2023

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️🔄Breaking Change(Cross-Version) inProgress [Detail]
    ️⌛CredScan pending [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️🔄ApiReadinessCheck inProgress [Detail]
    ️🔄~[Staging] ServiceAPIReadinessTest inProgress [Detail]
    ️🔄~[Staging] SwaggerAPIView inProgress [Detail]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⌛PoliCheck pending [Detail]
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️⌛PR Summary pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 1, 2023
    @lmazuel lmazuel merged commit 9f33c53 into Azure:main Feb 2, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 data-plane NewApiVersionRequired Synapses
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants