Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean properties which are never used #22423

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Clean properties which are never used #22423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 2 additions & 77 deletions ...on/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,31 +1041,6 @@
}
},
"definitions": {
"ManagedEnvironmentOutboundSettings": {
"type": "object",
"description": "Configuration used to control the Environment Egress outbound traffic",
"properties": {
"outBoundType": {
"$ref": "#/definitions/ManagedEnvironmentOutBoundType"
},
"virtualNetworkApplianceIp": {
"description": "Virtual Appliance IP used as the Egress controller for the Environment",
"type": "string"
}
}
},
"ManagedEnvironmentOutBoundType": {
"enum": [
"LoadBalancer",
"UserDefinedRouting"
],
"description": "Outbound type for the cluster",
"type": "string",
"x-ms-enum": {
"name": "ManagedEnvironmentOutBoundType",
"modelAsString": true
}
},
"AppLogsConfiguration": {
"description": "Configuration of application logs",
"type": "object",
Expand Down Expand Up @@ -1136,23 +1111,15 @@
"properties": {
"internal": {
"type": "boolean",
"description": "Boolean indicating the environment only has an internal load balancer. These environments do not have a public static IP resource. They must provide runtimeSubnetId and infrastructureSubnetId if enabling this property",
"description": "Boolean indicating the environment only has an internal load balancer. These environments do not have a public static IP resource. They must provide infrastructureSubnetId if enabling this property",
"x-ms-mutability": [
"create",
"read"
]
},
"infrastructureSubnetId": {
"type": "string",
"description": "Resource ID of a subnet for infrastructure components. This subnet must be in the same VNET as the subnet defined in runtimeSubnetId. Must not overlap with any other provided IP ranges.",
"x-ms-mutability": [
"create",
"read"
]
},
"runtimeSubnetId": {
"type": "string",
"description": "This field is deprecated and not used. If you wish to provide your own subnet that Container App containers are injected into, then you should leverage the infrastructureSubnetId.",
"description": "Resource ID of a subnet for infrastructure components. Must not overlap with any other provided IP ranges.",
"x-ms-mutability": [
"create",
"read"
Expand Down Expand Up @@ -1181,10 +1148,6 @@
"create",
"read"
]
},
"outboundSettings": {
"$ref": "#/definitions/ManagedEnvironmentOutboundSettings",
"description": "Configuration used to control the Environment Egress outbound traffic"
}
}
},
Expand All @@ -1197,10 +1160,6 @@
}
],
"properties": {
"sku": {
"$ref": "#/definitions/EnvironmentSkuProperties",
"description": "SKU properties of the Environment."
},
"kind": {
"type": "string",
"description": "Kind of the Environment."
Expand Down Expand Up @@ -1402,40 +1361,6 @@
"maximumCount"
]
},
"EnvironmentSkuProperties": {
"description": "Managed Environment resource SKU properties.",
"type": "object",
"properties": {
"name": {
"type": "string",
"description": "Name of the Sku.",
"externalDocs": {
"url": "https://aka.ms/container-apps-pricing"
},
"enum": [
"Consumption",
"Premium"
],
"x-ms-enum": {
"name": "SkuName",
"modelAsString": true,
"values": [
{
"value": "Consumption",
"description": "Consumption SKU of Managed Environment."
},
{
"value": "Premium",
"description": "Premium SKU of Managed Environment."
}
]
}
}
},
"required": [
"name"
]
},
"workloadProfileStates": {
"description": "Collection of all the workload Profile States for a Premium Managed Environment..",
"type": "object",
Expand Down
24 changes: 3 additions & 21 deletions ...Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
"api-version": "2022-11-01-preview",
"environmentEnvelope": {
"location": "East US",
"sku": {
"name": "Premium"
},
"properties": {
"daprAIConnectionString": "InstrumentationKey=00000000-0000-0000-0000-000000000000;IngestionEndpoint=https://northcentralus-0.in.applicationinsights.azure.com/",
"appLogsConfiguration": {
Expand All @@ -19,10 +16,7 @@
},
"zoneRedundant": true,
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
},
"customDomainConfiguration": {
"dnsSuffix": "www.my-name.com",
Expand Down Expand Up @@ -56,9 +50,6 @@
"name": "testcontainerenv",
"type": "Microsoft.App/managedEnvironments",
"location": "East US",
"sku": {
"name": "Premium"
},
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
Expand All @@ -71,10 +62,7 @@
},
"zoneRedundant": true,
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
},
"customDomainConfiguration": {
"customDomainVerificationId": "custom domain verification id",
Expand Down Expand Up @@ -110,9 +98,6 @@
"name": "testcontainerenv",
"type": "Microsoft.App/managedEnvironments",
"location": "East US",
"sku": {
"name": "Premium"
},
"properties": {
"provisioningState": "InitializationInProgress",
"deploymentErrors": null,
Expand All @@ -125,10 +110,7 @@
},
"zoneRedundant": true,
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
},
"customDomainConfiguration": {
"customDomainVerificationId": "custom domain verification id",
Expand Down
8 changes: 1 addition & 7 deletions ...ce-manager/Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,14 @@
"type": "Microsoft.App/managedEnvironments",
"location": "North Central US",
"tags": {},
"sku": {
"name": "Premium"
},
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"defaultDomain": "jlaw-demo1.k4apps.io",
"staticIp": "20.42.33.145",
"zoneRedundant": true,
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
},
"customDomainConfiguration": {
"customDomainVerificationId": "custom domain verification id",
Expand Down
16 changes: 2 additions & 14 deletions ...soft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_ListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
"type": "Microsoft.App/managedEnvironments",
"location": "North Central US",
"tags": {},
"sku": {
"name": "Premium"
},
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
Expand All @@ -25,10 +22,7 @@
"appLogsConfiguration": null,
"zoneRedundant": true,
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
},
"customDomainConfiguration": {
"customDomainVerificationId": "custom domain verification id",
Expand Down Expand Up @@ -63,9 +57,6 @@
"type": "Microsoft.App/managedEnvironments",
"location": "North Central US",
"tags": {},
"sku": {
"name": "Consumption"
},
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
Expand All @@ -82,10 +73,7 @@
},
"eventStreamEndpoint": "testEndpoint",
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
}
}
}
Expand Down
16 changes: 2 additions & 14 deletions ...osoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_ListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
"type": "Microsoft.App/managedEnvironments",
"location": "North Central US",
"tags": {},
"sku": {
"name": "Premium"
},
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
Expand All @@ -24,10 +21,7 @@
"appLogsConfiguration": null,
"zoneRedundant": true,
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
},
"customDomainConfiguration": {
"customDomainVerificationId": "custom domain verification id",
Expand Down Expand Up @@ -62,9 +56,6 @@
"type": "Microsoft.App/managedEnvironments",
"location": "North Central US",
"tags": {},
"sku": {
"name": "Consumption"
},
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
Expand All @@ -73,10 +64,7 @@
"appLogsConfiguration": null,
"zoneRedundant": true,
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
},
"customDomainConfiguration": {
"customDomainVerificationId": "custom domain verification id",
Expand Down
9 changes: 0 additions & 9 deletions ...-manager/Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_Patch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,12 @@
"type": "Microsoft.App/managedEnvironments",
"location": "North Central US",
"tags": {},
"sku": {
"name": "Premium"
},
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"defaultDomain": "jlaw-demo1.k4apps.io",
"staticIp": "20.42.33.145",
"zoneRedundant": true,
"vnetConfiguration": {
"outboundSettings": {
"outBoundType": "UserDefinedRouting",
"virtualNetworkApplianceIp": "192.168.1.20"
}
},
"customDomainConfiguration": {
"customDomainVerificationId": "custom domain verification id",
"dnsSuffix": "www.my-name.com",
Expand Down