{AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required #22546

navba-MSFT · 2023-02-10T06:03:45Z

For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below. Intrestingly the Azure

Request Body:

{
  "properties": {
    "securityRules": [
      {
        "name": "rule1",
        "properties": {
          "protocol": "*",
          "sourceAddressPrefix": "*",
          "destinationAddressPrefix": "*",
          "access": "Allow",
          "destinationPortRange": "80",
          "sourcePortRange": "*",
          "direction": "Inbound"
        }
      }
    ]
  },
  "location": "eastus"
}

Response received:

{
  "error": {
    "code": "SecurityRuleInvalidPriority",
    "message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.",
    "details": []
  }
}

This PR will make the priority parameter as required.

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

fixes #22448 [This is the API](https://learn.microsoft.com/en-us/rest/api/virtualnetwork/network-security-groups/create-or-update?tabs=HTTP#code-try-0) I invoked. For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below. Intrestingly the Azure Request Body: ``` { "properties": { "securityRules": [ { "name": "rule1", "properties": { "protocol": "*", "sourceAddressPrefix": "*", "destinationAddressPrefix": "*", "access": "Allow", "destinationPortRange": "80", "sourcePortRange": "*", "direction": "Inbound" } } ] }, "location": "eastus" } ``` Response received: ``` { "error": { "code": "SecurityRuleInvalidPriority", "message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.", "details": [] } } ``` This PR will make the `priority` parameter as required.

openapi-workflow-bot · 2023-02-10T06:03:49Z

Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-02-10T06:03:50Z

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
networkSecurityGroup.json	2022-07-01(adb4db6)	2022-07-01(main)

Rule	Message
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L720:7 Old: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L720:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'priority' that was not found in the old version. New: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L830:9 Old: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L829:9
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'priority' that was not found in the old version. New: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L719:5 Old: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L719:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-07	package-2022-07(adb4db6)	package-2022-07(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'networkSecurityGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L37
`❌` LongRunningResponseStatusCode	A 'delete' operation 'NetworkSecurityGroups_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L38
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L67
`❌` ResourceNameRestriction	The resource name parameter 'networkSecurityGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L361
`❌` ResourceNameRestriction	The resource name parameter 'securityRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L361
`❌` LongRunningResponseStatusCode	A 'delete' operation 'SecurityRules_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L362
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L401
`❌` ResourceNameRestriction	The resource name parameter 'networkSecurityGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L554
`❌` ResourceNameRestriction	The resource name parameter 'networkSecurityGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L607
`❌` ResourceNameRestriction	The resource name parameter 'networkSecurityGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L660
`❌` ResourceNameRestriction	The resource name parameter 'defaultSecurityRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L660
`❌` MissingTypeObject	The schema 'SecurityRulePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L719
`❌` MissingTypeObject	The schema 'SecurityRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L828
`❌` RequiredPropertiesMissingInResourceModel	Model definition 'SecurityRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L828
`❌` MissingTypeObject	The schema 'SecurityRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L856
`❌` MissingTypeObject	The schema 'NetworkSecurityGroupPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L872
`❌` MissingTypeObject	The schema 'NetworkSecurityGroup' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L930
`❌` RequiredPropertiesMissingInResourceModel	Model definition 'NetworkSecurityGroup' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L930
`❌` MissingTypeObject	The schema 'NetworkSecurityGroupListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L950
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L44
⚠️ RequiredReadOnlySystemData	The response of operation:'NetworkSecurityGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L93
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L99
⚠️ RequiredReadOnlySystemData	The response of operation:'NetworkSecurityGroups_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L148
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L154
⚠️ RequiredReadOnlySystemData	The response of operation:'NetworkSecurityGroups_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L218
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L224
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L283
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L322
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L368
⚠️ RequiredReadOnlySystemData	The response of operation:'SecurityRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L424

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L66:22 ExampleUrl: stable/2022-07-01/examples/NetworkSecurityGroupDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-07-01/networkSecurityGroup.json#L397:22 ExampleUrl: stable/2022-07-01/examples/NetworkSecurityGroupRuleDelete.json

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-02-10T06:03:51Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-network - 31.0.0

+	Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken
+	Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top
+	Interface AdminRulesListNextOptionalParams no longer has parameter skipToken
+	Interface AdminRulesListNextOptionalParams no longer has parameter top
+	Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken
+	Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top
+	Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
+	Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
+	Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken
+	Interface NetworkGroupsListNextOptionalParams no longer has parameter top
+	Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand
+	Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken
+	Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top
+	Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken
+	Interface NetworkManagersListNextOptionalParams no longer has parameter top
+	Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken
+	Interface ScopeConnectionsListNextOptionalParams no longer has parameter top
+	Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken
+	Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top
+	Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes
+	Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName
+	Interface StaticMembersListNextOptionalParams no longer has parameter skipToken
+	Interface StaticMembersListNextOptionalParams no longer has parameter top
+	Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
+	Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
+	Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken
+	Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top

️❌ azure-sdk-for-net failed [Detail]

❌Code Generator Failed [Logs] Generate from 1c3811a7165a0765acd8d60ed9bc59b245953994. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]

cmderr	[msbuild] The command could not be loaded, possibly because:
cmderr	[msbuild]   * You intended to execute a .NET application:
cmderr	[msbuild]       The application 'msbuild' does not exist.
cmderr	[msbuild]   * You intended to execute a .NET SDK command:
cmderr	[msbuild]       A compatible .NET SDK was not found.
cmderr	[msbuild] Requested SDK version: 7.0.101
cmderr	[msbuild] global.json file: /mnt/vss/_work/1/s/azure-sdk-for-net/global.json
cmderr	[msbuild] Installed SDKs:
cmderr	[msbuild] Install the [7.0.101] .NET SDK or update [/mnt/vss/_work/1/s/azure-sdk-for-net/global.json] to match an installed SDK.
cmderr	[msbuild] Learn about SDK resolution:
cmderr	[msbuild] https://aka.ms/dotnet/sdk-not-found
error	Script return with result [failed] code [145] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 1c3811a7165a0765acd8d60ed9bc59b245953994. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Network [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.Network.1.2.0-alpha.20230210.1.nupkg
```
info	[Changelog]
```

️🔄 azure-sdk-for-python-track2 inProgress [Detail]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 1c3811a7165a0765acd8d60ed9bc59b245953994. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 1c3811a7165a0765acd8d60ed9bc59b245953994. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ApplicationGatewaySKUNameStandardBasic` added to type alias `ApplicationGatewaySKUName`
info	[Changelog] - New value `ApplicationGatewayTierStandardBasic` added to type alias `ApplicationGatewayTier`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 2 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 1c3811a7165a0765acd8d60ed9bc59b245953994. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-network-31.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Enum KnownApplicationGatewaySkuName has a new value StandardBasic
info	[Changelog]   - Enum KnownApplicationGatewayTier has a new value StandardBasic
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface AdminRulesListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface AdminRulesListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface NetworkGroupsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand
info	[Changelog]   - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface NetworkManagersListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ScopeConnectionsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes
info	[Changelog]   - Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName
info	[Changelog]   - Interface StaticMembersListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface StaticMembersListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Failed [Logs] Generate from 1c3811a7165a0765acd8d60ed9bc59b245953994. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.network [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-02-10T06:03:52Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/7b6ce5ef1c124ae5bc8e5efa3167f610
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/981766b84a4e4180bbff17d864c74111
.Net	Azure.ResourceManager.Network	There is no API change compared with the previous version
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/327888faf5b0478eb591c9c7731cc371

openapi-workflow-bot · 2023-02-10T06:22:03Z

Hi @navba-MSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

openapi-workflow-bot · 2023-02-10T06:22:04Z

Hi @navba-MSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

lirenhe · 2023-02-10T10:38:56Z

@navba-MSFT, please follow the below guide for breaking change review.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

@MikhailTryakhov, please review this PR.

navba-MSFT · 2023-02-13T06:52:54Z

Waiting for the review from Service team

navba-MSFT · 2023-03-02T08:58:19Z

Creating a new PR to fix it in latest version 2022-09-01 . So closing this PR as a duplicate of #22874

navba-MSFT requested a review from MikhailTryakhov as a code owner February 10, 2023 06:03

openapi-assignment-bot bot assigned lirenhe Feb 10, 2023

ghost added the Network label Feb 10, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Feb 10, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Feb 10, 2023

azure-sdk mentioned this pull request Feb 10, 2023

[AutoPR Microsoft.Azure.Management.Network] {AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required azure-sdk/azure-sdk-for-net#2641

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 13, 2023

navba-MSFT closed this Mar 2, 2023

navba-MSFT deleted the navba-MSFT-patch-9 branch March 2, 2023 09:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

{AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required #22546

{AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required #22546

navba-MSFT commented Feb 10, 2023 •

edited

Loading

openapi-workflow-bot bot commented Feb 10, 2023

openapi-pipeline-app bot commented Feb 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 10, 2023 •

edited

Loading

openapi-workflow-bot bot commented Feb 10, 2023

openapi-workflow-bot bot commented Feb 10, 2023

lirenhe commented Feb 10, 2023

navba-MSFT commented Feb 13, 2023

navba-MSFT commented Mar 2, 2023

{AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required #22546

{AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required #22546

Conversation

navba-MSFT commented Feb 10, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 10, 2023

openapi-pipeline-app bot commented Feb 10, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 10, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 10, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Feb 10, 2023

openapi-workflow-bot bot commented Feb 10, 2023

lirenhe commented Feb 10, 2023

navba-MSFT commented Feb 13, 2023

navba-MSFT commented Mar 2, 2023

navba-MSFT commented Feb 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2023 •

edited

Loading