Sync main branch to Dev sql microsoft.sql 2022 08 01 preview (no change anything) #22553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add PDS swagger specification. * Use default instead of multiple error codes. * Add desctiptions. * Fix error response model. * Update PDS api specifications as per API guidelines * Pretty. * Correct example. * fix dug property. * Remove from custom words. * Fix linting errors. * Fix errors. * Fix conflict. * Fix examples. * Fix linting errors. * Linting errors. * Linting errors. * Fix operatio Id. * Fix x-ms-pageable. * Add filter description. Co-authored-by: Gaurav Gupta <gauravgupta@microsoft.com>
* AAD Domain Services: Add 2022-12-01 API version * Update all api-version in files to latest 2022-12-01 version * Add SyncApplicationId property to domainservices.json * pr review feedback on the property description
…ure#21746) * [AutoSync] 3a0ff3ca9 Merged PR 7162965: fix: add missing change * Update readme.md Co-authored-by: swagger-automation <swagger@microsoft.com>
…version stable/2022-10-01 (Azure#21450) * Adds base for updating Microsoft.RecoveryServices from version preview/2022-09-01-preview to version 2022-10-01 * Updates readme * Updates API version in new specs and examples * moving latest preview to stable Co-authored-by: Himanshu Agarwal <himanshu.123j@gmail.com>
* Add more parameters to common types * Put back the line at the end of the file * Skip URL encoding on already-encoded parameter
…1717) * add or modify files * Fixed spellcheck validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * avacado fix * avacado fix * avacado fix * avacado fix' * avacado fix * avacado fix * revert custom-words.txt * update custom-words.txt * updated PreCheckResult * removed SystemData * removed SystemData Co-authored-by: Aditya Ravishankar <ravishankara@microsoft.com>
* add or modify files * Update FileSystems_CreateOrUpdate_MaximumSet_Gen.json * Adding 2022-06-27 preview folder * Adding custom-words.txt * Adding Qumulo.Storage in ./custom.txt file * Adding id in the response * Fixed ModelValidation errors * Fixed prettier issue * Reverting FileSystems_CreateOrUpdate_MaximumSet_Gen.json * Fixed prettier issue * Adding cadl file * Adding examples for cadl * Removing readme file * Adding read me files * /Removing read me files * Adding Read me all supported languages * Changed python readme * Removing npmrc and cadl-project.yaml * Moved the cadl under resource-manager and added cadl to support both API versions * Adding readme files * Removing read me * Adding .gitignore file * Removing examples * Renaming to cadl folder * Renaming cadl folder to Qumulo.Management * Formatted cadl file * Formatted cadl file * Adding examples in Qumulo.Management * adding cadl-project.yaml * Adding new package.json * Reverting examples in Qumulo.Management * Adding examples in Qumulo.Management Co-authored-by: shamsthabrez <shamsthabrez@microsoft.com>
…rsion stable/2022-05-01 (Azure#21588) * Adds base for updating Microsoft.ResourceHealth from version preview/2022-05-01-preview to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Changes to example files for ImpactedResources. * was told to add a pattern restiction * was told to add a pattern restiction Co-authored-by: ABHISHEK SINGHAL <abhsinghal@microsoft.com>
* Previous API Version 2022-04-01 * add new api 2022-09-04 refactor list install versions * Add patterns, remove 201s for PUTs * Update examples * Remove patterns, add back 201s for PUTs * Fix response codes * Remove patterns * Update examples * Update readme.python.md * Removed 201 modified from added resources * Satisfy ModelValidation. * Implement pattern restrictions on new resources Co-authored-by: Ross Bryan <robryan@redhat.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
…work-2022-11-01' (Azure#21752) * add or modify files * Use "5Qi" as the schema to define Default QoS Flow 5G QoS Indicator value. (Azure#9817) On SIM policy we use the 'Default QoS Flow 5G QoS Indicator value', we were incorrectly using the '5QiPriorityLevel' schema (which is an interger between 1 and 127 as per https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/mobilenetwork/resource-manager/Microsoft.MobileNetwork/stable/2022-11-01/ts29571.json#L117. We should have used 5Qi - an integer between 0 and 255. We made a mistake when we first p ut this in and have no spotted it. Even though changing the allowed values for a property is a breaking change, we think this is acceptable because: 1) This is our first stable API, there is no pre-existing stable API we need to be back-compatible with 2) 2022-04-01-preview to 2022-11-01 already contains breaking changes that we have discussed in https://eng.ms/docs/strategic-missions-and-technologies/strategic-missions-and-technologies-organization/azure-for-operators/packet-core/private-mobile-network/azure-private-5g-core/cross-team/releases/2022-11-01-arm-api/back-compatibility 3) We have one customer who may need to use values 128-255 -> if that customer does PUTs with the 2022-11-01 API then a GET with the 2022-04-01, it will fail, while this is sad, we think this is an acceptable risk. * Update ICCID definition to support shorter ICCID (Azure#9910) GSM 11.1 Version 8 has been replaced by 3GPP TS 11.11, which itself has been replaced by 3GPP TS 102.211 Rel 16, and all of them share the same information for the definition of ICCID. ISO/IEC 7812-1 2017, ITU-T E.118 - 05/2006 and 3GPP TS 102.211 all alllow ICCID/Primary Account Numbers which are shorter than 19 digits. While ISO/IEC 7812-1 2017 and ITU-T E.118 - 05/2006 both require a maximum number of digits of 19, and GSM 11.11 is clear than 20 digits ICCID are allowed to be grandfathered in. ITU-T E.118 - 05/2006 mandates that all new SIM cards use a prefix of 89, but allows 66 as a transitional mechanism for older SIM cards. ISO/IEC 7812-1 2017 mandates a minimum length of 10 digits. No other specification comments on a minimum size, so we go with this. The original validation was based on an incorrect reading of the specs, where 19 and 20 were assumed to be the only valid lengths, and the comment on the transitional mechanism was missed. Even though changing the allowed values for a property is a breaking change, we think this is acceptable because: 1) This is our first stable API, there is no pre-existing stable API we need to be back-compatible with 2) 2022-04-01-preview to 2022-11-01 already contains breaking changes that we have discussed in https://eng.ms/docs/strategic-missions-and-technologies/strategic-missions-and-technologies-organization/azure-for-operators/packet-core/private-mobile-network/azure-private-5g-core/cross-team/releases/2022-11-01-arm-api/back-compatibility 3) We have customers who are currently blocked and having to work around this restriction, and it's acceptable for them to be unable to resubmit the data on the old API. 4) This is relaxing the restriction on a optional field, so the impact of this change is restricted anyway. 5) Not making this change leaves the product ill defined for ever. * Remove reference to 2021-04-01-preview API in readme * Fix python output-folder * Update readme.python.md Co-authored-by: Richard Whitehouse <github@richardwhiuk.com> Co-authored-by: Andrew Lee <andrewlee@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
* Adds base for updating Microsoft.App from version preview/2022-06-01-preview to version 2022-10-01 * Updates readme * Updates API version in new specs and examples * Add AppState and LatestReadyRevisionName (Azure#21034) * Add new props * add defaults * Add swagger for client cert & CORS policy (Azure#21126) * Fix password format of env domain for 2022-10-01 (Azure#21463) * fix * fix * Remove AppState property as we decided to postpone it (Azure#21483) * Remove AppState property as we decided to postpone it * Fix swagger issues * More swagger fixes * s360 swagger correctness fixes (Azure#21472) Co-authored-by: Nan Jiang <naji@microsoft.com> * Add kind for managed environment (Azure#21589) * add * fix * fix (Azure#21730) * fix (Azure#21747) Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com> Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: najian <jiangnan8924@gmail.com> Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
… version preview/2022-08-01-preview (Azure#21422) * Adds base for updating Microsoft.SqlVirtualMachine from version preview/2022-07-01-preview to version 2022-08-01-preview * Updates readme * Updates API version in new specs and examples * Adding 2022-08-01-preview version for Sql Virtual Machine swagger * move all api-version to 2022-08-01-preview * fix the following validation errors: R4041 - XmsIdentifierValidation R4009 - RequiredReadOnlySystemData * add location for 202 reponse * fix typo * fix LRO_RESPONSE_HEADER validation error * fix Swagger PrettierCheck * fix 1047 - XmsEnumChanged, manually move IdentityTypeWithNone to IdentityType * fix DefinitionsPropertiesNamesCamelCase, adding azureADAuthenticationSettings to the custom-words.txt * adding azureADAuthenticationSettings in the alphabetical position. * fix PostOperationAsyncResponseValidation and LroLocationHeader errors * fix typo * missing quote * adding quote * fix DefinitionsPropertiesNamesCamelCase * remove azureADAuthenticationSettings * fix ResourceNameRestriction * use \" to escape " * fix swagger regex syntax difference comparing to C# regex * addressing one comment from ARM team to add error response schema for the default response: * fix 202 response: 1. adding Location header 2. adding specify x-ms-long-running-operation-options * UnHealthyReplica to UnhealthyReplica uuHealthyReplica to unhealthyReplica * TroubleShoot to Troubleshoot troubleShoot to troubleshoot * "UTC format" to "UTC timezone" * SqlVmTroubleshoot to SqlVmTroubleshooting * Successfully started SQL virtual machine troubleshoot to Successfully started SQL virtual machine troubleshooting and similar cases * "SQL Iaas Extension" to "SQL IaaS Extension" * Assessment to "an assessment" and other similiar issues * resolve conflict for custom-words.txt * resolve conflict * adding default for troubleshootingScenario * refactor all sqlVirtualMachineName into common definition and reference it elsewhere * add x-ms-long-running-operation-options with azure-async-operation * remove Location header from the Post request * add back the Location header for the Post method, as the validation checks it * add response schema to HA troubleshooting endpoint 200 response. * add "default" to false for SQL IAAS auto upgrade property * renaming: troubleshootStatus => troubleshootingStatus unhealthyReplicaProperties => unhealthyReplicaInfo * update the HA troubleshooting example after the renaming in this endpoint * rewording Assessment as SQL best practices Assessment after consulting with PM. * revert custom-words.tx file Co-authored-by: Qiang Liu <qianliu@microsoft.com>
…ive terminology (Azure#21069) * Delete term AADP from custom-words as its not a commonly known acronym. * Delete term 'accountid' from custom-words.txt. You should use proper casing and spacing according to context, such as 'AccountId', 'accountId', 'accountID', 'account ID', or so on, instead. * Delete a whole lot of terms that don't seem to be used anywhere in the specification folder according to a cursory search. * Delete many duplicates from custom-words.txt * Use cSpell.json to quarantine away some misspelled words from custom-words.txt. And remove duplicates of PPSX and PPTM. * 'Mwarev' should not be a word. Terms like 'VMwarevSphere' 'vmware', 'vSphere' should be words instead. * Using cSpell and custom-words better. 'targetv' should not be a custom word in order to allow 'targetvCenterId'. * Actually remove UNKNOWON from custom-words now that it has a cSpell.json exception. * Updation is not a real word. * Sort 'vcenters' * Expand away the nonstandard capitalized acronym Vrops from old documentation, * Noreuse isn't a proper word, so making it a cSpell exception. * Sort 'cadl' * Retire some references to whitelists from documentation. * Replace */* with **
* create 2022-09-04 cloudService Folder * update references to new version * update readme and fix common.json divergence * Adding zones, example and renaming IP to Ip in cloudservices swagger (Azure#21232) * Adding zones, example and renaming frontendIPConfigurations to frontendIpConfigurations, LoadBalancerFrontendIPConfiguration to LoadBalancerFrontendIpConfiguration, LoadBalancerFrontendIPConfigurationProperties to LoadBalancerFrontendIpConfigurationProperties * resolving CI validations * changing privateIPAddress to privateIpAddress, publiCIPAddress to ppublicIpAddress * reverting publicIpAddress, privateIpAddress to privateIPAddress, publicIPAddress * removing x-ms-client-flatten and parameter order change Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: ashvermamsft <70934942+ashvermamsft@users.noreply.github.com>
* Updates for Face PersonDirectory Add parameter descriptions, and add flatten flags for currently nested request body. * Another description update * More
Co-authored-by: Tianxiang Chen <tianxchen@microsoft.com>
* TASK 2104196: Adding a new API version to AzureArcData In this commit, I just copied over all the current files in 2022-03-01-preview to 2022-06-01-preview so that it serves as a base commit. I will add all new files on top of this commit to make main branch at par with RPSaaSMaster. * Added the new changes on top of base version * Updated the readme file
* don't close and mark PR as stable for customer-reported PR * Update fabricbot.json
* Initial Commit * Example Changes * Parameter Changes * Parameter Changes * Definition Changes * Semantic Fix * Lint error Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <vamshikrishna.chirra@quadrantresource.com>
…zure#21583) * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * Private endpoint changes * updated examples * updated db update example * build fixes * changed common-types version * pr comments * minor update * Removed 202 response code from Put call * update examples * prettier fix * enum example fix * Incremental change of sensor feature * Adding support for operationResults api for farmbeats resource. * Making cosmetic changes to fix checks * Update readme.python.md pin the title for python SDK * Fixing one change * Rsolving comments * FarmBeats Solution API Review * fixed error * pr comment change * fixing errors * fixing semantic validation errors * example file changes * fixing errors * pr update fields * prettier fix * solution api changes updated * revert changes in custom words file * Swagger Spell check fix * new changes updated in solution definitions * solution discoverability example file change * changes updated * changes updated * changes updated * comment changes * rebaseing main branch * adding solutions resource in swagger * rebasing main branch * solutions resource added in paths * Solution properties added in definitions * solution Id added in parameters * model validation error fix * model validation errors fixes * changes updated Co-authored-by: Prabhav Gupta <prabhavgupta1996@gmail.com> Co-authored-by: Prabhav Gupta <prabgupt@microsoft.com> Co-authored-by: Priyanka Jayaswal <prjayasw@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
…ad the spec, causing global outages for RPaaS RPs (Azure#21860)
ericshape
requested review from
a team,
DominikMe,
weidongxu-microsoft and
raych1
and removed request for
deyaaeldeen,
kristapratico,
mssfang,
yangyuan,
jorinmejia,
yunheMsft,
t-bzhan,
wilcobmsft,
asarkar84,
paterasMSFT,
dpwatrous,
stankovski,
solankisamir,
ofirmanor,
orieldar,
markweitzel,
bexxx and
a team
ericshape
changed the title
@raych1 I have marked this PR as ready. thanks~ |
|
If target is dev branch, you team (backend) should be able to approve and merge. Note there is lots of CI failure. |
@weidongxu-microsoft I just use git merge main to sync the main branch into the dev branch. |
raych1
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.