Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-01-preview #23171

Merged
merged 12 commits into from
Apr 4, 2023
Merged

[Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-01-preview #23171

merged 12 commits into from
Apr 4, 2023

Conversation

RenzoPrettoMS
Copy link
Contributor

@RenzoPrettoMS RenzoPrettoMS commented Mar 17, 2023 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @RenzoPrettoMS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 17, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    capabilities.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    capabilityTypes.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    experiments.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    operations.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    targetTypes.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    targets.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    capabilities.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    capabilityTypes.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    common.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    experiments.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    targetTypes.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    targets.json 2023-04-01-preview(b46b17e) 2022-10-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-04 package-preview-2023-04(b46b17e) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L266


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'Capabilities_List' does not match the response definition in the individual GET operation 'Capabilities_Get' .
    Location: Microsoft.Chaos/preview/2023-04-01-preview/capabilities.json#L37
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'CapabilityTypes_List' does not match the response definition in the individual GET operation 'CapabilityTypes_Get' .
    Location: Microsoft.Chaos/preview/2023-04-01-preview/capabilityTypes.json#L37
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'Experiments_ListAll' does not match the response definition in the individual GET operation 'Experiments_Get' .
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L37
    ❌ PostOperationAsyncResponseValidation An async POST operation must set ''x-ms-long-running-operation' : true''.
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L311
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L311
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L332
    ❌ PostOperationAsyncResponseValidation An async POST operation must set ''x-ms-long-running-operation' : true''.
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L353
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L353
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L374
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'Experiments_ListAllStatuses' does not match the response definition in the individual GET operation 'Experiments_GetStatus' .
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L394
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'Experiments_ListExecutionDetails' does not match the response definition in the individual GET operation 'Experiments_GetExecutionDetails' .
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L484
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'Targets_List' does not match the response definition in the individual GET operation 'Targets_Get' .
    Location: Microsoft.Chaos/preview/2023-04-01-preview/targets.json#L37
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'TargetTypes_List' does not match the response definition in the individual GET operation 'TargetTypes_Get' .
    Location: Microsoft.Chaos/preview/2023-04-01-preview/targetTypes.json#L37
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/capabilities.json#L44
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/capabilities.json#L101
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/capabilities.json#L153
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/capabilities.json#L205
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/capabilityTypes.json#L44
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/capabilityTypes.json#L92
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L44
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L89
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L137
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L177
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L217
    ⚠️ LroExtension Operations with a 202 response should specify x-ms-long-running-operation: true.
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L311
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L317
    ⚠️ LroExtension Operations with a 202 response should specify x-ms-long-running-operation: true.
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L353
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L359
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L401
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Chaos/preview/2023-04-01-preview/experiments.json#L446
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ Error "\nfatal error: ENOENT: no such file or directory,
    open '/mnt/vss/_work/1/azure-rest-api-specs/specification/chaos/resource-manager/Microsoft.Chaos/preview/2023-04-01-preview/scenarios/basic.yaml',
    "errno":-2,
    "code":"ENOENT",
    "syscall":"open",
    "path":"/mnt/vss/_work/1/azure-rest-api-specs/specification/chaos/resource-manager/Microsoft.Chaos/preview/2023-04-01-preview/scenarios/basic.yaml"\n"
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 17, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/chaos/armchaos - 0.6.0
    +	Operation `*ExperimentsClient.BeginCancel` has been changed to non-LRO, use `*ExperimentsClient.Cancel` instead.
+	Operation `*ExperimentsClient.BeginCreateOrUpdate` has been changed to non-LRO, use `*ExperimentsClient.CreateOrUpdate` instead.


    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 22d6be2. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.3` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-chaos [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ExperimentsOperations.update
info	[Changelog]   - Model CapabilityType has a new parameter permissions_necessary
info	[Changelog]   - Model ResourceIdentity has a new parameter user_assigned_identities
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 22d6be2. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/chaos/armchaos [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*ExperimentsClient.BeginCancel` has been changed to non-LRO, use `*ExperimentsClient.Cancel` instead.
info	[Changelog] - Operation `*ExperimentsClient.BeginCreateOrUpdate` has been changed to non-LRO, use `*ExperimentsClient.CreateOrUpdate` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ResourceIdentityTypeUserAssigned` added to enum type `ResourceIdentityType`
info	[Changelog] - New enum type `FilterType` with values `FilterTypeSimple`
info	[Changelog] - New function `*ExperimentsClient.Update(context.Context, string, string, ExperimentUpdate, *ExperimentsClientUpdateOptions) (ExperimentsClientUpdateResponse, error)`
info	[Changelog] - New function `*Filter.GetFilter() *Filter`
info	[Changelog] - New function `*SimpleFilter.GetFilter() *Filter`
info	[Changelog] - New struct `CapabilityTypePropertiesPermissionsNecessary`
info	[Changelog] - New struct `CapabilityTypePropertiesRuntimeProperties`
info	[Changelog] - New struct `ComponentsEwb5TmSchemasUserassignedidentitiesAdditionalproperties`
info	[Changelog] - New struct `ExperimentUpdate`
info	[Changelog] - New struct `SimpleFilter`
info	[Changelog] - New struct `SimpleFilterParameters`
info	[Changelog] - New field `Kind` in struct `CapabilityTypeProperties`
info	[Changelog] - New field `PermissionsNecessary` in struct `CapabilityTypeProperties`
info	[Changelog] - New field `RuntimeProperties` in struct `CapabilityTypeProperties`
info	[Changelog] - New field `UserAssignedIdentities` in struct `ResourceIdentity`
info	[Changelog] - New field `Filter` in struct `Selector`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 22 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 22d6be2. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-chaos [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation Experiments.update
info	[Changelog]   - Added Interface CapabilityTypePropertiesPermissionsNecessary
info	[Changelog]   - Added Interface ComponentsEwb5TmSchemasUserassignedidentitiesAdditionalproperties
info	[Changelog]   - Added Interface ExperimentsUpdateOptionalParams
info	[Changelog]   - Added Interface ExperimentUpdate
info	[Changelog]   - Added Type Alias ExperimentsUpdateResponse
info	[Changelog]   - Interface CapabilityType has a new optional parameter permissionsNecessary
info	[Changelog]   - Interface ResourceIdentity has a new optional parameter userAssignedIdentities
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 22d6be2. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 22d6be2. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.chaos.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 17, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/chaos/armchaos https://apiview.dev/Assemblies/Review/a9f235750b954a939672e58b5d6a135d
    Java azure-resourcemanager-chaos https://apiview.dev/Assemblies/Review/609f4bef15f34a30b439761ee958702c
    JavaScript @azure/arm-chaos https://apiview.dev/Assemblies/Review/2f8bcf7d60f54bc5850c886ac755d86c

    This was referenced Mar 17, 2023
    Closed
    Closed
    This was referenced Mar 17, 2023
    Closed
    Closed
    Closed
    @RenzoPrettoMS
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @RenzoPrettoMS
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @RenzoPrettoMS RenzoPrettoMS force-pushed the RenzoPrettoMS-chaos-Microsoft.Chaos-2023-04-01-preview branch from 27cfc33 to 592f5a4 Compare March 18, 2023 01:31
    @RenzoPrettoMS
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @RenzoPrettoMS RenzoPrettoMS force-pushed the RenzoPrettoMS-chaos-Microsoft.Chaos-2023-04-01-preview branch from 592f5a4 to 1d1079c Compare March 18, 2023 01:41
    @RenzoPrettoMS
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @RenzoPrettoMS RenzoPrettoMS force-pushed the RenzoPrettoMS-chaos-Microsoft.Chaos-2023-04-01-preview branch from 1d1079c to 37ec657 Compare March 18, 2023 01:59
    @brrusino brrusino changed the title [Hub Generated] Review request for Microsoft.Chaos to add version preview/2022-10-01-preview [Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-01-preview Mar 21, 2023
    @RenzoPrettoMS RenzoPrettoMS marked this pull request as ready for review March 21, 2023 20:48
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 21, 2023
    @RenzoPrettoMS
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 22, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 22, 2023
    @azure-sdk azure-sdk mentioned this pull request Mar 22, 2023
    Closed
    @RenzoPrettoMS RenzoPrettoMS force-pushed the RenzoPrettoMS-chaos-Microsoft.Chaos-2023-04-01-preview branch 2 times, most recently from e6e97cc to 4e8faad Compare March 22, 2023 17:50
    @RenzoPrettoMS RenzoPrettoMS force-pushed the RenzoPrettoMS-chaos-Microsoft.Chaos-2023-04-01-preview branch from 4e8faad to b51dc6b Compare March 22, 2023 17:52
    @konrad-jamrozik konrad-jamrozik mentioned this pull request Mar 28, 2023
    Closed
    @XiaofeiCao XiaofeiCao merged commit 22d6be2 into main Apr 4, 2023
    @XiaofeiCao XiaofeiCao deleted the RenzoPrettoMS-chaos-Microsoft.Chaos-2023-04-01-preview branch April 4, 2023 03:48
    This was referenced Apr 4, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    @RenzoPrettoMS @brrusino @JoshLove-msft
    [Hub Generated] Review request for Microsoft.Chaos to add version pre…
    affa1e7 
    …view/2023-04-01-preview (Azure#23171)

* Adds base for updating Microsoft.Chaos from version preview/2022-10-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* chore: update resource identity type and add user assigned identity type

* chore: added patch call and experiment update definition

* chore: add patch example and fix patch validation issues

* chore: fixed lint and prettier checks

* chore: add permission information for capability types

* chore: add permission information for capability types and fix lint issue

* chore: update example for lint issue

* fixed prettier error

---------

Co-authored-by: Brent Rusinow <brrusino@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @XiaofeiCao XiaofeiCao XiaofeiCao approved these changes

    Assignees

    @XiaofeiCao XiaofeiCao

    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @RenzoPrettoMS @XiaofeiCao @raosuhas @AzureRestAPISpecReview @brrusino