Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Communication to add version stable/2023-03-31 #23202

Merged
merged 3 commits into from
Mar 27, 2023
Merged

[Hub Generated] Review request for Microsoft.Communication to add version stable/2023-03-31 #23202

merged 3 commits into from
Mar 27, 2023

Conversation

matthohn-msft
Copy link
Member

@matthohn-msft matthohn-msft commented Mar 21, 2023 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @matthohn-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    CommunicationServices.json 2023-03-31(bbee55e) 2023-03-01-preview(main)
    Domains.json 2023-03-31(bbee55e) 2023-03-01-preview(main)
    EmailServices.json 2023-03-31(bbee55e) 2023-03-01-preview(main)
    SenderUsernames.json 2023-03-31(bbee55e) 2023-03-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2023-03 package-2023-03(bbee55e) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.Communication' for api version '2023-03-31'. The supported api-versions are '2020-08-20-preview,
    2020-08-20,
    2021-10-01-preview,
    2022-07-01-preview,
    2022-10-01-preview,
    2022-03-29-preview'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/communication/armcommunication - Approved - 2.0.0
    +	Function `*ServiceClient.BeginCreateOrUpdate` has been removed
+	Function `*ServiceClient.BeginDelete` has been removed
+	Function `*ServiceClient.CheckNameAvailability` has been removed
+	Function `*ServiceClient.Get` has been removed
+	Function `*ServiceClient.LinkNotificationHub` has been removed
+	Function `*ServiceClient.ListKeys` has been removed
+	Function `*ServiceClient.NewListByResourceGroupPager` has been removed
+	Function `*ServiceClient.NewListBySubscriptionPager` has been removed
+	Function `*ServiceClient.RegenerateKey` has been removed
+	Function `*ServiceClient.Update` has been removed
+	Function `NewServiceClient` has been removed
+	Struct `LocationResource` has been removed
+	Struct `NameAvailability` has been removed
+	Struct `ServiceClient` has been removed
+	Type of `ServiceProperties.ProvisioningState` has been changed from `*ProvisioningState` to `*CommunicationServicesProvisioningState`
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-communication - Approved - 2.0.0b2
    -	Model DomainResource no longer has parameter valid_sender_usernames
-	Model UpdateDomainRequestParameters no longer has parameter valid_sender_usernames
-	Removed operation CommunicationServicesOperations.begin_regenerate_key
-	Removed operation CommunicationServicesOperations.begin_update
+	Parameter location of model CommunicationServiceResource is now required
+	Removed operation group CommunicationServiceOperations
+	Removed operation group OperationStatusesOperations
    ❌azure-sdk-for-js - @azure/arm-communication - Approved - 4.0.0
    +	Class CommunicationServiceManagementClient no longer has parameter communicationService
+	Removed operation group CommunicationService
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7248457. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.2` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-communication [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group CommunicationServicesOperations
info	[Changelog]   - Added operation group DomainsOperations
info	[Changelog]   - Added operation group EmailServicesOperations
info	[Changelog]   - Added operation group SenderUsernamesOperations
info	[Changelog]   - Model CommunicationServiceResource has a new parameter linked_domains
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Parameter location of model CommunicationServiceResource is now required
info	[Changelog]   - Removed operation group CommunicationServiceOperations
info	[Changelog]   - Removed operation group OperationStatusesOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7248457. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/communication/armcommunication [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ServiceProperties.ProvisioningState` has been changed from `*ProvisioningState` to `*CommunicationServicesProvisioningState`
info	[Changelog] - Function `NewServiceClient` has been removed
info	[Changelog] - Function `*ServiceClient.CheckNameAvailability` has been removed
info	[Changelog] - Function `*ServiceClient.BeginCreateOrUpdate` has been removed
info	[Changelog] - Function `*ServiceClient.BeginDelete` has been removed
info	[Changelog] - Function `*ServiceClient.Get` has been removed
info	[Changelog] - Function `*ServiceClient.LinkNotificationHub` has been removed
info	[Changelog] - Function `*ServiceClient.NewListByResourceGroupPager` has been removed
info	[Changelog] - Function `*ServiceClient.NewListBySubscriptionPager` has been removed
info	[Changelog] - Function `*ServiceClient.ListKeys` has been removed
info	[Changelog] - Function `*ServiceClient.RegenerateKey` has been removed
info	[Changelog] - Function `*ServiceClient.Update` has been removed
info	[Changelog] - Struct `LocationResource` has been removed
info	[Changelog] - Struct `NameAvailability` has been removed
info	[Changelog] - Struct `ServiceClient` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `CheckNameAvailabilityReason` with values `CheckNameAvailabilityReasonAlreadyExists`, `CheckNameAvailabilityReasonInvalid`
info	[Changelog] - New enum type `CommunicationServicesProvisioningState` with values `CommunicationServicesProvisioningStateCanceled`, `CommunicationServicesProvisioningStateCreating`, `CommunicationServicesProvisioningStateDeleting`, `CommunicationServicesProvisioningStateFailed`, `CommunicationServicesProvisioningStateMoving`, `CommunicationServicesProvisioningStateRunning`, `CommunicationServicesProvisioningStateSucceeded`, `CommunicationServicesProvisioningStateUnknown`, `CommunicationServicesProvisioningStateUpdating`
info	[Changelog] - New enum type `DomainManagement` with values `DomainManagementAzureManaged`, `DomainManagementCustomerManaged`, `DomainManagementCustomerManagedInExchangeOnline`
info	[Changelog] - New enum type `DomainsProvisioningState` with values `DomainsProvisioningStateCanceled`, `DomainsProvisioningStateCreating`, `DomainsProvisioningStateDeleting`, `DomainsProvisioningStateFailed`, `DomainsProvisioningStateMoving`, `DomainsProvisioningStateRunning`, `DomainsProvisioningStateSucceeded`, `DomainsProvisioningStateUnknown`, `DomainsProvisioningStateUpdating`
info	[Changelog] - New enum type `EmailServicesProvisioningState` with values `EmailServicesProvisioningStateCanceled`, `EmailServicesProvisioningStateCreating`, `EmailServicesProvisioningStateDeleting`, `EmailServicesProvisioningStateFailed`, `EmailServicesProvisioningStateMoving`, `EmailServicesProvisioningStateRunning`, `EmailServicesProvisioningStateSucceeded`, `EmailServicesProvisioningStateUnknown`, `EmailServicesProvisioningStateUpdating`
info	[Changelog] - New enum type `UserEngagementTracking` with values `UserEngagementTrackingDisabled`, `UserEngagementTrackingEnabled`
info	[Changelog] - New enum type `VerificationStatus` with values `VerificationStatusCancellationRequested`, `VerificationStatusNotStarted`, `VerificationStatusVerificationFailed`, `VerificationStatusVerificationInProgress`, `VerificationStatusVerificationRequested`, `VerificationStatusVerified`
info	[Changelog] - New enum type `VerificationType` with values `VerificationTypeDKIM`, `VerificationTypeDKIM2`, `VerificationTypeDMARC`, `VerificationTypeDomain`, `VerificationTypeSPF`
info	[Changelog] - New function `NewClientFactory(string, azcore.TokenCredential, *arm.ClientOptions) (*ClientFactory, error)`
info	[Changelog] - New function `*ClientFactory.NewDomainsClient() *DomainsClient`
info	[Changelog] - New function `*ClientFactory.NewEmailServicesClient() *EmailServicesClient`
info	[Changelog] - New function `*ClientFactory.NewOperationsClient() *OperationsClient`
info	[Changelog] - New function `*ClientFactory.NewSenderUsernamesClient() *SenderUsernamesClient`
info	[Changelog] - New function `*ClientFactory.NewServicesClient() *ServicesClient`
info	[Changelog] - New function `NewDomainsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DomainsClient, error)`
info	[Changelog] - New function `*DomainsClient.BeginCancelVerification(context.Context, string, string, string, VerificationParameter, *DomainsClientBeginCancelVerificationOptions) (*runtime.Poller[DomainsClientCancelVerificationResponse], error)`
info	[Changelog] - New function `*DomainsClient.BeginCreateOrUpdate(context.Context, string, string, string, DomainResource, *DomainsClientBeginCreateOrUpdateOptions) (*runtime.Poller[DomainsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*DomainsClient.BeginDelete(context.Context, string, string, string, *DomainsClientBeginDeleteOptions) (*runtime.Poller[DomainsClientDeleteResponse], error)`
info	[Changelog] - New function `*DomainsClient.Get(context.Context, string, string, string, *DomainsClientGetOptions) (DomainsClientGetResponse, error)`
info	[Changelog] - New function `*DomainsClient.BeginInitiateVerification(context.Context, string, string, string, VerificationParameter, *DomainsClientBeginInitiateVerificationOptions) (*runtime.Poller[DomainsClientInitiateVerificationResponse], error)`
info	[Changelog] - New function `*DomainsClient.NewListByEmailServiceResourcePager(string, string, *DomainsClientListByEmailServiceResourceOptions) *runtime.Pager[DomainsClientListByEmailServiceResourceResponse]`
info	[Changelog] - New function `*DomainsClient.BeginUpdate(context.Context, string, string, string, UpdateDomainRequestParameters, *DomainsClientBeginUpdateOptions) (*runtime.Poller[DomainsClientUpdateResponse], error)`
info	[Changelog] - New function `NewEmailServicesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*EmailServicesClient, error)`
info	[Changelog] - New function `*EmailServicesClient.BeginCreateOrUpdate(context.Context, string, string, EmailServiceResource, *EmailServicesClientBeginCreateOrUpdateOptions) (*runtime.Poller[EmailServicesClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*EmailServicesClient.BeginDelete(context.Context, string, string, *EmailServicesClientBeginDeleteOptions) (*runtime.Poller[EmailServicesClientDeleteResponse], error)`
info	[Changelog] - New function `*EmailServicesClient.Get(context.Context, string, string, *EmailServicesClientGetOptions) (EmailServicesClientGetResponse, error)`
info	[Changelog] - New function `*EmailServicesClient.NewListByResourceGroupPager(string, *EmailServicesClientListByResourceGroupOptions) *runtime.Pager[EmailServicesClientListByResourceGroupResponse]`
info	[Changelog] - New function `*EmailServicesClient.NewListBySubscriptionPager(*EmailServicesClientListBySubscriptionOptions) *runtime.Pager[EmailServicesClientListBySubscriptionResponse]`
info	[Changelog] - New function `*EmailServicesClient.ListVerifiedExchangeOnlineDomains(context.Context, *EmailServicesClientListVerifiedExchangeOnlineDomainsOptions) (EmailServicesClientListVerifiedExchangeOnlineDomainsResponse, error)`
info	[Changelog] - New function `*EmailServicesClient.BeginUpdate(context.Context, string, string, EmailServiceResourceUpdate, *EmailServicesClientBeginUpdateOptions) (*runtime.Poller[EmailServicesClientUpdateResponse], error)`
info	[Changelog] - New function `NewSenderUsernamesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SenderUsernamesClient, error)`
info	[Changelog] - New function `*SenderUsernamesClient.CreateOrUpdate(context.Context, string, string, string, string, SenderUsernameResource, *SenderUsernamesClientCreateOrUpdateOptions) (SenderUsernamesClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*SenderUsernamesClient.Delete(context.Context, string, string, string, string, *SenderUsernamesClientDeleteOptions) (SenderUsernamesClientDeleteResponse, error)`
info	[Changelog] - New function `*SenderUsernamesClient.Get(context.Context, string, string, string, string, *SenderUsernamesClientGetOptions) (SenderUsernamesClientGetResponse, error)`
info	[Changelog] - New function `*SenderUsernamesClient.NewListByDomainsPager(string, string, string, *SenderUsernamesClientListByDomainsOptions) *runtime.Pager[SenderUsernamesClientListByDomainsResponse]`
info	[Changelog] - New function `NewServicesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ServicesClient, error)`
info	[Changelog] - New function `*ServicesClient.CheckNameAvailability(context.Context, NameAvailabilityParameters, *ServicesClientCheckNameAvailabilityOptions) (ServicesClientCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*ServicesClient.BeginCreateOrUpdate(context.Context, string, string, ServiceResource, *ServicesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ServicesClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*ServicesClient.BeginDelete(context.Context, string, string, *ServicesClientBeginDeleteOptions) (*runtime.Poller[ServicesClientDeleteResponse], error)`
info	[Changelog] - New function `*ServicesClient.Get(context.Context, string, string, *ServicesClientGetOptions) (ServicesClientGetResponse, error)`
info	[Changelog] - New function `*ServicesClient.LinkNotificationHub(context.Context, string, string, *ServicesClientLinkNotificationHubOptions) (ServicesClientLinkNotificationHubResponse, error)`
info	[Changelog] - New function `*ServicesClient.NewListByResourceGroupPager(string, *ServicesClientListByResourceGroupOptions) *runtime.Pager[ServicesClientListByResourceGroupResponse]`
info	[Changelog] - New function `*ServicesClient.NewListBySubscriptionPager(*ServicesClientListBySubscriptionOptions) *runtime.Pager[ServicesClientListBySubscriptionResponse]`
info	[Changelog] - New function `*ServicesClient.ListKeys(context.Context, string, string, *ServicesClientListKeysOptions) (ServicesClientListKeysResponse, error)`
info	[Changelog] - New function `*ServicesClient.RegenerateKey(context.Context, string, string, RegenerateKeyParameters, *ServicesClientRegenerateKeyOptions) (ServicesClientRegenerateKeyResponse, error)`
info	[Changelog] - New function `*ServicesClient.Update(context.Context, string, string, ServiceResourceUpdate, *ServicesClientUpdateOptions) (ServicesClientUpdateResponse, error)`
info	[Changelog] - New struct `CheckNameAvailabilityRequest`
info	[Changelog] - New struct `CheckNameAvailabilityResponse`
info	[Changelog] - New struct `ClientFactory`
info	[Changelog] - New struct `DNSRecord`
info	[Changelog] - New struct `DomainProperties`
info	[Changelog] - New struct `DomainPropertiesVerificationRecords`
info	[Changelog] - New struct `DomainPropertiesVerificationStates`
info	[Changelog] - New struct `DomainResource`
info	[Changelog] - New struct `DomainResourceList`
info	[Changelog] - New struct `EmailServiceProperties`
info	[Changelog] - New struct `EmailServiceResource`
info	[Changelog] - New struct `EmailServiceResourceList`
info	[Changelog] - New struct `EmailServiceResourceUpdate`
info	[Changelog] - New struct `ProxyResource`
info	[Changelog] - New struct `SenderUsernameProperties`
info	[Changelog] - New struct `SenderUsernameResource`
info	[Changelog] - New struct `SenderUsernameResourceCollection`
info	[Changelog] - New struct `ServiceResourceUpdate`
info	[Changelog] - New struct `ServiceUpdateProperties`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New struct `UpdateDomainProperties`
info	[Changelog] - New struct `UpdateDomainRequestParameters`
info	[Changelog] - New struct `VerificationParameter`
info	[Changelog] - New struct `VerificationStatusRecord`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `LinkedDomains` in struct `ServiceProperties`
info	[Changelog]
info	[Changelog] Total 18 breaking change(s), 141 additive change(s).
    ️❌ azure-sdk-for-js failed [Detail]
    • ❌Code Generator Failed [Logs]Release - Generate from 7248457. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh
warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7248457. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.communication.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/communication/armcommunication https://apiview.dev/Assemblies/Review/825ca1ddca8c4230a32f6e85a3bbae15
    Java azure-resourcemanager-communication There is no API change compared with the previous version
    .Net Azure.ResourceManager.Communication There is no API change compared with the previous version

    @azure-sdk azure-sdk mentioned this pull request Mar 21, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Mar 21, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Mar 21, 2023
    Closed
    This was referenced Mar 21, 2023
    Closed
    Closed
    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 21, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @matthohn-msft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @matthohn-msft matthohn-msft marked this pull request as ready for review March 22, 2023 05:15
    @lirenhe
    Copy link
    Member

    lirenhe commented Mar 23, 2023

    @msyyc and @MaryGao, could you take a look at the SDK breaking changes? thanks

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 23, 2023
    @mikekistler
    Copy link
    Member

    The tooling to detect breaking changes does not catch the breaking changes in this PR because the file names were changed (issue has been opened). I added the Approved-BreakingChange label to confirm that the breaking changes have been reviewed and approved.

    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 23, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 23, 2023
    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Mar 24, 2023
    @usvoyager usvoyager added the Communication Services Azure Communication Service label Mar 24, 2023
    @MaryGao MaryGao merged commit 7248457 into main Mar 27, 2023
    @MaryGao MaryGao deleted the matthohn-msft-communication-Microsoft.Communication-2023-03-31-stable-public branch March 27, 2023 03:28
    This was referenced Mar 27, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    @matthohn-msft matthohn-msft mentioned this pull request Mar 28, 2023
    Merged
    11 tasks
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    @matthohn-msft @JoshLove-msft
    [Hub Generated] Review request for Microsoft.Communication to add ver…
    45f9317 
    …sion stable/2023-03-31 (Azure#23202)

* Adds base for updating Microsoft.Communication from version preview/2023-03-01-preview to version 2023-03-31

* Updates readme

* Updates API version in new specs and examples
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @msyyc msyyc msyyc left review comments

    @MaryGao MaryGao MaryGao approved these changes

    Assignees

    @lirenhe lirenhe

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript Communication Services Azure Communication Service new-api-version resource-manager RPaaS
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    9 participants
    @matthohn-msft @lirenhe @mikekistler @MaryGao @msyyc @tadelesh @raosuhas @usvoyager @AzureRestAPISpecReview