Add Workspace Managed Network Swagger #23283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @joshharrin Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
resource-manager
WaitForARMFeedback
|
Hi @joshharrin, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 24, 2023
|
@joshharrin Can you please fix the errors introduced by your current PR here : https://github.com/Azure/azure-rest-api-specs/pull/23283/checks?check_run_id=12263002892 for "Swagger LintDiff" |
raosuhas
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
|
Hi @joshharrin, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
joshharrin
force-pushed
the
joharrington/add-managed-network-to-04-01-preview
branch
from
2a34e93
to
d5d8e14
Compare
joshharrin
force-pushed
the
joharrington/add-managed-network-to-04-01-preview
branch
from
d5d8e14
to
cf504eb
Compare
seanyao1
approved these changes
Mar 28, 2023
joshharrin
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
@raosuhas changes have been made to fix certain validation errors. Remaining Lintdiff errors will not be fixed per discussion within our team. Our service will continue to follow the valid ARM pattern of returning 202 with polling uri in location header for LRO operations same as our other APIs. Please help to approve and merge this PR, I have had teammates review as well. Thanks! cc @seanyao1 |
visingla-ms
reviewed
Mar 30, 2023
...er/Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
visingla-ms
reviewed
Mar 30, 2023
...er/Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
visingla-ms
reviewed
Mar 30, 2023
...er/Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json
Show resolved
Hide resolved
visingla-ms
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
@visingla-ms @raosuhas . Thank you for your comments and recommendations, all have been addressed. Please help approve, thanks. |
joshharrin
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
joshharrin
force-pushed
the
joharrington/add-managed-network-to-04-01-preview
branch
from
1d04c81
to
b19cf5a
Compare
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
visingla-ms
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
Please see comments: #23283 (comment) and #23283 (comment). |
joshharrin
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
ArcturusZhang
approved these changes
Mar 31, 2023
|
lintdiff errors are either false alarms or not intorduced by this PR |
ArcturusZhang
merged commit 72e8f6b
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-04-01-preview
ArcturusZhang
pushed a commit
that referenced
this pull request
Apr 18, 2023
…023 04 01 preview (#23449) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * [Preview] Bring Back Scheduled Shutdown MLC models (#23040) * [Preview] Bring Back Scheduled Shutdown MLC models * update example json --------- Co-authored-by: Naman Agarwal <naagarw@microsoft.com> * add minLength:1 prop to required strings (#23108) * add parameter enableDataIsolation to workspace properties (#23061) * add parameter enableDataIsolation to workspace properties * minor change to re-run the test pipelines * minor comment change to trigger the test pipeline again --------- Co-authored-by: Mingwei He <mingweihe@microsoft.com> * expose connection expiryTime in 2023-04-01-preview swagger (#23118) * Add Workspace Managed Network Swagger (#23283) * add managed network swagger * fix validation errors * address ARM comments * fix example * do not flatten outbound rules, need nested props --------- Co-authored-by: Josh Harrington <joharrington@microsoft.com> * Add Registries 2023-04-01-Preview Swagger (#23163) * x * fix spellcheck * update preview examples * update examples * fix for swagger modelvalidation gate * examples should be in camelCase * more fixes for pr gates * fix syntax * add registryNameParameter * addressing comments * fix one more location property * address comments * update PrivateEndpointConnectionProperties * git didn't push all of my changes * fix circular dependency * update * PATCH operation should have sku, identity properties --------- Co-authored-by: Komal Yadav <komalyadav@microsoft.com> * MFE April-preview 2023 staging (#23165) * update mfe.json to latest * update preview examples * make it pretty * createOrUpload example touch-ups * pretty check * POST pendingUpload lint violation, description, and array * spell check fixes * featurestore updates + notification patch updates to align with jobs * fix feature examples * rename PendingUpload -> startPendingUpload + better description * prettier feature get/list.json * update Job-Update example * update descriptions * x-ms-secret-true, remove wasbs and pattern for registries * update examples to remove wasbsUri * update registry refrence and add pattern to featuresetname * temporarily add in registry reference * one more pattern add-on for featuresetname * remove wasbs since that is no longer a part of PR * bump * add empty secrets to examples - can show object but hide secret itself * original-uri -> azure-async-operation * createOrGetPendingUpload -> createOrGetStartPendingUpload * add ms-secret to uri to keep it from breaking relative to GA --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * [HUB] update team configuration related properties (#23285) * [HUB] update team configuration related properties * Update description * fix merge issue * update workspace get operation example with managenetwork included (#23411) * custom words merge * swap to original-uri * v5->v3 * registryRenames * mlc update to align with v3 types * finish updating examples --------- Co-authored-by: Naman Agarwal <namanag16@gmail.com> Co-authored-by: Naman Agarwal <naagarw@microsoft.com> Co-authored-by: Teddy Todorov <thtodoro@microsoft.com> Co-authored-by: Ming <hemingwei2017@gmail.com> Co-authored-by: Mingwei He <mingweihe@microsoft.com> Co-authored-by: jiewe <127981966+jiewe@users.noreply.github.com> Co-authored-by: Josh Harrington <53531213+joshharrin@users.noreply.github.com> Co-authored-by: Josh Harrington <joharrington@microsoft.com> Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com> Co-authored-by: Komal Yadav <komalyadav@microsoft.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
…023 04 01 preview (Azure#23449) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * [Preview] Bring Back Scheduled Shutdown MLC models (Azure#23040) * [Preview] Bring Back Scheduled Shutdown MLC models * update example json --------- Co-authored-by: Naman Agarwal <naagarw@microsoft.com> * add minLength:1 prop to required strings (Azure#23108) * add parameter enableDataIsolation to workspace properties (Azure#23061) * add parameter enableDataIsolation to workspace properties * minor change to re-run the test pipelines * minor comment change to trigger the test pipeline again --------- Co-authored-by: Mingwei He <mingweihe@microsoft.com> * expose connection expiryTime in 2023-04-01-preview swagger (Azure#23118) * Add Workspace Managed Network Swagger (Azure#23283) * add managed network swagger * fix validation errors * address ARM comments * fix example * do not flatten outbound rules, need nested props --------- Co-authored-by: Josh Harrington <joharrington@microsoft.com> * Add Registries 2023-04-01-Preview Swagger (Azure#23163) * x * fix spellcheck * update preview examples * update examples * fix for swagger modelvalidation gate * examples should be in camelCase * more fixes for pr gates * fix syntax * add registryNameParameter * addressing comments * fix one more location property * address comments * update PrivateEndpointConnectionProperties * git didn't push all of my changes * fix circular dependency * update * PATCH operation should have sku, identity properties --------- Co-authored-by: Komal Yadav <komalyadav@microsoft.com> * MFE April-preview 2023 staging (Azure#23165) * update mfe.json to latest * update preview examples * make it pretty * createOrUpload example touch-ups * pretty check * POST pendingUpload lint violation, description, and array * spell check fixes * featurestore updates + notification patch updates to align with jobs * fix feature examples * rename PendingUpload -> startPendingUpload + better description * prettier feature get/list.json * update Job-Update example * update descriptions * x-ms-secret-true, remove wasbs and pattern for registries * update examples to remove wasbsUri * update registry refrence and add pattern to featuresetname * temporarily add in registry reference * one more pattern add-on for featuresetname * remove wasbs since that is no longer a part of PR * bump * add empty secrets to examples - can show object but hide secret itself * original-uri -> azure-async-operation * createOrGetPendingUpload -> createOrGetStartPendingUpload * add ms-secret to uri to keep it from breaking relative to GA --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * [HUB] update team configuration related properties (Azure#23285) * [HUB] update team configuration related properties * Update description * fix merge issue * update workspace get operation example with managenetwork included (Azure#23411) * custom words merge * swap to original-uri * v5->v3 * registryRenames * mlc update to align with v3 types * finish updating examples --------- Co-authored-by: Naman Agarwal <namanag16@gmail.com> Co-authored-by: Naman Agarwal <naagarw@microsoft.com> Co-authored-by: Teddy Todorov <thtodoro@microsoft.com> Co-authored-by: Ming <hemingwei2017@gmail.com> Co-authored-by: Mingwei He <mingweihe@microsoft.com> Co-authored-by: jiewe <127981966+jiewe@users.noreply.github.com> Co-authored-by: Josh Harrington <53531213+joshharrin@users.noreply.github.com> Co-authored-by: Josh Harrington <joharrington@microsoft.com> Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com> Co-authored-by: Komal Yadav <komalyadav@microsoft.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.