[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-04-01-preview #23391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…023-01-01 to version 2023-04-01-preview
|
Hi, @amchandn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| dataprotection.json | 2023-04-01-preview(dbb52b2) | 2023-01-01(main) |
| dataprotection.json | 2023-04-01-preview(dbb52b2) | 2022-11-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 25 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 18 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.1) | new version | base version |
|---|---|---|
| package-preview-2023-04 | package-preview-2023-04(dbb52b2) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
The following errors/warnings exist before current PR submission:
Only 25 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 49 Errors, 0 Warnings failed [Detail]
Tag package-preview-2023-04; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 72, untested: 0, failed: 49, passed: 23
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
statusCode: 400, errorCode: BMSUserErrorInvalidInput, errorMessage: User input provided for the call is invalid Source: runtime OperationId: BackupVaults_CreateOrUpdate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupVaults_Get |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupVaults_Update |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_CreateOrUpdate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_List |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_GetBackupInstanceOperationResult |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_Get |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_AdhocBackup |
|
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/backupInstances/validateRestore/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ugReAG-23391/providers/Microsoft.DataProtection/backupVaults/vaultnam39acn5/backupInstances/backupin1fsqij'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest/databases/testdb' or the linked scope(s) are invalid. Source: runtime OperationId: BackupInstances_ValidateForRestore |
|
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/locations/validateCrossRegionRestore/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ugReAG-23391/providers/Microsoft.DataProtection/locations/westcentralus'; however, it does not have permission to perform action 'write' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest/databases/targetdb' or the linked scope(s) are invalid. Source: runtime OperationId: BackupInstances_ValidateCrossRegionRestore |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_SyncBackupInstance |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_StopProtection |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_SuspendBackups |
|
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/locations/crossRegionRestore/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ugReAG-23391/providers/Microsoft.DataProtection/locations/westcentralus'; however, it does not have permission to perform action 'write' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest/databases/targetdb' or the linked scope(s) are invalid. Source: runtime OperationId: BackupInstances_TriggerCrossRegionRestore |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_ResumeBackups |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_ResumeProtection |
|
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/backupInstances/restore/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ugReAG-23391/providers/Microsoft.DataProtection/backupVaults/vaultnam39acn5/backupInstances/backupin1fsqij'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest/databases/testdb' or the linked scope(s) are invalid. Source: runtime OperationId: BackupInstances_TriggerRestore |
|
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/validateForBackup/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ugReAG-23391/providers/Microsoft.DataProtection/backupVaults/vaultnam39acn5'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest' or the linked scope(s) are invalid. Source: runtime OperationId: BackupInstances_ValidateForBackup |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_TriggerRehydrate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DppResourceGuardProxy_CreateOrUpdate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DppResourceGuardProxy_List |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DppResourceGuardProxy_Get |
|
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.DataProtection/resourceGuards/deleteBackupInstanceRequests/approve/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ugReAG-23391/providers/Microsoft.DataProtection/backupVaults/vaultnam39acn5/backupResourceGuardProxies/resourceclrkhd', however the linked subscription 'f9e67185-f313-4e79-aa71-6458d429369d' was not found. Source: runtime OperationId: DppResourceGuardProxy_UnlockDelete |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupPolicies_CreateOrUpdate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnam39acn5' under resource group 'apiTest-ugReAG-23391' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupPolicies_List |
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
@live1206 , can you please merge this PR now? |
|
@live1206 , could you please merge this PR? |
|
@msyyc Could you help to check the python generation failure? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...ion/resource-manager/Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json
Outdated
Show resolved
Hide resolved
live1206
reviewed
May 6, 2023
...ion/resource-manager/Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json
Show resolved
Hide resolved
...ion/resource-manager/Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json
Outdated
Show resolved
Hide resolved
...ion/resource-manager/Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json
Outdated
Show resolved
Hide resolved
|
@amchandn Please fix the swagger comments, .Net SDK track 2 generation is failing due to them. |
live1206
requested changes
May 8, 2023
| } | ||
| } | ||
| }, | ||
| "/{resourceId}/providers/Microsoft.DataProtection/backupInstances": { |
There was a problem hiding this comment.
Should skip url encoding for {resourceId}
…4-01-preview' of https://github.com/Azure/azure-rest-api-specs into amchandn-dataprotection-Microsoft.DataProtection-2023-04-01-preview
live1206
approved these changes
May 9, 2023
live1206
deleted the
amchandn-dataprotection-Microsoft.DataProtection-2023-04-01-preview
branch
This was referenced May 9, 2023
amchandn
restored the
amchandn-dataprotection-Microsoft.DataProtection-2023-04-01-preview
branch
11 tasks
6 tasks
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.