Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release machinelearningservices microsoft.machine learning services 2023 04 01 #23414

Closed
wants to merge 9 commits into from
Closed

Release machinelearningservices microsoft.machine learning services 2023 04 01 #23414

wants to merge 9 commits into from

Conversation

kseager
Copy link
Contributor

@kseager kseager commented Apr 3, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

kseager and others added 9 commits March 10, 2023 12:55
@kseager
Adds base for updating Microsoft.MachineLearningServices from version…
02c5d0e 
… stable/2022-10-01 to version 2023-04-01
@kseager
Updates readme
25c4564
@kseager
Updates API version in new specs and examples
54a1ab2
@namanag16
[Stable] Bring Back schedule shutdown MLC models (#23039)
ab9a82e 
* bring back schedule shutdown MLC models

* add description

---------

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
@forteddyt
add minLength:1 prop to required strings (#23109)
f5b686a
@namanag16
[Stable] Add IdleShutdown properties and api (#23042)
e033ca0 
* [Stable] Add IdleShutdown properties and api

* update version

* remove api to update IdleShutdownSetting

* Delete example

---------

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
@srivatsasinha
Pushing new features in stable swagger (#23071)
ea7763c 
* Pushing new features in stable swagger

* Added example file

* Triggering retest

* Fixed version issue

* Triggering retest

* Removing OS Patching

* Changes as per feedback, and add os patching back

* Fix formatting

* Removed Custom Service Update API

* Fixed Example Files

* Added as per review comments

* Added as per review comments

* Retrigger test

---------

Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com>
@komo23x
Add Registries 2023-04-01 Swagger (#23085)
e8258cb 
* add swagger + examples

* fix readme

* fix readme

* switching to autogenerated registries swagger

* fix spellcheck

* update ga examples

* previous API version for comparison = 2023-02-01-preview

* new API version for comparison = 2023-04-01

* update examples

* update swagger, examples to fix pr gates

* fix lint diff errors

* delete should have a 202 response, update createorupdate examples, fix removeRegions operation

* removeRegions -> LRO POST operation

* fix LRO options on removeRegions

* add registryNameParamert

* update swagger

* update

* PATCH property should have sku, identity properties

* fix example

---------

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
@kseager
MFE April 2023 staging (#23164)
cf237c6 
* add latest mfe.json

* updated examples

* add wasbs to known words

* swap pendingupload to proper naming

* align RPs on Azure Machine Learning Services

* rename pendingUpload to verb: startPendingUpload

* remove trailing slash startpendingupload

* improve descriptions

* add pattern to all resource name types + examples

* update original-uri -> azure-async-operation

* remove wasbs and mark credential usage as secret

* test is changing all to azure-async-operation causes breaking change

* the code is implemented where the original-uri is where you will find the final object post-polling

* update examples to remove wasbsUri

* reference registries instead for RegistryName

* remove wasbs

* original-uri -> azure-async-operation

* update examples to empty secrets

* CreateOrUpdatePendingUpload -> CreateOrUpdateStartPendingUpload

* add pattern for workspaceName

* x-ms-secret on the SASUri

* switch back to original-uri given update from auto-rest folks

---------

Co-authored-by: Kayla Ames <kaseager@microsoft.com>
@openapi-pipeline-app
Copy link

Swagger pipeline can not start as the pull request has merge conflicts.

@openapi-workflow-bot
Copy link

Hi, @kseager Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 3, 2023
    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @openapi-workflow-bot
    Copy link

    Hi, @kseager your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @kseager
    Copy link
    Contributor Author

    kseager commented Apr 5, 2023

    Do not have permissions to resolve merge conflict instead please review this tracking branch to the staging branch #23450 (all the same pre-approved ARM commits + merge conflict resolved)

    @kseager kseager closed this Apr 5, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees

    @ArcturusZhang ArcturusZhang

    Labels
    ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @kseager @ArcturusZhang @namanag16 @forteddyt @srivatsasinha @komo23x