[Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-15-preview #23443

brrusino · 2023-04-05T17:55:17Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…1-preview to version 2023-04-15-preview

openapi-workflow-bot · 2023-04-05T17:55:21Z

Hi, @brrusino Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-04-05T17:55:22Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 12 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
capabilities.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
capabilityTypes.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
experiments.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
operations.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
targetTypes.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
targets.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
capabilities.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
capabilityTypes.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
common.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
experiments.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
targetTypes.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)
targets.json	2023-04-15-preview(5d2652a)	2023-04-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Percent, Random, Tag' from the old version. New: preview/2023-04-15-preview/types/experiments.json#L332:9 Old: preview/2023-04-01-preview/types/experiments.json#L331:9
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Percent, Random, Tag' from the old version. New: preview/2023-04-15-preview/types/experiments.json#L332:9 Old: preview/2023-04-01-preview/types/experiments.json#L331:9
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: preview/2023-04-15-preview/types/experiments.json#L102:11 Old: preview/2023-04-01-preview/types/experiments.json#L102:11
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: preview/2023-04-15-preview/types/experiments.json#L327:5 Old: preview/2023-04-01-preview/types/experiments.json#L327:5
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: preview/2023-04-15-preview/types/experiments.json#L102:11 Old: preview/2023-04-01-preview/types/experiments.json#L102:11
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: preview/2023-04-15-preview/types/experiments.json#L327:5 Old: preview/2023-04-01-preview/types/experiments.json#L327:5
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'targets' renamed or removed? New: preview/2023-04-15-preview/types/experiments.json#L331:7 Old: preview/2023-04-01-preview/types/experiments.json#L330:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'targets' renamed or removed? New: preview/2023-04-15-preview/types/experiments.json#L331:7 Old: preview/2023-04-01-preview/types/experiments.json#L330:7
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: preview/2023-04-15-preview/types/experiments.json#L332:9 Old: preview/2023-04-01-preview/types/experiments.json#L331:9
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: preview/2023-04-15-preview/types/experiments.json#L469:9 Old: preview/2023-04-01-preview/types/experiments.json#L425:9
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: preview/2023-04-15-preview/types/experiments.json#L332:9 Old: preview/2023-04-01-preview/types/experiments.json#L331:9
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: preview/2023-04-15-preview/types/experiments.json#L469:9 Old: preview/2023-04-01-preview/types/experiments.json#L425:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2023-04-15-preview	package-2023-04-15-preview(5d2652a)	default(main)
package-2023-04-01-preview	package-2023-04-01-preview(5d2652a)	default(main)
package-2022-10-01-preview	package-2022-10-01-preview(5d2652a)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'Capabilities_List' does not match the response definition in the individual GET operation 'Capabilities_Get' . Location: Microsoft.Chaos/preview/2023-04-15-preview/capabilities.json#L37
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'CapabilityTypes_List' does not match the response definition in the individual GET operation 'CapabilityTypes_Get' . Location: Microsoft.Chaos/preview/2023-04-15-preview/capabilityTypes.json#L37
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'Experiments_ListAll' does not match the response definition in the individual GET operation 'Experiments_Get' . Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L37
`❌` PostOperationAsyncResponseValidation	An async POST operation must set ''x-ms-long-running-operation' : true''. Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L311
`❌` PostOperationAsyncResponseValidation	An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L311
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L332
`❌` PostOperationAsyncResponseValidation	An async POST operation must set ''x-ms-long-running-operation' : true''. Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L353
`❌` PostOperationAsyncResponseValidation	An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L353
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L374
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'Experiments_ListAllStatuses' does not match the response definition in the individual GET operation 'Experiments_GetStatus' . Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L394
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'Experiments_ListExecutionDetails' does not match the response definition in the individual GET operation 'Experiments_GetExecutionDetails' . Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L484
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'Targets_List' does not match the response definition in the individual GET operation 'Targets_Get' . Location: Microsoft.Chaos/preview/2023-04-15-preview/targets.json#L37
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'TargetTypes_List' does not match the response definition in the individual GET operation 'TargetTypes_Get' . Location: Microsoft.Chaos/preview/2023-04-15-preview/targetTypes.json#L37
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/capabilities.json#L44
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/capabilities.json#L101
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/capabilities.json#L153
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/capabilities.json#L205
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/capabilityTypes.json#L44
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/capabilityTypes.json#L92
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L44
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L89
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L137
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L177
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L217
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L266
⚠️ LroExtension	Operations with a 202 response should specify `x-ms-long-running-operation: true`. Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L311
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L317
⚠️ LroExtension	Operations with a 202 response should specify `x-ms-long-running-operation: true`. Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L353
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L359
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L401

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-05T17:55:23Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/chaos/armchaos - Approved - 0.7.0

+	Const `SelectorTypePercent`, `SelectorTypeRandom`, `SelectorTypeTag` from type alias `SelectorType` has been removed
+	Field `Targets` of struct `Selector` has been removed
+	Operation `*ExperimentsClient.BeginCancel` has been changed to non-LRO, use `*ExperimentsClient.Cancel` instead.
+	Operation `*ExperimentsClient.BeginCreateOrUpdate` has been changed to non-LRO, use `*ExperimentsClient.CreateOrUpdate` instead.
+	Type of `ExperimentProperties.Selectors` has been changed from `[]*Selector` to `[]SelectorClassification`
+	Type of `TargetReference.Type` has been changed from `*string` to `*TargetReferenceType`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-chaos - Approved - 1.0.0b6

+	Model Selector no longer has parameter targets

❌azure-sdk-for-js - @azure/arm-chaos - Approved - 1.0.0-beta.4

+	Interface Selector no longer has parameter targets
+	Type of parameter selectors of interface Experiment is changed from Selector[] to SelectorUnion[]
+	Type of parameter type of interface Selector is changed from SelectorType to "List" | "Query"
+	Type of parameter type of interface TargetReference is changed from "ChaosTarget" to TargetReferenceType

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 38311a1. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.5` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-chaos [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ExperimentsOperations.update
info	[Changelog]   - Model CapabilityType has a new parameter permissions_necessary
info	[Changelog]   - Model ResourceIdentity has a new parameter user_assigned_identities
info	[Changelog]   - Model Selector has a new parameter additional_properties
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Selector no longer has parameter targets

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 38311a1. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-chaos [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 38311a1. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/chaos/armchaos [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ExperimentProperties.Selectors` has been changed from `[]*Selector` to `[]SelectorClassification`
info	[Changelog] - Type of `TargetReference.Type` has been changed from `*string` to `*TargetReferenceType`
info	[Changelog] - `SelectorTypePercent`, `SelectorTypeRandom`, `SelectorTypeTag` from enum `SelectorType` has been removed
info	[Changelog] - Operation `*ExperimentsClient.BeginCancel` has been changed to non-LRO, use `*ExperimentsClient.Cancel` instead.
info	[Changelog] - Operation `*ExperimentsClient.BeginCreateOrUpdate` has been changed to non-LRO, use `*ExperimentsClient.CreateOrUpdate` instead.
info	[Changelog] - Field `Targets` of struct `Selector` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ResourceIdentityTypeUserAssigned` added to enum type `ResourceIdentityType`
info	[Changelog] - New value `SelectorTypeQuery` added to enum type `SelectorType`
info	[Changelog] - New enum type `FilterType` with values `FilterTypeSimple`
info	[Changelog] - New enum type `TargetReferenceType` with values `TargetReferenceTypeChaosTarget`
info	[Changelog] - New function `*ExperimentsClient.Update(context.Context, string, string, ExperimentUpdate, *ExperimentsClientUpdateOptions) (ExperimentsClientUpdateResponse, error)`
info	[Changelog] - New function `*Filter.GetFilter() *Filter`
info	[Changelog] - New function `*ListSelector.GetSelector() *Selector`
info	[Changelog] - New function `*QuerySelector.GetSelector() *Selector`
info	[Changelog] - New function `*Selector.GetSelector() *Selector`
info	[Changelog] - New function `*SimpleFilter.GetFilter() *Filter`
info	[Changelog] - New struct `CapabilityTypePropertiesPermissionsNecessary`
info	[Changelog] - New struct `CapabilityTypePropertiesRuntimeProperties`
info	[Changelog] - New struct `ComponentsEwb5TmSchemasUserassignedidentitiesAdditionalproperties`
info	[Changelog] - New struct `ExperimentUpdate`
info	[Changelog] - New struct `ListSelector`
info	[Changelog] - New struct `QuerySelector`
info	[Changelog] - New struct `SimpleFilter`
info	[Changelog] - New struct `SimpleFilterParameters`
info	[Changelog] - New field `Kind`, `PermissionsNecessary`, `RuntimeProperties` in struct `CapabilityTypeProperties`
info	[Changelog] - New field `UserAssignedIdentities` in struct `ResourceIdentity`
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 32 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 38311a1. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-chaos [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-chaos-1.0.0-beta.4.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation Experiments.update
info	[Changelog]   - Added Interface CapabilityTypePropertiesPermissionsNecessary
info	[Changelog]   - Added Interface ComponentsEwb5TmSchemasUserassignedidentitiesAdditionalproperties
info	[Changelog]   - Added Interface ExperimentsUpdateOptionalParams
info	[Changelog]   - Added Interface ExperimentUpdate
info	[Changelog]   - Added Interface ListSelector
info	[Changelog]   - Added Interface QuerySelector
info	[Changelog]   - Added Type Alias ExperimentsUpdateResponse
info	[Changelog]   - Added Type Alias SelectorUnion
info	[Changelog]   - Added Type Alias TargetReferenceType
info	[Changelog]   - Interface CapabilityType has a new optional parameter permissionsNecessary
info	[Changelog]   - Interface ResourceIdentity has a new optional parameter userAssignedIdentities
info	[Changelog]   - Added Enum KnownSelectorType
info	[Changelog]   - Added Enum KnownTargetReferenceType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface Selector no longer has parameter targets
info	[Changelog]   - Type of parameter selectors of interface Experiment is changed from Selector[] to SelectorUnion[]
info	[Changelog]   - Type of parameter type of interface Selector is changed from SelectorType to "List" | "Query"
info	[Changelog]   - Type of parameter type of interface TargetReference is changed from "ChaosTarget" to TargetReferenceType

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 38311a1. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️chaos [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 38311a1. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.chaos.DefaultTag [View full logs]

Az.Chaos.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.chaos.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-05T17:55:24Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/chaos/armchaos	https://apiview.dev/Assemblies/Review/01b3a24aa6b84023979d9fe5c51b2b2f
Java	azure-resourcemanager-chaos	https://apiview.dev/Assemblies/Review/8f72de0973414def843b9a3d67a2c96b
JavaScript	@azure/arm-chaos	https://apiview.dev/Assemblies/Review/857d5a207b764504ba8aa8b41701370e

openapi-workflow-bot · 2023-04-05T19:26:12Z

Hi, @brrusino your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

brrusino · 2023-04-05T19:55:22Z

...ion/chaos/resource-manager/Microsoft.Chaos/preview/2023-04-15-preview/types/experiments.json

-            "Random",
-            "Tag",
-            "List"
+            "List",


Previously, List was the only value supported by Chaos Studio. These previous existing enum values were never actually supported, and were added a long time ago.

brrusino · 2023-04-11T17:59:34Z

@MaryGao , can you please take a look at this PR? We are aware of the mentioned breaking changes and would like to proceed regardless.

MaryGao · 2023-04-12T10:51:12Z

I'll take a look once the ARM team reviewed

zizw123 · 2023-04-14T22:10:57Z

...ion/chaos/resource-manager/Microsoft.Chaos/preview/2023-04-15-preview/types/experiments.json

+          ],
+          "x-ms-enum": {
+            "name": "SelectorType",
+            "modelAsString": false


false

Why false for this? This can break client if you need to update the enum

No explicit reason, string works for us - will change.

changes applied

zizw123 · 2023-04-14T22:11:32Z

...ion/chaos/resource-manager/Microsoft.Chaos/preview/2023-04-15-preview/types/experiments.json

+          ],
+          "x-ms-enum": {
+            "name": "FilterType",
+            "modelAsString": false


false

Same question here, why specifically change this to false?

Changed back to true

openapi-workflow-bot · 2023-04-14T22:11:57Z

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

MaryGao · 2023-04-18T03:03:43Z

@tadelesh @msyyc Could you help review Go and Python's breaking?

brrusino · 2023-04-24T19:27:07Z

@MaryGao Is anything else required to complete this PR?

brrusino and others added 5 commits April 5, 2023 10:13

Adds base for updating Microsoft.Chaos from version preview/2023-04-0…

52c75b8

…1-preview to version 2023-04-15-preview

Updates readme

2cbb719

Updates API version in new specs and examples

be8774e

updates to Chaos Studio selectors

f6fc69a

updated readme

2e50d73

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 5, 2023

AzureRestAPISpecReview added new-api-version resource-manager labels Apr 5, 2023

azure-sdk mentioned this pull request Apr 5, 2023

[AutoPR track2_azure-mgmt-chaos] [Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-15-preview azure-sdk/azure-sdk-for-python#3225

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 5, 2023

azure-sdk mentioned this pull request Apr 5, 2023

[AutoPR @azure/arm-chaos] [Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-15-preview azure-sdk/azure-sdk-for-js#4673

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Apr 5, 2023

brrusino marked this pull request as ready for review April 5, 2023 19:25

openapi-assignment-bot bot assigned MaryGao Apr 5, 2023

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 5, 2023

brrusino commented Apr 5, 2023

View reviewed changes

zizw123 reviewed Apr 14, 2023

View reviewed changes

zizw123 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 14, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 14, 2023

changed modelAsString to True for all enums

5d2652a

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Apr 14, 2023

zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 15, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 15, 2023

MaryGao added the Approved-SdkBreakingChange-JavaScript label Apr 18, 2023

MaryGao requested a review from zizw123 April 18, 2023 03:07

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Apr 18, 2023

msyyc added the Approved-SdkBreakingChange-Python label Apr 18, 2023

brrusino requested a review from RenzoPrettoMS April 25, 2023 16:26

RenzoPrettoMS approved these changes Apr 25, 2023

View reviewed changes

MaryGao approved these changes Apr 26, 2023

View reviewed changes

MaryGao merged commit 38311a1 into main Apr 26, 2023

MaryGao deleted the brrusino-chaos-Microsoft.Chaos-2023-04-15-preview2 branch April 26, 2023 05:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-15-preview #23443

[Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-15-preview #23443

brrusino commented Apr 5, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 5, 2023

openapi-pipeline-app bot commented Apr 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 5, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 5, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 5, 2023

brrusino Apr 5, 2023

brrusino commented Apr 11, 2023

MaryGao commented Apr 12, 2023

zizw123 Apr 14, 2023

brrusino Apr 14, 2023

brrusino Apr 14, 2023

zizw123 Apr 14, 2023

brrusino Apr 14, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 14, 2023

MaryGao commented Apr 18, 2023

brrusino commented Apr 24, 2023

[Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-15-preview #23443

[Hub Generated] Review request for Microsoft.Chaos to add version preview/2023-04-15-preview #23443

Conversation

brrusino commented Apr 5, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 5, 2023

openapi-pipeline-app bot commented Apr 5, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 5, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 5, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 5, 2023

brrusino Apr 5, 2023

Choose a reason for hiding this comment

brrusino commented Apr 11, 2023

MaryGao commented Apr 12, 2023

zizw123 Apr 14, 2023

Choose a reason for hiding this comment

brrusino Apr 14, 2023

Choose a reason for hiding this comment

brrusino Apr 14, 2023

Choose a reason for hiding this comment

zizw123 Apr 14, 2023

Choose a reason for hiding this comment

brrusino Apr 14, 2023 • edited Loading

Choose a reason for hiding this comment

openapi-workflow-bot bot commented Apr 14, 2023

MaryGao commented Apr 18, 2023

brrusino commented Apr 24, 2023

brrusino commented Apr 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 5, 2023 •

edited

Loading

brrusino Apr 14, 2023 •

edited

Loading