Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eventhubs] Adding schema for status code 201 for Disaster-recovery #23474

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

schaudhari6254888
Copy link
Contributor

@schaudhari6254888 schaudhari6254888 commented Apr 7, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @schaudhari6254888 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @ghost ghost added the Event Hubs label Apr 7, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 7, 2023

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/5a0be94e8ff3c224843e5839850b823a20c325a5/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json",
    "details":"Command failed: dotnet "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/@azure/oad/dlls/OpenApiDiff.dll" -o /tmp/old-resolved.json -n /tmp/new-resolved.json\nYou must install or update .NET to run this application.
    App: /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/@azure/oad/dlls/OpenApiDiff.dll\nArchitecture: x64\nFramework: 'Microsoft.NETCore.App',
    version '3.1.0' (x64)\n.NET location: /usr/share/dotnet/
    The following frameworks were found:\n 6.0.15 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]\n 7.0.4 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
    Learn about framework resolution:\nhttps://aka.ms/dotnet/app-launch-failed
    To install missing framework,
    download:\nhttps://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.20.04-x64\n"
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/5a0be94e8ff3c224843e5839850b823a20c325a5/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json",
    "details":"Command failed: dotnet "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/@azure/oad/dlls/OpenApiDiff.dll" -o /tmp/old-resolved.json -n /tmp/new-resolved.json\nYou must install or update .NET to run this application.
    App: /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/@azure/oad/dlls/OpenApiDiff.dll\nArchitecture: x64\nFramework: 'Microsoft.NETCore.App',
    version '3.1.0' (x64)\n.NET location: /usr/share/dotnet/
    The following frameworks were found:\n 6.0.15 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]\n 7.0.4 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
    Learn about framework resolution:\nhttps://aka.ms/dotnet/app-launch-failed
    To install missing framework,
    download:\nhttps://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.20.04-x64\n"
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-01-preview package-2022-01-preview(5a0be94) package-2022-01-preview(main)
    package-2022-10-preview package-2022-10-preview(5a0be94) package-2022-10-preview(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L37
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L37
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L88
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L133
    TrackedResourcePatchOperation Tracked resource 'ArmDisasterRecovery' must have patch operation that at least supports the update of tags.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L133
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L279
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L321
    MissingTypeObject The schema 'CheckNameAvailabilityParameter' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L381
    MissingTypeObject The schema 'CheckNameAvailabilityResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L393
    MissingTypeObject The schema 'ArmDisasterRecovery' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L411
    MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L413
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L416
    MissingTypeObject The schema 'ArmDisasterRecoveryListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L474
    PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L37
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L37
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L88
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L133
    TrackedResourcePatchOperation Tracked resource 'ArmDisasterRecovery' must have patch operation that at least supports the update of tags.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L133
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L279
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L321
    MissingTypeObject The schema 'CheckNameAvailabilityParameter' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L381
    MissingTypeObject The schema 'CheckNameAvailabilityResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L393
    MissingTypeObject The schema 'ArmDisasterRecovery' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L411
    MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L413
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L416
    MissingTypeObject The schema 'ArmDisasterRecoveryListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.EventHub/preview/2022-10-01-preview/disasterRecoveryConfigs.json#L474
    ⚠️ PreviewVersionOverOneYear The API version:2022-01-01-preview having been in a preview state over one year , please move it to GA or retire.
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L6
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L49
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L100
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.EventHub/preview/2022-01-01-preview/disasterRecoveryConfigs.json#L145
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 7, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/eventhub/armeventhub - Approved - 1.1.0-beta.3
    +	Field `Location` of struct `NetworkSecurityPerimeterConfiguration` has been removed
    +	Field `Tags` of struct `NetworkSecurityPerimeterConfiguration` has been removed
    azure-sdk-for-js - @azure/arm-eventhub - 6.0.0-beta.1
    +	Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
    +	Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
    +	Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
    +	Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
    +	Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
    +	Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top
    azure-sdk-for-python-track2 - track2_azure-mgmt-eventhub - Approved - 11.0.0b1
    +	Model NetworkSecurityPerimeterConfiguration no longer has parameter location
    +	Model NetworkSecurityPerimeterConfiguration no longer has parameter tags
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0a5ed10. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.4` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-eventhub [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model Eventhub has a new parameter retention_description
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model NetworkSecurityPerimeterConfiguration no longer has parameter location
      info	[Changelog]   - Model NetworkSecurityPerimeterConfiguration no longer has parameter tags
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0a5ed10. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/eventhub/armeventhub [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `PublicNetworkAccessFlagSecuredByPerimeter` added to enum type `PublicNetworkAccessFlag`
      info	[Changelog] - New enum type `ApplicationGroupPolicyType` with values `ApplicationGroupPolicyTypeThrottlingPolicy`
      info	[Changelog] - New enum type `CleanupPolicyRetentionDescription` with values `CleanupPolicyRetentionDescriptionCompaction`, `CleanupPolicyRetentionDescriptionDelete`
      info	[Changelog] - New enum type `MetricID` with values `MetricIDIncomingBytes`, `MetricIDIncomingMessages`, `MetricIDOutgoingBytes`, `MetricIDOutgoingMessages`
      info	[Changelog] - New enum type `NetworkSecurityPerimeterConfigurationProvisioningState` with values `NetworkSecurityPerimeterConfigurationProvisioningStateAccepted`, `NetworkSecurityPerimeterConfigurationProvisioningStateCanceled`, `NetworkSecurityPerimeterConfigurationProvisioningStateCreating`, `NetworkSecurityPerimeterConfigurationProvisioningStateDeleted`, `NetworkSecurityPerimeterConfigurationProvisioningStateDeleting`, `NetworkSecurityPerimeterConfigurationProvisioningStateFailed`, `NetworkSecurityPerimeterConfigurationProvisioningStateInvalidResponse`, `NetworkSecurityPerimeterConfigurationProvisioningStateSucceeded`, `NetworkSecurityPerimeterConfigurationProvisioningStateSucceededWithIssues`, `NetworkSecurityPerimeterConfigurationProvisioningStateUnknown`, `NetworkSecurityPerimeterConfigurationProvisioningStateUpdating`
      info	[Changelog] - New enum type `NspAccessRuleDirection` with values `NspAccessRuleDirectionInbound`, `NspAccessRuleDirectionOutbound`
      info	[Changelog] - New enum type `PublicNetworkAccess` with values `PublicNetworkAccessDisabled`, `PublicNetworkAccessEnabled`, `PublicNetworkAccessSecuredByPerimeter`
      info	[Changelog] - New enum type `ResourceAssociationAccessMode` with values `ResourceAssociationAccessModeAuditMode`, `ResourceAssociationAccessModeEnforcedMode`, `ResourceAssociationAccessModeLearningMode`, `ResourceAssociationAccessModeNoAssociationMode`, `ResourceAssociationAccessModeUnspecifiedMode`
      info	[Changelog] - New enum type `TLSVersion` with values `TLSVersionOne0`, `TLSVersionOne1`, `TLSVersionOne2`
      info	[Changelog] - New function `NewApplicationGroupClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ApplicationGroupClient, error)`
      info	[Changelog] - New function `*ApplicationGroupClient.CreateOrUpdateApplicationGroup(context.Context, string, string, string, ApplicationGroup, *ApplicationGroupClientCreateOrUpdateApplicationGroupOptions) (ApplicationGroupClientCreateOrUpdateApplicationGroupResponse, error)`
      info	[Changelog] - New function `*ApplicationGroupClient.Delete(context.Context, string, string, string, *ApplicationGroupClientDeleteOptions) (ApplicationGroupClientDeleteResponse, error)`
      info	[Changelog] - New function `*ApplicationGroupClient.Get(context.Context, string, string, string, *ApplicationGroupClientGetOptions) (ApplicationGroupClientGetResponse, error)`
      info	[Changelog] - New function `*ApplicationGroupClient.NewListByNamespacePager(string, string, *ApplicationGroupClientListByNamespaceOptions) *runtime.Pager[ApplicationGroupClientListByNamespaceResponse]`
      info	[Changelog] - New function `*ApplicationGroupPolicy.GetApplicationGroupPolicy() *ApplicationGroupPolicy`
      info	[Changelog] - New function `*ClientFactory.NewApplicationGroupClient() *ApplicationGroupClient`
      info	[Changelog] - New function `*ClientFactory.NewNetworkSecurityPerimeterConfigurationClient() *NetworkSecurityPerimeterConfigurationClient`
      info	[Changelog] - New function `*ClientFactory.NewNetworkSecurityPerimeterConfigurationsClient() *NetworkSecurityPerimeterConfigurationsClient`
      info	[Changelog] - New function `*ThrottlingPolicy.GetApplicationGroupPolicy() *ApplicationGroupPolicy`
      info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationClient, error)`
      info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationClient.List(context.Context, string, string, *NetworkSecurityPerimeterConfigurationClientListOptions) (NetworkSecurityPerimeterConfigurationClientListResponse, error)`
      info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationsClient, error)`
      info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.BeginCreateOrUpdate(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientBeginCreateOrUpdateOptions) (*runtime.Poller[NetworkSecurityPerimeterConfigurationsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New struct `ApplicationGroup`
      info	[Changelog] - New struct `ApplicationGroupListResult`
      info	[Changelog] - New struct `ApplicationGroupProperties`
      info	[Changelog] - New struct `NetworkSecurityPerimeter`
      info	[Changelog] - New struct `NetworkSecurityPerimeterConfiguration`
      info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationList`
      info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties`
      info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesProfile`
      info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation`
      info	[Changelog] - New struct `NspAccessRule`
      info	[Changelog] - New struct `NspAccessRuleProperties`
      info	[Changelog] - New struct `NspAccessRulePropertiesSubscriptionsItem`
      info	[Changelog] - New struct `ProvisioningIssue`
      info	[Changelog] - New struct `ProvisioningIssueProperties`
      info	[Changelog] - New struct `RetentionDescription`
      info	[Changelog] - New struct `ThrottlingPolicy`
      info	[Changelog] - New field `SupportsScaling` in struct `ClusterProperties`
      info	[Changelog] - New field `MinimumTLSVersion` in struct `EHNamespaceProperties`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `EHNamespaceProperties`
      info	[Changelog] - New field `RetentionDescription` in struct `Properties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 90 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0a5ed10. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-eventhub [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group ApplicationGroupOperations
      info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationOperations
      info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
      info	[Changelog]   - Added Interface ApplicationGroup
      info	[Changelog]   - Added Interface ApplicationGroupCreateOrUpdateApplicationGroupOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupDeleteOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupGetOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceNextOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupListResult
      info	[Changelog]   - Added Interface ApplicationGroupPolicy
      info	[Changelog]   - Added Interface NetworkSecurityPerimeter
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationListOptionalParams
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesProfile
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface NspAccessRule
      info	[Changelog]   - Added Interface NspAccessRuleProperties
      info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
      info	[Changelog]   - Added Interface ProvisioningIssue
      info	[Changelog]   - Added Interface ProvisioningIssueProperties
      info	[Changelog]   - Added Interface RetentionDescription
      info	[Changelog]   - Added Interface ThrottlingPolicy
      info	[Changelog]   - Added Type Alias ApplicationGroupCreateOrUpdateApplicationGroupResponse
      info	[Changelog]   - Added Type Alias ApplicationGroupGetResponse
      info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceNextResponse
      info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceResponse
      info	[Changelog]   - Added Type Alias ApplicationGroupPolicyType
      info	[Changelog]   - Added Type Alias ApplicationGroupPolicyUnion
      info	[Changelog]   - Added Type Alias CleanupPolicyRetentionDescription
      info	[Changelog]   - Added Type Alias MetricId
      info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationListResponse
      info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
      info	[Changelog]   - Added Type Alias NspAccessRuleDirection
      info	[Changelog]   - Added Type Alias PublicNetworkAccess
      info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
      info	[Changelog]   - Added Type Alias TlsVersion
      info	[Changelog]   - Interface Cluster has a new optional parameter supportsScaling
      info	[Changelog]   - Interface EHNamespace has a new optional parameter minimumTlsVersion
      info	[Changelog]   - Interface EHNamespace has a new optional parameter publicNetworkAccess
      info	[Changelog]   - Interface Eventhub has a new optional parameter retentionDescription
      info	[Changelog]   - Added Enum KnownApplicationGroupPolicyType
      info	[Changelog]   - Added Enum KnownCleanupPolicyRetentionDescription
      info	[Changelog]   - Added Enum KnownMetricId
      info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
      info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
      info	[Changelog]   - Added Enum KnownPublicNetworkAccess
      info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
      info	[Changelog]   - Added Enum KnownTlsVersion
      info	[Changelog]   - Enum KnownPublicNetworkAccessFlag has a new value SecuredByPerimeter
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
      info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
      info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
      info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0a5ed10. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️eventhub [View full logs
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0a5ed10. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.eventhub.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 7, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/eventhub/armeventhub https://apiview.dev/Assemblies/Review/ce1319a3b14f42a7832f56d2b0a55cb7
    Java azure-resourcemanager-eventhubs-generated https://apiview.dev/Assemblies/Review/c2da9b8f09ae4b60bba28429935a028b
    .Net Azure.ResourceManager.EventHubs https://apiview.dev/Assemblies/Review/33beedc58bfe425a8c8bf0fb43c799b5
    JavaScript @azure/arm-eventhub https://apiview.dev/Assemblies/Review/ca24d29505ff40c6ba7f850dac19e858

    @damodaravadhani damodaravadhani marked this pull request as ready for review April 10, 2023 07:31
    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 10, 2023
    @chunyu3 chunyu3 added Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python labels Apr 13, 2023
    @chunyu3
    Copy link
    Member

    chunyu3 commented Apr 13, 2023

    The breaking change in js SDK is not related with this PR. Ignore this.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python CI-BreakingChange-Go CI-BreakingChange-JavaScript Event Hubs resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants