-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2023-05-01-privatepreview #23601
[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2023-05-01-privatepreview #23601
Conversation
…/2021-08-08 to version 2023-05-01-privatepreview
Hi, @noneumar Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @noneumar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
...023-05-01-privatepreview/examples/AlertProcessingRules_Create_or_update_add_correlation.json
Outdated
Show resolved
Hide resolved
...023-05-01-privatepreview/examples/AlertProcessingRules_Create_or_update_add_correlation.json
Outdated
Show resolved
Hide resolved
...023-05-01-privatepreview/examples/AlertProcessingRules_Create_or_update_add_correlation.json
Outdated
Show resolved
Hide resolved
...023-05-01-privatepreview/examples/AlertProcessingRules_Create_or_update_add_correlation.json
Outdated
Show resolved
Hide resolved
...023-05-01-privatepreview/examples/AlertProcessingRules_Create_or_update_add_correlation.json
Outdated
Show resolved
Hide resolved
...023-05-01-privatepreview/examples/AlertProcessingRules_Create_or_update_add_correlation.json
Outdated
Show resolved
Hide resolved
...023-05-01-privatepreview/examples/AlertProcessingRules_Create_or_update_add_correlation.json
Outdated
Show resolved
Hide resolved
@noneumar Please follow #23601 (comment) then architect will review the PR. |
Regarding: |
@mikekistler The PR uses common-types for api-version instead of self-definition but it causes breaking alert of CI. Could you help approve it? Thanks! |
All issues flagged as breaking changes appear benign. |
@tadelesh please help confirm Go breaking. |
…version preview/2023-05-01-privatepreview (Azure#23601) * Adds base for updating Microsoft.AlertsManagement from version stable/2021-08-08 to version 2023-05-01-privatepreview * Updates readme * Updates API version in new specs and examples * added correlation example * Updated the example according to the discussion. * Continue after discussion * Removed targe region * Removed the target region * Modified correlationInterval * Fixed after a review. * Fixed file path * removed 'private' from apiversion * cont * fixed model validation * cont * Cont. * run prettier * Added "x-ms-identifiers" * Fixed avocade * fixed readme * fixed avocado * Continue * updated readmy * Modified "SuppressAll" to "SuppressAlways"
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.