Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LRO final state via operation and change integer format for Cosmos DB for PostgreSQL #23876

Merged
merged 5 commits into from
May 24, 2023
Merged

Update LRO final state via operation and change integer format for Cosmos DB for PostgreSQL #23876

merged 5 commits into from
May 24, 2023

Conversation

senatol
Copy link
Member

@senatol senatol commented May 9, 2023 •
edited
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      Minor update on integer format and LRO operation due to errors during SDK generation tests
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
    Not released any SDK's yet.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @senatol Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 14 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    postgresqlhsc.json 2022-11-08(4c3395b) 2022-11-08(main)
    Rule Message
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2181:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2181:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2186:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2186:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2199:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2199:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2204:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2204:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2209:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2209:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2046:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2046:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2051:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2051:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2064:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2064:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2069:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2069:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2074:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2074:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1873:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1873:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1878:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1878:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1873:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1873:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1878:9
    Old: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1878:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.1) new version base version
    package-2022-11-08 package-2022-11-08(4c3395b) package-2022-11-08(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L163
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L396
    ❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L680
    ❌ PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L680
    ❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L795
    ❌ PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L795
    ❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L867
    ❌ PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L867
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1024
    ❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1125
    ❌ PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1125
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1239
    ❌ LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1256
    ❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1307
    ❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1361
    ❌ LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1415
    ❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1531
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1575
    ❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1676
    ❌ PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1676
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1790
    ⚠️ ProvisioningStateSpecifiedForLRODelete 200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L262
    ⚠️ AllProxyResourcesShouldHaveDelete The resource ServerConfiguration does not have a corresponding delete operation.
    Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2465
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/postgresqlhsc/armpostgresqlhsc - Approved - 1.0.0
    +	Enum `CitusVersion` has been removed
+	Enum `CreateMode` has been removed
+	Enum `PostgreSQLVersion` has been removed
+	Enum `ResourceProviderType` has been removed
+	Enum `ServerEdition` has been removed
+	Enum `ServerHaState` has been removed
+	Enum `ServerState` has been removed
+	Field `EnablePublicIP` of struct `ServerProperties` has been removed
+	Field `ServerGroupConfiguration` of struct `ConfigurationsClientGetResponse` has been removed
+	Field `ServerGroupServer` of struct `ServersClientGetResponse` has been removed
+	Function `*ClientFactory.NewServerGroupsClient` has been removed
+	Function `*ConfigurationsClient.BeginUpdate` has been removed
+	Function `*ConfigurationsClient.NewListByServerGroupPager` has been removed
+	Function `*FirewallRulesClient.NewListByServerGroupPager` has been removed
+	Function `*RolesClient.NewListByServerGroupPager` has been removed
+	Function `*ServerGroupsClient.BeginCreateOrUpdate` has been removed
+	Function `*ServerGroupsClient.BeginDelete` has been removed
+	Function `*ServerGroupsClient.BeginRestart` has been removed
+	Function `*ServerGroupsClient.BeginStart` has been removed
+	Function `*ServerGroupsClient.BeginStop` has been removed
+	Function `*ServerGroupsClient.BeginUpdate` has been removed
+	Function `*ServerGroupsClient.CheckNameAvailability` has been removed
+	Function `*ServerGroupsClient.Get` has been removed
+	Function `*ServerGroupsClient.NewListByResourceGroupPager` has been removed
+	Function `*ServerGroupsClient.NewListPager` has been removed
+	Function `*ServersClient.NewListByServerGroupPager` has been removed
+	Function `NewServerGroupsClient` has been removed
+	Struct `ServerGroupConfigurationListResult` has been removed
+	Struct `ServerGroupConfigurationProperties` has been removed
+	Struct `ServerGroupConfiguration` has been removed
+	Struct `ServerGroupForUpdate` has been removed
+	Struct `ServerGroupListResult` has been removed
+	Struct `ServerGroupPropertiesDelegatedSubnetArguments` has been removed
+	Struct `ServerGroupPropertiesForUpdate` has been removed
+	Struct `ServerGroupPropertiesPrivateDNSZoneArguments` has been removed
+	Struct `ServerGroupProperties` has been removed
+	Struct `ServerGroupServerListResult` has been removed
+	Struct `ServerGroupServerProperties` has been removed
+	Struct `ServerGroupServer` has been removed
+	Struct `ServerGroup` has been removed
+	Struct `ServerRoleGroup` has been removed
+	Type of `ServerProperties.ServerEdition` has been changed from `*ServerEdition` to `*string`
+	Type of `ServerProperties.StorageQuotaInMb` has been changed from `*int64` to `*int32`
+	Type of `ServerProperties.VCores` has been changed from `*int64` to `*int32`

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08d139c. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/postgresqlhsc/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
warn	No package detected after generation
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08d139c. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes] 
      info	[Changelog] change log generation failed!!!
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08d139c. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-postgresqlhsc [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08d139c. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/postgresqlhsc/armpostgresqlhsc [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ServerProperties.ServerEdition` has been changed from `*ServerEdition` to `*string`
info	[Changelog] - Type of `ServerProperties.StorageQuotaInMb` has been changed from `*int64` to `*int32`
info	[Changelog] - Type of `ServerProperties.VCores` has been changed from `*int64` to `*int32`
info	[Changelog] - Enum `CitusVersion` has been removed
info	[Changelog] - Enum `CreateMode` has been removed
info	[Changelog] - Enum `PostgreSQLVersion` has been removed
info	[Changelog] - Enum `ResourceProviderType` has been removed
info	[Changelog] - Enum `ServerEdition` has been removed
info	[Changelog] - Enum `ServerHaState` has been removed
info	[Changelog] - Enum `ServerState` has been removed
info	[Changelog] - Function `*ClientFactory.NewServerGroupsClient` has been removed
info	[Changelog] - Function `*ConfigurationsClient.NewListByServerGroupPager` has been removed
info	[Changelog] - Function `*ConfigurationsClient.BeginUpdate` has been removed
info	[Changelog] - Function `*FirewallRulesClient.NewListByServerGroupPager` has been removed
info	[Changelog] - Function `*RolesClient.NewListByServerGroupPager` has been removed
info	[Changelog] - Function `NewServerGroupsClient` has been removed
info	[Changelog] - Function `*ServerGroupsClient.CheckNameAvailability` has been removed
info	[Changelog] - Function `*ServerGroupsClient.BeginCreateOrUpdate` has been removed
info	[Changelog] - Function `*ServerGroupsClient.BeginDelete` has been removed
info	[Changelog] - Function `*ServerGroupsClient.Get` has been removed
info	[Changelog] - Function `*ServerGroupsClient.NewListByResourceGroupPager` has been removed
info	[Changelog] - Function `*ServerGroupsClient.NewListPager` has been removed
info	[Changelog] - Function `*ServerGroupsClient.BeginRestart` has been removed
info	[Changelog] - Function `*ServerGroupsClient.BeginStart` has been removed
info	[Changelog] - Function `*ServerGroupsClient.BeginStop` has been removed
info	[Changelog] - Function `*ServerGroupsClient.BeginUpdate` has been removed
info	[Changelog] - Function `*ServersClient.NewListByServerGroupPager` has been removed
info	[Changelog] - Struct `ServerGroup` has been removed
info	[Changelog] - Struct `ServerGroupConfiguration` has been removed
info	[Changelog] - Struct `ServerGroupConfigurationListResult` has been removed
info	[Changelog] - Struct `ServerGroupConfigurationProperties` has been removed
info	[Changelog] - Struct `ServerGroupForUpdate` has been removed
info	[Changelog] - Struct `ServerGroupListResult` has been removed
info	[Changelog] - Struct `ServerGroupProperties` has been removed
info	[Changelog] - Struct `ServerGroupPropertiesDelegatedSubnetArguments` has been removed
info	[Changelog] - Struct `ServerGroupPropertiesForUpdate` has been removed
info	[Changelog] - Struct `ServerGroupPropertiesPrivateDNSZoneArguments` has been removed
info	[Changelog] - Struct `ServerGroupServer` has been removed
info	[Changelog] - Struct `ServerGroupServerListResult` has been removed
info	[Changelog] - Struct `ServerGroupServerProperties` has been removed
info	[Changelog] - Struct `ServerRoleGroup` has been removed
info	[Changelog] - Field `ServerGroupConfiguration` of struct `ConfigurationsClientGetResponse` has been removed
info	[Changelog] - Field `EnablePublicIP` of struct `ServerProperties` has been removed
info	[Changelog] - Field `ServerGroupServer` of struct `ServersClientGetResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `PrivateEndpointConnectionProvisioningState` with values `PrivateEndpointConnectionProvisioningStateCreating`, `PrivateEndpointConnectionProvisioningStateDeleting`, `PrivateEndpointConnectionProvisioningStateFailed`, `PrivateEndpointConnectionProvisioningStateSucceeded`
info	[Changelog] - New enum type `PrivateEndpointServiceConnectionStatus` with values `PrivateEndpointServiceConnectionStatusApproved`, `PrivateEndpointServiceConnectionStatusPending`, `PrivateEndpointServiceConnectionStatusRejected`
info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateCanceled`, `ProvisioningStateFailed`, `ProvisioningStateInProgress`, `ProvisioningStateSucceeded`
info	[Changelog] - New function `*ClientFactory.NewClustersClient() *ClustersClient`
info	[Changelog] - New function `*ClientFactory.NewPrivateEndpointConnectionsClient() *PrivateEndpointConnectionsClient`
info	[Changelog] - New function `*ClientFactory.NewPrivateLinkResourcesClient() *PrivateLinkResourcesClient`
info	[Changelog] - New function `NewClustersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ClustersClient, error)`
info	[Changelog] - New function `*ClustersClient.CheckNameAvailability(context.Context, NameAvailabilityRequest, *ClustersClientCheckNameAvailabilityOptions) (ClustersClientCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*ClustersClient.BeginCreate(context.Context, string, string, Cluster, *ClustersClientBeginCreateOptions) (*runtime.Poller[ClustersClientCreateResponse], error)`
info	[Changelog] - New function `*ClustersClient.BeginDelete(context.Context, string, string, *ClustersClientBeginDeleteOptions) (*runtime.Poller[ClustersClientDeleteResponse], error)`
info	[Changelog] - New function `*ClustersClient.Get(context.Context, string, string, *ClustersClientGetOptions) (ClustersClientGetResponse, error)`
info	[Changelog] - New function `*ClustersClient.NewListByResourceGroupPager(string, *ClustersClientListByResourceGroupOptions) *runtime.Pager[ClustersClientListByResourceGroupResponse]`
info	[Changelog] - New function `*ClustersClient.NewListPager(*ClustersClientListOptions) *runtime.Pager[ClustersClientListResponse]`
info	[Changelog] - New function `*ClustersClient.BeginPromoteReadReplica(context.Context, string, string, *ClustersClientBeginPromoteReadReplicaOptions) (*runtime.Poller[ClustersClientPromoteReadReplicaResponse], error)`
info	[Changelog] - New function `*ClustersClient.BeginRestart(context.Context, string, string, *ClustersClientBeginRestartOptions) (*runtime.Poller[ClustersClientRestartResponse], error)`
info	[Changelog] - New function `*ClustersClient.BeginStart(context.Context, string, string, *ClustersClientBeginStartOptions) (*runtime.Poller[ClustersClientStartResponse], error)`
info	[Changelog] - New function `*ClustersClient.BeginStop(context.Context, string, string, *ClustersClientBeginStopOptions) (*runtime.Poller[ClustersClientStopResponse], error)`
info	[Changelog] - New function `*ClustersClient.BeginUpdate(context.Context, string, string, ClusterForUpdate, *ClustersClientBeginUpdateOptions) (*runtime.Poller[ClustersClientUpdateResponse], error)`
info	[Changelog] - New function `*ConfigurationsClient.GetCoordinator(context.Context, string, string, string, *ConfigurationsClientGetCoordinatorOptions) (ConfigurationsClientGetCoordinatorResponse, error)`
info	[Changelog] - New function `*ConfigurationsClient.GetNode(context.Context, string, string, string, *ConfigurationsClientGetNodeOptions) (ConfigurationsClientGetNodeResponse, error)`
info	[Changelog] - New function `*ConfigurationsClient.NewListByClusterPager(string, string, *ConfigurationsClientListByClusterOptions) *runtime.Pager[ConfigurationsClientListByClusterResponse]`
info	[Changelog] - New function `*ConfigurationsClient.BeginUpdateOnCoordinator(context.Context, string, string, string, ServerConfiguration, *ConfigurationsClientBeginUpdateOnCoordinatorOptions) (*runtime.Poller[ConfigurationsClientUpdateOnCoordinatorResponse], error)`
info	[Changelog] - New function `*ConfigurationsClient.BeginUpdateOnNode(context.Context, string, string, string, ServerConfiguration, *ConfigurationsClientBeginUpdateOnNodeOptions) (*runtime.Poller[ConfigurationsClientUpdateOnNodeResponse], error)`
info	[Changelog] - New function `*FirewallRulesClient.NewListByClusterPager(string, string, *FirewallRulesClientListByClusterOptions) *runtime.Pager[FirewallRulesClientListByClusterResponse]`
info	[Changelog] - New function `NewPrivateEndpointConnectionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateEndpointConnectionsClient, error)`
info	[Changelog] - New function `*PrivateEndpointConnectionsClient.BeginCreateOrUpdate(context.Context, string, string, string, PrivateEndpointConnection, *PrivateEndpointConnectionsClientBeginCreateOrUpdateOptions) (*runtime.Poller[PrivateEndpointConnectionsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*PrivateEndpointConnectionsClient.BeginDelete(context.Context, string, string, string, *PrivateEndpointConnectionsClientBeginDeleteOptions) (*runtime.Poller[PrivateEndpointConnectionsClientDeleteResponse], error)`
info	[Changelog] - New function `*PrivateEndpointConnectionsClient.Get(context.Context, string, string, string, *PrivateEndpointConnectionsClientGetOptions) (PrivateEndpointConnectionsClientGetResponse, error)`
info	[Changelog] - New function `*PrivateEndpointConnectionsClient.NewListByClusterPager(string, string, *PrivateEndpointConnectionsClientListByClusterOptions) *runtime.Pager[PrivateEndpointConnectionsClientListByClusterResponse]`
info	[Changelog] - New function `NewPrivateLinkResourcesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateLinkResourcesClient, error)`
info	[Changelog] - New function `*PrivateLinkResourcesClient.Get(context.Context, string, string, string, *PrivateLinkResourcesClientGetOptions) (PrivateLinkResourcesClientGetResponse, error)`
info	[Changelog] - New function `*PrivateLinkResourcesClient.NewListByClusterPager(string, string, *PrivateLinkResourcesClientListByClusterOptions) *runtime.Pager[PrivateLinkResourcesClientListByClusterResponse]`
info	[Changelog] - New function `*RolesClient.Get(context.Context, string, string, string, *RolesClientGetOptions) (RolesClientGetResponse, error)`
info	[Changelog] - New function `*RolesClient.NewListByClusterPager(string, string, *RolesClientListByClusterOptions) *runtime.Pager[RolesClientListByClusterResponse]`
info	[Changelog] - New function `*ServersClient.NewListByClusterPager(string, string, *ServersClientListByClusterOptions) *runtime.Pager[ServersClientListByClusterResponse]`
info	[Changelog] - New struct `Cluster`
info	[Changelog] - New struct `ClusterConfigurationListResult`
info	[Changelog] - New struct `ClusterForUpdate`
info	[Changelog] - New struct `ClusterListResult`
info	[Changelog] - New struct `ClusterProperties`
info	[Changelog] - New struct `ClusterPropertiesForUpdate`
info	[Changelog] - New struct `ClusterServer`
info	[Changelog] - New struct `ClusterServerListResult`
info	[Changelog] - New struct `ClusterServerProperties`
info	[Changelog] - New struct `Configuration`
info	[Changelog] - New struct `ConfigurationProperties`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog] - New struct `PrivateEndpoint`
info	[Changelog] - New struct `PrivateEndpointConnection`
info	[Changelog] - New struct `PrivateEndpointConnectionListResult`
info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New struct `PrivateEndpointConnectionSimpleProperties`
info	[Changelog] - New struct `PrivateEndpointProperty`
info	[Changelog] - New struct `PrivateLinkResource`
info	[Changelog] - New struct `PrivateLinkResourceListResult`
info	[Changelog] - New struct `PrivateLinkResourceProperties`
info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
info	[Changelog] - New struct `SimplePrivateEndpointConnection`
info	[Changelog] - New anonymous field `Configuration` in struct `ConfigurationsClientGetResponse`
info	[Changelog] - New field `ProvisioningState` in struct `FirewallRuleProperties`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `ProvisioningState` in struct `RoleProperties`
info	[Changelog] - New field `ProvisioningState`, `RequiresRestart` in struct `ServerConfigurationProperties`
info	[Changelog] - New field `AdministratorLogin`, `EnablePublicIPAccess`, `IsReadOnly` in struct `ServerProperties`
info	[Changelog] - New anonymous field `ClusterServer` in struct `ServersClientGetResponse`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 56 breaking change(s), 105 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08d139c. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08d139c. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️postgresqlhsc [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from 08d139c. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.postgresqlhsc.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.postgresqlhsc.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/postgresqlhsc/armpostgresqlhsc https://apiview.dev/Assemblies/Review/95f85623463e40109d0946ac6da071e1
    Java azure-resourcemanager-postgresqlhsc https://apiview.dev/Assemblies/Review/d0ec0ea94f8e489f8a70481ff4466174

    @senatol senatol requested a review from mozansaka May 9, 2023 12:50
    This was referenced May 9, 2023
    Closed
    Closed
    This was referenced May 9, 2023
    Closed
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels May 9, 2023
    @openapi-workflow-bot
    Copy link

    Hi @senatol, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @senatol, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @senatol senatol changed the title Update LRO final state via operation and remove integer format for Cosmos DB for PostgreSQL Update LRO final state via operation and change integer format for Cosmos DB for PostgreSQL May 16, 2023
    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 18, 2023
    @senatol
    Copy link
    Member Author

    senatol commented May 22, 2023

    Hello @zedy-wj,
    We got Breaking Changes approved by the board, can you help us merge the PR? Thank you.

    @zedy-wj
    Copy link
    Member

    zedy-wj commented May 23, 2023

    @tadelesh - Please help review Go breaking changes.

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 23, 2023
    @senatol
    Copy link
    Member Author

    senatol commented May 23, 2023

    Hello @zedy-wj ,
    Go breaking changes are approved, is there any other steps that's blocking merge? Thank you

    @zedy-wj zedy-wj added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 24, 2023
    @live1206 live1206 merged commit 08d139c into Azure:main May 24, 2023
    This was referenced May 24, 2023
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mozansaka mozansaka mozansaka approved these changes

    Assignees

    @zedy-wj zedy-wj

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @senatol @zedy-wj @mozansaka @tadelesh @live1206 @AzureRestAPISpecReview @mikekistler