Added the new Voice action and increased the API version for this change #2396

micongjie · 2018-02-01T03:44:30Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-02-01T03:44:56Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-02-01T03:45:44Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

lmazuel · 2018-02-02T00:46:37Z

New API in stable folder @ravbhatnagar

lmazuel · 2018-02-02T00:48:45Z

...fication/monitor/resource-manager/microsoft.insights/stable/2018-03-01/actionGroups_API.json

+        }
+    },
+    "definitions": {
+        "Resource": {


@fearthecowboy Is this an opportunity to inherit the common models?

lmazuel · 2018-02-02T00:49:39Z

@micongjie Please add this file in the Readme

azuresdkciprbot · 2018-02-02T02:38:30Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-02T02:43:21Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp3ahg9dza/rest/specification/monitor/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp3ahg9dza/sdk', '--multiapi', '--package-version=v12.2.1-beta', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/v12.2.1-beta services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4244; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4245).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4244/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4244)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (preview->3.0.40)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Processing batch task - {"tag":"package-2017-08"} .
Failure during batch task - {"tag":"package-2017-08"} -- Error: [Exception] No input files provided.

Use --help to get help information..
[Exception] No input files provided.

Use --help to get help information.

This reverts commit b58bec5.

azuresdkciprbot · 2018-02-02T03:00:09Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-02T03:06:23Z

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@265490d

AutorestCI · 2018-02-02T03:27:11Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@e2d0872

ravbhatnagar · 2018-02-09T08:40:14Z

Looks good.

lmazuel · 2018-02-09T17:23:08Z

Thanks! merged.

AutorestCI · 2018-02-09T17:24:49Z

Automation for azure-sdk-for-go

Swagger to SDK encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 274, in create_context_pr
    base=sdk_base
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 137, in get_or_create_pull
    base=base
  File "/usr/local/lib/python3.6/dist-packages/github/Repository.py", line 1016, in create_pull
    return self.__create_pull_1(*args, **kwds)
  File "/usr/local/lib/python3.6/dist-packages/github/Repository.py", line 1025, in __create_pull_1
    return self.__create_pull(title=title, body=body, base=base, head=head)
  File "/usr/local/lib/python3.6/dist-packages/github/Repository.py", line 1038, in __create_pull
    input=post_parameters
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 169, in requestJsonAndCheck
    return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 182, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 422 {'message': 'Validation Failed', 'errors': [{'resource': 'PullRequest', 'code': 'custom', 'message': 'No commits between dev and restapi_auto_monitor/resource-manager'}], 'documentation_url': 'https://developer.github.com/v3/pulls/#create-a-pull-request'}

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 197, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, context_tags, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 355, in rest_pull_close
    rest_pull_open(body, github_con, restapi_repo, sdk_pr_target_repo, context_tags, sdk_default_base, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 264, in rest_pull_open
    create_context_pr(sdk_pr_target_repo, context_tags, sdk_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 283, in create_context_pr
    _LOGGER.info("Unable to manage Context PR %s:\n%s", context_pr.number if context_pr else "", response)
UnboundLocalError: local variable 'context_pr' referenced before assignment

Added the new Voice action and increased the API version for this change

c303c87

azuresdkci assigned lmazuel Feb 1, 2018

lmazuel requested a review from ravbhatnagar February 2, 2018 00:46

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2018

lmazuel reviewed Feb 2, 2018

View reviewed changes

added the _API.json file to the Readme

b58bec5

micongjie added 2 commits February 1, 2018 18:52

Revert "added the _API.json file to the Readme"

d373d0b

This reverts commit b58bec5.

fix python sdk failure

df75ee5

Azure deleted a comment from AutorestCI Feb 2, 2018

lmazuel mentioned this pull request Feb 2, 2018

[Monitor] Added the new Voice action and increased the API version for this change Azure/azure-sdk-for-python#1891

Merged

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 9, 2018

lmazuel merged commit 084653b into Azure:master Feb 9, 2018

AutorestCI mentioned this pull request Feb 9, 2018

[AutoPR monitor/resource-manager] Added the new Voice action and increased the API version for this change Azure/azure-sdk-for-go#1067

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the new Voice action and increased the API version for this change #2396

Added the new Voice action and increased the API version for this change #2396

micongjie commented Feb 1, 2018 •

edited

Loading

AutorestCI commented Feb 1, 2018

AutorestCI commented Feb 1, 2018

lmazuel commented Feb 2, 2018

lmazuel Feb 2, 2018

lmazuel commented Feb 2, 2018

azuresdkciprbot commented Feb 2, 2018

AutorestCI commented Feb 2, 2018

azuresdkciprbot commented Feb 2, 2018

AutorestCI commented Feb 2, 2018

AutorestCI commented Feb 2, 2018

ravbhatnagar commented Feb 9, 2018

lmazuel commented Feb 9, 2018

AutorestCI commented Feb 9, 2018 •

edited

Loading

Added the new Voice action and increased the API version for this change #2396

Added the new Voice action and increased the API version for this change #2396

Conversation

micongjie commented Feb 1, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Feb 1, 2018

AutorestCI commented Feb 1, 2018

lmazuel commented Feb 2, 2018

lmazuel Feb 2, 2018

Choose a reason for hiding this comment

lmazuel commented Feb 2, 2018

azuresdkciprbot commented Feb 2, 2018

AutorestCI commented Feb 2, 2018

azuresdkciprbot commented Feb 2, 2018

AutorestCI commented Feb 2, 2018

AutorestCI commented Feb 2, 2018

ravbhatnagar commented Feb 9, 2018

lmazuel commented Feb 9, 2018

AutorestCI commented Feb 9, 2018 • edited Loading

Automation for azure-sdk-for-go

micongjie commented Feb 1, 2018 •

edited

Loading

AutorestCI commented Feb 9, 2018 •

edited

Loading