Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag for dotnet sdk generation #24016

Merged
merged 2 commits into from
May 19, 2023
Merged

Add tag for dotnet sdk generation #24016

merged 2 commits into from
May 19, 2023

Conversation

GalGoldi72
Copy link
Contributor

@GalGoldi72 GalGoldi72 commented May 16, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @GalGoldi72 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.1) new version base version
    package-dotnet-sdk package-dotnet-sdk(3423c8f) default(main)
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/security/resource-manager/readme.md
    tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from b8f04b9. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.SecurityCenter [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b8f04b9. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/security/armsecurity [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b8f04b9. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-security [View full logs]  [Release SDK Changes]
      info	[Changelog] change log generation failed!!!
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b8f04b9. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias APICollectionGetResponse
      info	[Changelog]   - Added Type Alias APICollectionListNextResponse
      info	[Changelog]   - Added Type Alias APICollectionListResponse
      info	[Changelog]   - Added Type Alias APICollectionOnboardingCreateResponse
      info	[Changelog]   - Added Type Alias ApplicationConditionOperator
      info	[Changelog]   - Added Type Alias ApplicationCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ApplicationGetResponse
      info	[Changelog]   - Added Type Alias ApplicationsListNextResponse
      info	[Changelog]   - Added Type Alias ApplicationsListResponse
      info	[Changelog]   - Added Type Alias ApplicationSourceResourceType
      info	[Changelog]   - Added Type Alias AwsOrganizationalDataUnion
      info	[Changelog]   - Added Type Alias Code
      info	[Changelog]   - Added Type Alias ConnectionType
      info	[Changelog]   - Added Type Alias EnvironmentDataUnion
      info	[Changelog]   - Added Type Alias EnvironmentType
      info	[Changelog]   - Added Type Alias GcpOrganizationalDataUnion
      info	[Changelog]   - Added Type Alias GetSensitivitySettingsOperationResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsGetResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsListNextResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsListResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleConditionOperator
      info	[Changelog]   - Added Type Alias GovernanceRuleOwnerSourceType
      info	[Changelog]   - Added Type Alias GovernanceRulesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesExecuteResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesGetResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesListNextResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesListResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesOperationResultsResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleSourceResourceType
      info	[Changelog]   - Added Type Alias GovernanceRuleType
      info	[Changelog]   - Added Type Alias HealthReportGetResponse
      info	[Changelog]   - Added Type Alias HealthReportsListNextResponse
      info	[Changelog]   - Added Type Alias HealthReportsListResponse
      info	[Changelog]   - Added Type Alias IsEnabled
      info	[Changelog]   - Added Type Alias MinimalSeverity
      info	[Changelog]   - Added Type Alias MipIntegrationStatus
      info	[Changelog]   - Added Type Alias OperationResult
      info	[Changelog]   - Added Type Alias Roles
      info	[Changelog]   - Added Type Alias ScanningMode
      info	[Changelog]   - Added Type Alias ScopeName
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationGetResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationsListNextResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationsListResponse
      info	[Changelog]   - Added Type Alias SecurityOperatorsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SecurityOperatorsGetResponse
      info	[Changelog]   - Added Type Alias SecurityOperatorsListResponse
      info	[Changelog]   - Added Type Alias SensitivitySettingsListResponse
      info	[Changelog]   - Added Type Alias StatusName
      info	[Changelog]   - Added Type Alias SubPlan
      info	[Changelog]   - Added Type Alias Type
      info	[Changelog]   - Added Type Alias UpdateSensitivitySettingsResponse
      info	[Changelog]   - Interface AlertsSimulateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface AlertsSimulateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface DefenderForServersAwsOfferingArcAutoProvisioning has a new optional parameter cloudRoleArn
      info	[Changelog]   - Interface DefenderForServersAwsOfferingArcAutoProvisioning has a new optional parameter configuration
      info	[Changelog]   - Interface ScanProperties has a new optional parameter lastScanTime
      info	[Changelog]   - Type of parameter offeringType of interface CloudOffering is changed from "CspmMonitorAws" | "DefenderForContainersAws" | "DefenderForServersAws" | "InformationProtectionAws" to "CspmMonitorAws" | "DefenderForContainersAws" | "DefenderForServersAws" | "DefenderForDatabasesAws" | "InformationProtectionAws" | "CspmMonitorGcp" | "DefenderForServersGcp" | "DefenderForDatabasesGcp" | "DefenderForContainersGcp" | "CspmMonitorGithub" | "CspmMonitorAzureDevOps" | "DefenderCspmAws" | "DefenderCspmGcp" | "DefenderForDevOpsGithub" | "DefenderForDevOpsAzureDevOps" | "CspmMonitorGitLab" | "DefenderForDevOpsGitLab"
      info	[Changelog]   - Added Enum KnownApplicationConditionOperator
      info	[Changelog]   - Added Enum KnownApplicationSourceResourceType
      info	[Changelog]   - Added Enum KnownCode
      info	[Changelog]   - Added Enum KnownEnvironmentType
      info	[Changelog]   - Added Enum KnownGovernanceRuleConditionOperator
      info	[Changelog]   - Added Enum KnownGovernanceRuleOwnerSourceType
      info	[Changelog]   - Added Enum KnownGovernanceRuleSourceResourceType
      info	[Changelog]   - Added Enum KnownGovernanceRuleType
      info	[Changelog]   - Added Enum KnownIsEnabled
      info	[Changelog]   - Added Enum KnownMinimalSeverity
      info	[Changelog]   - Added Enum KnownMipIntegrationStatus
      info	[Changelog]   - Added Enum KnownOperationResult
      info	[Changelog]   - Added Enum KnownRoles
      info	[Changelog]   - Added Enum KnownScanningMode
      info	[Changelog]   - Added Enum KnownScopeName
      info	[Changelog]   - Added Enum KnownStatusName
      info	[Changelog]   - Added Enum KnownSubPlan
      info	[Changelog]   - Added Enum KnownType
      info	[Changelog]   - Enum KnownAlertStatus has a new value InProgress
      info	[Changelog]   - Enum KnownBundleType has a new value CosmosDbs
      info	[Changelog]   - Enum KnownCloudName has a new value AzureDevOps
      info	[Changelog]   - Enum KnownCloudName has a new value Github
      info	[Changelog]   - Enum KnownCloudName has a new value GitLab
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorAzureDevOps
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorGithub
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorGitLab
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderCspmAws
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderCspmGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForContainersGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDatabasesAws
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDatabasesGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDevOpsAzureDevOps
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDevOpsGithub
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDevOpsGitLab
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForServersGcp
      info	[Changelog]   - Enum KnownSettingName has a new value WdatpUnifiedSolution
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation Alerts.simulate
      info	[Changelog]   - Removed operation SecurityContacts.update
      info	[Changelog]   - Operation AllowedConnections.get has a new signature
      info	[Changelog]   - Interface AlertsSuppressionRulesListNextOptionalParams no longer has parameter alertType
      info	[Changelog]   - Interface DefenderForServersAwsOfferingArcAutoProvisioning no longer has parameter servicePrincipalSecretMetadata
      info	[Changelog]   - Interface IotSecuritySolutionListByResourceGroupNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface IotSecuritySolutionListBySubscriptionNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface IotSecuritySolutionsAnalyticsAggregatedAlertListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface IotSecuritySolutionsAnalyticsRecommendationListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface RegulatoryComplianceAssessmentsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface RegulatoryComplianceControlsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface RegulatoryComplianceStandardsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SecureScoreControlsListBySecureScoreNextOptionalParams no longer has parameter expand
      info	[Changelog]   - Interface SecureScoreControlsListNextOptionalParams no longer has parameter expand
      info	[Changelog]   - Interface TasksListByHomeRegionNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface TasksListByResourceGroupNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface TasksListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Type of parameter value of interface ExternalSecuritySolutionList is changed from ExternalSecuritySolutionUnion[] to ExternalSecuritySolution[]
      info	[Changelog]   - Removed Enum KnownAlertNotifications
      info	[Changelog]   - Removed Enum KnownAlertsToAdmins
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b8f04b9. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-security [View full logs]  [Release SDK Changes]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs]Release - Generate from b8f04b9. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • security/resource-manager [View full logs
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from b8f04b9. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.security.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.security.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/security/armsecurity There is no API change compared with the previous version
    Java azure-resourcemanager-security https://apiview.dev/Assemblies/Review/aa9ca1ce12b14b568a71d1200f000e3e
    JavaScript @azure/arm-security https://apiview.dev/Assemblies/Review/3148df6b7adb4d33bb483ede3681ee94

    @GalGoldi72
    Copy link
    Contributor Author

    GalGoldi72 commented May 16, 2023

    This PR only adds a new tag - this tag will include all the APIs that are updated in the dotnet SDK client.
    This is a request from Arthur Ma: Since the API wasn't updates for a while and I can't update for all the rest of the API owners- we will use this tag as the base for the SDK generation.

    @eliagrady
    Copy link
    Member

    diffs from package-composite-v3:
    dropped:
    sensitivitySettings
    apiCollections
    healthReports
    securityOperators

    securityConnectors api-version was downgraded from 2023-03-01-preview to 2022-08-01-preview

    is this intended? please provide some context for this change

    @GalGoldi72
    Copy link
    Contributor Author

    diffs from package-composite-v3: dropped: sensitivitySettings apiCollections healthReports securityOperators

    securityConnectors api-version was downgraded from 2023-03-01-preview to 2022-08-01-preview

    is this intended? please provide some context for this change

    These APIs you mentioned are not in the .NET SDK.
    Since I have to update the .NET SDK ASAP and I can't update it for all these APIs I created a new tag as Arthur Ma suggested (.NET SDK team) and I will update the .NET SDK according to this tag.

    Copy link
    Member

    @eliagrady eliagrady left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates CI-BreakingChange-JavaScript resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants