-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom key identifier #2403
Conversation
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Did a commit to Azure/azure-sdk-for-go: |
Did a commit to Azure/azure-sdk-for-python: |
The change looks good to me. Once @darshanhs90 or somebody else from the service teams approves I will merge. |
Ping @darshanhs90 |
Let me add one of the guys from the graph team to take a look at this,as they shall have more context about this |
@jmprieur Could you add any dev on your team to look at this PR? |
Ping @jmprieur |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: dep ensure /bin/sh: 1: dep: not found |
According to
https://msdn.microsoft.com/Library/Azure/Ad/Graph/api/entity-and-complex-type-reference#keycredential-type
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger