Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom key identifier #2403

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Added custom key identifier #2403

merged 1 commit into from
Feb 20, 2018

Conversation

mcardosos
Copy link
Contributor

@mcardosos mcardosos commented Feb 2, 2018

According to
https://msdn.microsoft.com/Library/Azure/Ad/Graph/api/entity-and-complex-type-reference#keycredential-type

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/graphrbac/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 19
After the PR: Warning(s): 0 Error(s): 19

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@add8926

@AutorestCI
Copy link

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@147d1d6

@jhendrixMSFT
Copy link
Member

The change looks good to me. Once @darshanhs90 or somebody else from the service teams approves I will merge.

@jhendrixMSFT
Copy link
Member

Ping @darshanhs90

@darshanhs90
Copy link
Contributor

Let me add one of the guys from the graph team to take a look at this,as they shall have more context about this

@darshanhs90
Copy link
Contributor

@jmprieur Could you add any dev on your team to look at this PR?

@jhendrixMSFT
Copy link
Member

Ping @jmprieur

@AutorestCI
Copy link

AutorestCI commented Feb 20, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2013

@AutorestCI
Copy link

AutorestCI commented Feb 20, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 127
and output:

/bin/sh: 1: dep: not found

@mcardosos mcardosos deleted the graph branch February 20, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants