Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync ADF changes into Synapse: Add state and onInactiveMarkAs to Synapse activities #24075

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

mikaelmello
Copy link
Contributor

@mikaelmello mikaelmello commented May 19, 2023

Sync ADF changes (#23910) to Synapse

The changes being replicated originate from these PRs:
Private PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/12375
Public PR: #23910

Following the same approach of a similar PR: #23619

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 19, 2023

Swagger Validation Report

️❌BreakingChange: 82 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
Pipeline.json 2020-12-01(ae2a13e) 2020-12-01(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L190:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L165:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L190:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L165:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L201:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L176:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L201:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L176:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L1421:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L1396:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L1421:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L1396:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L4997:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L4972:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L4997:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L4972:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5083:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5058:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5083:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5058:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5140:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5115:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5140:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5115:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5217:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5192:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5217:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5192:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5317:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5292:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5317:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5292:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5387:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5362:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5387:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5362:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5704:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5679:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5704:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5679:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5785:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5760:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5785:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5760:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5823:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5798:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5823:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5798:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5864:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5839:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5864:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5839:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5918:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5893:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5918:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5893:7
1045 - AddedOptionalProperty The new version has a new optional property 'state' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5955:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5930:7
1045 - AddedOptionalProperty The new version has a new optional property 'onInactiveMarkAs' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L5955:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L5930:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⌛CredScan pending [Detail]
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⌛PoliCheck pending [Detail]
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @mikaelmello Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 19, 2023

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @openapi-workflow-bot
    Copy link

    The automation detected this Pull Request introduces breaking changes to an existing API version and hence it added the NewApiVersionRequired label. This means you cannot proceed with merging this PR until you complete one of the following action items:

    - A) Submit a new PR instead of this one, or modify this PR, so that it introduces a new API version instead of introducing breaking changes to an existing API version. The automation will remove the label once it detects there are no more breaking changes.
    - B) OR you can request an approval of the breaking changes, get it reviewed, and approved. The reviewer will add Approved-BreakingChange label if they approve.

    For additional guidance, please see https://aka.ms/NewApiVersionRequired

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 19, 2023
    @ghost
    Copy link

    ghost commented Jun 4, 2023

    Hi, @mikaelmello. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Jun 4, 2023
    @mikaelmello
    Copy link
    Contributor Author

    @lmazuel can you please take a look?

    @ghost ghost removed the no-recent-activity label Jun 5, 2023
    @lmazuel lmazuel merged commit 46e158c into main Jun 8, 2023
    @lmazuel lmazuel deleted the mm/synapse/state branch June 8, 2023 16:16
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 data-plane NewApiVersionRequired Synapses
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants