Adding database vulnerability assessmen scan APIs #2418

yaakoviyun · 2018-02-05T12:46:09Z

Adding database vulnerability assessmen scan APIs

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Adding database vulnerability assessmen scan APIs

AutorestCI · 2018-02-05T12:47:41Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpldfb13v7/rest/specification/sql/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpldfb13v7/sdk', '--use=@microsoft.azure/autorest.python@preview', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4245; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4246/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4246)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (preview->2.1.34)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: swagger-document-override/md-override-loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 77): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 78): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 79): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 80): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 81): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 82): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 83): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 84): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 85): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 86): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 87): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 88): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 89): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 90): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 91): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 92): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:28065) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 93): Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
FATAL: swagger-document/loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
Process() cancelled due to exception : Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
  Error: Could not read 'file:///tmp/tmpldfb13v7/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.

AutorestCI · 2018-02-05T12:48:52Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp9z0w7fmq/sdk', '--multiapi', '--package-version=v12.2.1-beta', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/v12.2.1-beta services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4244; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4245).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4244/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4244)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (preview->3.0.40)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Processing batch task - {"tag":"package-2017-10-preview"} .
FATAL: swagger-document-override/md-override-loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 82): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 83): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 84): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 85): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 86): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 87): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 88): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 89): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 90): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 91): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 92): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 93): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 94): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 95): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 96): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 97): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
(node:42377) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 98): Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
FATAL: swagger-document/loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
Process() cancelled due to exception : Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.
Failure during batch task - {"tag":"package-2017-10-preview"} -- Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'..
  Error: Could not read 'file:///tmp/tmp9z0w7fmq/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/serverDnsAliases.json'.

AutorestCI · 2018-02-05T13:04:44Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@0e285bf

AutorestCI · 2018-02-05T13:09:53Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: gofmt -w ./services/
Finished with return code 2
and output:

services/sql/mgmt/2014-04-01/sql/models.go:566:8: expected ';', found ':'
services/sql/mgmt/2014-04-01/sql/models.go:571:145: rune literal not terminated
services/sql/mgmt/2014-04-01/sql/models.go:573:98: expected '}', found 'for'
services/sql/mgmt/2014-04-01/sql/models.go:573:150: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:158: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:169: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:193: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:212: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:234: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:246: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:257: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:291: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1177:8: expected ';', found ':'
services/sql/mgmt/2015-05-01-preview/sql/models.go:1182:145: rune literal not terminated
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:98: expected '}', found 'for'
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:150: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:158: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:169: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:193: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:212: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:234: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:246: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:257: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:291: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1433:8: expected ';', found ':'
services/sql/mgmt/2017-03-01-preview/sql/models.go:1438:145: rune literal not terminated
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:98: expected '}', found 'for'
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:150: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:158: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:169: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:193: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:212: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:234: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:246: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:257: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:291: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1461:8: expected ';', found ':'
services/sql/mgmt/2017-10-01-preview/sql/models.go:1466:145: rune literal not terminated
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:98: expected '}', found 'for'
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:150: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:158: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:169: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:193: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:212: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:234: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:246: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:257: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:291: illegal rune literal

AutorestCI · 2018-02-05T13:29:12Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@3ea5e06

azuresdkciprbot · 2018-02-05T13:32:36Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-05T13:34:14Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: gofmt -w ./services/
Finished with return code 2
and output:

services/sql/mgmt/2014-04-01/sql/models.go:566:8: expected ';', found ':'
services/sql/mgmt/2014-04-01/sql/models.go:571:145: rune literal not terminated
services/sql/mgmt/2014-04-01/sql/models.go:573:98: expected '}', found 'for'
services/sql/mgmt/2014-04-01/sql/models.go:573:150: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:158: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:169: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:193: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:212: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:234: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:246: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:257: illegal rune literal
services/sql/mgmt/2014-04-01/sql/models.go:573:291: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1177:8: expected ';', found ':'
services/sql/mgmt/2015-05-01-preview/sql/models.go:1182:145: rune literal not terminated
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:98: expected '}', found 'for'
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:150: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:158: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:169: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:193: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:212: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:234: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:246: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:257: illegal rune literal
services/sql/mgmt/2015-05-01-preview/sql/models.go:1184:291: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1433:8: expected ';', found ':'
services/sql/mgmt/2017-03-01-preview/sql/models.go:1438:145: rune literal not terminated
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:98: expected '}', found 'for'
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:150: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:158: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:169: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:193: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:212: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:234: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:246: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:257: illegal rune literal
services/sql/mgmt/2017-03-01-preview/sql/models.go:1440:291: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1461:8: expected ';', found ':'
services/sql/mgmt/2017-10-01-preview/sql/models.go:1466:145: rune literal not terminated
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:98: expected '}', found 'for'
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:150: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:158: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:169: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:193: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:212: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:234: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:246: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:257: illegal rune literal
services/sql/mgmt/2017-10-01-preview/sql/models.go:1468:291: illegal rune literal

anuchandy · 2018-02-05T17:20:32Z

...e-manager/Microsoft.Sql/preview/2017-10-01-preview/databaseVulnerabilityAssessmentScans.json

+            "create",
+            "update"
+          ]
+        },


The storage account should be referenced using the fully qualified ARM resource id instead of passing the url and access-key. You can then enable linked access check on it reliably to ensure sufficient permission are there to perform the operation. Since this is an ARM guideline, tagging Gaurav @ravbhatnagar

We already got the approval from ARM to go this way before.
The intention here is that a user will supply a SAS key (not access key) with an expiration date and privileges he chooses to supply.
This way he is more "secure" as we have a SAS key that he controls on.

anuchandy · 2018-02-05T17:22:33Z

...e-manager/Microsoft.Sql/preview/2017-10-01-preview/databaseVulnerabilityAssessmentScans.json

+        ],
+        "responses": {
+          "200": {
+            "description": "Successfully executed a Vulnerability Assessment database scan."


Just confirming, is there any final response that contains the scan id? or it should always be retrieved using DatabaseVulnerabilityAssessmentScans_ListByDatabase?

Currently to get the scan ID of a past scan, the user should use: DatabaseVulnerabilityAssessmentScans_ListByDatabase

If the user has a scan ID he can use DatabaseVulnerabilityAssessmentScans_Get

anuchandy · 2018-02-05T17:24:43Z

...e-manager/Microsoft.Sql/preview/2017-10-01-preview/databaseVulnerabilityAssessmentScans.json

+          "200": {
+            "description": "Scan result was converted successfully.",
+            "schema": {
+              "$ref": "#/definitions/DatabaseVulnerabilityAssessmentScansExport"


If scan result was already converted, does this POST call return that existing result?

anuchandy · 2018-02-08T23:17:06Z

@yaakoviyun thanks for the response. @ravbhatnagar please sign-off since this is a new spec.

anuchandy · 2018-02-09T18:10:35Z

@yaakoviyun Could you share your MS alias, wanted to start an email thread but could't locate your name/alias.

anuchandy · 2018-02-14T07:10:02Z

@ravbhatnagar ping

anuchandy · 2018-02-15T19:15:39Z

@ravbhatnagar can you please take a look?

ravbhatnagar · 2018-02-15T21:33:50Z

...e-manager/Microsoft.Sql/preview/2017-10-01-preview/databaseVulnerabilityAssessmentScans.json

+          }
+        }
+      },
+      "post": {


Why is a scan not created (initiated) using PUT instead of POST?

Put is traditionally used to create a resource. This API is for executing a scan (doing operation on a resource), so we thought POST will be a better match.

@yaakoviyun - But this is not modeled as an action on a resource. Should it be modeled like - POST subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/vulnerabilityAssessments/{vulnerabilityAssessmentName}/initiateScan

OK Will make the change in the next API-version of this API.

We decided to implement it for this api version

ravbhatnagar · 2018-02-15T21:44:48Z

Just one comment around the use of POST instead of PUT.

ravbhatnagar · 2018-02-16T08:16:04Z

@yaakoviyun

anuchandy · 2018-02-26T22:05:07Z

@yaakoviyun can you please take a look at the one comment from Gaurav?

- POST subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/vulnerabilityAssessments/{vulnerabilityAssessmentName}/initiateScan

AutorestCI · 2018-02-28T10:08:15Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2285

AutorestCI · 2018-02-28T10:13:13Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1741

yaakoviyun · 2018-03-04T14:54:56Z

Ping. Regards, Yaakov From: Anu Thomas Chandy <notifications@github.com> Sent: Tuesday, February 27, 2018 12:05 AM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: Yaakov Iyun <yaiyun@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] Adding database vulnerability assessmen scan APIs (#2418) @yaakoviyun<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fyaakoviyun&data=04%7C01%7Cyaiyun%40microsoft.com%7C072bd5bb2aec4b0e9adc08d57d65079b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636552795224583242%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=iKKGw2bnGRxab21qf9%2Bv9Esq%2FH8zaikI%2BCD3pGp4dKA%3D&reserved=0> can you please take a look at the one comment from Gaurav? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2418%23issuecomment-368667435&data=04%7C01%7Cyaiyun%40microsoft.com%7C072bd5bb2aec4b0e9adc08d57d65079b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636552795224583242%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=17D3rgfewz7BKcG4fExPXH8Qy%2BEDZDxafJ5lzvU58lc%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALNguQg0HeteCQNOIWkbyhV_AJyEAcrjks5tYyqegaJpZM4R5YxO&data=04%7C01%7Cyaiyun%40microsoft.com%7C072bd5bb2aec4b0e9adc08d57d65079b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636552795224583242%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=kUVwkpzKhAG%2F4qAhFbYC%2FyF9Kq76apRzaVyzeiqQ56s%3D&reserved=0>.

yaakoviyun · 2018-03-08T06:18:59Z

@ravbhatnagar can you take a look?

ravbhatnagar · 2018-03-09T08:53:22Z

Looks good!

AutorestCI · 2018-03-20T15:15:42Z

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#9

AutorestCI · 2018-03-20T15:18:37Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2715

jaredmoo · 2018-03-20T16:40:46Z

specification/sql/resource-manager/readme.md

@@ -468,6 +469,7 @@ batch:
  - tag: package-2014-04
 ```

+


Undo whitespace

jaredmoo · 2018-03-20T16:41:25Z

specification/sql/resource-manager/readme.md

@@ -78,6 +78,7 @@ input-file:
 - Microsoft.Sql/preview/2017-03-01-preview/restorePoints.json
 - Microsoft.Sql/preview/2017-10-01-preview/cancelOperations.json
 - Microsoft.Sql/preview/2017-10-01-preview/cancelPoolOperations.json
+- Microsoft.Sql/preview/2017-10-01-preview/databaseVulnerabilityAssessmentScans.json


Please add to both package-composite-v1 and -v2 sections, and package-pure-2017-10-preview

anuchandy · 2018-04-13T03:15:29Z

@yaakoviyun could you address comments from @jaredmoo?

Add new swagger to both package-composite-v1 and -v2 sections, and package-pure-2017-10-preview

yaakoviyun · 2018-04-15T08:28:45Z

Done. Regards, Yaakov From: Anu Thomas Chandy <notifications@github.com> Sent: Friday, April 13, 2018 6:16 AM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: Yaakov Iyun <yaiyun@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] Adding database vulnerability assessmen scan APIs (#2418) @yaakoviyun<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fyaakoviyun&data=02%7C01%7Cyaiyun%40microsoft.com%7C6aa7f8b00d3e4536cd4608d5a0ecd957%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636591861501019013&sdata=5X%2BMrgIP3%2BywmSOSUWrOImE%2FD8yd4pqGQEExRmY4yRg%3D&reserved=0> could you address comments from @jaredmoo<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjaredmoo&data=02%7C01%7Cyaiyun%40microsoft.com%7C6aa7f8b00d3e4536cd4608d5a0ecd957%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636591861501019013&sdata=kVH9MOwDJCFe%2F9up%2BP6w72nV4AjNPxbWQv9P4PwFyeU%3D&reserved=0>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2418%23issuecomment-381009239&data=02%7C01%7Cyaiyun%40microsoft.com%7C6aa7f8b00d3e4536cd4608d5a0ecd957%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636591861501019013&sdata=1Wj6m4HQBmyovfRjaOL5gok4RN5G7R2jZV8G%2FpM43f0%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALNguYWRUsIvc22hpITdBUQz5Vv1FIgkks5toBhhgaJpZM4R5YxO&data=02%7C01%7Cyaiyun%40microsoft.com%7C6aa7f8b00d3e4536cd4608d5a0ecd957%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636591861501019013&sdata=sWndnLq8j5uuXxRzgrFEVcwqwOCOwDuNiXu7VGWuFCA%3D&reserved=0>.

azuresdkciprbot · 2018-04-15T08:34:08Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 24 Error(s): 0
After the PR: Warning(s): 24 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jaredmoo

Thanks for readme.md changes, since last month there is now a new composite-v3 section. Please add there as well. I am approving now because I am on vacation and might not look at your next commit :)

azuresdkciprbot · 2018-04-23T10:38:06Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/sql/resource-manager/readme.md

⚠️

0 new Warnings.(6 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-23T10:38:06Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/sql/resource-manager/readme.md

⚠️

0 new Warnings.(20 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-23T10:51:08Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/sql/resource-manager/readme.md

⚠️

0 new Warnings.(20 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-23T10:51:08Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/sql/resource-manager/readme.md

⚠️

0 new Warnings.(6 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

yaakoviyun · 2018-04-23T10:52:24Z

ping, can you merge?

jaredmoo · 2018-04-30T23:56:08Z

@yaakoviyun There are merge conflicts again. Can you resolve?

@ravbhatnagar it looks like you signed off in comments, can you approve?

azuresdkciprbot · 2018-05-01T09:20:27Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/sql/resource-manager/readme.md

⚠️

1 new Warnings.(21 total)

Code	Id	Source	Message
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'initiatescan' in:'DatabaseVulnerabilityAssessmentScans_Execute'. Consider updating the operationId

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-01T09:20:27Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/sql/resource-manager/readme.md

⚠️

0 new Warnings.(6 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

yaakoviyun · 2018-05-02T07:57:12Z

ping...

Adding database vulnerability assessmen scan APIs

28767a5

Adding database vulnerability assessmen scan APIs

azuresdkci assigned anuchandy Feb 5, 2018

Fixed readme file

eaeb4ec

spelling fix

388912f

anuchandy reviewed Feb 5, 2018

View reviewed changes

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 5, 2018

anuchandy requested a review from ravbhatnagar February 5, 2018 17:49

ravbhatnagar reviewed Feb 15, 2018

View reviewed changes

Add initiateScan to trigger scan URL

0d3083e

- POST subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/vulnerabilityAssessments/{vulnerabilityAssessmentName}/initiateScan

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 9, 2018

This was referenced Mar 20, 2018

[AutoPR sql/resource-manager] Adding database vulnerability assessmen scan APIs Azure/azure-sdk-for-python#2233

Closed

[AutoPR sql/resource-manager] Adding database vulnerability assessmen scan APIs Azure/azure-libraries-for-java#345

Closed

AutorestCI mentioned this pull request Mar 20, 2018

[AutoPR sql/resource-manager] Adding database vulnerability assessmen scan APIs Azure/azure-sdk-for-node#2480

Closed

jaredmoo suggested changes Mar 20, 2018

View reviewed changes

Add new swagger to more packges

db3276b

Add new swagger to both package-composite-v1 and -v2 sections, and package-pure-2017-10-preview

AutorestCI mentioned this pull request Apr 15, 2018

[AutoPR sql/resource-manager] Adding database vulnerability assessmen scan APIs AutorestCI/azure-libraries-for-java#79

Open

AutorestCI mentioned this pull request Apr 15, 2018

[AutoPR sql/resource-manager] Adding database vulnerability assessmen scan APIs Azure/azure-sdk-for-go#1600

Closed

jaredmoo approved these changes Apr 16, 2018

View reviewed changes

Merge remote-tracking branch 'refs/remotes/Azure/master'

f8feb6c

This was referenced Apr 23, 2018

[AutoPR sql/resource-manager] Adding database vulnerability assessmen scan APIs Azure/azure-sdk-for-python#2449

Closed

[AutoPR sql/resource-manager] Adding database vulnerability assessmen scan APIs Azure/azure-sdk-for-go#1675

Closed

Merge branch 'master' into master

7d497dc

Updated "package-composite-v3"

10b1f67

Merge branch 'master' into master

44bbc7e

anuchandy approved these changes May 7, 2018

View reviewed changes

anuchandy merged commit cef11c5 into Azure:master May 7, 2018

Adding database vulnerability assessmen scan APIs #2418

Adding database vulnerability assessmen scan APIs #2418

Conversation

yaakoviyun commented Feb 5, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Feb 5, 2018

AutorestCI commented Feb 5, 2018

AutorestCI commented Feb 5, 2018

AutorestCI commented Feb 5, 2018

AutorestCI commented Feb 5, 2018

azuresdkciprbot commented Feb 5, 2018

AutorestCI commented Feb 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anuchandy commented Feb 8, 2018

anuchandy commented Feb 9, 2018

anuchandy commented Feb 14, 2018

anuchandy commented Feb 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravbhatnagar commented Feb 15, 2018

ravbhatnagar commented Feb 16, 2018

anuchandy commented Feb 26, 2018

AutorestCI commented Feb 28, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 28, 2018 • edited Loading

Automation for azure-sdk-for-go

yaakoviyun commented Mar 4, 2018 via email

yaakoviyun commented Mar 8, 2018

ravbhatnagar commented Mar 9, 2018

AutorestCI commented Mar 20, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Mar 20, 2018 • edited Loading

Automation for azure-sdk-for-node

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anuchandy commented Apr 13, 2018

yaakoviyun commented Apr 15, 2018 via email

azuresdkciprbot commented Apr 15, 2018

jaredmoo left a comment

Choose a reason for hiding this comment

azuresdkciprbot commented Apr 23, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 23, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 23, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 23, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

yaakoviyun commented Apr 23, 2018

jaredmoo commented Apr 30, 2018

azuresdkciprbot commented May 1, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 1, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

yaakoviyun commented May 2, 2018

yaakoviyun commented Feb 5, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Feb 28, 2018 •

edited

Loading

AutorestCI commented Feb 28, 2018 •

edited

Loading

AutorestCI commented Mar 20, 2018 •

edited

Loading

AutorestCI commented Mar 20, 2018 •

edited

Loading