-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PostgreSQL Flexible Server version 15 #24203
Conversation
PostgreSQL version 15 is now available in public preview
Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
FlexibleServers.json | 2023-03-01-preview(775161a) | 2023-03-01-preview(main) |
Rule | Message |
---|---|
1020 - AddedEnumValue |
The new version is adding enum value(s) '15' from the old version. New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L411:9 Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L410:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) '15' from the old version. New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L589:9 Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L588:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) '15' from the old version. New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L375:5 Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L375:5 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.3) | new version | base version |
---|---|---|
package-flexibleserver-2023-03-01-preview | package-flexibleserver-2023-03-01-preview(775161a) | package-flexibleserver-2023-03-01-preview(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L38 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L90 |
ProvisioningStateSpecifiedForLROPatch |
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L170 |
Schema should have a description or title. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L577 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01 |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
...postgresql/resource-manager/Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json
Outdated
Show resolved
Hide resolved
add "BreakingChangeReviewRequired" to review breaking change |
Hi @navba-MSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@ambrahma ,please ask BreakingChange Review Board to review breaking change |
Raised Breaking change review https://msazure.visualstudio.com/One/_workitems/edit/24246982 |
Breaking change review request => https://msazure.visualstudio.com/One/_workitems/edit/24246982 |
@ambrahma @kazrael2119 This is the workitem for the breaking change. You can see the reply from the breaking change board: https://msazure.visualstudio.com/One/_workitems/edit/24122987 |
@navba-MSFT ,please let me know when you want to merge this pr, thanks |
@kazrael2119 Since the Service Team and Breaking change approval is done. You can merge it now. CC: @ambrahma |
* Update FlexibleServers.json PostgreSQL version 15 is now available in public preview * Update FlexibleServers.json * Update FlexibleServers.json
PostgreSQL version 15 is now available in public preview
PostgreSQL version 15 is now available in public preview in limited regions (West Europe, East US, West US2, South East Asia, UK SOuth, North Europe, Japan east). Refer to the PostgreSQL documentation to learn more about improvements and fixes in this release. New servers will be created with this minor version.
fixes #24186
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.