Adding new api version 2023-04-01 for recoveryservicessiterecovery microsoft.recovery services #24220

chandrikagonuguntla · 2023-05-30T09:35:31Z

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…/2023-02-01 to version 2023-04-01

openapi-workflow-bot · 2023-05-30T09:35:35Z

Hi, @chandrikagonuguntla Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-05-30T09:35:37Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
service.json	2023-04-01(8a49581)	2023-02-01(main)

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-30T09:35:37Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1c598e6. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.RecoveryServicesSiteRecovery [View full logs] [Release SDK Changes]
- Azure.ResourceManager.RecoveryServicesSiteRecovery.1.0.0-alpha.20230606.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 1c598e6. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-recoveryservicessiterecovery [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model AzureFabricSpecificDetails has a new parameter location_details
info	[Changelog]   - Model FabricQueryParameter has a new parameter extended_location_mappings
info	[Changelog]   - Model FabricQueryParameter has a new parameter location_details
info	[Changelog]   - Model VMwareCbtEnableMigrationInput has a new parameter confidential_vm_key_vault_id
info	[Changelog]   - Model VMwareCbtEnableMigrationInput has a new parameter target_vm_security_profile
info	[Changelog]   - Model VMwareCbtMigrateInput has a new parameter os_upgrade_version
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter confidential_vm_key_vault_id
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter os_name
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter supported_os_versions
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter target_vm_security_profile
info	[Changelog]   - Model VMwareCbtProtectionContainerMappingDetails has a new parameter excluded_skus
info	[Changelog]   - Model VMwareCbtTestMigrateInput has a new parameter os_upgrade_version

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 1c598e6. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-recoveryservicessiterecovery [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1c598e6. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `SecurityType` with values `SecurityTypeConfidentialVM`, `SecurityTypeNone`, `SecurityTypeTrustedLaunch`
info	[Changelog] - New struct `A2AFabricSpecificLocationDetails`
info	[Changelog] - New struct `VMwareCbtSecurityProfileProperties`
info	[Changelog] - New field `LocationDetails` in struct `AzureFabricSpecificDetails`
info	[Changelog] - New field `ExtendedLocationMappings`, `LocationDetails` in struct `FabricQueryParameter`
info	[Changelog] - New field `ConfidentialVMKeyVaultID`, `TargetVMSecurityProfile` in struct `VMwareCbtEnableMigrationInput`
info	[Changelog] - New field `OSUpgradeVersion` in struct `VMwareCbtMigrateInput`
info	[Changelog] - New field `ConfidentialVMKeyVaultID`, `OSName`, `SupportedOSVersions`, `TargetVMSecurityProfile` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `ExcludedSKUs` in struct `VMwareCbtProtectionContainerMappingDetails`
info	[Changelog] - New field `OSUpgradeVersion` in struct `VMwareCbtTestMigrateInput`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 15 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1c598e6. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-recoveryservices-siterecovery [View full logs] [Release SDK Changes]

azure-arm-recoveryservices-siterecovery-5.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface A2AFabricSpecificLocationDetails
info	[Changelog]   - Added Interface VMwareCbtSecurityProfileProperties
info	[Changelog]   - Added Type Alias SecurityType
info	[Changelog]   - Interface AzureFabricSpecificDetails has a new optional parameter locationDetails
info	[Changelog]   - Interface FabricQueryParameter has a new optional parameter extendedLocationMappings
info	[Changelog]   - Interface FabricQueryParameter has a new optional parameter locationDetails
info	[Changelog]   - Interface VMwareCbtEnableMigrationInput has a new optional parameter confidentialVmKeyVaultId
info	[Changelog]   - Interface VMwareCbtEnableMigrationInput has a new optional parameter targetVmSecurityProfile
info	[Changelog]   - Interface VMwareCbtMigrateInput has a new optional parameter osUpgradeVersion
info	[Changelog]   - Interface VMwareCbtMigrationDetails has a new optional parameter confidentialVmKeyVaultId
info	[Changelog]   - Interface VMwareCbtMigrationDetails has a new optional parameter osName
info	[Changelog]   - Interface VMwareCbtMigrationDetails has a new optional parameter supportedOSVersions
info	[Changelog]   - Interface VMwareCbtMigrationDetails has a new optional parameter targetVmSecurityProfile
info	[Changelog]   - Interface VMwareCbtProtectionContainerMappingDetails has a new optional parameter excludedSkus
info	[Changelog]   - Interface VMwareCbtTestMigrateInput has a new optional parameter osUpgradeVersion
info	[Changelog]   - Added Enum KnownSecurityType

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 1c598e6. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️recoveryservicessiterecovery [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 1c598e6. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.recoveryservicessiterecovery.DefaultTag [View full logs]

Az.SiteRecovery.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.recoveryservicessiterecovery.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-30T09:35:38Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery	https://apiview.dev/Assemblies/Review/9304a0446b564185bc7dd57814fc007c
Java	azure-resourcemanager-recoveryservicessiterecovery	Create ApiView failed. Please ask PR assignee for help
.Net	Azure.ResourceManager.RecoveryServicesSiteRecovery	Create ApiView failed. Please ask PR assignee for help
JavaScript	@azure/arm-recoveryservices-siterecovery	Create ApiView failed. Please ask PR assignee for help

openapi-workflow-bot · 2023-05-30T09:41:43Z

Hi, @chandrikagonuguntla, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

openapi-workflow-bot · 2023-05-30T09:59:32Z

Hi, @chandrikagonuguntla your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

kazrael2119 · 2023-05-31T02:27:31Z

/azp run

azure-pipelines · 2023-05-31T02:27:41Z

Azure Pipelines successfully started running 1 pipeline(s).

chandrikagonuguntla · 2023-06-01T11:47:41Z

@kazrael2119 could you please review the PR

mentat9 · 2023-06-01T17:55:40Z

@chandrikagonuguntla - No API changes in this PR: signing off for ARM.

kazrael2119 · 2023-06-02T02:19:32Z

@chandrikagonuguntla ,Why did your pr just update the apiversion without any other changes and submit it to public main?

chandrikagonuguntla · 2023-06-05T10:51:16Z

@chandrikagonuguntla ,Why did your pr just update the apiversion without any other changes and submit it to public main?

@mentat9 recoveryservicessiterecovery and recoveryservicesbackup share the same api surface, the changes for the api version 2023-04-01 are in recoveryservicesbackup folder and a separate PR has been raised(#24210, this PR is for recoveryservicessiterecovery to support the new version.

kazrael2119

approved because no changes

…crosoft.recovery services (Azure#24220) * Adds base for updating Microsoft.RecoveryServices from version stable/2023-02-01 to version 2023-04-01 * Updates readme * Updates API version in new specs and examples * Removing blank line

chandrikagonuguntla added 4 commits May 30, 2023 15:01

Adds base for updating Microsoft.RecoveryServices from version stable…

4369501

…/2023-02-01 to version 2023-04-01

Updates readme

4f34b29

Updates API version in new specs and examples

a595a10

Removing blank line

8a49581

ghost added the Recovery Services Site-Recovery label May 30, 2023

azure-sdk mentioned this pull request May 30, 2023

[AutoPR sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery] Adding new api version 2023-04-01 for recoveryservicessiterecovery microsoft.recovery services azure-sdk/azure-sdk-for-go#5912

Closed

AzureRestAPISpecReview added CI-MissingBaseCommit new-api-version resource-manager labels May 30, 2023

chandrikagonuguntla marked this pull request as ready for review May 30, 2023 09:58

openapi-assignment-bot bot assigned kazrael2119 May 30, 2023

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 30, 2023

chandrikagonuguntla changed the title ~~Chandrikagonuguntla recoveryservicessiterecovery microsoft.recovery services 2023 04 01~~ Adding new api version 2023-04-01 for recoveryservicessiterecovery microsoft.recovery services May 30, 2023

azure-sdk mentioned this pull request May 30, 2023

[AutoPR recoveryservicessiterecovery] Adding new api version 2023-04-01 for recoveryservicessiterecovery microsoft.recovery services azure-sdk/azure-resource-manager-schemas#2679

Closed

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label May 31, 2023

mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 1, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 1, 2023

kazrael2119 approved these changes Jun 6, 2023

View reviewed changes

tadelesh merged commit 1c598e6 into main Jun 6, 2023

tadelesh deleted the chandrikagonuguntla-recoveryservicessiterecovery-Microsoft.RecoveryServices-2023-04-01 branch June 6, 2023 01:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding new api version 2023-04-01 for recoveryservicessiterecovery microsoft.recovery services #24220

Adding new api version 2023-04-01 for recoveryservicessiterecovery microsoft.recovery services #24220

chandrikagonuguntla commented May 30, 2023 •

edited

Loading

openapi-workflow-bot bot commented May 30, 2023

openapi-pipeline-app bot commented May 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented May 30, 2023 •

edited

Loading

openapi-workflow-bot bot commented May 30, 2023

openapi-workflow-bot bot commented May 30, 2023

kazrael2119 commented May 31, 2023

azure-pipelines bot commented May 31, 2023

chandrikagonuguntla commented Jun 1, 2023

mentat9 commented Jun 1, 2023

kazrael2119 commented Jun 2, 2023

chandrikagonuguntla commented Jun 5, 2023

kazrael2119 left a comment

Adding new api version 2023-04-01 for recoveryservicessiterecovery microsoft.recovery services #24220

Adding new api version 2023-04-01 for recoveryservicessiterecovery microsoft.recovery services #24220

Conversation

chandrikagonuguntla commented May 30, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 30, 2023

openapi-pipeline-app bot commented May 30, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 30, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented May 30, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented May 30, 2023

openapi-workflow-bot bot commented May 30, 2023

kazrael2119 commented May 31, 2023

azure-pipelines bot commented May 31, 2023

chandrikagonuguntla commented Jun 1, 2023

mentat9 commented Jun 1, 2023

kazrael2119 commented Jun 2, 2023

chandrikagonuguntla commented Jun 5, 2023

kazrael2119 left a comment

Choose a reason for hiding this comment

chandrikagonuguntla commented May 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2023 •

edited

Loading