Calec/new api version #24542

calecarter · 2023-06-21T22:14:45Z

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
I commit to follow the Breaking Change Policy.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

…into calec/new-api-version

openapi-workflow-bot · 2023-06-21T22:14:49Z

Hi, @calecarter Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-06-21T22:14:51Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 55 Errors, 73 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
policyAssignments.json	2023-04-01(5a7178b)	2022-06-01(main)
policyAssignments.json	2023-04-01(5a7178b)	2017-06-01-preview(main)
policyDefinitions.json	2023-04-01(5a7178b)	2021-06-01(main)
policySetDefinitions.json	2023-04-01(5a7178b)	2021-06-01(main)
policySetDefinitions.json	2023-04-01(5a7178b)	2017-06-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L304:9 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L300:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L361:9 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L357:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L495:9 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L490:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L633:5 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L1011:5
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L53:9 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L53:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L105:9 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L104:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L148:9 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L146:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L375:9 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L368:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L633:5 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L660:5
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L53:9 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L53:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L111:9 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L110:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L154:9 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L152:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L241:9 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L237:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L633:5 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L678:5
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L59:11 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L59:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L128:11 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L127:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L197:11 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L195:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L254:11 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L251:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L398:11 Old: Microsoft.Authorization/stable/2022-06-01/policyAssignments.json#L391:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L57:11 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L54:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L109:11 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L105:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L152:11 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L147:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L194:11 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L191:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L239:11 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L232:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L291:11 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L283:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json#L334:11 Old: Microsoft.Authorization/stable/2021-06-01/policyDefinitions.json#L325:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L57:11 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L54:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L115:11 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L111:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L158:11 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L153:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L200:11 Old: Microsoft.Authorization/stable/2021-06-01/policySetDefinitions.json#L197:11

The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule	Message
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L12:3
⚠️ 1003 - RequestBodyFormatNoLongerSupported	The new version does not support 'text/json' as a request body format. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L12:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L12:3
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}/providers/Microsoft.Authorization/policyAssignments' removed or restructured? Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L239:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementgroups/{managementGroupId}/providers/Microsoft.Authorization/policySetDefinitions/{policySetDefinitionName}' removed or restructured? Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L289:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementgroups/{managementGroupId}/providers/Microsoft.Authorization/policySetDefinitions' removed or restructured? Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L424:5
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'PolicySku' removed or renamed? New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L719:3 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L486:3
⚠️ 1011 - AddingResponseCode	The new version adds a response code '204'. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L562:11
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L753:9 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L508:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L83:13 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L78:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L158:13 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L134:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L218:13 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L180:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L337:13 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L229:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L518:13 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L358:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L567:13 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L399:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L619:13 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L443:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policyAssignments.json#L662:13 Old: Microsoft.Authorization/preview/2017-06-01-preview/policyAssignments.json#L478:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L553:9 Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L492:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json#L601:9 Old: Microsoft.Authorization/preview/2017-06-01-preview/policySetDefinitions.json#L515:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 6 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-policy-2023-04	package-policy-2023-04(5a7178b)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listpolicydefinitionversions' in:'PolicyDefinitionVersions_ListAllBuiltins'. Consider updating the operationId Location: Microsoft.Authorization/stable/2023-04-01/policyDefinitionVersions.json#L42
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listpolicydefinitionversions' in:'PolicyDefinitionVersions_ListAllAtManagementGroup'. Consider updating the operationId Location: Microsoft.Authorization/stable/2023-04-01/policyDefinitionVersions.json#L76
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listpolicydefinitionversions' in:'PolicyDefinitionVersions_ListAll'. Consider updating the operationId Location: Microsoft.Authorization/stable/2023-04-01/policyDefinitionVersions.json#L113
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listpolicysetdefinitionversions' in:'PolicySetDefinitionVersions_ListAllBuiltins'. Consider updating the operationId Location: Microsoft.Authorization/stable/2023-04-01/policySetDefinitionVersions.json#L42
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listpolicysetdefinitionversions' in:'PolicySetDefinitionVersions_ListAllAtManagementGroup'. Consider updating the operationId Location: Microsoft.Authorization/stable/2023-04-01/policySetDefinitionVersions.json#L76
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listpolicysetdefinitionversions' in:'PolicySetDefinitionVersions_ListAll'. Consider updating the operationId Location: Microsoft.Authorization/stable/2023-04-01/policySetDefinitionVersions.json#L113

️❌Avocado: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` MULTIPLE_DEFAULT_TAGS	The readme file has more than one default tag. readme: specification/resources/resource-manager/readme.md

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-21T22:14:52Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/resources/armpolicy - Approved - 0.8.0

+	Function `NewClientFactory` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, string, string, string, azcore.TokenCredential, *arm.ClientOptions)`

❌azure-sdk-for-js - @azure/arm-policy - Approved - 6.0.0-beta.1

+	Class PolicyClient has a new signature
+	Operation PolicyAssignments.list has a new signature
+	Operation PolicyAssignments.listForResource has a new signature
+	Operation PolicyAssignments.listForResourceGroup has a new signature
+	Operation PolicyDefinitions.createOrUpdate has a new signature
+	Operation PolicyDefinitions.delete has a new signature
+	Operation PolicyDefinitions.get has a new signature
+	Operation PolicyDefinitions.list has a new signature
+	Operation PolicySetDefinitions.createOrUpdate has a new signature
+	Operation PolicySetDefinitions.delete has a new signature
+	Operation PolicySetDefinitions.get has a new signature
+	Operation PolicySetDefinitions.list has a new signature

️⚠️ azure-sdk-for-net-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from b1f57e5. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️Azure.ResourceManager.Resources [View full logs]
- Azure.ResourceManager.Resources.1.7.0-alpha.20230912.1.nupkg
```
info	[Changelog]
```

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from b1f57e5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from b1f57e5. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-resources-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b1f57e5. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/resources/armresources [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 11 items here, please refer to log for details.

info	[Changelog] - Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
info	[Changelog] - Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
info	[Changelog] - Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `DeploymentParameter`
info	[Changelog] - New struct `KeyVaultParameterReference`
info	[Changelog] - New struct `KeyVaultReference`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).

️✔️sdk/resourcemanager/resources/armdeploymentscripts [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armfeatures [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armlinks [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armlocks [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armmanagedapplications [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armpolicy [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 11 items here, please refer to log for details.

info	[Changelog] - New struct `VariableValueColumnValue`
info	[Changelog] - New struct `VariableValueListResult`
info	[Changelog] - New struct `VariableValueProperties`
info	[Changelog] - New field `Overrides`, `ResourceSelectors` in struct `AssignmentProperties`
info	[Changelog] - New field `Properties` in struct `AssignmentUpdate`
info	[Changelog] - New field `Version`, `Versions` in struct `DefinitionProperties`
info	[Changelog] - New field `AssignmentScopeValidation`, `ResourceSelectors` in struct `ExemptionProperties`
info	[Changelog] - New field `Schema` in struct `ParameterDefinitionsValue`
info	[Changelog] - New field `Version`, `Versions` in struct `SetDefinitionProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 107 additive change(s).

️✔️sdk/resourcemanager/resources/armsubscriptions [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armtemplatespecs [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armchanges [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armdeploymentstacks [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️🔄 azure-sdk-for-js inProgress [Detail]

️❌ azure-resource-manager-schemas failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from b1f57e5. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.

️✔️resources [View full logs] [Release Schema Changes]

️✔️resources [View full logs]

error	Fatal error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		resources
error		resources
error		resources
error		resources

️✔️resources
️✔️resources

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from b1f57e5. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.resources.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.resources.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-21T22:14:53Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/resources/armchanges	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armdeploymentscripts	https://apiview.dev/Assemblies/Review/0dd895fcc6ba46fca0c2ec0aa39b9bd4
Go	sdk/resourcemanager/resources/armdeploymentstacks	https://apiview.dev/Assemblies/Review/cea4bebc259d463dbf381e45095307fa
Go	sdk/resourcemanager/resources/armfeatures	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armlinks	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armlocks	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armmanagedapplications	https://apiview.dev/Assemblies/Review/2f4ef9016cac46b09d515302c25de169
Go	sdk/resourcemanager/resources/armpolicy	https://apiview.dev/Assemblies/Review/4ee3742a9ea74e4d91d5797e0f669efe
Go	sdk/resourcemanager/resources/armresources	https://apiview.dev/Assemblies/Review/bcf353f198e54dd3ae0e6786cbcec0bd
Go	sdk/resourcemanager/resources/armsubscriptions	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armtemplatespecs	There is no API change compared with the previous version
.Net	Azure.ResourceManager.Resources	There is no API change compared with the previous version

openapi-workflow-bot · 2023-06-21T22:21:21Z

Hi @calecarter! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki. #Resolved

openapi-workflow-bot · 2023-06-21T22:21:21Z

Hi @calecarter! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic Validation	Fix-SemanticValidation-Error	High
Model Validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	High

If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. #Resolved

kazrael2119 · 2023-09-11T08:05:23Z

js sdk generation failure is a known issue

openapi-pipeline-app · 2023-09-12T18:41:33Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

* Baseline current api version * Add new version properties/apis * Add new list apis * Sync with main * Update readme files * Updated python readme * reverting to sync with main * updating python and main readme * Fixing some automation failures * add examples for all policyDefinitionVersion apis * Add examples for policy set versions * Updated readme to remove tangling tag * Fix linter issues and and suppression where applicable * Fix linter errors for assignmenets swagger * Fix more linter errors * fix more linter errors * Add schema property to definition parameters to reflect reality * Fix prettier check issues * Updated based on feedback * Fixing linter errors * Fixed more linter errors * Fix JSON syntax error * updated based on feedback to remove RepeatedPathInfo subpression for new apis * Updated subid and api version to use common types

msyyc · 2024-03-07T01:39:55Z

specification/resources/resource-manager/readme.md

+input-file:
+- Microsoft.Authorization/stable/2020-09-01/dataPolicyManifests.json
+- Microsoft.Authorization/stable/2023-04-01/policyDefinitions.json
+- Microsoft.Authorization/stable/2023-04-01/policyDefinitionVersions.json
+- Microsoft.Authorization/stable/2023-04-01/policySetDefinitions.json
+- Microsoft.Authorization/stable/2023-04-01/policySetDefinitionVersions.json
+- Microsoft.Authorization/stable/2023-04-01/policyAssignments.json
+- Microsoft.Authorization/preview/2022-07-01-preview/policyExemptions.json
+- Microsoft.Authorization/preview/2022-08-01-preview/policyVariables.json
+- Microsoft.Authorization/preview/2022-08-01-preview/policyVariableValues.json


One tag shall only contain one api-version, otherwise it will cause Python SDK generation failure.

Can you elaborate? This tag has a single api-version for each type.

Your new tag package-policy-2023-04 contains multi api-version 2020-09-01/2023-04-01/...:

One tag shall only contain one kind of api-version like:

calecarter added 9 commits March 15, 2023 14:27

Baseline current api version

9158a69

Add new version properties/apis

11333f5

Add new list apis

da0f647

Sync with main

bbdc4f5

Update readme files

947a691

Updated python readme

72c7354

reverting to sync with main

5573006

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

e8c2284

…into calec/new-api-version

updating python and main readme

a9de5d2

calecarter added the ARMReview label Jun 21, 2023

calecarter requested a review from mentat9 June 21, 2023 22:14

calecarter requested review from msyyc, Wzb123456789 and ArcturusZhang as code owners June 21, 2023 22:14

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2023

openapi-assignment-bot bot assigned rkmanda Jun 21, 2023

azure-sdk mentioned this pull request Jun 21, 2023

[AutoPR resources/resource-manager] Calec/new api version azure-sdk/azure-resource-manager-schemas#2808

Draft

AzureRestAPISpecReview added CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager labels Jun 21, 2023

calecarter marked this pull request as draft June 21, 2023 22:22

azure-sdk mentioned this pull request Jun 21, 2023

[AutoPR azure-resourcemanager-resources-generated] Calec/new api version azure-sdk/azure-sdk-for-java#5842

Closed

Fixing some automation failures

a0728ec

openapi-pipeline-app bot added the no-recent-activity label Sep 11, 2023

microsoft-github-policy-service bot removed the no-recent-activity label Sep 11, 2023

openapi-pipeline-app bot added the no-recent-activity label Sep 11, 2023

microsoft-github-policy-service bot removed the no-recent-activity label Sep 11, 2023

openapi-pipeline-app bot added the no-recent-activity label Sep 11, 2023

microsoft-github-policy-service bot removed the no-recent-activity label Sep 11, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Sep 11, 2023

calecarter added the MergeRequested label Sep 11, 2023

rkmanda approved these changes Sep 12, 2023

View reviewed changes

rkmanda merged commit b1f57e5 into Azure:main Sep 12, 2023

msyyc reviewed Mar 7, 2024

View reviewed changes

calecarter deleted the calec/new-api-version branch April 5, 2024 19:52

msyyc mentioned this pull request May 8, 2024

missing x-ms-parameter-location: method for Parameters in policyDefinitionVersions.json #29030

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Calec/new api version #24542

Calec/new api version #24542

calecarter commented Jun 21, 2023

openapi-workflow-bot bot commented Jun 21, 2023

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jun 21, 2023 •

edited by calecarter

Loading

openapi-workflow-bot bot commented Jun 21, 2023 •

edited by calecarter

Loading

kazrael2119 commented Sep 11, 2023

openapi-pipeline-app bot commented Sep 12, 2023

msyyc Mar 7, 2024

calecarter Mar 7, 2024

msyyc Jun 5, 2024

Calec/new api version #24542

Calec/new api version #24542

Conversation

calecarter commented Jun 21, 2023

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

Due diligence checklist

ARM API changes review

Breaking change review

Getting help

openapi-workflow-bot bot commented Jun 21, 2023

openapi-pipeline-app bot commented Jun 21, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 21, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 21, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Jun 21, 2023 • edited by calecarter Loading

openapi-workflow-bot bot commented Jun 21, 2023 • edited by calecarter Loading

kazrael2119 commented Sep 11, 2023

openapi-pipeline-app bot commented Sep 12, 2023

msyyc Mar 7, 2024

Choose a reason for hiding this comment

calecarter Mar 7, 2024

Choose a reason for hiding this comment

msyyc Jun 5, 2024

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jun 21, 2023 •

edited by calecarter

Loading

openapi-workflow-bot bot commented Jun 21, 2023 •

edited by calecarter

Loading