Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsv path requirement check #24971

Closed
wants to merge 1 commit into from
Closed

tsv path requirement check #24971

wants to merge 1 commit into from

Conversation

ckairen
Copy link
Member

@ckairen ckairen commented Jul 25, 2023 •
edited
Loading

closes #24984

@ckairen ckairen added the Central-EngSys This issue is owned by the Engineering System team. label Jul 25, 2023
@ckairen ckairen self-assigned this Jul 25, 2023
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 25, 2023 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
Validation passes for ServiceAPIReadinessTest.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand] 
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️All merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @ckairen! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

    • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 25, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 25, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @ckairen ckairen marked this pull request as ready for review July 25, 2023 19:57
    mikeharder
    mikeharder requested changes Jul 25, 2023
    View reviewed changes
    Copy link
    Member

    @mikeharder mikeharder left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I'm not sure if this addresses all the concerns in the issue. It ensures the last word after the dot is capitalized, but what if there is no dot in the folder name? What if the folder is named something like Foo.Bar where Bar is not a valid suffix?

    mikeharder
    mikeharder requested changes Jul 26, 2023
    View reviewed changes
    Copy link
    Member

    @mikeharder mikeharder left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Please delay this PR until #24983 is addressed.

    weshaggard
    weshaggard reviewed Jul 26, 2023
    View reviewed changes
    eng/tools/TypeSpecValidation/src/TypeSpecValidation.ts
    "Please rename the folder " +
    leafDir +
    " to " +
    leafDir.replace(/\.\w/g, (l) => l.toUpperCase())
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Won't this also cause any other of the same letters to be upper cased in the path?

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @weshaggard: I converted this PR back to draft. It will have significant changes before merging.

    @mikeharder mikeharder marked this pull request as draft July 26, 2023 23:24
    @ckairen
    Copy link
    Member Author

    ckairen commented Sep 7, 2023

    combining with #25712

    @ckairen ckairen closed this Sep 7, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @weshaggard weshaggard weshaggard left review comments

    @mikeharder mikeharder mikeharder requested changes

    @konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

    @benbp benbp Awaiting requested review from benbp benbp will be requested when the pull request is marked ready for review benbp is a code owner

    Assignees

    @ckairen ckairen

    Labels
    Central-EngSys This issue is owned by the Engineering System team.
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    [TypeSpec Validation] Add rule to ensure specs match file and folder structure guidelines
    3 participants
    @ckairen @weshaggard @mikeharder