[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25183

sumitparwal · 2023-08-04T20:56:59Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…-05-01 to version 2023-11-01

openapi-workflow-bot · 2023-08-04T20:57:02Z

Hi, @sumitparwal! Thank you for your pull request. To help get your PR merged:

Ensure you reviewed the checklists in the PR description.

Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

openapi-pipeline-app · 2023-08-04T20:57:02Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 48 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
consumption.json	2023-11-01(723db51)	2023-05-01(main)
consumption.json	2023-11-01(723db51)	2019-05-01-preview(main)
consumption_pricesheet.json	2023-11-01(723db51)	2023-05-01(main)

The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.Consumption/usageDetails/download' removed or restructured? Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L154:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/providers/Microsoft.Consumption/balances' removed or restructured? Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L620:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/reservationRecommendations' removed or restructured? Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L876:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/forecasts' removed or restructured? Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1058:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedcost' removed or restructured? Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1194:5
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Filters' removed or renamed? New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1882:3 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1237:3
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'Charges_ListByScope' to 'Charges_List'. This will impact generated code. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L486:7 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L533:7
⚠️ 1011 - AddingResponseCode	The new version adds a response code '204'. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L155:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code '204'. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L252:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code '204'. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L473:11
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L577:13 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L568:13
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Usage' from the old version. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L4241:9 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2238:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L131:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L119:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L221:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L275:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1334:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L958:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1400:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1023:11
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L577:13 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L568:13
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1992:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1313:11
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1958:5 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1290:5
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L3480:5 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2071:5
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L3464:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2097:11
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L4763:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2724:11
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L4769:5 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2730:5
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L577:13 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L568:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L4763:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2724:11
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L4769:5 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2730:5
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'properties' renamed or removed? New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1967:7 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1298:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'filters' renamed or removed? New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L4240:7 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2237:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'properties' renamed or removed? New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L4758:7 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'id' renamed or removed? New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L4758:7 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-11	package-2023-11(723db51)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PathForResourceAction	Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Consumption/stable/2023-11-01/consumption_pricesheet.json#L37
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L155
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L252
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.Consumption/budgets/{budgetName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Consumption/budgets' that has the scope parameter.'. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L267
`❌` ResourceNameRestriction	The resource name parameter 'budgetName' should be defined with a 'pattern' restriction. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L309
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L384
`❌` DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L430
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L469
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L473
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L577
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L616
`❌` ResourceNameRestriction	The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L629
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L658
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1109
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1113
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1181
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1185
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1319
`❌` ParametersInPointGet	Query parameter $skiptoken should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1319
`❌` ParametersInPointGet	Query parameter $top should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1319
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1354
`❌` ResourceNameRestriction	The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1367
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1385
`❌` ParametersInPointGet	Query parameter $skiptoken should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1385
`❌` ParametersInPointGet	Query parameter $top should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1385
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1423
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1456
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1457
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1508
`❌` ResourceNameRestriction	The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1521

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-04T20:57:03Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/consumption/armconsumption - Approved - 2.0.0

+	Field `Etag`, `Tags` of struct `CreditSummary` has been removed
+	Field `MarketplaceCharges` of struct `LegacyChargeSummaryProperties` has been removed
+	Type of `ModernReservationRecommendation.Properties` has been changed from `*ModernReservationRecommendationProperties` to `ModernReservationRecommendationPropertiesClassification`

❌azure-sdk-for-js - @azure/arm-consumption - Approved - 10.0.0

+	Class ConsumptionManagementClient has a new signature
+	Interface BudgetFilter no longer has parameter not
+	Interface LegacyChargeSummary no longer has parameter marketplaceCharges
+	Operation ReservationRecommendationDetails.get has a new signature
+	Parameter scope of interface ModernReservationRecommendation is now required

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 0158236. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Consumption [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0158236. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/consumption/armconsumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ModernReservationRecommendation.Properties` has been changed from `*ModernReservationRecommendationProperties` to `ModernReservationRecommendationPropertiesClassification`
info	[Changelog] - Field `Etag`, `Tags` of struct `CreditSummary` has been removed
info	[Changelog] - Field `MarketplaceCharges` of struct `LegacyChargeSummaryProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `EventTypeCreditExpired` added to enum type `EventType`
info	[Changelog] - New enum type `OperationStatusType` with values `OperationStatusTypeCompleted`, `OperationStatusTypeFailed`, `OperationStatusTypeRunning`
info	[Changelog] - New enum type `OrgType` with values `OrgTypeContributorOrgType`, `OrgTypePrimaryOrgType`
info	[Changelog] - New function `*ModernReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New function `*ModernSharedScopeReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New function `*ModernSingleScopeReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New function `*PriceSheetClient.BeginDownloadByBillingAccountPeriod(context.Context, string, string, *PriceSheetClientBeginDownloadByBillingAccountPeriodOptions) (*runtime.Poller[PriceSheetClientDownloadByBillingAccountPeriodResponse], error)`
info	[Changelog] - New struct `ModernSharedScopeReservationRecommendationProperties`
info	[Changelog] - New struct `ModernSingleScopeReservationRecommendationProperties`
info	[Changelog] - New struct `OperationStatus`
info	[Changelog] - New struct `PricesheetDownloadProperties`
info	[Changelog] - New struct `SavingsPlan`
info	[Changelog] - New field `OverageRefund` in struct `BalanceProperties`
info	[Changelog] - New field `ETag` in struct `CreditSummary`
info	[Changelog] - New field `IsEstimatedBalance` in struct `CreditSummaryProperties`
info	[Changelog] - New field `IsEstimatedBalance` in struct `EventProperties`
info	[Changelog] - New field `AzureMarketplaceCharges` in struct `LegacyChargeSummaryProperties`
info	[Changelog] - New field `IsEstimatedBalance`, `OrgType`, `UsedAmount` in struct `LotProperties`
info	[Changelog] - New field `SubscriptionID` in struct `ModernChargeSummaryProperties`
info	[Changelog] - New field `SavingsPlan` in struct `PriceSheetProperties`
info	[Changelog] - New field `Filter` in struct `ReservationRecommendationDetailsClientGetOptions`
info	[Changelog] - New field `PreviewMarkupPercentage`, `UseMarkupIfPartner` in struct `ReservationTransactionsClientListOptions`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 33 additive change(s).

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from 0158236. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh]  New minor version of npm available! 9.6.7 -> 9.8.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest]   - properties.error.$ref: "#/components/schemas/schemas:468" => "#/components/schemas/schemas:677"
cmdout	[automation_generate.sh] [Autorest]   - title: <none> => "Error response"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/PropertyRedeclarationWarning | Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmdout	[automation_generate.sh] [Autorest]   - properties.error.$ref: "#/components/schemas/schemas:468" => "#/components/schemas/schemas:677"
cmdout	[automation_generate.sh] [Autorest]   - title: <none> => "Error response"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/PropertyRedeclarationWarning | Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 0158236. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-consumption [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0158236. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-consumption-10.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation LotsOperations.listByCustomer
info	[Changelog]   - Added operation PriceSheet.beginDownloadByBillingAccountPeriod
info	[Changelog]   - Added operation PriceSheet.beginDownloadByBillingAccountPeriodAndWait
info	[Changelog]   - Added Interface ErrorAdditionalInfo
info	[Changelog]   - Added Interface ErrorDetail
info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
info	[Changelog]   - Added Interface LotsListByCustomerNextOptionalParams
info	[Changelog]   - Added Interface LotsListByCustomerOptionalParams
info	[Changelog]   - Added Interface ModernReservationRecommendationProperties
info	[Changelog]   - Added Interface ModernSharedScopeReservationRecommendationProperties
info	[Changelog]   - Added Interface ModernSingleScopeReservationRecommendationProperties
info	[Changelog]   - Added Interface OperationStatus
info	[Changelog]   - Added Interface PriceSheetDownloadByBillingAccountPeriodHeaders
info	[Changelog]   - Added Interface PriceSheetDownloadByBillingAccountPeriodOptionalParams
info	[Changelog]   - Added Interface SavingsPlan
info	[Changelog]   - Added Type Alias LotsListByCustomerNextResponse
info	[Changelog]   - Added Type Alias LotsListByCustomerResponse
info	[Changelog]   - Added Type Alias ModernReservationRecommendationPropertiesUnion
info	[Changelog]   - Added Type Alias OperationStatusType
info	[Changelog]   - Added Type Alias OrgType
info	[Changelog]   - Added Type Alias PriceSheetDownloadByBillingAccountPeriodResponse
info	[Changelog]   - Interface Balance has a new optional parameter overageRefund
info	[Changelog]   - Interface CreditSummary has a new optional parameter eTagPropertiesETag
info	[Changelog]   - Interface CreditSummary has a new optional parameter isEstimatedBalance
info	[Changelog]   - Interface EventSummary has a new optional parameter isEstimatedBalance
info	[Changelog]   - Interface LegacyChargeSummary has a new optional parameter azureMarketplaceCharges
info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitId
info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitName
info	[Changelog]   - Interface LotSummary has a new optional parameter isEstimatedBalance
info	[Changelog]   - Interface LotSummary has a new optional parameter orgType
info	[Changelog]   - Interface LotSummary has a new optional parameter usedAmount
info	[Changelog]   - Interface ModernChargeSummary has a new optional parameter subscriptionId
info	[Changelog]   - Interface ModernReservationRecommendation has a new optional parameter resourceType
info	[Changelog]   - Interface PriceSheetProperties has a new optional parameter savingsPlan
info	[Changelog]   - Interface ReservationRecommendationDetailsGetOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface ReservationTransactionsListOptionalParams has a new optional parameter previewMarkupPercentage
info	[Changelog]   - Interface ReservationTransactionsListOptionalParams has a new optional parameter useMarkupIfPartner
info	[Changelog]   - Added Enum KnownOperationStatusType
info	[Changelog]   - Added Enum KnownOrgType
info	[Changelog]   - Enum KnownEventType has a new value CreditExpired
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation ReservationRecommendationDetails.get has a new signature
info	[Changelog]   - Class ConsumptionManagementClient has a new signature
info	[Changelog]   - Interface BudgetFilter no longer has parameter not
info	[Changelog]   - Interface LegacyChargeSummary no longer has parameter marketplaceCharges
info	[Changelog]   - Parameter scope of interface ModernReservationRecommendation is now required

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0158236. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️consumption [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 0158236. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.consumption.DefaultTag [View full logs]

Az.Consumption.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.consumption.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-04T20:57:04Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/consumption/armconsumption	https://apiview.dev/Assemblies/Review/1cb09722812e45399c64cb46fa661994
Java	azure-resourcemanager-consumption	https://apiview.dev/Assemblies/Review/c3ee5a357ac04beeb0f8bc70472d23fd
JavaScript	@azure/arm-consumption	https://apiview.dev/Assemblies/Review/09ba79342ef246a0b1b0f9942815425e

… 2023 11 01 (#25185) * updated documentation * fixed prettier check * fixed name

kazrael2119 · 2023-08-14T08:43:45Z

this js sdk breaking is not caused by this pr

sumitparwal added 3 commits August 2, 2023 15:50

Adds base for updating Microsoft.Consumption from version stable/2023…

928cfbf

…-05-01 to version 2023-11-01

Updates readme

83d93ff

Updates API version in new specs and examples

fefd707

sumitparwal requested a review from kjeur as a code owner August 4, 2023 20:56

openapi-assignment-bot bot assigned rkmanda Aug 4, 2023

azure-sdk mentioned this pull request Aug 4, 2023

[AutoPR sdk/resourcemanager/consumption/armconsumption] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 azure-sdk/azure-sdk-for-go#6693

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Aug 4, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Aug 4, 2023

sumitparwal and others added 3 commits August 8, 2023 16:14

User/sumitparwal/rebase sumitparwal consumption microsoft.consumption…

866ef0d

… 2023 11 01 (#25185) * updated documentation * fixed prettier check * fixed name

fixed based on suggestion from PM team

c6a592f

added period at the end

723db51

ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 11, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Aug 14, 2023

qiaozha added the Approved-SdkBreakingChange-JavaScript label Aug 14, 2023

thramu self-assigned this Aug 14, 2023

thramu self-requested a review August 14, 2023 18:14

rkmanda approved these changes Aug 15, 2023

View reviewed changes

rkmanda merged commit 0158236 into main Aug 15, 2023

rkmanda deleted the sumitparwal-consumption-Microsoft.Consumption-2023-11-01 branch August 15, 2023 03:18

msyyc mentioned this pull request May 7, 2024

Update readme.python.md #28995

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25183

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25183

sumitparwal commented Aug 4, 2023

openapi-workflow-bot bot commented Aug 4, 2023

openapi-pipeline-app bot commented Aug 4, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 4, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 4, 2023 •

edited

Loading

kazrael2119 commented Aug 14, 2023

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25183

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25183

Conversation

sumitparwal commented Aug 4, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Getting help

openapi-workflow-bot bot commented Aug 4, 2023

openapi-pipeline-app bot commented Aug 4, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 4, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 4, 2023 • edited Loading

Generated ApiView

kazrael2119 commented Aug 14, 2023

openapi-pipeline-app bot commented Aug 4, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 4, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 4, 2023 •

edited

Loading