-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Resources to add version stable/2023-08-01 #25270
Merged
sjanamma
merged 18 commits into
main
from
subha-sa-resources-Microsoft.Resources-2023-08-01
Oct 6, 2023
Merged
[Hub Generated] Review request for Microsoft.Resources to add version stable/2023-08-01 #25270
sjanamma
merged 18 commits into
main
from
subha-sa-resources-Microsoft.Resources-2023-08-01
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @subha-sa! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
This was referenced Aug 10, 2023
This was referenced Aug 10, 2023
This was referenced Oct 6, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
… stable/2023-08-01 (#25270) * Adds base for updating Microsoft.Resources from version stable/2020-10-01 to version 2023-08-01 * Updates readme * Updates API version in new specs and examples * adding new subnet Id Property to the ARM template and example file * updated the readme file * added example files * prettier check update * fixed the readme files errors * lint error and model validation error fix * more model valiadtion fixes * updated format of suppression * applying suppressions based on new format * updating integer format * suppressing the integer format check as there is tooling issue * added x-ms-arm-details format to subnet id * added more suppression * added more suppression --------- Co-authored-by: Subha Sambandamurthy <susamban@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-Avocado
Approved-SdkBreakingChange-Go
Approve the breaking change tracking for azure-sdk-for-go
Approved-SdkBreakingChange-JavaScript
Approved-Suppression
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
CI-BreakingChange-Go
CI-BreakingChange-JavaScript
CI-FixRequiredOnFailure
new-api-version
resource-manager
SuppressionReviewRequired
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Getting help
and https://aka.ms/ci-fix.