Signalr 2023-08-01-preview #25378
Merged
Signalr 2023-08-01-preview #25378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=380821&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-js - @azure/arm-webpubsub - Approved - 2.0.0-beta.2+ Interface CustomCertificate no longer has parameter systemData + Interface CustomDomain no longer has parameter systemData + Interface PrivateEndpointConnection no longer has parameter systemData + Interface SharedPrivateLinkResource no longer has parameter systemData + Interface WebPubSubHub no longer has parameter systemData + Interface WebPubSubResource no longer has parameter systemData + Parameter location of interface TrackedResource is now required
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.SignalR [View full logs] [Release SDK Changes]info [Changelog]
️✔️Azure.ResourceManager.WebPubSub [View full logs] [Release SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] notice cmderr [automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-signalr [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation SignalROperations.list_replica_skus info [Changelog] - Added operation group SignalRReplicasOperations info [Changelog] - Model PrivateLinkResource has a new parameter system_data info [Changelog] - Model ProxyResource has a new parameter system_data info [Changelog] - Model Resource has a new parameter system_data info [Changelog] - Model SignalRNetworkACLs has a new parameter ip_rules info [Changelog] - Model SignalRResource has a new parameter region_endpoint_enabled info [Changelog] - Model SignalRResource has a new parameter resource_stopped info [Changelog] - Model TrackedResource has a new parameter system_data info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Parameter location of model SignalRResource is now required info [Changelog] - Parameter location of model TrackedResource is now required
️✔️track2_azure-mgmt-webpubsub [View full logs] [Release SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Model Replica has a new parameter region_endpoint_enabled info [Changelog] - Model Replica has a new parameter resource_stopped info [Changelog] - Model WebPubSubNetworkACLs has a new parameter ip_rules info [Changelog] - Model WebPubSubResource has a new parameter region_endpoint_enabled info [Changelog] - Model WebPubSubResource has a new parameter resource_stopped
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-signalr [View full logs] [Release SDK Changes]️✔️azure-resourcemanager-webpubsub [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-signalr [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group SignalRReplicas info [Changelog] - Added operation SignalR.listReplicaSkus info [Changelog] - Added Interface IPRule info [Changelog] - Added Interface Replica info [Changelog] - Added Interface ReplicaList info [Changelog] - Added Interface SignalRListReplicaSkusOptionalParams info [Changelog] - Added Interface SignalRRegenerateKeyHeaders info [Changelog] - Added Interface SignalRReplicasCreateOrUpdateOptionalParams info [Changelog] - Added Interface SignalRReplicasDeleteOptionalParams info [Changelog] - Added Interface SignalRReplicasGetOptionalParams info [Changelog] - Added Interface SignalRReplicasListNextOptionalParams info [Changelog] - Added Interface SignalRReplicasListOptionalParams info [Changelog] - Added Interface SignalRReplicasRestartHeaders info [Changelog] - Added Interface SignalRReplicasRestartOptionalParams info [Changelog] - Added Interface SignalRReplicasUpdateHeaders info [Changelog] - Added Interface SignalRReplicasUpdateOptionalParams info [Changelog] - Added Interface SignalRRestartHeaders info [Changelog] - Added Interface SignalRUpdateHeaders info [Changelog] - Added Type Alias SignalRListReplicaSkusResponse info [Changelog] - Added Type Alias SignalRReplicasCreateOrUpdateResponse info [Changelog] - Added Type Alias SignalRReplicasGetResponse info [Changelog] - Added Type Alias SignalRReplicasListNextResponse info [Changelog] - Added Type Alias SignalRReplicasListResponse info [Changelog] - Added Type Alias SignalRReplicasRestartResponse info [Changelog] - Added Type Alias SignalRReplicasUpdateResponse info [Changelog] - Added Type Alias SignalRRestartResponse info [Changelog] - Interface Resource has a new optional parameter systemData info [Changelog] - Interface SignalRNetworkACLs has a new optional parameter ipRules info [Changelog] - Interface SignalRResource has a new optional parameter regionEndpointEnabled info [Changelog] - Interface SignalRResource has a new optional parameter resourceStopped info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface CustomCertificate no longer has parameter systemData info [Changelog] - Interface CustomDomain no longer has parameter systemData info [Changelog] - Interface PrivateEndpointConnection no longer has parameter systemData info [Changelog] - Interface SharedPrivateLinkResource no longer has parameter systemData info [Changelog] - Interface SignalRResource no longer has parameter systemData info [Changelog] - Parameter location of interface TrackedResource is now required
️✔️@azure/arm-webpubsub [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group WebPubSubReplicas info [Changelog] - Added operation WebPubSub.listReplicaSkus info [Changelog] - Added Interface IPRule info [Changelog] - Added Interface Replica info [Changelog] - Added Interface ReplicaList info [Changelog] - Added Interface WebPubSubListReplicaSkusOptionalParams info [Changelog] - Added Interface WebPubSubRegenerateKeyHeaders info [Changelog] - Added Interface WebPubSubReplicasCreateOrUpdateOptionalParams info [Changelog] - Added Interface WebPubSubReplicasDeleteOptionalParams info [Changelog] - Added Interface WebPubSubReplicasGetOptionalParams info [Changelog] - Added Interface WebPubSubReplicasListNextOptionalParams info [Changelog] - Added Interface WebPubSubReplicasListOptionalParams info [Changelog] - Added Interface WebPubSubReplicasRestartHeaders info [Changelog] - Added Interface WebPubSubReplicasRestartOptionalParams info [Changelog] - Added Interface WebPubSubReplicasUpdateHeaders info [Changelog] - Added Interface WebPubSubReplicasUpdateOptionalParams info [Changelog] - Added Interface WebPubSubRestartHeaders info [Changelog] - Added Interface WebPubSubUpdateHeaders info [Changelog] - Added Type Alias ServiceKind info [Changelog] - Added Type Alias WebPubSubListReplicaSkusResponse info [Changelog] - Added Type Alias WebPubSubReplicasCreateOrUpdateResponse info [Changelog] - Added Type Alias WebPubSubReplicasGetResponse info [Changelog] - Added Type Alias WebPubSubReplicasListNextResponse info [Changelog] - Added Type Alias WebPubSubReplicasListResponse info [Changelog] - Added Type Alias WebPubSubReplicasRestartResponse info [Changelog] - Added Type Alias WebPubSubReplicasUpdateResponse info [Changelog] - Added Type Alias WebPubSubRestartResponse info [Changelog] - Interface Resource has a new optional parameter systemData info [Changelog] - Interface WebPubSubNetworkACLs has a new optional parameter ipRules info [Changelog] - Interface WebPubSubResource has a new optional parameter kind info [Changelog] - Interface WebPubSubResource has a new optional parameter regionEndpointEnabled info [Changelog] - Interface WebPubSubResource has a new optional parameter resourceStopped info [Changelog] - Added Enum KnownServiceKind info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface CustomCertificate no longer has parameter systemData info [Changelog] - Interface CustomDomain no longer has parameter systemData info [Changelog] - Interface PrivateEndpointConnection no longer has parameter systemData info [Changelog] - Interface SharedPrivateLinkResource no longer has parameter systemData info [Changelog] - Interface WebPubSubHub no longer has parameter systemData info [Changelog] - Interface WebPubSubResource no longer has parameter systemData info [Changelog] - Parameter location of interface TrackedResource is now required
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/signalr/armsignalr [View full logs] [Release SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New function `*Client.ListReplicaSKUs(context.Context, string, string, string, *ClientListReplicaSKUsOptions) (ClientListReplicaSKUsResponse, error)` info [Changelog] - New function `*ClientFactory.NewReplicasClient() *ReplicasClient` info [Changelog] - New function `NewReplicasClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ReplicasClient, error)` info [Changelog] - New function `*ReplicasClient.BeginCreateOrUpdate(context.Context, string, string, string, Replica, *ReplicasClientBeginCreateOrUpdateOptions) (*runtime.Poller[ReplicasClientCreateOrUpdateResponse], error)` info [Changelog] - New function `*ReplicasClient.Delete(context.Context, string, string, string, *ReplicasClientDeleteOptions) (ReplicasClientDeleteResponse, error)` info [Changelog] - New function `*ReplicasClient.Get(context.Context, string, string, string, *ReplicasClientGetOptions) (ReplicasClientGetResponse, error)` info [Changelog] - New function `*ReplicasClient.NewListPager(string, string, *ReplicasClientListOptions) *runtime.Pager[ReplicasClientListResponse]` info [Changelog] - New function `*ReplicasClient.BeginRestart(context.Context, string, string, string, *ReplicasClientBeginRestartOptions) (*runtime.Poller[ReplicasClientRestartResponse], error)` info [Changelog] - New function `*ReplicasClient.BeginUpdate(context.Context, string, string, string, Replica, *ReplicasClientBeginUpdateOptions) (*runtime.Poller[ReplicasClientUpdateResponse], error)` info [Changelog] - New struct `IPRule` info [Changelog] - New struct `Replica` info [Changelog] - New struct `ReplicaList` info [Changelog] - New struct `ReplicaProperties` info [Changelog] - New field `IPRules` in struct `NetworkACLs` info [Changelog] - New field `SystemData` in struct `PrivateLinkResource` info [Changelog] - New field `RegionEndpointEnabled`, `ResourceStopped` in struct `Properties` info [Changelog] - New field `SystemData` in struct `ProxyResource` info [Changelog] - New field `SystemData` in struct `Resource` info [Changelog] - New field `SystemData` in struct `TrackedResource` info [Changelog] info [Changelog] Total 0 breaking change(s), 23 additive change(s).
️✔️sdk/resourcemanager/webpubsub/armwebpubsub [View full logs] [Release SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New struct `IPRule` info [Changelog] - New field `IPRules` in struct `NetworkACLs` info [Changelog] - New field `RegionEndpointEnabled`, `ResourceStopped` in struct `Properties` info [Changelog] - New field `RegionEndpointEnabled`, `ResourceStopped` in struct `ReplicaProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 5 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0> cmderr [initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️signalr [View full logs] [Release Schema Changes]️✔️webpubsub [View full logs] [Release Schema Changes]
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️Az.signalr.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.signalr.DefaultTag error Az.webpubsub.DefaultTag
⚠️Az.webpubsub.DefaultTag
Generated ApiView
|
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
|
Hi @bjqian! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Aug 18, 2023
Closed
Closed
This was referenced Aug 18, 2023
Closed
Closed
[AutoPR Azure.ResourceManager.WebPubSub] Signalr 2023 08 01 preview
azure-sdk/azure-sdk-for-net#4848
Closed
|
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
This was referenced Aug 18, 2023
|
Looks we skipped step 1 and completed step 2. So I added back the label "WaitforArmFeedBack" to put it into the Arm review queue. Then the bot removes the "ArmSignOff" 😂 . We need to wait again.. |
sjanamma
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
rkmanda
added
Approved-BreakingChange
JeffreyRichter
added
the
Approved-BreakingChange
raych1
added
the
Approved-SdkBreakingChange-Go
|
/prRequestMerge |
|
/pr RequestMerge |
rkmanda
approved these changes
Sep 12, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Sep 12, 2023
Closed
This was referenced Sep 12, 2023
Closed
Closed
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* init 2023-08-01-preview * update to 2023-08-01-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Getting help
and https://aka.ms/ci-fix.