Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add osRollingUpgradeDeferral property and ApproveRollingUpgrade call #25543

Merged
merged 5 commits into from
Nov 16, 2023

remove 200 response from example

933c21d
Select commit
Loading
Failed to load commit list.
Merged

Add osRollingUpgradeDeferral property and ApproveRollingUpgrade call #25543

remove 200 response from example
933c21d
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff completed Oct 24, 2023 in 4m 20s

Swagger LintDiff failed

LintDiff: 196 Errors, 122 Warnings
The check status is neutral due to the check was suppressed by label Approved-LintDiff. If you have any question, pls contact vscswagger@microsoft.com
View more details.

Details

compared tags (via openapi-validator v2.1.6) new version base version
package-2023-09-01 package-2023-09-01(933c21d) package-2023-09-01(feature/cplat-2023-09-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1811
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L2761
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1768
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L2720
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L3740


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L138
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L266
❌ LroPatch202 The async patch operation should return 202.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L303
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L313
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L327
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L366
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L375
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L392
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L459
❌ ParametersInPost hibernate is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L465
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L507
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L513
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L529
❌ ParametersInPost forceDeletion is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L535
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L577
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L583
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L630
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L761
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L775
❌ LroPatch202 The async patch operation should return 202.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L819
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L835
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L849
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L888
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L897
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L917
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1188
❌ ParametersInPost skipShutdown is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1194
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1237
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1243
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1259
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1300
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1306
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1322
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1363
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1369
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1385
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1428
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1447
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1488
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1494
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1510
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1551
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1557
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1573
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1614
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1620
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1636
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1677
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1683
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1699
View more details on openapi-pipeline-app