Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brrusino chaos microsoft.chaos 2023 09 01 preview #25708

Merged
merged 12 commits into from
Sep 27, 2023

Conversation

brrusino
Copy link
Contributor

@brrusino brrusino commented Sep 7, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 7, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 7, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 10 Warnings warning [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
capabilities.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
capabilityTypes.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
experiments.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
operations.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
targetTypes.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
targets.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
capabilities.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
capabilityTypes.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
common.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
experiments.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
targetTypes.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)
targets.json 2023-09-01-preview(1574be2) 2023-04-15-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Chaos/preview/2023-09-01-preview/experiments.json#L152:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '201'.
New: Microsoft.Chaos/preview/2023-09-01-preview/experiments.json#L242:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Chaos/preview/2023-09-01-preview/experiments.json#L295:11
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'startOnCreation' renamed or removed?
New: preview/2023-09-01-preview/types/experiments.json#L93:7
Old: preview/2023-04-15-preview/types/experiments.json#L88:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'startOnCreation' renamed or removed?
New: preview/2023-09-01-preview/types/experiments.json#L93:7
Old: preview/2023-04-15-preview/types/experiments.json#L88:7
⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Chaos/preview/2023-09-01-preview/experiments.json#L131:7
Old: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L131:7
⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Chaos/preview/2023-09-01-preview/experiments.json#L212:7
Old: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L211:7
⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Chaos/preview/2023-09-01-preview/experiments.json#L265:7
Old: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L260:7
⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Chaos/preview/2023-09-01-preview/experiments.json#L320:7
Old: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L311:7
⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Chaos/preview/2023-09-01-preview/experiments.json#L363:7
Old: Microsoft.Chaos/preview/2023-04-15-preview/experiments.json#L353:7
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.5) new version base version
package-preview-2023-09 package-preview-2023-09(1574be2) default(main)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 7, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/chaos/armchaos - Approved - 0.8.0
+	Field `StartOnCreation` of struct `ExperimentProperties` has been removed
+	Function `*Action.GetAction` has been removed
+	Function `*ContinuousAction.GetAction` has been removed
+	Function `*DelayAction.GetAction` has been removed
+	Function `*DiscreteAction.GetAction` has been removed
+	Function `*Filter.GetFilter` has been removed
+	Function `*ListSelector.GetSelector` has been removed
+	Function `*QuerySelector.GetSelector` has been removed
+	Function `*Selector.GetSelector` has been removed
+	Function `*SimpleFilter.GetFilter` has been removed
+	Operation `*ExperimentsClient.Cancel` has been changed to LRO, use `*ExperimentsClient.BeginCancel` instead.
+	Operation `*ExperimentsClient.CreateOrUpdate` has been changed to LRO, use `*ExperimentsClient.BeginCreateOrUpdate` instead.
+	Operation `*ExperimentsClient.Delete` has been changed to LRO, use `*ExperimentsClient.BeginDelete` instead.
+	Operation `*ExperimentsClient.Start` has been changed to LRO, use `*ExperimentsClient.BeginStart` instead.
+	Operation `*ExperimentsClient.Update` has been changed to LRO, use `*ExperimentsClient.BeginUpdate` instead.
+	Struct `Branch` has been removed
+	Struct `ExperimentCancelOperationResult` has been removed
+	Struct `ExperimentStartOperationResult` has been removed
+	Struct `ListSelector` has been removed
+	Struct `QuerySelector` has been removed
+	Struct `SimpleFilterParameters` has been removed
+	Struct `SimpleFilter` has been removed
+	Struct `Step` has been removed
+	Type of `ExperimentProperties.Selectors` has been changed from `[]SelectorClassification` to `[]TargetSelectorClassification`
+	Type of `ExperimentProperties.Steps` has been changed from `[]*Step` to `[]*ExperimentStep`
azure-sdk-for-python-track2 - track2_azure-mgmt-chaos - Approved - 1.0.0b7
+	Model Experiment no longer has parameter start_on_creation
+	Renamed operation ExperimentsOperations.cancel to ExperimentsOperations.begin_cancel
+	Renamed operation ExperimentsOperations.create_or_update to ExperimentsOperations.begin_create_or_update
+	Renamed operation ExperimentsOperations.delete to ExperimentsOperations.begin_delete
+	Renamed operation ExperimentsOperations.start to ExperimentsOperations.begin_start
+	Renamed operation ExperimentsOperations.update to ExperimentsOperations.begin_update
azure-sdk-for-js - @azure/arm-chaos - Approved - 1.0.0-beta.5
+	Interface Experiment no longer has parameter startOnCreation
+	Removed operation Experiments.cancel
+	Removed operation Experiments.createOrUpdate
+	Removed operation Experiments.delete
+	Removed operation Experiments.start
+	Removed operation Experiments.update
+	Type of parameter selectors of interface Experiment is changed from SelectorUnion[] to ChaosTargetSelectorUnion[]
+	Type of parameter steps of interface Experiment is changed from Step[] to ChaosExperimentStep[]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 658830c. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-chaos [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation group OperationStatusesOperations
    info	[Changelog]   - Model Experiment has a new parameter provisioning_state
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model Experiment no longer has parameter start_on_creation
    info	[Changelog]   - Renamed operation ExperimentsOperations.cancel to ExperimentsOperations.begin_cancel
    info	[Changelog]   - Renamed operation ExperimentsOperations.create_or_update to ExperimentsOperations.begin_create_or_update
    info	[Changelog]   - Renamed operation ExperimentsOperations.delete to ExperimentsOperations.begin_delete
    info	[Changelog]   - Renamed operation ExperimentsOperations.start to ExperimentsOperations.begin_start
    info	[Changelog]   - Renamed operation ExperimentsOperations.update to ExperimentsOperations.begin_update
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 658830c. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-chaos [View full logs]  [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 658830c. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/chaos/armchaos [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `ExperimentProperties.Selectors` has been changed from `[]SelectorClassification` to `[]TargetSelectorClassification`
    info	[Changelog] - Type of `ExperimentProperties.Steps` has been changed from `[]*Step` to `[]*ExperimentStep`
    info	[Changelog] - Function `*Action.GetAction` has been removed
    info	[Changelog] - Function `*ContinuousAction.GetAction` has been removed
    info	[Changelog] - Function `*DelayAction.GetAction` has been removed
    info	[Changelog] - Function `*DiscreteAction.GetAction` has been removed
    info	[Changelog] - Function `*Filter.GetFilter` has been removed
    info	[Changelog] - Function `*ListSelector.GetSelector` has been removed
    info	[Changelog] - Function `*QuerySelector.GetSelector` has been removed
    info	[Changelog] - Function `*Selector.GetSelector` has been removed
    info	[Changelog] - Function `*SimpleFilter.GetFilter` has been removed
    info	[Changelog] - Operation `*ExperimentsClient.Cancel` has been changed to LRO, use `*ExperimentsClient.BeginCancel` instead.
    info	[Changelog] - Operation `*ExperimentsClient.CreateOrUpdate` has been changed to LRO, use `*ExperimentsClient.BeginCreateOrUpdate` instead.
    info	[Changelog] - Operation `*ExperimentsClient.Delete` has been changed to LRO, use `*ExperimentsClient.BeginDelete` instead.
    info	[Changelog] - Operation `*ExperimentsClient.Start` has been changed to LRO, use `*ExperimentsClient.BeginStart` instead.
    info	[Changelog] - Operation `*ExperimentsClient.Update` has been changed to LRO, use `*ExperimentsClient.BeginUpdate` instead.
    info	[Changelog] - Struct `Branch` has been removed
    info	[Changelog] - Struct `ExperimentCancelOperationResult` has been removed
    info	[Changelog] - Struct `ExperimentStartOperationResult` has been removed
    info	[Changelog] - Struct `ListSelector` has been removed
    info	[Changelog] - Struct `QuerySelector` has been removed
    info	[Changelog] - Struct `SimpleFilter` has been removed
    info	[Changelog] - Struct `SimpleFilterParameters` has been removed
    info	[Changelog] - Struct `Step` has been removed
    info	[Changelog] - Field `StartOnCreation` of struct `ExperimentProperties` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`, `ProvisioningStateUpdating`
    info	[Changelog] - New function `*ClientFactory.NewOperationStatusesClient() *OperationStatusesClient`
    info	[Changelog] - New function `*ContinuousAction.GetExperimentAction() *ExperimentAction`
    info	[Changelog] - New function `*DelayAction.GetExperimentAction() *ExperimentAction`
    info	[Changelog] - New function `*DiscreteAction.GetExperimentAction() *ExperimentAction`
    info	[Changelog] - New function `*ExperimentAction.GetExperimentAction() *ExperimentAction`
    info	[Changelog] - New function `NewOperationStatusesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OperationStatusesClient, error)`
    info	[Changelog] - New function `*OperationStatusesClient.Get(context.Context, string, string, *OperationStatusesClientGetOptions) (OperationStatusesClientGetResponse, error)`
    info	[Changelog] - New function `*TargetFilter.GetTargetFilter() *TargetFilter`
    info	[Changelog] - New function `*TargetListSelector.GetTargetSelector() *TargetSelector`
    info	[Changelog] - New function `*TargetQuerySelector.GetTargetSelector() *TargetSelector`
    info	[Changelog] - New function `*TargetSelector.GetTargetSelector() *TargetSelector`
    info	[Changelog] - New function `*TargetSimpleFilter.GetTargetFilter() *TargetFilter`
    info	[Changelog] - New struct `ExperimentBranch`
    info	[Changelog] - New struct `ExperimentStep`
    info	[Changelog] - New struct `OperationStatus`
    info	[Changelog] - New struct `TargetListSelector`
    info	[Changelog] - New struct `TargetQuerySelector`
    info	[Changelog] - New struct `TargetSimpleFilter`
    info	[Changelog] - New struct `TargetSimpleFilterParameters`
    info	[Changelog] - New field `ProvisioningState` in struct `Experiment`
    info	[Changelog]
    info	[Changelog] Total 35 breaking change(s), 37 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 658830c. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-chaos [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group OperationStatuses
    info	[Changelog]   - Added operation Experiments.beginCancel
    info	[Changelog]   - Added operation Experiments.beginCancelAndWait
    info	[Changelog]   - Added operation Experiments.beginCreateOrUpdate
    info	[Changelog]   - Added operation Experiments.beginCreateOrUpdateAndWait
    info	[Changelog]   - Added operation Experiments.beginDelete
    info	[Changelog]   - Added operation Experiments.beginDeleteAndWait
    info	[Changelog]   - Added operation Experiments.beginStart
    info	[Changelog]   - Added operation Experiments.beginStartAndWait
    info	[Changelog]   - Added operation Experiments.beginUpdate
    info	[Changelog]   - Added operation Experiments.beginUpdateAndWait
    info	[Changelog]   - Added Interface ChaosExperimentAction
    info	[Changelog]   - Added Interface ChaosExperimentBranch
    info	[Changelog]   - Added Interface ChaosExperimentStep
    info	[Changelog]   - Added Interface ChaosTargetFilter
    info	[Changelog]   - Added Interface ChaosTargetListSelector
    info	[Changelog]   - Added Interface ChaosTargetQuerySelector
    info	[Changelog]   - Added Interface ChaosTargetSelector
    info	[Changelog]   - Added Interface ChaosTargetSimpleFilter
    info	[Changelog]   - Added Interface ChaosTargetSimpleFilterParameters
    info	[Changelog]   - Added Interface OperationStatus
    info	[Changelog]   - Added Interface OperationStatusesGetOptionalParams
    info	[Changelog]   - Added Type Alias ChaosExperimentActionUnion
    info	[Changelog]   - Added Type Alias ChaosTargetFilterUnion
    info	[Changelog]   - Added Type Alias ChaosTargetSelectorUnion
    info	[Changelog]   - Added Type Alias OperationStatusesGetResponse
    info	[Changelog]   - Added Type Alias ProvisioningState
    info	[Changelog]   - Interface Experiment has a new optional parameter provisioningState
    info	[Changelog]   - Interface ExperimentsCancelOptionalParams has a new optional parameter resumeFrom
    info	[Changelog]   - Interface ExperimentsCancelOptionalParams has a new optional parameter updateIntervalInMs
    info	[Changelog]   - Interface ExperimentsCreateOrUpdateOptionalParams has a new optional parameter resumeFrom
    info	[Changelog]   - Interface ExperimentsCreateOrUpdateOptionalParams has a new optional parameter updateIntervalInMs
    info	[Changelog]   - Interface ExperimentsDeleteOptionalParams has a new optional parameter resumeFrom
    info	[Changelog]   - Interface ExperimentsDeleteOptionalParams has a new optional parameter updateIntervalInMs
    info	[Changelog]   - Interface ExperimentsStartOptionalParams has a new optional parameter resumeFrom
    info	[Changelog]   - Interface ExperimentsStartOptionalParams has a new optional parameter updateIntervalInMs
    info	[Changelog]   - Interface ExperimentsUpdateOptionalParams has a new optional parameter resumeFrom
    info	[Changelog]   - Interface ExperimentsUpdateOptionalParams has a new optional parameter updateIntervalInMs
    info	[Changelog]   - Added Enum KnownProvisioningState
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Removed operation Experiments.cancel
    info	[Changelog]   - Removed operation Experiments.createOrUpdate
    info	[Changelog]   - Removed operation Experiments.delete
    info	[Changelog]   - Removed operation Experiments.start
    info	[Changelog]   - Removed operation Experiments.update
    info	[Changelog]   - Interface Experiment no longer has parameter startOnCreation
    info	[Changelog]   - Type of parameter selectors of interface Experiment is changed from SelectorUnion[] to ChaosTargetSelectorUnion[]
    info	[Changelog]   - Type of parameter steps of interface Experiment is changed from Step[] to ChaosExperimentStep[]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 658830c. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 658830c. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.chaos.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.chaos.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 7, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/chaos/armchaos https://apiview.dev/Assemblies/Review/db5220d390524bd48f15c1537b150761
Java azure-resourcemanager-chaos https://apiview.dev/Assemblies/Review/bcbd221e9c9b4e06a3e9ee2059328e46
JavaScript @azure/arm-chaos https://apiview.dev/Assemblies/Review/175497feae284b6fa0d44a9a9d333e97

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 7, 2023
@openapi-workflow-bot
Copy link

Hi @brrusino! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

@brrusino
Copy link
Contributor Author

brrusino commented Sep 7, 2023

This branch was created using the automated OpenApiHub process, and the first 3 commits were generated during that process. If this is triggering a CI-MissingBaseCommit error case, Is this check potentially out-of-sync with the OpenApiHub automated process?

https://openapihub.azure-devex-tools.com/branch/Azure/azure-rest-api-specs/brrusino-chaos-Microsoft.Chaos-2023-09-01-preview...main/

@visingla-ms visingla-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 19, 2023
@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2023
@brrusino brrusino removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 22, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2023
@visingla-ms visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 22, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2023
@Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 25, 2023
@brrusino
Copy link
Contributor Author

@rkmanda I see that we have ARM sign-off as well as approval for Python, Go, and Javascript breaking changes. Is anything else required to complete this PR?

@brrusino
Copy link
Contributor Author

/pr RequestMerge

@raosuhas raosuhas merged commit 658830c into main Sep 27, 2023
29 of 30 checks passed
@raosuhas raosuhas deleted the brrusino-chaos-Microsoft.Chaos-2023-09-01-preview branch September 27, 2023 16:01
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants