[BugFix] Add "ExtendedLocation" property in IaasVMRestorePoint #25713

viananth · 2023-09-07T21:20:35Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- The API already returns "ExtendedLocation" property in Get-RecoveryPoint. But the swagger spec does not include "ExtendedLocation" property in "RecoveryPoint". This PR fixes that issue by adding "ExtendedLocation" property in RecoveryPoint.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-09-07T21:20:38Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-09-07T21:20:39Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
bms.json	2023-04-01(9ab65c9)	2023-04-01(main)

Rule	Message
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'extendedLocation' that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L7368:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L7368:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.5)	new version	base version
package-2023-04	package-2023-04(9ab65c9)	package-2023-04(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ImplementPrivateEndpointAPIs	The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateLinkResources is missing. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L20
`❌` ImplementPrivateEndpointAPIs	The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L20
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L21
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L22
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L65
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L117
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L164
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L194
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L209
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L239
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L254
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L284
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L299
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName,fabricName,intentObjectName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L300
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L337
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName,fabricName,intentObjectName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L351
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L397
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName,fabricName,intentObjectName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L411
`❌` DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L448
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L448
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L460
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L461
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L498
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L517
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L518
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L555
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L589
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L609
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L652
`❌` ParametersOrder	The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L704

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-07T21:20:40Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 68c5002. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.RecoveryServicesBackup [View full logs] [Release SDK Changes] Breaking Change Detected
- Azure.ResourceManager.RecoveryServicesBackup.1.2.0-alpha.20230925.1.nupkg
```
info	[Changelog] Breaking Changes:
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 68c5002. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-recoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model BackupStatusResponse has a new parameter acquire_storage_account_lock
info	[Changelog]   - Model BackupStatusResponse has a new parameter protected_items_count
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Renamed operation ProtectionContainersOperations.register to ProtectionContainersOperations.begin_register

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 68c5002. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-recoveryservicesbackup [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 68c5002. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*ProtectionContainersClient.Register` has been changed to LRO, use `*ProtectionContainersClient.BeginRegister` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `ExtendedLocation` in struct `IaasVMRecoveryPoint`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 1 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 68c5002. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-recoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-recoveryservicesbackup-12.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ProtectionContainers.beginRegister
info	[Changelog]   - Added operation ProtectionContainers.beginRegisterAndWait
info	[Changelog]   - Interface BackupStatusResponse has a new optional parameter acquireStorageAccountLock
info	[Changelog]   - Interface BackupStatusResponse has a new optional parameter protectedItemsCount
info	[Changelog]   - Interface IaasVMRecoveryPoint has a new optional parameter extendedLocation
info	[Changelog]   - Interface ProtectionContainersRegisterOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface ProtectionContainersRegisterOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation ProtectionContainers.register

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 68c5002. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️recoveryservicesbackup [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 68c5002. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.recoveryservicesbackup.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.recoveryservicesbackup.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-07T21:20:41Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup	https://apiview.dev/Assemblies/Review/09e6918ee949439e8ca6152879474c1e
JavaScript	@azure/arm-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/4cf8d2cc27ff4d5986312aeb6f375f46
.Net	Azure.ResourceManager.RecoveryServicesBackup	https://apiview.dev/Assemblies/Review/9c4d97fe89a348d19aa40c74283c184d
Java	azure-resourcemanager-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/f0bb85293de94e2f81efbad03a58fe27

openapi-workflow-bot · 2023-09-07T21:27:22Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

ajaygit158 · 2023-09-08T06:51:22Z

Hi

Since the PR Automated Merge Requirements are blocked by Swagger Breaking Change, you would need to reach out to the Azure Breaking Changes Reviewers azbreakchangereview@microsoft.com.

viananth · 2023-09-14T06:05:09Z

@ajaygit158 Breaking change has been approved, can we merge this if it looks good?

dhruvesh · 2023-09-22T13:07:58Z

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-04-01/bms.json

@@ -7448,6 +7448,10 @@
        "isPrivateAccessEnabledOnAnyDisk": {
          "description": "This flag denotes if any of the disks in the VM are using Private access network setting",
          "type": "boolean"
+        },


can we also make relevant changes to example

visingla-ms · 2023-09-22T16:46:25Z

Please update the examples also, for users using these API and referring to Docs.

hiaga · 2023-09-24T09:45:38Z

@visingla-ms / @rkmanda : can you please review this PR now

hiaga · 2023-09-25T05:15:39Z

/pr RequestMerge

openapi-pipeline-app · 2023-09-25T12:52:26Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

* Add "ExtendedLocation" property in IaasVMRestorePoint * Add Extendedlocation sample in get rp

Add "ExtendedLocation" property in IaasVMRestorePoint

819ee88

openapi-assignment-bot bot assigned rkmanda Sep 7, 2023

azure-sdk mentioned this pull request Sep 7, 2023

[AutoPR sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup] [BugFix] Add "ExtendedLocation" property in IaasVMRestorePoint azure-sdk/azure-sdk-for-go#7228

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Sep 7, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Sep 7, 2023

openapi-workflow-bot bot added the FixS360 label Sep 8, 2023

hiaga added the AzCoreIDC label Sep 8, 2023

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 13, 2023

hiaga removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 22, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2023

dhruvesh reviewed Sep 22, 2023

View reviewed changes

visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 22, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2023

Add Extendedlocation sample in get rp

9ab65c9

msyyc added the Approved-SdkBreakingChange-Python label Sep 25, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 25, 2023

github-actions bot added the MergeRequested label Sep 25, 2023

visingla-ms approved these changes Sep 25, 2023

View reviewed changes

visingla-ms merged commit 68c5002 into Azure:main Sep 25, 2023
29 of 30 checks passed

This was referenced Sep 25, 2023

[ReleasePR sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup] Update readme.python.md Azure/azure-sdk-for-go#19248

Closed

[ReleasePR @azure/arm-recoveryservicesbackup] Update readme.python.md Azure/azure-sdk-for-js#21784

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Sep 25, 2023

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023

[BugFix] Add "ExtendedLocation" property in IaasVMRestorePoint (#25713)

37abc55

* Add "ExtendedLocation" property in IaasVMRestorePoint * Add Extendedlocation sample in get rp

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Add "ExtendedLocation" property in IaasVMRestorePoint #25713

[BugFix] Add "ExtendedLocation" property in IaasVMRestorePoint #25713

viananth commented Sep 7, 2023 •

edited by hiaga

Loading

openapi-pipeline-app bot commented Sep 7, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 7, 2023 •

edited

Loading

openapi-workflow-bot bot commented Sep 7, 2023

ajaygit158 commented Sep 8, 2023

viananth commented Sep 14, 2023

dhruvesh Sep 22, 2023

visingla-ms commented Sep 22, 2023

hiaga commented Sep 24, 2023

hiaga commented Sep 25, 2023

openapi-pipeline-app bot commented Sep 25, 2023

[BugFix] Add "ExtendedLocation" property in IaasVMRestorePoint #25713

[BugFix] Add "ExtendedLocation" property in IaasVMRestorePoint #25713

Conversation

viananth commented Sep 7, 2023 • edited by hiaga Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Sep 7, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Sep 7, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 7, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 7, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Sep 7, 2023

ajaygit158 commented Sep 8, 2023

viananth commented Sep 14, 2023

dhruvesh Sep 22, 2023

Choose a reason for hiding this comment

visingla-ms commented Sep 22, 2023

hiaga commented Sep 24, 2023

hiaga commented Sep 25, 2023

openapi-pipeline-app bot commented Sep 25, 2023

viananth commented Sep 7, 2023 •

edited by hiaga

Loading

openapi-pipeline-app bot commented Sep 7, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2023 •

edited

Loading