Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] Update Google AdWords linked service #25789

Merged
merged 4 commits into from
Oct 27, 2023
Merged

[DataFactory] Update Google AdWords linked service #25789

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f34cb21
update Google AdWords linked service
Yao725 Sep 14, 2023
753556e
Merge remote-tracking branch 'upstream/main' into yaokou/updateGoogle…
Yao725 Oct 13, 2023
91c612b
update the description for supportLegacyDataTypes
Yao725 Oct 13, 2023
68b631b
add one more missed property
Yao725 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...y/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7045,10 +7045,6 @@
"description": "Google AdWords service linked service properties.",
"type": "object",
"properties": {
"connectionProperties": {
"description": "Properties used to connect to GoogleAds. It is mutually exclusive with any other properties in the linked service. Type: object.",
"type": "object"
},
"clientCustomerID": {
"description": "The Client customer ID of the AdWords account that you want to fetch report data for. Type: string (or Expression with resultType string).",
"x-ms-format": "dfe-string",
Expand Down Expand Up @@ -7088,18 +7084,22 @@
"x-ms-format": "dfe-string",
"type": "object"
},
"keyFilePath": {
"description": "The full path to the .p12 key file that is used to authenticate the service account email address and can only be used on self-hosted IR. Type: string (or Expression with resultType string).",
"privateKey": {
"description": "The private key that is used to authenticate the service account email address and can only be used on self-hosted IR.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ARMBlockingComment] If this entity is being used as a response of a get operation, you should not be returning sensitive information. Such information must be returned as a post action

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this entity will not be returned in the response. The backend will handle the encryption/decryption for this sensitive information to make sure the credentials are safe. One sample response is shown below.

{
    "name": "GoogleAds_ServiceAuth",
    "type": "Microsoft.DataFactory/factories/linkedservices",
    "properties": {
        "annotations": [],
        "type": "GoogleAdWords",
        "typeProperties": {
            "clientCustomerID": "123",
            "loginCustomerID": "123",
            "authenticationType": "ServiceAuthentication",
            "email": "123@456.com",
            "supportLegacyDataTypes": false,
            "googleAdsApiVersion": "v14",
            "encryptedCredential": "xxx"
        }
    }
}

"$ref": "../datafactory.json#/definitions/SecretBase"
},
"loginCustomerID": {
"description": "The customer ID of the Google Ads Manager account through which you want to fetch report data of specific Customer. Type: string (or Expression with resultType string).",
"x-ms-format": "dfe-string",
"type": "object"
},
"trustedCertPath": {
"description": "The full path of the .pem file containing trusted CA certificates for verifying the server when connecting over SSL. This property can only be set when using SSL on self-hosted IR. The default value is the cacerts.pem file installed with the IR. Type: string (or Expression with resultType string).",
"googleAdsApiVersion": {
"description": "The Google Ads API major version such as v14. The supported major versions could be found on https://developers.google.com/google-ads/api/docs/sunset-dates#timetable. Type: string (or Expression with resultType string).",
"x-ms-format": "dfe-string",
"type": "object"
},
"useSystemTrustStore": {
"description": "Specifies whether to use a CA certificate from the system trust store or from a specified PEM file. The default value is false. Type: boolean (or Expression with resultType boolean).",
"supportLegacyDataTypes": {
"description": "Specifies whether to use the legacy data type mappings, which maps float, int32 and int64 from Google to string. Do not set this to true unless you want to keep backward compatibility with legacy driver's data type mappings. Type: boolean (or Expression with resultType boolean).",
"x-ms-format": "dfe-bool",
"type": "object"
},
Expand Down