-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New api version for redis 2018-03-01 #2581
Conversation
…seline for new API version.
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
2f96a49
to
8c574ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @TimLovellSmith !
Changes in the swagger itself look good. However there are some example validation errors
d419ec6
to
3c9f27c
Compare
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
3c9f27c
to
7942ad2
Compare
hey @TimLovellSmith Out of interest does this API version include fixes for #1347 and #1499? Thanks! |
@tombuildsstuff RE #1347 yes, it is intended it will (api spec is done here, but server fixes are not yet rolled out). RE #1499 no, although I believe that is purely a server bug and won't require a new api version. If #1499 is still happening for you could you get me some more details in that bug's thread? I've had trouble tracking down what is going on there. |
@TimLovellSmith There are still issues. Probably an invalid JSON. |
…ed on DELETE, minimumTlsVersion)
7942ad2
to
f4e7a2a
Compare
@AutorestCI rebuild azure-sdk-for-go |
1 similar comment
@AutorestCI rebuild azure-sdk-for-go |
@mcardosos This PR is now ready to be accepted! |
Great! |
@mcardosos |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
@AutorestCI rebuild azure-sdk-for-go |
@AutorestCI rebuild azure-sdk-for-go |
@AutorestCI rebuild azure-libraries-for-java |
Fixes #1347. Redis RP now supports long-running delete operation with this api version.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger