Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New api version for redis 2018-03-01 #2581

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

TimLovellSmith
Copy link
Member

@TimLovellSmith TimLovellSmith commented Mar 2, 2018

Fixes #1347. Redis RP now supports long-running delete operation with this api version.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 2, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1312

@AutorestCI
Copy link

AutorestCI commented Mar 2, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2091

Copy link
Contributor

@mcardosos mcardosos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @TimLovellSmith !
Changes in the swagger itself look good. However there are some example validation errors

@TimLovellSmith TimLovellSmith force-pushed the redis-2018-03-01 branch 2 times, most recently from d419ec6 to 3c9f27c Compare March 6, 2018 23:35
@AutorestCI
Copy link

AutorestCI commented Mar 6, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@tombuildsstuff
Copy link
Contributor

hey @TimLovellSmith

Out of interest does this API version include fixes for #1347 and #1499?

Thanks!

@TimLovellSmith
Copy link
Member Author

TimLovellSmith commented Mar 7, 2018

@tombuildsstuff RE #1347 yes, it is intended it will (api spec is done here, but server fixes are not yet rolled out). RE #1499 no, although I believe that is purely a server bug and won't require a new api version.

If #1499 is still happening for you could you get me some more details in that bug's thread? I've had trouble tracking down what is going on there.

@mcardosos
Copy link
Contributor

@TimLovellSmith There are still issues. Probably an invalid JSON.
On the other hand, we had some recent issues with CI, I would recommend to rebase the branch.

@jhendrixMSFT
Copy link
Member

@AutorestCI rebuild azure-sdk-for-go

1 similar comment
@jhendrixMSFT
Copy link
Member

@AutorestCI rebuild azure-sdk-for-go

@TimLovellSmith
Copy link
Member Author

TimLovellSmith commented Mar 16, 2018

@mcardosos This PR is now ready to be accepted!
/cc @jhendrixMSFT @tombuildsstuff

@mcardosos
Copy link
Contributor

Great!
@TimLovellSmith question, is this already deployed?

@TimLovellSmith
Copy link
Member Author

TimLovellSmith commented Mar 16, 2018

@mcardosos
Yes, you can now call the new api-version in public Azure
/cc @tombuildsstuff

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
Azure/azure-libraries-for-java#338

@jhendrixMSFT
Copy link
Member

@AutorestCI rebuild azure-sdk-for-go

@lmazuel
Copy link
Member

lmazuel commented Mar 16, 2018

@AutorestCI rebuild azure-sdk-for-go

@lmazuel
Copy link
Member

lmazuel commented Mar 20, 2018

@AutorestCI rebuild azure-libraries-for-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Redis] Internal Network API Bug
6 participants