-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Recoveryservicesbackup] Add LRO to ProtectionContainers PUT #25829
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
bms.json | 2023-04-01(118cef6) | 2023-04-01(main) |
Rule | Message |
---|---|
1044 - XmsLongRunningOperationChanged |
The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L3079:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L3079:7 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-2023-04 | package-2023-04(118cef6) | package-2023-04(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ImplementPrivateEndpointAPIs |
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateLinkResources is missing. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L20 |
ImplementPrivateEndpointAPIs |
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L20 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L21 |
ParametersOrder |
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L22 |
ParametersOrder |
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L65 |
ParametersOrder |
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L117 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L164 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L194 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L209 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L239 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L254 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L284 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L299 |
ParametersOrder |
The parameters:vaultName,resourceGroupName,fabricName,intentObjectName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L300 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L337 |
ParametersOrder |
The parameters:vaultName,resourceGroupName,fabricName,intentObjectName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L351 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L397 |
ParametersOrder |
The parameters:vaultName,resourceGroupName,fabricName,intentObjectName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L411 |
DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L448 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L448 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L460 |
ParametersOrder |
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L461 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L498 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L517 |
ParametersOrder |
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L518 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L555 |
RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L589 |
ParametersOrder |
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L609 |
ParametersOrder |
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L652 |
ParametersOrder |
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L704 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
@ishanjindalms @ankur741999 @ramat-msft Could someone from recovery service team to follow up with this PR? Thanks. |
this is a minor correctness fix for LRO for registering a backup container. looks good to me. |
/pr RequestMerge |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
ARM (Control Plane) API Specification Update Pull Request
This PR is a fix for Azure/azure-sdk-for-net#37904
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.