Adding New ExpressRoute Gateway SKU: ErGwScale #25969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneeshakella-microsoft
requested a review
from Joanna-Yang-Art
as a code owner
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| virtualNetworkGateway.json | 2023-06-01(9509e5c) | 2023-05-01(main) |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.1.5) | new version | base version |
|---|---|---|
| package-2023-06 | package-2023-06(9509e5c) | package-2023-06(release-network-Microsoft.Network-official-2023-06-01) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
aneeshakella-microsoft
changed the title
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
This was referenced Sep 26, 2023
|
The failure of the azure-powershell pipeline is a known issue of the CI framework. Please go ahead. |
raosuhas
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/pr RequestMerge |
sjanamma
merged commit 9500651
into
Azure:release-network-Microsoft.Network-official-2023-06-01
25 of 27 checks passed
zizw123
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Add missing DeleteBastionShareableLinkByToken API back to swagger (#25599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format * Adding Developer Sku (#25887) * Firewall Policy - IDPS profiles (#25666) * add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description * hostnames for l4 listeners (#25982) * added ergwscale support (#25969) * Fixed examples for gateway load balancer (#26058) * Add support for JSChallenge action in Application Gateway Web application Firewall (#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json * DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (#26248) * fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <manaschakka@microsoft.com> * [NVA] Internet Ingress Parameters (#26262) * [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix * Added description for each of the enums for ApplicationGatewayProtocol (#26437) * Added description for each of the enums for ApplicationGatewayProtocol * Spacing for prettier checks * Remove routingConfigNfv (#25962) * remove routingConfigNfv * remove api from older versions * remove PUT nvaconnection from older versions * apply prettier check * add suppression for modelValidation * remove suppression due to approval * Fix lint errors & add supressions (#26494) * fix lint error * add supression for ResourceNameRestriction & LroErrorContent * fix example accordingly --------- Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com> Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com> Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com> Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: Manas Chakka <mchakka@gmail.com> Co-authored-by: Manas Chakka <manaschakka@microsoft.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>
1 task
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Add missing DeleteBastionShareableLinkByToken API back to swagger (#25599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format * Adding Developer Sku (#25887) * Firewall Policy - IDPS profiles (#25666) * add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description * hostnames for l4 listeners (#25982) * added ergwscale support (#25969) * Fixed examples for gateway load balancer (#26058) * Add support for JSChallenge action in Application Gateway Web application Firewall (#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json * DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (#26248) * fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <manaschakka@microsoft.com> * [NVA] Internet Ingress Parameters (#26262) * [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix * Added description for each of the enums for ApplicationGatewayProtocol (#26437) * Added description for each of the enums for ApplicationGatewayProtocol * Spacing for prettier checks * Remove routingConfigNfv (#25962) * remove routingConfigNfv * remove api from older versions * remove PUT nvaconnection from older versions * apply prettier check * add suppression for modelValidation * remove suppression due to approval * Fix lint errors & add supressions (#26494) * fix lint error * add supression for ResourceNameRestriction & LroErrorContent * fix example accordingly --------- Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com> Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com> Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com> Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: Manas Chakka <mchakka@gmail.com> Co-authored-by: Manas Chakka <manaschakka@microsoft.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReviewlabel.ARMReviewlabel, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.