-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.DBforPostgreSQL to add version preview/2023-06-01-preview #26065
[Hub Generated] Review request for Microsoft.DBforPostgreSQL to add version preview/2023-06-01-preview #26065
Conversation
…/2023-03-01-preview to version 2023-06-01-preview
…and also update the name of the tag for flexible servers for the new API version 2023-06-01preview
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
common-types.json | 1.0(2d7078c) | 1.0(main) |
️❌
Breaking Change(Cross-Version): 165 Errors, 193 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
Administrators.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
Administrators.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
Backups.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
Backups.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
Capabilities.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
Capabilities.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
CheckNameAvailability.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
CheckNameAvailability.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
Configuration.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
Configuration.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
Databases.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
Databases.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
FirewallRules.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
FirewallRules.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
FlexibleServers.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
FlexibleServers.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
LongTermRetentionOperation.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
Migrations.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
Operations.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
Operations.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
PrivateDnsZone.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
PrivateDnsZone.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
PrivateEndpointConnections.json | 2023-06-01-preview(2d7078c) | 2018-06-01(main) |
PrivateEndpointConnections.json | 2023-06-01-preview(2d7078c) | 2018-06-01-privatepreview(main) |
PrivateLinkResources.json | 2023-06-01-preview(2d7078c) | 2018-06-01(main) |
PrivateLinkResources.json | 2023-06-01-preview(2d7078c) | 2018-06-01-privatepreview(main) |
Replicas.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
Replicas.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
ServerLogs.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
ServerStartStopRestart.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
ServerStartStopRestart.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
VirtualNetwork.json | 2023-06-01-preview(2d7078c) | 2022-12-01(main) |
VirtualNetwork.json | 2023-06-01-preview(2d7078c) | 2023-03-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 17 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 17 items are listed, please refer to log for more details.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 11 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-flexibleserver-2023-06-01-preview | package-flexibleserver-2023-06-01-preview(2d7078c) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
The following errors/warnings exist before current PR submission:
Only 17 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L38 |
PutRequestResponseSchemeArm |
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Administrators_Create' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L38 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L108 |
PatchResponseCodes |
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L126 |
ProvisioningStateSpecifiedForLROPatch |
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L164 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L196 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L196 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L196 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Databases.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Databases.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Databases.json#L38 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Databases.json#L108 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/FirewallRules.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/FirewallRules.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/FirewallRules.json#L38 |
️❌
Avocado: 1 Errors, 1 Warnings failed [Detail]
Rule | Message |
---|---|
MULTIPLE_DEFAULT_TAGS |
The readme file has more than one default tag. readme: specification/postgresql/resource-manager/readme.md |
The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01 |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
…into ambrahma/release-postgresql-Microsoft.DBforPostgreSQL-2023-06-01-preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ambrahma, please fix azure-sdk-for-go CI |
/pr RequestMerge |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
…ersion preview/2023-06-01-preview (#26065) * Adds base for updating Microsoft.DBforPostgreSQL from version preview/2023-03-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Updating readme file to point to the latest tag for flexible servers and also update the name of the tag for flexible servers for the new API version 2023-06-01preview * Added new API for advancedThreatProtectionSettings * Update API version and timestamp in examples for threat detection * Fix prettier errors for threat detection files * Fix api version for ThreatDetection in readme.md file to fix avocado error * Add VirtualEndpoints API to 2023-06-01-preview api version * Fix spellcheck, prettier and lintdiff errors for VirtualEndpoints * Fix model validation, semantic validation, lintdiff validation errors * FIx lintdiff errors * Fix pending lintdiff errors * Update VirtualEndpoints as a Resource * Add support for replica property bag in server properties to allow new operations like siteswap, promote replica * Fix prettier, spellcheck and lintdiff errors * Remove unsupported values for endpointType * Fix review comments for values * Add support for pre-migration validation and external migration * Rename the replica linkState value to Active instead of Succeeded * Fix lintDiff, model validation and spell check errors * Fix prettier errors * Add support for private endpoints * Add support for ManagedDiskV2 * Add support for Quota usages API * Update readme file to include QuotaUsages api * Add missing new Migration states * Update linkState Succeeded to Active * Fix lintDiff warnings * Revert v5 to v3 change for lintDiff warnings for existing resource * Revert lintDIff warning change for API resourcePath for quat usages API * Add missing reference to example for server with private endpoint * Use latest version v5 for types for VirtualEndpoints api * Updated description for SSL mode and remove the unsupported SSL modes * Add support for PG server version 16 * Add private endpoint connections API * Add support for PrivateLinkResources and fix the errors * Fix pipeline errors * Add privateEndpointConnections readonly property for flexible servers and fix the pipeline errors * Fix remaining issues * Update example and description for advanced threat protection settings * Fix objects for errors * Update back to v5/privatelinks.json * Update the filename for privatelinks.json * Fix review comments for using an enum * Fix few pending lintdiff errors * Adding errpr suppressions * Use v5/types.json for all files * Fix arm-id format errors for Migration examples * Remove duplicated systemData properties * Use newer version for privatelinks.json to solve duplicate reference error
…ersion preview/2023-06-01-preview (#26065) * Adds base for updating Microsoft.DBforPostgreSQL from version preview/2023-03-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Updating readme file to point to the latest tag for flexible servers and also update the name of the tag for flexible servers for the new API version 2023-06-01preview * Added new API for advancedThreatProtectionSettings * Update API version and timestamp in examples for threat detection * Fix prettier errors for threat detection files * Fix api version for ThreatDetection in readme.md file to fix avocado error * Add VirtualEndpoints API to 2023-06-01-preview api version * Fix spellcheck, prettier and lintdiff errors for VirtualEndpoints * Fix model validation, semantic validation, lintdiff validation errors * FIx lintdiff errors * Fix pending lintdiff errors * Update VirtualEndpoints as a Resource * Add support for replica property bag in server properties to allow new operations like siteswap, promote replica * Fix prettier, spellcheck and lintdiff errors * Remove unsupported values for endpointType * Fix review comments for values * Add support for pre-migration validation and external migration * Rename the replica linkState value to Active instead of Succeeded * Fix lintDiff, model validation and spell check errors * Fix prettier errors * Add support for private endpoints * Add support for ManagedDiskV2 * Add support for Quota usages API * Update readme file to include QuotaUsages api * Add missing new Migration states * Update linkState Succeeded to Active * Fix lintDiff warnings * Revert v5 to v3 change for lintDiff warnings for existing resource * Revert lintDIff warning change for API resourcePath for quat usages API * Add missing reference to example for server with private endpoint * Use latest version v5 for types for VirtualEndpoints api * Updated description for SSL mode and remove the unsupported SSL modes * Add support for PG server version 16 * Add private endpoint connections API * Add support for PrivateLinkResources and fix the errors * Fix pipeline errors * Add privateEndpointConnections readonly property for flexible servers and fix the pipeline errors * Fix remaining issues * Update example and description for advanced threat protection settings * Fix objects for errors * Update back to v5/privatelinks.json * Update the filename for privatelinks.json * Fix review comments for using an enum * Fix few pending lintdiff errors * Adding errpr suppressions * Use v5/types.json for all files * Fix arm-id format errors for Migration examples * Remove duplicated systemData properties * Use newer version for privatelinks.json to solve duplicate reference error
ARM (Control Plane) API Specification Update Pull Request
Changes included in this PR:
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.