Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.DBforPostgreSQL to add version preview/2023-06-01-preview #26065

Conversation

ambrahma
Copy link
Member

@ambrahma ambrahma commented Oct 3, 2023

ARM (Control Plane) API Specification Update Pull Request

Changes included in this PR:

  1. New preview API version added: 2023-06-01-preview
  2. Azure Defender / Threat protection APIs support added to this new API version.
  3. VirtualEndpoint APIs and SiteSwap support for read replicas.
  4. Pre-migration Validation API and support for other source types for Migration to PG flexible servers.
  5. Private Endpoint feature support.
  6. PremiumV2_LRS storage type support for PG flexible servers.
  7. Quota usages API feature support.
  8. PG version 16 support for provisioning.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • [X ] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • [X ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [X ] I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

ambrahma and others added 4 commits October 3, 2023 10:48
…/2023-03-01-preview to version 2023-06-01-preview
…and also update the name of the tag for flexible servers for the new API version 2023-06-01preview
@ambrahma ambrahma requested a review from a team as a code owner October 3, 2023 10:06
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 3, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 3, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
common-types.json 1.0(2d7078c) 1.0(main)
️❌Breaking Change(Cross-Version): 165 Errors, 193 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
Administrators.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
Administrators.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
Backups.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
Backups.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
Capabilities.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
Capabilities.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
CheckNameAvailability.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
CheckNameAvailability.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
Configuration.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
Configuration.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
Databases.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
Databases.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
FirewallRules.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
FirewallRules.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
FlexibleServers.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
FlexibleServers.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
LongTermRetentionOperation.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
Migrations.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
Operations.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
Operations.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
PrivateDnsZone.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
PrivateDnsZone.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
PrivateEndpointConnections.json 2023-06-01-preview(2d7078c) 2018-06-01(main)
PrivateEndpointConnections.json 2023-06-01-preview(2d7078c) 2018-06-01-privatepreview(main)
PrivateLinkResources.json 2023-06-01-preview(2d7078c) 2018-06-01(main)
PrivateLinkResources.json 2023-06-01-preview(2d7078c) 2018-06-01-privatepreview(main)
Replicas.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
Replicas.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
ServerLogs.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
ServerStartStopRestart.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
ServerStartStopRestart.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)
VirtualNetwork.json 2023-06-01-preview(2d7078c) 2022-12-01(main)
VirtualNetwork.json 2023-06-01-preview(2d7078c) 2023-03-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 17 items are listed, please refer to log for more details.

Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
Old: Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateEndpointConnections.json#L37:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/privateEndpointConnections' removed or restructured?
Old: Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateEndpointConnections.json#L251:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/privateLinkResources' removed or restructured?
Old: Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateLinkResources.json#L37:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/privateLinkResources/{groupName}' removed or restructured?
Old: Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateLinkResources.json#L82:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointProperty' removed or renamed?
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L247:3
Old: Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateEndpointConnections.json#L297:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionStateProperty' removed or renamed?
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L247:3
Old: Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateEndpointConnections.json#L297:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TagsObject' removed or renamed?
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L247:3
Old: Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateEndpointConnections.json#L297:3
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L49:9
Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/Administrators.json#L49:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L119:9
Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/Administrators.json#L119:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L174:9
Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/Administrators.json#L174:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L219:9
Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/Administrators.json#L219:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L632:5
Old: common-types/resource-management/v3/types.json#L622:5
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L204:9
Old: common-types/resource-management/v3/types.json#L204:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L210:9
Old: common-types/resource-management/v3/types.json#L209:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9


The following breaking changes are detected by comparison with the latest preview version:

Only 17 items are listed, please refer to log for more details.

Rule Message
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L37:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/privateEndpointConnections' removed or restructured?
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L251:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/privateLinkResources' removed or restructured?
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L37:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/privateLinkResources/{groupName}' removed or restructured?
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L82:5
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointProperty' removed or renamed?
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L247:3
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L297:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionStateProperty' removed or renamed?
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L247:3
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L297:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TagsObject' removed or renamed?
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L247:3
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L297:3
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed?
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L269:3
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L431:3
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed?
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateLinkResources.json#L154:3
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L222:3
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/privatelinks.json#L47:9
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L302:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/privatelinks.json#L51:9
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L306:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/privatelinks.json#L68:9
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L334:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/privatelinks.json#L55:9
Old: Microsoft.DBforPostgreSQL/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L310:9
⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L49:9
Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Administrators.json#L49:9
⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L119:9
Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Administrators.json#L119:9
⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L174:9
Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Administrators.json#L174:9
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 11 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-flexibleserver-2023-06-01-preview package-flexibleserver-2023-06-01-preview(2d7078c) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/FlexibleServers.json#L635
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L65
⚠️ PutInOperationName 'PUT' operation 'PrivateEndpointConnection_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L86
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L108
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L117
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L123
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateEndpointConnections.json#L256
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateLinkResources.json#L115
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/PrivateLinkResources.json#L142
⚠️ ReservedResourceNamesModelAsEnum The service-defined (reserved name) resource 'usages' should be represented as a path parameter enum with modelAsString set to true.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/QuotaUsages.json#L37
RPC-ConstrainedCollections-V1-04
⚠️ AllProxyResourcesShouldHaveDelete The resource ServerThreatProtectionSettingsModel does not have a corresponding delete operation.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/ThreatProtection.json#L218
RPC-Delete-V1-05


The following errors/warnings exist before current PR submission:

Only 17 items are listed, please refer to log for more details.

Rule Message
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L38
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L38
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Administrators_Create' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L38
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Administrators.json#L108
PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L126
ProvisioningStateSpecifiedForLROPatch 200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L164
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L196
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L196
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Configuration.json#L196
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Databases.json#L38
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Databases.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Databases.json#L38
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/Databases.json#L108
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/FirewallRules.json#L38
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/FirewallRules.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DBforPostgreSQL/preview/2023-06-01-preview/FirewallRules.json#L38
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
Rule Message
MULTIPLE_DEFAULT_TAGS The readme file has more than one default tag.
readme: specification/postgresql/resource-manager/readme.md
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/postgresql/resource-manager/readme.md
tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 3, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking




️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 6274f7b. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.2
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.2` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 6274f7b. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/postgresql/armpostgresql [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/postgresql/armpostgresqlflexibleservers [View full logs]  [Release SDK Changes]
    Only show 60 items here, please refer to log for details.
    info	[Changelog] - New enum type `VirtualEndpointType` with values `VirtualEndpointTypeReadWrite`
    info	[Changelog] - New function `*ClientFactory.NewPrivateEndpointConnectionClient() *PrivateEndpointConnectionClient`
    info	[Changelog] - New function `*ClientFactory.NewPrivateEndpointConnectionsClient() *PrivateEndpointConnectionsClient`
    info	[Changelog] - New function `*ClientFactory.NewPrivateLinkResourcesClient() *PrivateLinkResourcesClient`
    info	[Changelog] - New function `*ClientFactory.NewQuotaUsagesClient() *QuotaUsagesClient`
    info	[Changelog] - New function `*ClientFactory.NewServerThreatProtectionSettingsClient() *ServerThreatProtectionSettingsClient`
    info	[Changelog] - New function `*ClientFactory.NewVirtualEndpointsClient() *VirtualEndpointsClient`
    info	[Changelog] - New function `NewPrivateEndpointConnectionClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateEndpointConnectionClient, error)`
    info	[Changelog] - New function `*PrivateEndpointConnectionClient.BeginDelete(context.Context, string, string, string, *PrivateEndpointConnectionClientBeginDeleteOptions) (*runtime.Poller[PrivateEndpointConnectionClientDeleteResponse], error)`
    info	[Changelog] - New function `*PrivateEndpointConnectionClient.BeginUpdate(context.Context, string, string, string, PrivateEndpointConnection, *PrivateEndpointConnectionClientBeginUpdateOptions) (*runtime.Poller[PrivateEndpointConnectionClientUpdateResponse], error)`
    info	[Changelog] - New function `NewPrivateEndpointConnectionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateEndpointConnectionsClient, error)`
    info	[Changelog] - New function `*PrivateEndpointConnectionsClient.Get(context.Context, string, string, string, *PrivateEndpointConnectionsClientGetOptions) (PrivateEndpointConnectionsClientGetResponse, error)`
    info	[Changelog] - New function `*PrivateEndpointConnectionsClient.NewListByServerPager(string, string, *PrivateEndpointConnectionsClientListByServerOptions) *runtime.Pager[PrivateEndpointConnectionsClientListByServerResponse]`
    info	[Changelog] - New function `NewPrivateLinkResourcesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateLinkResourcesClient, error)`
    info	[Changelog] - New function `*PrivateLinkResourcesClient.Get(context.Context, string, string, string, *PrivateLinkResourcesClientGetOptions) (PrivateLinkResourcesClientGetResponse, error)`
    info	[Changelog] - New function `*PrivateLinkResourcesClient.NewListByServerPager(string, string, *PrivateLinkResourcesClientListByServerOptions) *runtime.Pager[PrivateLinkResourcesClientListByServerResponse]`
    info	[Changelog] - New function `NewQuotaUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QuotaUsagesClient, error)`
    info	[Changelog] - New function `*QuotaUsagesClient.NewListPager(string, *QuotaUsagesClientListOptions) *runtime.Pager[QuotaUsagesClientListResponse]`
    info	[Changelog] - New function `NewServerThreatProtectionSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ServerThreatProtectionSettingsClient, error)`
    info	[Changelog] - New function `*ServerThreatProtectionSettingsClient.BeginCreateOrUpdate(context.Context, string, string, ThreatProtectionName, ServerThreatProtectionSettingsModel, *ServerThreatProtectionSettingsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ServerThreatProtectionSettingsClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*ServerThreatProtectionSettingsClient.Get(context.Context, string, string, ThreatProtectionName, *ServerThreatProtectionSettingsClientGetOptions) (ServerThreatProtectionSettingsClientGetResponse, error)`
    info	[Changelog] - New function `*ServerThreatProtectionSettingsClient.NewListByServerPager(string, string, *ServerThreatProtectionSettingsClientListByServerOptions) *runtime.Pager[ServerThreatProtectionSettingsClientListByServerResponse]`
    info	[Changelog] - New function `NewVirtualEndpointsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualEndpointsClient, error)`
    info	[Changelog] - New function `*VirtualEndpointsClient.BeginCreate(context.Context, string, string, string, VirtualEndpointResource, *VirtualEndpointsClientBeginCreateOptions) (*runtime.Poller[VirtualEndpointsClientCreateResponse], error)`
    info	[Changelog] - New function `*VirtualEndpointsClient.BeginDelete(context.Context, string, string, string, *VirtualEndpointsClientBeginDeleteOptions) (*runtime.Poller[VirtualEndpointsClientDeleteResponse], error)`
    info	[Changelog] - New function `*VirtualEndpointsClient.Get(context.Context, string, string, string, *VirtualEndpointsClientGetOptions) (VirtualEndpointsClientGetResponse, error)`
    info	[Changelog] - New function `*VirtualEndpointsClient.NewListByServerPager(string, string, *VirtualEndpointsClientListByServerOptions) *runtime.Pager[VirtualEndpointsClientListByServerResponse]`
    info	[Changelog] - New function `*VirtualEndpointsClient.BeginUpdate(context.Context, string, string, string, VirtualEndpointResourceForPatch, *VirtualEndpointsClientBeginUpdateOptions) (*runtime.Poller[VirtualEndpointsClientUpdateResponse], error)`
    info	[Changelog] - New struct `DbLevelValidationStatus`
    info	[Changelog] - New struct `DbMigrationStatus`
    info	[Changelog] - New struct `NameProperty`
    info	[Changelog] - New struct `PrivateEndpoint`
    info	[Changelog] - New struct `PrivateEndpointConnection`
    info	[Changelog] - New struct `PrivateEndpointConnectionListResult`
    info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
    info	[Changelog] - New struct `PrivateLinkResource`
    info	[Changelog] - New struct `PrivateLinkResourceListResult`
    info	[Changelog] - New struct `PrivateLinkResourceProperties`
    info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
    info	[Changelog] - New struct `QuotaUsage`
    info	[Changelog] - New struct `QuotaUsagesListResult`
    info	[Changelog] - New struct `Replica`
    info	[Changelog] - New struct `ServerThreatProtectionListResult`
    info	[Changelog] - New struct `ServerThreatProtectionProperties`
    info	[Changelog] - New struct `ServerThreatProtectionSettingsModel`
    info	[Changelog] - New struct `ValidationDetails`
    info	[Changelog] - New struct `ValidationMessage`
    info	[Changelog] - New struct `ValidationSummaryItem`
    info	[Changelog] - New struct `VirtualEndpointResource`
    info	[Changelog] - New struct `VirtualEndpointResourceForPatch`
    info	[Changelog] - New struct `VirtualEndpointResourceProperties`
    info	[Changelog] - New struct `VirtualEndpointsListResult`
    info	[Changelog] - New field `MigrationOption`, `SSLMode`, `SourceType` in struct `MigrationResourceProperties`
    info	[Changelog] - New field `DbDetails`, `ValidationDetails` in struct `MigrationSubStateDetails`
    info	[Changelog] - New field `PrivateEndpointConnections`, `Replica` in struct `ServerProperties`
    info	[Changelog] - New field `Replica` in struct `ServerPropertiesForUpdate`
    info	[Changelog] - New field `Throughput`, `Type` in struct `Storage`
    info	[Changelog] - New field `MaximumStorageSizeMb`, `SupportedMaximumIops`, `SupportedMaximumThroughput`, `SupportedThroughput` in struct `StorageMbCapability`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 144 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 6274f7b. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    warn	No file changes detected after generation
    warn	No package detected after generation
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 6274f7b. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.2
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.2` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️postgresql [View full logs]  [Release Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 6274f7b. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.postgresql.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.postgresql.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 3, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/postgresql/armpostgresql There is no API change compared with the previous version
Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers https://apiview.dev/Assemblies/Review/89716e89fa604eb58cf90ca0e8e987d6
.Net Azure.ResourceManager.PostgreSql https://apiview.dev/Assemblies/Review/7291da0ccca444129eab61f685503389
Java azure-resourcemanager-postgresqlflexibleserver https://apiview.dev/Assemblies/Review/6c7b0baf32bd40ea86accfa64fc16150

@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 1, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 1, 2023
@Alancere
Copy link
Member

Alancere commented Nov 1, 2023

Hi @ambrahma, please fix azure-sdk-for-go CI Duplicate Schema error.

@Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 2, 2023
@ambrahma
Copy link
Member Author

ambrahma commented Nov 2, 2023

/pr RequestMerge

@rkmanda rkmanda merged commit 6274f7b into main Nov 2, 2023
28 of 31 checks passed
@rkmanda rkmanda deleted the ambrahma/release-postgresql-Microsoft.DBforPostgreSQL-2023-06-01-preview branch November 2, 2023 18:55
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
…ersion preview/2023-06-01-preview (#26065)

* Adds base for updating Microsoft.DBforPostgreSQL from version preview/2023-03-01-preview to version 2023-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Updating readme file to point to the latest tag for flexible servers and also update the name of the tag for flexible servers for the new API version 2023-06-01preview

* Added new API for advancedThreatProtectionSettings

* Update API version and timestamp in examples for threat detection

* Fix prettier errors for threat detection files

* Fix api version for ThreatDetection in readme.md file to fix avocado error

* Add VirtualEndpoints API to 2023-06-01-preview api version

* Fix spellcheck, prettier and lintdiff errors for VirtualEndpoints

* Fix model validation, semantic validation, lintdiff validation errors

* FIx lintdiff errors

* Fix pending lintdiff errors

* Update VirtualEndpoints as a Resource

* Add support for replica property bag in server properties to allow new operations like siteswap, promote replica

* Fix prettier, spellcheck and lintdiff errors

* Remove unsupported values for endpointType

* Fix review comments for values

* Add support for pre-migration validation and external migration

* Rename the replica linkState value to Active instead of Succeeded

* Fix lintDiff, model validation and spell check errors

* Fix prettier errors

* Add support for private endpoints

* Add support for ManagedDiskV2

* Add support for Quota usages API

* Update readme file to include QuotaUsages api

* Add missing new Migration states

* Update linkState Succeeded to Active

* Fix lintDiff warnings

* Revert v5 to v3 change for lintDiff warnings for existing resource

* Revert lintDIff warning change for API resourcePath for quat usages API

* Add missing reference to example for server with private endpoint

* Use latest version v5 for types for VirtualEndpoints api

* Updated description for SSL mode and remove the unsupported SSL modes

* Add support for PG server version 16

* Add private endpoint connections API

* Add support for PrivateLinkResources and fix the errors

* Fix pipeline errors

* Add privateEndpointConnections readonly property for flexible servers and fix the pipeline errors

* Fix remaining issues

* Update example and description for advanced threat protection settings

* Fix objects for errors

* Update back to v5/privatelinks.json

* Update the filename for privatelinks.json

* Fix review comments for using an enum

* Fix few pending lintdiff errors

* Adding errpr suppressions

* Use v5/types.json for all files

* Fix arm-id format errors for Migration examples

* Remove duplicated systemData properties

* Use newer version for privatelinks.json to solve duplicate reference error
zman-ms pushed a commit that referenced this pull request Jan 10, 2024
…ersion preview/2023-06-01-preview (#26065)

* Adds base for updating Microsoft.DBforPostgreSQL from version preview/2023-03-01-preview to version 2023-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Updating readme file to point to the latest tag for flexible servers and also update the name of the tag for flexible servers for the new API version 2023-06-01preview

* Added new API for advancedThreatProtectionSettings

* Update API version and timestamp in examples for threat detection

* Fix prettier errors for threat detection files

* Fix api version for ThreatDetection in readme.md file to fix avocado error

* Add VirtualEndpoints API to 2023-06-01-preview api version

* Fix spellcheck, prettier and lintdiff errors for VirtualEndpoints

* Fix model validation, semantic validation, lintdiff validation errors

* FIx lintdiff errors

* Fix pending lintdiff errors

* Update VirtualEndpoints as a Resource

* Add support for replica property bag in server properties to allow new operations like siteswap, promote replica

* Fix prettier, spellcheck and lintdiff errors

* Remove unsupported values for endpointType

* Fix review comments for values

* Add support for pre-migration validation and external migration

* Rename the replica linkState value to Active instead of Succeeded

* Fix lintDiff, model validation and spell check errors

* Fix prettier errors

* Add support for private endpoints

* Add support for ManagedDiskV2

* Add support for Quota usages API

* Update readme file to include QuotaUsages api

* Add missing new Migration states

* Update linkState Succeeded to Active

* Fix lintDiff warnings

* Revert v5 to v3 change for lintDiff warnings for existing resource

* Revert lintDIff warning change for API resourcePath for quat usages API

* Add missing reference to example for server with private endpoint

* Use latest version v5 for types for VirtualEndpoints api

* Updated description for SSL mode and remove the unsupported SSL modes

* Add support for PG server version 16

* Add private endpoint connections API

* Add support for PrivateLinkResources and fix the errors

* Fix pipeline errors

* Add privateEndpointConnections readonly property for flexible servers and fix the pipeline errors

* Fix remaining issues

* Update example and description for advanced threat protection settings

* Fix objects for errors

* Update back to v5/privatelinks.json

* Update the filename for privatelinks.json

* Fix review comments for using an enum

* Fix few pending lintdiff errors

* Adding errpr suppressions

* Use v5/types.json for all files

* Fix arm-id format errors for Migration examples

* Remove duplicated systemData properties

* Use newer version for privatelinks.json to solve duplicate reference error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go new-api-version resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.