Dev dataprotection microsoft.data protection 2023 08 01 #26372

soumyapattnaik · 2023-10-25T10:49:23Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…023-05-01 to version 2023-08-01

openapi-pipeline-app · 2023-10-25T10:49:28Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-10-25T10:49:29Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 26 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
dataprotection.json	2023-08-01(10dcdc6)	2023-05-01(main)
dataprotection.json	2023-08-01(10dcdc6)	2023-08-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/backupVaults/{vaultName}/backupInstances/{backupInstanceName}/validateForModifyBackup' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L1369:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchSecondaryRecoveryPoints' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L1619:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/crossRegionRestore' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L1694:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/validateCrossRegionRestore' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L1772:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchCrossRegionRestoreJob' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L1850:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchCrossRegionRestoreJobs' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L1906:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/{resourceId}/providers/Microsoft.DataProtection/backupInstances' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L1965:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/backupVaults/{vaultName}/backupJobs/{jobId}/triggerCancel' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L2729:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/backupVaults/{vaultName}/backupJobs/{jobId}/generateProgressUrl' removed or restructured? Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L2793:5
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreJobRequest' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreJobsRequest' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'FetchSecondaryRPsRequestParameters' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CmkKeyVaultProperties' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CmkKekIdentity' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'encryptionSettings' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreDetails' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ValidateCrossRegionRestoreRequestObject' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreRequestObject' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ValidateForModifyBackupRequest' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3747:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4333:3
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResourceId' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L7609:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L8427:3
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'RestrictedVaultName' removed or renamed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L7609:3 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L8427:3
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L6634:9 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L7428:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L6639:9 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L7432:9
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'encryptionSettings' renamed or removed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L7071:7 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L7856:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'warningDetails' renamed or removed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L6089:7 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L6822:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'sourceDataStoreType' renamed or removed? New: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L3989:7 Old: Microsoft.DataProtection/preview/2023-08-01-preview/dataprotection.json#L4575:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2023-08	package-2023-08(10dcdc6)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L42
`❌` LroExtension	Operations with a 202 response must specify `x-ms-long-running-operation: true`. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L64
`❌` ParametersOrder	The parameters:operationId,location should be kept in the same order as they present in the path. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L64
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L94
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L307
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L426
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L440
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L467
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L476
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L526
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L532
`❌` LroExtension	Operations with a 202 response must specify `x-ms-long-running-operation: true`. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L545
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L580
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L740
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L788
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L860
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L996
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1064
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1128
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1139
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1193
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1269
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1345
`❌` LroExtension	Operations with a 202 response must specify `x-ms-long-running-operation: true`. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1361
`❌` OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'BackupInstances' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1366
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1400
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1400
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1461
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1538
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-08-01/dataprotection.json#L1595

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-25T10:49:30Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/dataprotection/armdataprotection - Approved - 3.0.0

+	Function `*timeRFC3339.Parse` has been removed
+	Function `*timeRFC3339.UnmarshalText` has been removed
+	Function `timeRFC3339.MarshalText` has been removed
+	Type of `BaseResourceProperties.ObjectType` has been changed from `*string` to `*ResourcePropertiesObjectType`

❌azure-sdk-for-js - @azure/arm-dataprotection - Approved - 2.0.0

+	Type of parameter objectType of interface BaseResourceProperties is changed from "BaseResourceProperties" to "DefaultResourceProperties"
+	Type of parameter resourceProperties of interface Datasource is changed from BaseResourceProperties to BaseResourcePropertiesUnion
+	Type of parameter resourceProperties of interface DatasourceSet is changed from BaseResourceProperties to BaseResourcePropertiesUnion

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e7cfe1b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.DataProtectionBackup [View full logs] [Release SDK Changes]
- Azure.ResourceManager.DataProtectionBackup.1.3.0-alpha.20231109.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from e7cfe1b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.3` to update!
cmderr	[automation_generate.sh]

️✔️track2_azure-mgmt-dataprotection [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added model DefaultResourceProperties
info	[Changelog]   - Added model KubernetesClusterVaultTierRestoreCriteria
info	[Changelog]   - Added model ResourcePropertiesObjectType

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from e7cfe1b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-dataprotection [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e7cfe1b. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/dataprotection/armdataprotection [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `BaseResourceProperties.ObjectType` has been changed from `*string` to `*ResourcePropertiesObjectType`
info	[Changelog] - Function `timeRFC3339.MarshalText` has been removed
info	[Changelog] - Function `*timeRFC3339.Parse` has been removed
info	[Changelog] - Function `*timeRFC3339.UnmarshalText` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `ResourcePropertiesObjectType` with values `ResourcePropertiesObjectTypeDefaultResourceProperties`
info	[Changelog] - New function `*DefaultResourceProperties.GetBaseResourceProperties() *BaseResourceProperties`
info	[Changelog] - New function `*KubernetesClusterVaultTierRestoreCriteria.GetItemLevelRestoreCriteria() *ItemLevelRestoreCriteria`
info	[Changelog] - New function `dateTimeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `*dateTimeRFC3339.Parse(string) error`
info	[Changelog] - New function `*dateTimeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New struct `DefaultResourceProperties`
info	[Changelog] - New struct `KubernetesClusterVaultTierRestoreCriteria`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 11 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e7cfe1b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-dataprotection [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-dataprotection-2.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface DefaultResourceProperties
info	[Changelog]   - Added Interface KubernetesClusterVaultTierRestoreCriteria
info	[Changelog]   - Added Type Alias BaseResourcePropertiesUnion
info	[Changelog]   - Added Type Alias ResourcePropertiesObjectType
info	[Changelog]   - Type of parameter objectType of interface ItemLevelRestoreCriteria is changed from "ItemPathBasedRestoreCriteria" | "RangeBasedItemLevelRestoreCriteria" | "KubernetesStorageClassRestoreCriteria" | "KubernetesPVRestoreCriteria" | "KubernetesClusterRestoreCriteria" to "ItemPathBasedRestoreCriteria" | "RangeBasedItemLevelRestoreCriteria" | "KubernetesStorageClassRestoreCriteria" | "KubernetesPVRestoreCriteria" | "KubernetesClusterRestoreCriteria" | "KubernetesClusterVaultTierRestoreCriteria"
info	[Changelog]   - Added Enum KnownResourcePropertiesObjectType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter objectType of interface BaseResourceProperties is changed from "BaseResourceProperties" to "DefaultResourceProperties"
info	[Changelog]   - Type of parameter resourceProperties of interface Datasource is changed from BaseResourceProperties to BaseResourcePropertiesUnion
info	[Changelog]   - Type of parameter resourceProperties of interface DatasourceSet is changed from BaseResourceProperties to BaseResourcePropertiesUnion

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from e7cfe1b. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.dataprotection.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.dataprotection.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-25T10:49:31Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/dataprotection/armdataprotection	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-dataprotection	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.DataProtectionBackup	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-dataprotection	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2023-10-25T10:55:17Z

Hi @soumyapattnaik! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

ms-henglu · 2023-10-26T06:54:02Z

...taprotection/resource-manager/Microsoft.DataProtection/stable/2023-08-01/dataprotection.json

+          "x-ms-identifiers": [],
+          "type": "array"
+        },
+        "stagingResourceGroupId": {


Is it an azure resource ID? If so, please add "format": "arm-id" and "x-ms-arm-id-details".

https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details

ms-henglu · 2023-10-26T06:54:07Z

...taprotection/resource-manager/Microsoft.DataProtection/stable/2023-08-01/dataprotection.json

+          "description": "Gets or sets the staging RG Id for creating staging disks and snapshots during restore from vault.",
+          "type": "string"
+        },
+        "stagingStorageAccountId": {


Is it an azure resource ID? If so, please add "format": "arm-id" and "x-ms-arm-id-details".

https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details

openapi-workflow-bot · 2023-10-26T06:57:17Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

soumyapattnaik · 2023-11-09T12:49:29Z

/pr RequestMerge

zizw123 · 2023-11-09T18:49:38Z

/azp run

azure-pipelines · 2023-11-09T18:49:54Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-pipeline-app · 2023-11-09T19:35:12Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

* Adds base for updating Microsoft.DataProtection from version stable/2023-05-01 to version 2023-08-01 * Updates readme * Updates API version in new specs and examples * changes for vault tier * code review changes --------- Co-authored-by: Shashank Singh <shashank1306s@gmail.com>

Shashank1306s and others added 4 commits October 23, 2023 16:27

Adds base for updating Microsoft.DataProtection from version stable/2…

0ebe318

…023-05-01 to version 2023-08-01

Updates readme

0091391

Updates API version in new specs and examples

dc52fde

changes for vault tier

2eb558d

openapi-assignment-bot bot assigned rkmanda Oct 25, 2023

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 25, 2023

azure-sdk mentioned this pull request Oct 25, 2023

[AutoPR sdk/resourcemanager/dataprotection/armdataprotection] Dev dataprotection microsoft.data protection 2023 08 01 azure-sdk/azure-sdk-for-go#7822

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 25, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Oct 25, 2023

ms-henglu reviewed Oct 26, 2023

View reviewed changes

ms-henglu added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 26, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 26, 2023

code review changes

01d234f

hiaga removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 7, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 7, 2023

hiaga removed the CI-MissingBaseCommit label Nov 7, 2023

pull from main

10dcdc6

AzureRestAPISpecReview added the CI-MissingBaseCommit label Nov 7, 2023

zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 7, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 7, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Nov 8, 2023

microsoft-github-policy-service bot added the MergeRequested label Nov 9, 2023

hiaga added the AzCoreIDC label Nov 9, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 9, 2023

zizw123 approved these changes Nov 9, 2023

View reviewed changes

zizw123 merged commit e7cfe1b into Azure:main Nov 9, 2023
30 of 33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev dataprotection microsoft.data protection 2023 08 01 #26372

Dev dataprotection microsoft.data protection 2023 08 01 #26372

soumyapattnaik commented Oct 25, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-workflow-bot bot commented Oct 25, 2023

ms-henglu Oct 26, 2023

soumyapattnaik Nov 7, 2023

ms-henglu Oct 26, 2023

openapi-workflow-bot bot commented Oct 26, 2023

soumyapattnaik commented Nov 9, 2023

zizw123 commented Nov 9, 2023

azure-pipelines bot commented Nov 9, 2023

openapi-pipeline-app bot commented Nov 9, 2023

Dev dataprotection microsoft.data protection 2023 08 01 #26372

Dev dataprotection microsoft.data protection 2023 08 01 #26372

Conversation

soumyapattnaik commented Oct 25, 2023 • edited by openapi-workflow-bot bot Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Oct 25, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 25, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 25, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 25, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Oct 25, 2023

ms-henglu Oct 26, 2023

Choose a reason for hiding this comment

soumyapattnaik Nov 7, 2023

Choose a reason for hiding this comment

ms-henglu Oct 26, 2023

Choose a reason for hiding this comment

openapi-workflow-bot bot commented Oct 26, 2023

soumyapattnaik commented Nov 9, 2023

zizw123 commented Nov 9, 2023

azure-pipelines bot commented Nov 9, 2023

openapi-pipeline-app bot commented Nov 9, 2023

soumyapattnaik commented Oct 25, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading