fix incorrect error property in async-operationstatus response #26436

MasterRyd3l · 2023-10-27T07:56:09Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- We recently merged in 3 API versions 2023-09-01-preview, 2023-10-27-preview and 2023-11-01. We found a mistake with our async operation status response's error property type. As this is very recent and we have no released any SDK for either of these versions we are looking to fix the typing issue in all three of these SDK

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-10-27T07:56:14Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-10-27T07:56:14Z

Swagger Validation Report

️❌BreakingChange: 21 Errors, 6 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
operationStatuses.json	2023-09-01-preview(e6f5881)	2023-09-01-preview(main)
operationStatuses.json	2023-10-27-preview(e6f5881)	2023-10-27-preview(main)
operationStatuses.json	2023-11-01(e6f5881)	2023-11-01(main)

Rule	Message
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v2/types.json#L332:9 Old: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L113:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v2/types.json#L332:9 Old: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L113:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v2/types.json#L332:9 Old: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L113:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'error' renamed or removed? New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'error' renamed or removed? New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'error' renamed or removed? New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'code' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'message' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'target' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'details' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'additionalInfo' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'code' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'message' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'target' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'details' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'additionalInfo' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'code' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'message' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'target' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'details' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'additionalInfo' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L288:7 Old: common-types/resource-management/v2/types.json#L331:7
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L74:13 Old: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L74:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L89:5 Old: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L89:5
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L74:13 Old: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L74:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L89:5 Old: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L89:5
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L74:13 Old: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L74:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L89:5 Old: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L89:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 3 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2023-11	package-2023-11(e6f5881)	package-2023-11(main)
package-preview-2023-10	package-preview-2023-10(e6f5881)	package-preview-2023-10(main)
package-preview-2023-09	package-preview-2023-09(e6f5881)	package-preview-2023-09(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L94
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L94
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L94

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L49
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L65
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L68
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/preview/2023-09-01-preview/operationStatuses.json#L81
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L49
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L65
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L68
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/preview/2023-10-27-preview/operationStatuses.json#L81
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L49
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L65
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L68
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.Chaos/stable/2023-11-01/operationStatuses.json#L81

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-27T07:56:15Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/chaos/armchaos - 1.0.0

+	Field `CreatedDateTime`, `ExperimentID`, `LastActionDateTime`, `StartDateTime`, `StopDateTime` of struct `ExperimentExecutionDetailsProperties` has been removed
+	Field `StartOnCreation` of struct `ExperimentProperties` has been removed
+	Function `*Action.GetAction` has been removed
+	Function `*ContinuousAction.GetAction` has been removed
+	Function `*DelayAction.GetAction` has been removed
+	Function `*DiscreteAction.GetAction` has been removed
+	Function `*ExperimentsClient.GetExecutionDetails` has been removed
+	Function `*ExperimentsClient.GetStatus` has been removed
+	Function `*ExperimentsClient.NewListAllStatusesPager` has been removed
+	Function `*ExperimentsClient.NewListExecutionDetailsPager` has been removed
+	Function `*Filter.GetFilter` has been removed
+	Function `*ListSelector.GetSelector` has been removed
+	Function `*QuerySelector.GetSelector` has been removed
+	Function `*Selector.GetSelector` has been removed
+	Function `*SimpleFilter.GetFilter` has been removed
+	Operation `*ExperimentsClient.Cancel` has been changed to LRO, use `*ExperimentsClient.BeginCancel` instead.
+	Operation `*ExperimentsClient.CreateOrUpdate` has been changed to LRO, use `*ExperimentsClient.BeginCreateOrUpdate` instead.
+	Operation `*ExperimentsClient.Delete` has been changed to LRO, use `*ExperimentsClient.BeginDelete` instead.
+	Operation `*ExperimentsClient.Start` has been changed to LRO, use `*ExperimentsClient.BeginStart` instead.
+	Operation `*ExperimentsClient.Update` has been changed to LRO, use `*ExperimentsClient.BeginUpdate` instead.
+	Struct `Branch` has been removed
+	Struct `ExperimentCancelOperationResult` has been removed
+	Struct `ExperimentExecutionDetailsListResult` has been removed
+	Struct `ExperimentStartOperationResult` has been removed
+	Struct `ExperimentStatusListResult` has been removed
+	Struct `ExperimentStatusProperties` has been removed
+	Struct `ExperimentStatus` has been removed
+	Struct `ListSelector` has been removed
+	Struct `QuerySelector` has been removed
+	Struct `SimpleFilterParameters` has been removed
+	Struct `SimpleFilter` has been removed
+	Struct `Step` has been removed
+	Type of `ExperimentProperties.Selectors` has been changed from `[]SelectorClassification` to `[]TargetSelectorClassification`
+	Type of `ExperimentProperties.Steps` has been changed from `[]*Step` to `[]*ExperimentStep`

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 80a4872. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-chaos [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ExperimentsOperations.execution_details
info	[Changelog]   - Added operation ExperimentsOperations.get_execution
info	[Changelog]   - Added operation ExperimentsOperations.list_all_executions
info	[Changelog]   - Added operation group OperationStatusesOperations
info	[Changelog]   - Model Experiment has a new parameter provisioning_state
info	[Changelog]   - Model ExperimentExecutionDetails has a new parameter last_action_at
info	[Changelog]   - Model ExperimentExecutionDetails has a new parameter started_at
info	[Changelog]   - Model ExperimentExecutionDetails has a new parameter stopped_at
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Experiment no longer has parameter start_on_creation
info	[Changelog]   - Model ExperimentExecutionDetails no longer has parameter created_date_time
info	[Changelog]   - Model ExperimentExecutionDetails no longer has parameter experiment_id
info	[Changelog]   - Model ExperimentExecutionDetails no longer has parameter last_action_date_time
info	[Changelog]   - Model ExperimentExecutionDetails no longer has parameter start_date_time
info	[Changelog]   - Model ExperimentExecutionDetails no longer has parameter stop_date_time
info	[Changelog]   - Removed operation ExperimentsOperations.get_execution_details
info	[Changelog]   - Removed operation ExperimentsOperations.get_status
info	[Changelog]   - Removed operation ExperimentsOperations.list_all_statuses
info	[Changelog]   - Removed operation ExperimentsOperations.list_execution_details
info	[Changelog]   - Renamed operation ExperimentsOperations.cancel to ExperimentsOperations.begin_cancel
info	[Changelog]   - Renamed operation ExperimentsOperations.create_or_update to ExperimentsOperations.begin_create_or_update
info	[Changelog]   - Renamed operation ExperimentsOperations.delete to ExperimentsOperations.begin_delete
info	[Changelog]   - Renamed operation ExperimentsOperations.start to ExperimentsOperations.begin_start
info	[Changelog]   - Renamed operation ExperimentsOperations.update to ExperimentsOperations.begin_update

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 80a4872. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-chaos [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 80a4872. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/chaos/armchaos [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ExperimentProperties.Selectors` has been changed from `[]SelectorClassification` to `[]TargetSelectorClassification`
info	[Changelog] - Type of `ExperimentProperties.Steps` has been changed from `[]*Step` to `[]*ExperimentStep`
info	[Changelog] - Function `*Action.GetAction` has been removed
info	[Changelog] - Function `*ContinuousAction.GetAction` has been removed
info	[Changelog] - Function `*DelayAction.GetAction` has been removed
info	[Changelog] - Function `*DiscreteAction.GetAction` has been removed
info	[Changelog] - Function `*ExperimentsClient.GetExecutionDetails` has been removed
info	[Changelog] - Function `*ExperimentsClient.GetStatus` has been removed
info	[Changelog] - Function `*ExperimentsClient.NewListAllStatusesPager` has been removed
info	[Changelog] - Function `*ExperimentsClient.NewListExecutionDetailsPager` has been removed
info	[Changelog] - Function `*Filter.GetFilter` has been removed
info	[Changelog] - Function `*ListSelector.GetSelector` has been removed
info	[Changelog] - Function `*QuerySelector.GetSelector` has been removed
info	[Changelog] - Function `*Selector.GetSelector` has been removed
info	[Changelog] - Function `*SimpleFilter.GetFilter` has been removed
info	[Changelog] - Operation `*ExperimentsClient.Cancel` has been changed to LRO, use `*ExperimentsClient.BeginCancel` instead.
info	[Changelog] - Operation `*ExperimentsClient.CreateOrUpdate` has been changed to LRO, use `*ExperimentsClient.BeginCreateOrUpdate` instead.
info	[Changelog] - Operation `*ExperimentsClient.Delete` has been changed to LRO, use `*ExperimentsClient.BeginDelete` instead.
info	[Changelog] - Operation `*ExperimentsClient.Start` has been changed to LRO, use `*ExperimentsClient.BeginStart` instead.
info	[Changelog] - Operation `*ExperimentsClient.Update` has been changed to LRO, use `*ExperimentsClient.BeginUpdate` instead.
info	[Changelog] - Struct `Branch` has been removed
info	[Changelog] - Struct `ExperimentCancelOperationResult` has been removed
info	[Changelog] - Struct `ExperimentExecutionDetailsListResult` has been removed
info	[Changelog] - Struct `ExperimentStartOperationResult` has been removed
info	[Changelog] - Struct `ExperimentStatus` has been removed
info	[Changelog] - Struct `ExperimentStatusListResult` has been removed
info	[Changelog] - Struct `ExperimentStatusProperties` has been removed
info	[Changelog] - Struct `ListSelector` has been removed
info	[Changelog] - Struct `QuerySelector` has been removed
info	[Changelog] - Struct `SimpleFilter` has been removed
info	[Changelog] - Struct `SimpleFilterParameters` has been removed
info	[Changelog] - Struct `Step` has been removed
info	[Changelog] - Field `CreatedDateTime`, `ExperimentID`, `LastActionDateTime`, `StartDateTime`, `StopDateTime` of struct `ExperimentExecutionDetailsProperties` has been removed
info	[Changelog] - Field `StartOnCreation` of struct `ExperimentProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`, `ProvisioningStateUpdating`
info	[Changelog] - New function `*ClientFactory.NewOperationStatusesClient() *OperationStatusesClient`
info	[Changelog] - New function `*ContinuousAction.GetExperimentAction() *ExperimentAction`
info	[Changelog] - New function `*DelayAction.GetExperimentAction() *ExperimentAction`
info	[Changelog] - New function `*DiscreteAction.GetExperimentAction() *ExperimentAction`
info	[Changelog] - New function `*ExperimentAction.GetExperimentAction() *ExperimentAction`
info	[Changelog] - New function `*ExperimentsClient.ExecutionDetails(context.Context, string, string, string, *ExperimentsClientExecutionDetailsOptions) (ExperimentsClientExecutionDetailsResponse, error)`
info	[Changelog] - New function `*ExperimentsClient.GetExecution(context.Context, string, string, string, *ExperimentsClientGetExecutionOptions) (ExperimentsClientGetExecutionResponse, error)`
info	[Changelog] - New function `*ExperimentsClient.NewListAllExecutionsPager(string, string, *ExperimentsClientListAllExecutionsOptions) *runtime.Pager[ExperimentsClientListAllExecutionsResponse]`
info	[Changelog] - New function `NewOperationStatusesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OperationStatusesClient, error)`
info	[Changelog] - New function `*OperationStatusesClient.Get(context.Context, string, string, *OperationStatusesClientGetOptions) (OperationStatusesClientGetResponse, error)`
info	[Changelog] - New function `*TargetFilter.GetTargetFilter() *TargetFilter`
info	[Changelog] - New function `*TargetListSelector.GetTargetSelector() *TargetSelector`
info	[Changelog] - New function `*TargetQuerySelector.GetTargetSelector() *TargetSelector`
info	[Changelog] - New function `*TargetSelector.GetTargetSelector() *TargetSelector`
info	[Changelog] - New function `*TargetSimpleFilter.GetTargetFilter() *TargetFilter`
info	[Changelog] - New struct `ExperimentBranch`
info	[Changelog] - New struct `ExperimentExecution`
info	[Changelog] - New struct `ExperimentExecutionListResult`
info	[Changelog] - New struct `ExperimentExecutionProperties`
info	[Changelog] - New struct `ExperimentStep`
info	[Changelog] - New struct `OperationStatus`
info	[Changelog] - New struct `TargetListSelector`
info	[Changelog] - New struct `TargetQuerySelector`
info	[Changelog] - New struct `TargetSimpleFilter`
info	[Changelog] - New struct `TargetSimpleFilterParameters`
info	[Changelog] - New field `LastActionAt`, `StartedAt`, `StoppedAt` in struct `ExperimentExecutionDetailsProperties`
info	[Changelog] - New field `ProvisioningState` in struct `ExperimentProperties`
info	[Changelog]
info	[Changelog] Total 48 breaking change(s), 47 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 80a4872. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-chaos [View full logs] [Release SDK Changes]

azure-arm-chaos-1.0.0.tgz

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 80a4872. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.2
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.2` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️chaos [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 80a4872. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.chaos.DefaultTag [View full logs]

Az.Chaos.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.chaos.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-27T07:56:16Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/chaos/armchaos	https://apiview.dev/Assemblies/Review/ce34529886a74d4d8013e13804183323
Java	azure-resourcemanager-chaos	https://apiview.dev/Assemblies/Review/2c080351c5e74c0986ca3504664cb733
JavaScript	@azure/arm-chaos	https://apiview.dev/Assemblies/Review/ad81a79d78c440c2914d7dbc64b65d36

openapi-workflow-bot · 2023-10-27T08:02:33Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

rkmanda

MasterRyd3l · 2023-11-01T17:39:02Z

/pr RequestMerge

openapi-pipeline-app · 2023-11-01T19:56:26Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

Co-authored-by: James Duan <jduan@microsoft.com>

fix incorrect error property in async-operationstatus response

e6f5881

openapi-assignment-bot bot assigned rkmanda Oct 27, 2023

azure-sdk mentioned this pull request Oct 27, 2023

[AutoPR track2_azure-mgmt-chaos] fix incorrect error property in async-operationstatus response azure-sdk/azure-sdk-for-python#5127

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Oct 27, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 27, 2023

MasterRyd3l removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 27, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 27, 2023

rkmanda approved these changes Oct 31, 2023

View reviewed changes

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 31, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 31, 2023

msyyc added the Approved-SdkBreakingChange-Python label Nov 1, 2023

github-actions bot added the MergeRequested label Nov 1, 2023

rkmanda approved these changes Nov 1, 2023

View reviewed changes

rkmanda merged commit 80a4872 into main Nov 1, 2023
28 of 31 checks passed

rkmanda deleted the MasterRyd3l-chaos-Microsoft.Chaos-2023-11-01 branch November 1, 2023 19:56

azure-sdk mentioned this pull request Nov 1, 2023

[ReleasePR sdk/resourcemanager/chaos/armchaos] fix incorrect error property in async-operationstatus response Azure/azure-sdk-for-go#19239

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 1, 2023

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023

fix incorrect error property in async-operationstatus response (#26436)

086b0a4

Co-authored-by: James Duan <jduan@microsoft.com>

zman-ms pushed a commit that referenced this pull request Jan 10, 2024

fix incorrect error property in async-operationstatus response (#26436)

5f9f9ed

Co-authored-by: James Duan <jduan@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix incorrect error property in async-operationstatus response #26436

fix incorrect error property in async-operationstatus response #26436

MasterRyd3l commented Oct 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 27, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 27, 2023 •

edited

Loading

openapi-workflow-bot bot commented Oct 27, 2023

rkmanda left a comment

MasterRyd3l commented Nov 1, 2023

openapi-pipeline-app bot commented Nov 1, 2023

fix incorrect error property in async-operationstatus response #26436

fix incorrect error property in async-operationstatus response #26436

Conversation

MasterRyd3l commented Oct 27, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Oct 27, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 27, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 27, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 27, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Oct 27, 2023

rkmanda left a comment

Choose a reason for hiding this comment

MasterRyd3l commented Nov 1, 2023

openapi-pipeline-app bot commented Nov 1, 2023

MasterRyd3l commented Oct 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 27, 2023 •

edited

Loading