Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PostgreSQL] Add missing new api version tag for typescript #26614

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ambrahma
Copy link
Member

@ambrahma ambrahma commented Nov 8, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • Added missing tag for typescript SDK generation for new API version

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@ambrahma ambrahma requested a review from qiaozha as a code owner November 8, 2023 04:47
Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.6) new version base version
default default(bdccb50) default(main)
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/postgresql/resource-manager/readme.md
tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking



azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - Approved - 10.2.0b11
+	Model PrivateLinkResource no longer has parameter properties
+	Removed operation PrivateEndpointConnectionsOperations.begin_create_or_update
+	Removed operation PrivateEndpointConnectionsOperations.begin_delete
+	Removed operation PrivateEndpointConnectionsOperations.begin_update_tags
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 5c72410. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation group PrivateEndpointConnectionOperations
    info	[Changelog]   - Added operation group QuotaUsagesOperations
    info	[Changelog]   - Added operation group ServerThreatProtectionSettingsOperations
    info	[Changelog]   - Added operation group VirtualEndpointsOperations
    info	[Changelog]   - Model MigrationResource has a new parameter migration_option
    info	[Changelog]   - Model MigrationResource has a new parameter source_type
    info	[Changelog]   - Model MigrationResource has a new parameter ssl_mode
    info	[Changelog]   - Model MigrationSubStateDetails has a new parameter db_details
    info	[Changelog]   - Model MigrationSubStateDetails has a new parameter validation_details
    info	[Changelog]   - Model PrivateEndpointConnection has a new parameter group_ids
    info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
    info	[Changelog]   - Model PrivateLinkResource has a new parameter group_id
    info	[Changelog]   - Model PrivateLinkResource has a new parameter required_members
    info	[Changelog]   - Model PrivateLinkResource has a new parameter required_zone_names
    info	[Changelog]   - Model PrivateLinkResource has a new parameter system_data
    info	[Changelog]   - Model Server has a new parameter private_endpoint_connections
    info	[Changelog]   - Model Server has a new parameter replica
    info	[Changelog]   - Model ServerForUpdate has a new parameter replica
    info	[Changelog]   - Model Storage has a new parameter throughput
    info	[Changelog]   - Model Storage has a new parameter type
    info	[Changelog]   - Model StorageMbCapability has a new parameter maximum_storage_size_mb
    info	[Changelog]   - Model StorageMbCapability has a new parameter supported_maximum_iops
    info	[Changelog]   - Model StorageMbCapability has a new parameter supported_maximum_throughput
    info	[Changelog]   - Model StorageMbCapability has a new parameter supported_throughput
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model PrivateLinkResource no longer has parameter properties
    info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_create_or_update
    info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_delete
    info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_update_tags
️⚠️ azure-sdk-for-java warning [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 5c72410. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/postgresql/armpostgresql [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/postgresql/armpostgresqlflexibleservers [View full logs]  [Release SDK Changes]
    Only show 60 items here, please refer to log for details.
    info	[Changelog] - New enum type `VirtualEndpointType` with values `VirtualEndpointTypeReadWrite`
    info	[Changelog] - New function `*ClientFactory.NewPrivateEndpointConnectionClient() *PrivateEndpointConnectionClient`
    info	[Changelog] - New function `*ClientFactory.NewPrivateEndpointConnectionsClient() *PrivateEndpointConnectionsClient`
    info	[Changelog] - New function `*ClientFactory.NewPrivateLinkResourcesClient() *PrivateLinkResourcesClient`
    info	[Changelog] - New function `*ClientFactory.NewQuotaUsagesClient() *QuotaUsagesClient`
    info	[Changelog] - New function `*ClientFactory.NewServerThreatProtectionSettingsClient() *ServerThreatProtectionSettingsClient`
    info	[Changelog] - New function `*ClientFactory.NewVirtualEndpointsClient() *VirtualEndpointsClient`
    info	[Changelog] - New function `NewPrivateEndpointConnectionClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateEndpointConnectionClient, error)`
    info	[Changelog] - New function `*PrivateEndpointConnectionClient.BeginDelete(context.Context, string, string, string, *PrivateEndpointConnectionClientBeginDeleteOptions) (*runtime.Poller[PrivateEndpointConnectionClientDeleteResponse], error)`
    info	[Changelog] - New function `*PrivateEndpointConnectionClient.BeginUpdate(context.Context, string, string, string, PrivateEndpointConnection, *PrivateEndpointConnectionClientBeginUpdateOptions) (*runtime.Poller[PrivateEndpointConnectionClientUpdateResponse], error)`
    info	[Changelog] - New function `NewPrivateEndpointConnectionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateEndpointConnectionsClient, error)`
    info	[Changelog] - New function `*PrivateEndpointConnectionsClient.Get(context.Context, string, string, string, *PrivateEndpointConnectionsClientGetOptions) (PrivateEndpointConnectionsClientGetResponse, error)`
    info	[Changelog] - New function `*PrivateEndpointConnectionsClient.NewListByServerPager(string, string, *PrivateEndpointConnectionsClientListByServerOptions) *runtime.Pager[PrivateEndpointConnectionsClientListByServerResponse]`
    info	[Changelog] - New function `NewPrivateLinkResourcesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateLinkResourcesClient, error)`
    info	[Changelog] - New function `*PrivateLinkResourcesClient.Get(context.Context, string, string, string, *PrivateLinkResourcesClientGetOptions) (PrivateLinkResourcesClientGetResponse, error)`
    info	[Changelog] - New function `*PrivateLinkResourcesClient.NewListByServerPager(string, string, *PrivateLinkResourcesClientListByServerOptions) *runtime.Pager[PrivateLinkResourcesClientListByServerResponse]`
    info	[Changelog] - New function `NewQuotaUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QuotaUsagesClient, error)`
    info	[Changelog] - New function `*QuotaUsagesClient.NewListPager(string, *QuotaUsagesClientListOptions) *runtime.Pager[QuotaUsagesClientListResponse]`
    info	[Changelog] - New function `NewServerThreatProtectionSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ServerThreatProtectionSettingsClient, error)`
    info	[Changelog] - New function `*ServerThreatProtectionSettingsClient.BeginCreateOrUpdate(context.Context, string, string, ThreatProtectionName, ServerThreatProtectionSettingsModel, *ServerThreatProtectionSettingsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ServerThreatProtectionSettingsClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*ServerThreatProtectionSettingsClient.Get(context.Context, string, string, ThreatProtectionName, *ServerThreatProtectionSettingsClientGetOptions) (ServerThreatProtectionSettingsClientGetResponse, error)`
    info	[Changelog] - New function `*ServerThreatProtectionSettingsClient.NewListByServerPager(string, string, *ServerThreatProtectionSettingsClientListByServerOptions) *runtime.Pager[ServerThreatProtectionSettingsClientListByServerResponse]`
    info	[Changelog] - New function `NewVirtualEndpointsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualEndpointsClient, error)`
    info	[Changelog] - New function `*VirtualEndpointsClient.BeginCreate(context.Context, string, string, string, VirtualEndpointResource, *VirtualEndpointsClientBeginCreateOptions) (*runtime.Poller[VirtualEndpointsClientCreateResponse], error)`
    info	[Changelog] - New function `*VirtualEndpointsClient.BeginDelete(context.Context, string, string, string, *VirtualEndpointsClientBeginDeleteOptions) (*runtime.Poller[VirtualEndpointsClientDeleteResponse], error)`
    info	[Changelog] - New function `*VirtualEndpointsClient.Get(context.Context, string, string, string, *VirtualEndpointsClientGetOptions) (VirtualEndpointsClientGetResponse, error)`
    info	[Changelog] - New function `*VirtualEndpointsClient.NewListByServerPager(string, string, *VirtualEndpointsClientListByServerOptions) *runtime.Pager[VirtualEndpointsClientListByServerResponse]`
    info	[Changelog] - New function `*VirtualEndpointsClient.BeginUpdate(context.Context, string, string, string, VirtualEndpointResourceForPatch, *VirtualEndpointsClientBeginUpdateOptions) (*runtime.Poller[VirtualEndpointsClientUpdateResponse], error)`
    info	[Changelog] - New struct `DbLevelValidationStatus`
    info	[Changelog] - New struct `DbMigrationStatus`
    info	[Changelog] - New struct `NameProperty`
    info	[Changelog] - New struct `PrivateEndpoint`
    info	[Changelog] - New struct `PrivateEndpointConnection`
    info	[Changelog] - New struct `PrivateEndpointConnectionListResult`
    info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
    info	[Changelog] - New struct `PrivateLinkResource`
    info	[Changelog] - New struct `PrivateLinkResourceListResult`
    info	[Changelog] - New struct `PrivateLinkResourceProperties`
    info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
    info	[Changelog] - New struct `QuotaUsage`
    info	[Changelog] - New struct `QuotaUsagesListResult`
    info	[Changelog] - New struct `Replica`
    info	[Changelog] - New struct `ServerThreatProtectionListResult`
    info	[Changelog] - New struct `ServerThreatProtectionProperties`
    info	[Changelog] - New struct `ServerThreatProtectionSettingsModel`
    info	[Changelog] - New struct `ValidationDetails`
    info	[Changelog] - New struct `ValidationMessage`
    info	[Changelog] - New struct `ValidationSummaryItem`
    info	[Changelog] - New struct `VirtualEndpointResource`
    info	[Changelog] - New struct `VirtualEndpointResourceForPatch`
    info	[Changelog] - New struct `VirtualEndpointResourceProperties`
    info	[Changelog] - New struct `VirtualEndpointsListResult`
    info	[Changelog] - New field `MigrationOption`, `SSLMode`, `SourceType` in struct `MigrationResourceProperties`
    info	[Changelog] - New field `DbDetails`, `ValidationDetails` in struct `MigrationSubStateDetails`
    info	[Changelog] - New field `PrivateEndpointConnections`, `Replica` in struct `ServerProperties`
    info	[Changelog] - New field `Replica` in struct `ServerPropertiesForUpdate`
    info	[Changelog] - New field `Throughput`, `Type` in struct `Storage`
    info	[Changelog] - New field `MaximumStorageSizeMb`, `SupportedMaximumIops`, `SupportedMaximumThroughput`, `SupportedThroughput` in struct `StorageMbCapability`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 144 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 5c72410. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    warn	No file changes detected after generation
    warn	No package detected after generation
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 5c72410. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.3
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️postgresql [View full logs]  [Release Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 5c72410. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.postgresql.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.postgresql.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/postgresql/armpostgresql There is no API change compared with the previous version
Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers https://apiview.dev/Assemblies/Review/9cb7d46504954ead9750268c8ad4bcd8
.Net Azure.ResourceManager.PostgreSql There is no API change compared with the previous version
Java azure-resourcemanager-postgresqlflexibleserver https://apiview.dev/Assemblies/Review/80950d20c21c4bac9fce9652be15570e

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is only TypeScript readme change I think we don't need ARM signoff. So I removed the WaitForARMFeedback lable.

@MaryGao MaryGao removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReview labels Nov 8, 2023
@MaryGao MaryGao merged commit 5c72410 into main Nov 8, 2023
29 of 31 checks passed
@MaryGao MaryGao deleted the ambrahma/fix-missingnew-api-version-tags branch November 8, 2023 05:47
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-SdkBreakingChange-Python ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants