Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/Azure/azure-rest-api-specs/issues/1697#iss… #2664

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix for https://github.com/Azure/azure-rest-api-specs/issues/1697#iss… #2664

merged 1 commit into from
Mar 23, 2018

Conversation

naveedaz
Copy link
Contributor

@naveedaz naveedaz commented Mar 14, 2018

…uecomment-367167726

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#4

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2065

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1430

@olydis olydis added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 15, 2018
@olydis
Copy link
Contributor

olydis commented Mar 15, 2018

@ravbhatnagar breaking change, however specifying any of these parameters (which were not meant for customer use) cause the service to fail (@naveedaz correct me if I'm wrong), rendering some SDKs unusable. See this issue for more info.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 22
After the PR: Warning(s): 0 Error(s): 22

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@naveedaz
Copy link
Contributor Author

@ravbhatnagar Can we get this approved please. Customers are asking for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants