Update Instance Pool API version to preview 2023-05-01 #26666

MilanNz · 2023-11-10T12:22:31Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

[x ] New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-11-10T12:22:38Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-11-10T12:22:39Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.1.6)	new version	base version
default	default(8ec0b01)	default(main)

️❌Avocado: 168 Errors, 1 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/RecoverableDatabases.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/ReplicationLinks.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/databases/{}/replicationLinks/{}/unlink` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01-legacy/replicationLinks_legacy.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/ServerUsages.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/ServerAdvisors.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/DatabaseAdvisors.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/RestorableDroppedDatabases.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/LocationCapabilities.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/Servers.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/ServerConnectionPolicies.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/Databases.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/elasticPools/{}/databases/{}` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/databases.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/recommendedElasticPools/{}/databases/{}` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/databases.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/recommendedElasticPools/{}/databases` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/databases.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/DatabaseSecurityAlertPolicies.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/DataMaskingPolicies.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/DataMaskingRules.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/TransparentDataEncryptions.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/DatabaseExtensions.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/disasterRecoveryConfiguration` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/disasterRecoveryConfigurations.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/disasterRecoveryConfiguration/{}` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/disasterRecoveryConfigurations.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/disasterRecoveryConfiguration/{}/failover` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/disasterRecoveryConfigurations.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/disasterRecoveryConfiguration/{}/forceFailoverAllowDataLoss` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/disasterRecoveryConfigurations.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/ElasticPools.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/FirewallRules.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/GeoBackupPolicies.json
`❌` NOT_LATEST_API_VERSION_IN_DEFAULT_TAG	The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-05-01-preview/Operations.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/databases/{}/topQueries` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/queries.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/databases/{}/topQueries/{}/statistics` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/queries.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/servers/{}/databases/{}/topQueries/{}/queryText` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/stable/2014-04-01/queries.json

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-10T12:22:40Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/sql/armsql - Approved - 2.0.0-beta.3

-	Enum `ManagedInstancePropertiesProvisioningState` has been removed
-	Enum `PrimaryAggregationType` has been removed
-	Enum `ReplicationMode` has been removed
-	Enum `ServiceObjectiveName` has been removed
-	Enum `UnitDefinitionType` has been removed
-	Enum `UnitType` has been removed
-	Enum `UpsertManagedServerOperationStepStatus` has been removed
-	Field `CurrentValue`, `DisplayName`, `Limit`, `NextResetTime`, `ResourceName`, `Unit` of struct `ServerUsage` has been removed
-	Field `LastHardenedLsn`, `LinkState`, `PrimaryAvailabilityGroupName`, `SecondaryAvailabilityGroupName`, `SourceEndpoint`, `SourceReplicaID`, `TargetDatabase`, `TargetReplicaID` of struct `DistributedAvailabilityGroupProperties` has been removed
-	Field `ZoneRedundant` of struct `ManagedInstanceEditionCapability` has been removed
-	Function `*ClientFactory.NewElasticPoolActivitiesClient` has been removed
-	Function `*ClientFactory.NewElasticPoolDatabaseActivitiesClient` has been removed
-	Function `*ClientFactory.NewServerCommunicationLinksClient` has been removed
-	Function `*ClientFactory.NewServiceObjectivesClient` has been removed
-	Function `*DataMaskingPoliciesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, DataMaskingPolicy, *DataMaskingPoliciesClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, DataMaskingPolicyName, DataMaskingPolicy, *DataMaskingPoliciesClientCreateOrUpdateOptions)`
-	Function `*DataMaskingPoliciesClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, *DataMaskingPoliciesClientGetOptions)` to `(context.Context, string, string, string, DataMaskingPolicyName, *DataMaskingPoliciesClientGetOptions)`
-	Function `*DataMaskingRulesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, string, DataMaskingRule, *DataMaskingRulesClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, DataMaskingPolicyName, string, DataMaskingRule, *DataMaskingRulesClientCreateOrUpdateOptions)`
-	Function `*DataMaskingRulesClient.NewListByDatabasePager` parameter(s) have been changed from `(string, string, string, *DataMaskingRulesClientListByDatabaseOptions)` to `(string, string, string, DataMaskingPolicyName, *DataMaskingRulesClientListByDatabaseOptions)`
-	Function `*DatabasesClient.NewListMetricDefinitionsPager` has been removed
-	Function `*DatabasesClient.NewListMetricsPager` has been removed
-	Function `*DistributedAvailabilityGroupsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, DistributedAvailabilityGroup, *DistributedAvailabilityGroupsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, string, DistributedAvailabilityGroupsCreateOrUpdateRequestBody, *DistributedAvailabilityGroupsClientBeginCreateOrUpdateOptions)`
-	Function `*ElasticPoolActivitiesClient.NewListByElasticPoolPager` has been removed
-	Function `*ElasticPoolDatabaseActivitiesClient.NewListByElasticPoolPager` has been removed
-	Function `*ElasticPoolsClient.NewListMetricDefinitionsPager` has been removed
-	Function `*ElasticPoolsClient.NewListMetricsPager` has been removed
-	Function `*GeoBackupPoliciesClient.NewListByDatabasePager` has been removed
-	Function `*ManagedServerSecurityAlertPoliciesClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, SecurityAlertPolicyName, ManagedServerSecurityAlertPolicy, *ManagedServerSecurityAlertPoliciesClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, SecurityAlertPolicyNameAutoGenerated, ManagedServerSecurityAlertPolicy, *ManagedServerSecurityAlertPoliciesClientBeginCreateOrUpdateOptions)`
-	Function `*ManagedServerSecurityAlertPoliciesClient.Get` parameter(s) have been changed from `(context.Context, string, string, SecurityAlertPolicyName, *ManagedServerSecurityAlertPoliciesClientGetOptions)` to `(context.Context, string, string, SecurityAlertPolicyNameAutoGenerated, *ManagedServerSecurityAlertPoliciesClientGetOptions)`
-	Function `*OutboundFirewallRulesClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, OutboundFirewallRule, *OutboundFirewallRulesClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, string, *OutboundFirewallRulesClientBeginCreateOrUpdateOptions)`
-	Function `*ServerCommunicationLinksClient.BeginCreateOrUpdate` has been removed
-	Function `*ServerCommunicationLinksClient.Delete` has been removed
-	Function `*ServerCommunicationLinksClient.Get` has been removed
-	Function `*ServerCommunicationLinksClient.NewListByServerPager` has been removed
-	Function `*ServerSecurityAlertPoliciesClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, SecurityAlertPolicyName, ServerSecurityAlertPolicy, *ServerSecurityAlertPoliciesClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, SecurityAlertPolicyNameAutoGenerated, ServerSecurityAlertPolicy, *ServerSecurityAlertPoliciesClientBeginCreateOrUpdateOptions)`
-	Function `*ServerSecurityAlertPoliciesClient.Get` parameter(s) have been changed from `(context.Context, string, string, SecurityAlertPolicyName, *ServerSecurityAlertPoliciesClientGetOptions)` to `(context.Context, string, string, SecurityAlertPolicyNameAutoGenerated, *ServerSecurityAlertPoliciesClientGetOptions)`
-	Function `*ServiceObjectivesClient.Get` has been removed
-	Function `*ServiceObjectivesClient.NewListByServerPager` has been removed
-	Function `NewElasticPoolActivitiesClient` has been removed
-	Function `NewElasticPoolDatabaseActivitiesClient` has been removed
-	Function `NewServerCommunicationLinksClient` has been removed
-	Function `NewServiceObjectivesClient` has been removed
-	Struct `ElasticPoolActivityListResult` has been removed
-	Struct `ElasticPoolActivityProperties` has been removed
-	Struct `ElasticPoolActivity` has been removed
-	Struct `ElasticPoolDatabaseActivityListResult` has been removed
-	Struct `ElasticPoolDatabaseActivityProperties` has been removed
-	Struct `ElasticPoolDatabaseActivity` has been removed
-	Struct `MetricAvailability` has been removed
-	Struct `MetricDefinitionListResult` has been removed
-	Struct `MetricDefinition` has been removed
-	Struct `MetricListResult` has been removed
-	Struct `MetricName` has been removed
-	Struct `MetricValue` has been removed
-	Struct `Metric` has been removed
-	Struct `OperationImpact` has been removed
-	Struct `ServerCommunicationLinkListResult` has been removed
-	Struct `ServerCommunicationLinkProperties` has been removed
-	Struct `ServerCommunicationLink` has been removed
-	Struct `ServiceObjectiveListResult` has been removed
-	Struct `ServiceObjectiveProperties` has been removed
-	Struct `ServiceObjective` has been removed
-	Struct `SloUsageMetric` has been removed
-	Struct `UpsertManagedServerOperationStep` has been removed
-	Type of `DistributedAvailabilityGroupProperties.ReplicationMode` has been changed from `*ReplicationMode` to `*ReplicationModeType`
-	Type of `JobExecutionsClientListByAgentOptions.Skip` has been changed from `*int32` to `*int64`
-	Type of `JobExecutionsClientListByAgentOptions.Top` has been changed from `*int32` to `*int64`
-	Type of `JobExecutionsClientListByJobOptions.Skip` has been changed from `*int32` to `*int64`
-	Type of `JobExecutionsClientListByJobOptions.Top` has been changed from `*int32` to `*int64`
-	Type of `JobStepExecutionsClientListByJobExecutionOptions.Skip` has been changed from `*int32` to `*int64`
-	Type of `JobStepExecutionsClientListByJobExecutionOptions.Top` has been changed from `*int32` to `*int64`
-	Type of `JobTargetExecutionsClientListByJobExecutionOptions.Skip` has been changed from `*int32` to `*int64`
-	Type of `JobTargetExecutionsClientListByJobExecutionOptions.Top` has been changed from `*int32` to `*int64`
-	Type of `JobTargetExecutionsClientListByStepOptions.Skip` has been changed from `*int32` to `*int64`
-	Type of `JobTargetExecutionsClientListByStepOptions.Top` has been changed from `*int32` to `*int64`
-	Type of `LongTermRetentionPolicy.Properties` has been changed from `*BaseLongTermRetentionPolicyProperties` to `*LongTermRetentionPolicyProperties`
-	Type of `ManagedDatabaseSecurityEventsClientListByDatabaseOptions.Skip` has been changed from `*int32` to `*int64`
-	Type of `ManagedDatabaseSecurityEventsClientListByDatabaseOptions.Top` has been changed from `*int32` to `*int64`
-	Type of `ManagedInstanceOperationSteps.StepsList` has been changed from `[]*UpsertManagedServerOperationStep` to `[]*UpsertManagedServerOperationStepWithEstimatesAndDuration`
-	Type of `ManagedInstanceProperties.ProvisioningState` has been changed from `*ManagedInstancePropertiesProvisioningState` to `*ProvisioningState`
+	Function `*timeRFC3339.Parse` has been removed
+	Function `*timeRFC3339.UnmarshalText` has been removed
+	Function `timeRFC3339.MarshalText` has been removed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 930319b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.3` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-sql [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group JobPrivateEndpointsOperations
info	[Changelog]   - Model FailoverGroupReadOnlyEndpoint has a new parameter target_server
info	[Changelog]   - Model FailoverGroupUpdate has a new parameter partner_servers
info	[Changelog]   - Model InstancePool has a new parameter dns_zone
info	[Changelog]   - Model InstancePool has a new parameter maintenance_configuration_id
info	[Changelog]   - Model InstancePoolUpdate has a new parameter dns_zone
info	[Changelog]   - Model InstancePoolUpdate has a new parameter license_type
info	[Changelog]   - Model InstancePoolUpdate has a new parameter maintenance_configuration_id
info	[Changelog]   - Model InstancePoolUpdate has a new parameter sku
info	[Changelog]   - Model InstancePoolUpdate has a new parameter subnet_id
info	[Changelog]   - Model InstancePoolUpdate has a new parameter v_cores
info	[Changelog]   - Model Server has a new parameter is_i_pv6_enabled
info	[Changelog]   - Model ServerUpdate has a new parameter is_i_pv6_enabled

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 930319b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Sql [View full logs] [Release SDK Changes]
- Azure.ResourceManager.Sql.1.3.0-alpha.20231114.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 930319b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-sql-generated [View full logs] [Release SDK Changes]
- pom.xml

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 930319b. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/sql/armsql [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `timeRFC3339.MarshalText` has been removed
info	[Changelog] - Function `*timeRFC3339.Parse` has been removed
info	[Changelog] - Function `*timeRFC3339.UnmarshalText` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `*ClientFactory.NewJobPrivateEndpointsClient() *JobPrivateEndpointsClient`
info	[Changelog] - New function `NewJobPrivateEndpointsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobPrivateEndpointsClient, error)`
info	[Changelog] - New function `*JobPrivateEndpointsClient.BeginCreateOrUpdate(context.Context, string, string, string, string, JobPrivateEndpoint, *JobPrivateEndpointsClientBeginCreateOrUpdateOptions) (*runtime.Poller[JobPrivateEndpointsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*JobPrivateEndpointsClient.BeginDelete(context.Context, string, string, string, string, *JobPrivateEndpointsClientBeginDeleteOptions) (*runtime.Poller[JobPrivateEndpointsClientDeleteResponse], error)`
info	[Changelog] - New function `*JobPrivateEndpointsClient.Get(context.Context, string, string, string, string, *JobPrivateEndpointsClientGetOptions) (JobPrivateEndpointsClientGetResponse, error)`
info	[Changelog] - New function `*JobPrivateEndpointsClient.NewListByAgentPager(string, string, string, *JobPrivateEndpointsClientListByAgentOptions) *runtime.Pager[JobPrivateEndpointsClientListByAgentResponse]`
info	[Changelog] - New function `dateTimeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `*dateTimeRFC3339.Parse(string) error`
info	[Changelog] - New function `*dateTimeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New struct `JobPrivateEndpoint`
info	[Changelog] - New struct `JobPrivateEndpointListResult`
info	[Changelog] - New struct `JobPrivateEndpointProperties`
info	[Changelog] - New field `DNSZone`, `MaintenanceConfigurationID` in struct `InstancePoolProperties`
info	[Changelog] - New field `Properties`, `SKU` in struct `InstancePoolUpdate`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 17 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 930319b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-sql [View full logs] [Release SDK Changes]

azure-arm-sql-10.1.0-beta.3.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group JobPrivateEndpoints
info	[Changelog]   - Added operation FailoverGroups.beginTryPlannedBeforeForcedFailover
info	[Changelog]   - Added operation FailoverGroups.beginTryPlannedBeforeForcedFailoverAndWait
info	[Changelog]   - Added Interface FailoverGroupsTryPlannedBeforeForcedFailoverHeaders
info	[Changelog]   - Added Interface FailoverGroupsTryPlannedBeforeForcedFailoverOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpoint
info	[Changelog]   - Added Interface JobPrivateEndpointListResult
info	[Changelog]   - Added Interface JobPrivateEndpointsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpointsDeleteOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpointsGetOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpointsListByAgentNextOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpointsListByAgentOptionalParams
info	[Changelog]   - Added Type Alias FailoverGroupsTryPlannedBeforeForcedFailoverResponse
info	[Changelog]   - Added Type Alias FreeLimitExhaustionBehavior
info	[Changelog]   - Added Type Alias JobPrivateEndpointsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias JobPrivateEndpointsGetResponse
info	[Changelog]   - Added Type Alias JobPrivateEndpointsListByAgentNextResponse
info	[Changelog]   - Added Type Alias JobPrivateEndpointsListByAgentResponse
info	[Changelog]   - Interface Database has a new optional parameter encryptionProtectorAutoRotation
info	[Changelog]   - Interface Database has a new optional parameter freeLimitExhaustionBehavior
info	[Changelog]   - Interface Database has a new optional parameter useFreeLimit
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter encryptionProtectorAutoRotation
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter freeLimitExhaustionBehavior
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter useFreeLimit
info	[Changelog]   - Interface ElasticPool has a new optional parameter availabilityZone
info	[Changelog]   - Interface ElasticPool has a new optional parameter minCapacity
info	[Changelog]   - Interface ElasticPool has a new optional parameter preferredEnclaveType
info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter availabilityZone
info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter minCapacity
info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter preferredEnclaveType
info	[Changelog]   - Interface FailoverGroupReadOnlyEndpoint has a new optional parameter targetServer
info	[Changelog]   - Interface FailoverGroupUpdate has a new optional parameter partnerServers
info	[Changelog]   - Interface InstancePool has a new optional parameter dnsZone
info	[Changelog]   - Interface InstancePool has a new optional parameter maintenanceConfigurationId
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter dnsZone
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter licenseType
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter maintenanceConfigurationId
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter sku
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter subnetId
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter vCores
info	[Changelog]   - Interface ManagedDatabase has a new optional parameter isLedgerOn
info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter isLedgerOn
info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter groupIds
info	[Changelog]   - Interface Server has a new optional parameter isIPv6Enabled
info	[Changelog]   - Interface ServerUpdate has a new optional parameter isIPv6Enabled
info	[Changelog]   - Interface SqlVulnerabilityAssessmentScanRecord has a new optional parameter lastScanTime
info	[Changelog]   - Added Enum KnownFreeLimitExhaustionBehavior

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 930319b. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.3
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.3` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️sql [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 930319b. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.sql.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.sql.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-10T12:22:41Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/sql/armsql	Create ApiView timeout. Package is too large and we cannot create ApiView for it.
.Net	Azure.ResourceManager.Sql	https://apiview.dev/Assemblies/Review/7f0cdfec789e49259767afdc2228d790
JavaScript	@azure/arm-sql	https://apiview.dev/Assemblies/Review/25afea1d171342478a56ad45eac156eb

ericshape · 2023-11-13T17:26:09Z

specification/sql/resource-manager/readme.md

@@ -1174,7 +1174,7 @@ input-file:
 - ./Microsoft.Sql/preview/2020-11-01-preview/ElasticPoolOperations.json
 - ./Microsoft.Sql/preview/2020-11-01-preview/EncryptionProtectors.json
 - ./Microsoft.Sql/preview/2020-11-01-preview/FirewallRules.json
- ./Microsoft.Sql/preview/2020-11-01-preview/InstancePools.json
+- ./Microsoft.Sql/preview/2023-05-01-preview/InstancePools.json


please remove this line and put 2023-05-01-preview in the bottom of V5 section (by alphabetical order)

ericshape · 2023-11-13T17:29:49Z

specification/sql/resource-manager/readme.md

@@ -1174,7 +1174,7 @@ input-file:
 - ./Microsoft.Sql/preview/2020-11-01-preview/ElasticPoolOperations.json
 - ./Microsoft.Sql/preview/2020-11-01-preview/EncryptionProtectors.json
 - ./Microsoft.Sql/preview/2020-11-01-preview/FirewallRules.json


Please also modify Line 27 tag to "package-composite-v5"

About the revert and corresponding failed pipeline, please check my comment in another PR: #26683 (comment)

You could either add it or wait #26683 (comment) merge.

ericshape · 2023-11-14T17:36:57Z

ARM reviewers and @rkmanda , we revert "package-composite-v5" for downstream SDK client generation.

It was charged to "package-preview-2023-05" by mistake. Thus, all the Avacado failed pipelines could be ignored.

At the same time, all the failed messages in "Swagger SDK Breaking Change Tracking failed" should be ignored.

ericshape · 2023-11-14T17:38:55Z

all tags have been approved.

it is ready to merge

ericshape · 2023-11-14T17:39:38Z

/pr RequestMerge

openapi-pipeline-app · 2023-11-14T21:00:32Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

* Update Instance Pool API version to preview 2023-05-01 * Change default tag version and sort api by alphabetical order

Update Instance Pool API version to preview 2023-05-01

45d30b2

MilanNz requested review from jamestao, ericshape and jeremyfrosti as code owners November 10, 2023 12:22

openapi-assignment-bot bot assigned rkmanda Nov 10, 2023

azure-sdk mentioned this pull request Nov 10, 2023

[AutoPR sdk/resourcemanager/sql/armsql] Update Instance Pool API version to preview 2023-05-01 azure-sdk/azure-sdk-for-go#8197

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 10, 2023

AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 10, 2023

This was referenced Nov 10, 2023

[AutoPR azure-resourcemanager-sql-generated] Update Instance Pool API version to preview 2023-05-01 azure-sdk/azure-sdk-for-java#8467

Closed

[AutoPR @azure/arm-sql] Update Instance Pool API version to preview 2023-05-01 azure-sdk/azure-sdk-for-js#7635

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Nov 10, 2023

This was referenced Nov 10, 2023

[AutoPR Azure.ResourceManager.Sql] Update Instance Pool API version to preview 2023-05-01 azure-sdk/azure-sdk-for-net#6183

Closed

[AutoPR track2_azure-mgmt-sql] Update Instance Pool API version to preview 2023-05-01 azure-sdk/azure-sdk-for-python#5349

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Nov 10, 2023

azure-sdk mentioned this pull request Nov 10, 2023

[AutoPR sql] Update Instance Pool API version to preview 2023-05-01 azure-sdk/azure-resource-manager-schemas#3636

Closed

zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 10, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 10, 2023

msyyc added the Approved-SdkBreakingChange-Python label Nov 13, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Nov 13, 2023

ericshape reviewed Nov 13, 2023

View reviewed changes

ericshape mentioned this pull request Nov 14, 2023

Update ReadMe file of 2023-05-01 swagger LongTermRetentionBackups and LongTermRetentionPolicies #26683

Merged

4 tasks

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 14, 2023

Change default tag version and sort api by alphabetical order

8ec0b01

ericshape approved these changes Nov 14, 2023

View reviewed changes

microsoft-github-policy-service bot added the MergeRequested label Nov 14, 2023

TimLovellSmith merged commit 930319b into Azure:main Nov 14, 2023
28 of 31 checks passed

ericshape mentioned this pull request Dec 18, 2023

Revert client tag to package-composite-v5 #26809

Merged

6 tasks

zman-ms pushed a commit that referenced this pull request Jan 10, 2024

Update Instance Pool API version to preview 2023-05-01 (#26666)

eafc78a

* Update Instance Pool API version to preview 2023-05-01 * Change default tag version and sort api by alphabetical order

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Instance Pool API version to preview 2023-05-01 #26666

Update Instance Pool API version to preview 2023-05-01 #26666

MilanNz commented Nov 10, 2023

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

ericshape Nov 13, 2023

ericshape Nov 13, 2023

ericshape Nov 14, 2023

ericshape commented Nov 14, 2023

ericshape commented Nov 14, 2023

ericshape commented Nov 14, 2023

openapi-pipeline-app bot commented Nov 14, 2023

Update Instance Pool API version to preview 2023-05-01 #26666

Update Instance Pool API version to preview 2023-05-01 #26666

Conversation

MilanNz commented Nov 10, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading

Generated ApiView

ericshape Nov 13, 2023

Choose a reason for hiding this comment

ericshape Nov 13, 2023

Choose a reason for hiding this comment

ericshape Nov 14, 2023

Choose a reason for hiding this comment

ericshape commented Nov 14, 2023

ericshape commented Nov 14, 2023

ericshape commented Nov 14, 2023

openapi-pipeline-app bot commented Nov 14, 2023

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading