Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppInsights x-ms-parameter-location #2680

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Fix AppInsights x-ms-parameter-location #2680

merged 1 commit into from
Mar 19, 2018

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Mar 16, 2018

No description provided.

@lmazuel lmazuel self-assigned this Mar 16, 2018
@lmazuel lmazuel requested a review from dsgouda March 16, 2018 17:52
@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2022

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmppuwaqd77/rest/specification/applicationinsights/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmppuwaqd77/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4255/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4255)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.49)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/applicationinsights/implementation/FavoritesInner.java
   at AutoRest.Core.CodeGenerator.<Write>d__13.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.<Generate>d__6.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISHedxhk\164_20180307T193002\autorest.java\src\azurefluent\CodeGeneratorJvaf.cs:line 57
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISHedxhk\164_20180307T193002\autorest.java\src\Program.cs:line 115
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Process() cancelled due to exception : Plugin java reported failure.
  Error: Plugin java reported failure.

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1263

@lmazuel
Copy link
Member Author

lmazuel commented Mar 16, 2018

@d3r3kk We added some rules in our CI, and now "x-ms-parameter-location" is a required parameter for all global parameters.
I tried to fix the Swagger to fix the CI, but would appreciate if you confirm this is the correct fix in your scenario.
Thank you!

@lmazuel lmazuel requested a review from d3r3kk March 16, 2018 18:30
@d3r3kk
Copy link
Member

d3r3kk commented Mar 16, 2018

This looks correct to me, let me ask the experts on the team if they can look at it to confirm.

@lmazuel
Copy link
Member Author

lmazuel commented Mar 19, 2018

Got SKype approval from @frankguodongchen as well, merging

@lmazuel lmazuel merged commit 7c3b723 into Azure:master Mar 19, 2018
@lmazuel lmazuel deleted the fixappinsightmethod branch March 19, 2018 21:27
frankguodongchen added a commit to frankguodongchen/azure-rest-api-specs that referenced this pull request Mar 19, 2018
frankguodongchen added a commit to frankguodongchen/azure-rest-api-specs that referenced this pull request Mar 19, 2018
lmazuel pushed a commit that referenced this pull request Mar 20, 2018
…nd migration apis) (#2618)

* add capabilities related apis

* remove unnecesary change in pacakge.json

* update for code review feedback

* add preview api for new pricing version and migration related api

* fix typo

* fix for x-ms-long-running-operation required for purge api

* Revert "Fix AppInsights x-ms-parameter-location (#2680)"

This reverts commit 7c3b723.

* Revert "Revert "Fix AppInsights x-ms-parameter-location (#2680)""

This reverts commit 2685ce7.

* Revert "fix for x-ms-long-running-operation required for purge api"

This reverts commit 450ec6d.

* change microsoft.insights to Microsoft.Insights

* fix ova error and remove preview api from go sdk

* Remove extra space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants