Added/Updating Logic Apps Management Client endpoints #2727
Conversation
|
Reid, are you able to add Logic App engineers as reviewers for this PR? We should get all the authors of the operations you are adding coverage for to review their piece. |
I'm not super familiar with github's ui, I'll see if I can figure out how to add them |
| "properties": { | ||
| "value": { | ||
| "description": "Collection of resources", | ||
|
|
There was a problem hiding this comment.
impersonate a user account
Doesn't have to be the author's user account.
| "properties": { | ||
| "value": { | ||
| "description": "Collection of resources", | ||
|
|
There was a problem hiding this comment.
should oauthSettings be two words and capitalized for English language instead of the programming language Camel casing of a variable name?
There was a problem hiding this comment.
Since oathSettings isn't a property contained within this document. I think it better to use the English version of it.
| "type": "string" | ||
| }, | ||
| "etag": { | ||
| "description": "Resource etag", |
There was a problem hiding this comment.
Check if the casing should be ETag as it is an acronym.
| }, | ||
| "filterParameter": { | ||
| "name": "$filter", | ||
| "description": "The filter to apply on the operation.", |
There was a problem hiding this comment.
most sentences in this do not end with a dot so likely neither should this one.
| "exportParameter": { | ||
| "type": "string", | ||
| "name": "export", | ||
| "description": "flag showing whether to export API definition in format specified by Accept header", |
| "parameters": { | ||
| "locationParameter": { | ||
| "name": "location", | ||
| "description": "The location.", |
There was a problem hiding this comment.
consistent ending of lines with or without dot
There was a problem hiding this comment.
Made consistent all over by removing them
| "tags": [ | ||
| "Connections" | ||
| ], | ||
| "summary": "Update an existing connection", |
There was a problem hiding this comment.
should all operations have a summary like this one? delete below doesn't
There was a problem hiding this comment.
Yes, they all should. Will doublecheck all of them
| ], | ||
| "summary": "Update an existing connection", | ||
| "operationId": "Connections_Update", | ||
| "description": "Update a connection", |
There was a problem hiding this comment.
Verb is with present tense below, i.e. Deletes
Should this here be Updates then?
| "tags": [ | ||
| "Custom APIs" | ||
| ], | ||
| "summary": "Moves the Custom API", |
There was a problem hiding this comment.
consistent capitalization for custom in custom API
| ], | ||
| "summary": "Gets a specific gateway", | ||
| "operationId": "ConnectionGateways_Get", | ||
| "description": "Gets a specific gateway for under a subscription and in a specific resource group", |
There was a problem hiding this comment.
"for under" is that proper English? above was just "under"
There was a problem hiding this comment.
Nope, that is not proper English. Fixed
|
Need the examples files. Going to close this till those are done |
Automation for azure-sdk-for-nodeEncountered a Subprocess error: (azure-sdk-for-node)
Command: ['/usr/local/bin/autorest', '/tmp/tmpdie3d2x7/rest/specification/web/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpdie3d2x7/sdk', '--nodejs'] AutoRest code generation utility [version: 2.0.4259; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4259/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4259)
Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (~2.1.25->2.1.32)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down |
Automation for azure-libraries-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger