Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logicAppsManagementClient.json to current offerings #2761

Merged
merged 18 commits into from
Mar 29, 2018
Merged

Update logicAppsManagementClient.json to current offerings #2761

merged 18 commits into from
Mar 29, 2018

Conversation

refortie
Copy link
Contributor

@refortie refortie commented Mar 27, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

refortie added 5 commits March 21, 2018 15:29
@refortie
Added missing endpoints to swagger and updated existing endpoints
106212d
@refortie
Add examples to support swagger
b042890 
Added examples to support the swagger endpoints. Did some cleanup
on the swagger itself, such as organizing the parameters
alphabetically.
@refortie
PR changes
bd42802
@refortie
PR Updates
3212743
@refortie
PR Updates
a708b01
@azuresdkci azuresdkci requested a review from jhendrixMSFT March 27, 2018 23:22
@AutorestCI AutorestCI mentioned this pull request Mar 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 27, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2065

@AutorestCI AutorestCI mentioned this pull request Mar 27, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 27, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1456

@AutorestCI AutorestCI mentioned this pull request Mar 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 27, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#4

@AutorestCI AutorestCI mentioned this pull request Mar 27, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 27, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2568

jhendrixMSFT
jhendrixMSFT requested changes Mar 28, 2018
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are model validation errors with regards to samples, please see the log here.
Also this new swagger has not been added to any package in the README.md file, is that intentional?

@refortie
Copy link
Contributor Author

@jhendrixMSFT Fixed the model build. I'm not sure what you mean by the readme.md file

@jhendrixMSFT
Copy link
Member

@refortie thanks I'll review the changes. The README file here. If you want your new swagger to get included in SDKs then you must add it to the appropriate package(s) in the README.

@jhendrixMSFT
Copy link
Member

@refortie Also has this new API been reviewed by ARM and the API review board?

jhendrixMSFT
jhendrixMSFT requested changes Mar 29, 2018
View reviewed changes
...fication/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json Outdated
"Connection Gateways"
],
"summary": "Lists all of the connection gateways",
"operationId": "ConnectionGateways_ListAll",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ConnectionGateways_List.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

...fication/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json
"Connection Gateways"
],
"summary": "Lists all of the connection gateways",
"operationId": "ConnectionGateways_List",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ConnectionGateways_ListByResourceGroup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

...fication/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json Outdated
"Custom APIs"
],
"summary": "List of custom APIs",
"operationId": "CustomApis_ListAll",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be CustomApis_List.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

...fication/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json
"Custom APIs"
],
"summary": "List of custom APIs",
"operationId": "CustomApis_List",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be CustomApis_ListByResourceGroup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@refortie
Copy link
Contributor Author

We will be holding off on adding it to the SDK for the time being. We will be coming back next month to do more endpoints. This is just to bring us up to compliance.

Also this isn't a new API, these APIs have already existed in prod for a while now, this is just to put out swagger for them.

@jhendrixMSFT jhendrixMSFT merged commit 9f1cdba into Azure:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refortie @AutorestCI @jhendrixMSFT