Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't support python and output folder was incorrect. #2876

Merged
merged 2 commits into from
Apr 14, 2018

Conversation

deathly809
Copy link
Member

@deathly809 deathly809 commented Apr 13, 2018

My output-folder was wrong, have to have

    output-folder: $(csharp-sdks-folder)/Generated

Also, removed python as we don't support it currenlty.

@AutorestCI
Copy link

AutorestCI commented Apr 13, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Apr 13, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Apr 13, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Apr 13, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/azsadmin/resource-manager/gallery/readme.md
Before the PR: Warning(s): 3 Error(s): 0
After the PR: Warning(s): 3 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@@ -48,26 +48,6 @@ csharp:
license-header: MICROSOFT_MIT_NO_VERSION
namespace: Microsoft.AzureStack.Management.Gallery.Admin
payload-flattening-threshold: 1
output-folder: Generated
output-folder: $(csharp-sdks-folder)/Generated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that the generate.cmd/ps1 you create pass in this parameter

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 4a58a3b into Azure:master Apr 14, 2018
@marstr marstr assigned dsgouda and unassigned marstr Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants