Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update securityPostureReference in VMScaleSet API #28891

Merged
merged 14 commits into from
Jun 5, 2024
Merged

Update securityPostureReference in VMScaleSet API #28891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
98b386f
update securityPostureRef properties in VMScaleSet spec
Apr 17, 2024
75ee1fe
add securityPostureReference to UpdateVMProfile definition and fix mi…
May 6, 2024
2ca7291
add prettier changes
May 6, 2024
198f2d1
remove unsupported 'major.*' from spec
May 8, 2024
f742eea
add optional fields in security posture example
May 8, 2024
0f8032d
add required fields
May 13, 2024
c8a369e
correct minimum api version
May 15, 2024
283d7e3
add prettier fixes
May 15, 2024
2431064
remove extensionsSettings property
May 22, 2024
fbd440f
create new Update model for security posture reference & update
May 24, 2024
19c12c8
fix validation issue
May 28, 2024
e6c4fd8
Create sdk-suppressions.yaml
msyyc May 29, 2024
3c59e22
add azure-sdk-for-go suppression
Alancere May 29, 2024
8434bfb
Update sdk-suppressions.yaml
kazrael2119 May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions ...alMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
"overprovision": true,
"virtualMachineProfile": {
"securityPostureReference": {
"id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|{major.*}|latest"
"id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest",
"excludeExtensions": [
"{securityPostureVMExtensionName}"
],
"isOverridable": true
},
"storageProfile": {
"imageReference": {
Expand Down Expand Up @@ -81,7 +85,11 @@
"uniqueId": "d12ccb3d-ab15-4794-9836-c4196392e9f2",
"virtualMachineProfile": {
"securityPostureReference": {
"id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|{major.*}|latest"
"id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest",
"excludeExtensions": [
"{securityPostureVMExtensionName}"
],
"isOverridable": true
},
"storageProfile": {
"imageReference": {
Expand Down Expand Up @@ -159,7 +167,11 @@
"uniqueId": "d12ccb3d-ab15-4794-9836-c4196392e9f2",
"virtualMachineProfile": {
"securityPostureReference": {
"id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|{major.*}|latest"
"id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest",
"excludeExtensions": [
"{securityPostureVMExtensionName}"
],
"isOverridable": true
},
"storageProfile": {
"imageReference": {
Expand Down
42 changes: 37 additions & 5 deletions ...esource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5181,7 +5181,7 @@
},
"securityPostureReference": {
"$ref": "#/definitions/SecurityPostureReference",
"description": "Specifies the security posture to be used for all virtual machines in the scale set. Minimum api-version: 2023-03-01"
"description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01"
},
"timeCreated": {
"readOnly": true,
Expand All @@ -5206,6 +5206,10 @@
"$ref": "#/definitions/VirtualMachineScaleSetUpdateNetworkProfile",
"description": "The virtual machine scale set network profile."
},
"securityPostureReference": {
"$ref": "#/definitions/SecurityPostureReferenceUpdate",
"description": "The virtual machine scale set security posture reference."
},
"securityProfile": {
"$ref": "./computeRPCommon.json#/definitions/SecurityProfile",
"description": "The virtual machine scale set Security profile"
Expand Down Expand Up @@ -6336,17 +6340,45 @@
"properties": {
"id": {
martinezdylan marked this conversation as resolved.
Show resolved Hide resolved
"type": "string",
"description": "The security posture reference id in the form of /CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|{major.*}|latest"
"description": "The security posture reference id in the form of /CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest"
},
"excludeExtensions": {
"type": "array",
"items": {
"$ref": "./virtualMachine.json#/definitions/VirtualMachineExtension"
"type": "string"
},
"description": "List of virtual machine extensions to exclude when applying the Security Posture."
"description": "The list of virtual machine extension names to exclude when applying the security posture."
},
"isOverridable": {
martinezdylan marked this conversation as resolved.
Show resolved Hide resolved
"type": "boolean",
"description": "Whether the security posture can be overridden by the user."
}
},
"description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01",
"required": [
"id"
]
},
"SecurityPostureReferenceUpdate": {
"type": "object",
"properties": {
"id": {
"type": "string",
"description": "The security posture reference id in the form of /CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest"
},
"excludeExtensions": {
"type": "array",
"items": {
"type": "string"
},
"description": "The list of virtual machine extension names to exclude when applying the security posture."
},
"isOverridable": {
"type": "boolean",
"description": "Whether the security posture can be overridden by the user."
}
},
"description": "Specifies the security posture to be used for all virtual machines in the scale set. Minimum api-version: 2023-03-01"
"description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01"
}
}
}
14 changes: 14 additions & 0 deletions specification/compute/resource-manager/sdk-suppressions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
suppressions:
azure-sdk-for-python:
- package: azure-mgmt-compute
breaking-changes:
- Parameter id of model SecurityPostureReference is now required
azure-sdk-for-go:
- package: sdk/resourcemanager/compute/armcompute
breaking-changes:
- Type of `SecurityPostureReference.ExcludeExtensions` has been changed from `[]*VirtualMachineExtension` to `[]*string`
azure-sdk-for-js:
- package: "@azure/arm-compute"
breaking-changes:
- Parameter id of interface SecurityPostureReference is now required
- Type of parameter excludeExtensions of interface SecurityPostureReference is changed from VirtualMachineExtension[] to string[]