Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add undrainableNodeBehavior property #28919

Merged
merged 3 commits into from
May 6, 2024
Merged

add undrainableNodeBehavior property #28919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98462dc
add undrainableNodeBehavior property
zjpjack-github Apr 30, 2024
2020482
fix some spell errors
zjpjack-github Apr 30, 2024
f07e622
fix some grammer issues
zjpjack-github May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cSpell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,10 @@
"words": [
"vtpm",
"trustedlaunch",
"aksadvancednetworking"
"aksadvancednetworking",
"PDBs",
"undrainable",
"Undrainable"
]
},
{
Expand Down
22 changes: 22 additions & 0 deletions ...ce-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4728,6 +4728,28 @@
"minimum": 0,
"title": "The soak duration for a node",
"description": "The amount of time (in minutes) to wait after draining a node and before reimaging it and moving on to next node. If not specified, the default is 0 minutes."
},
"undrainableNodeBehavior": {
"type": "string",
"description": "Defines the behavior for undrainable nodes during upgrade. The most common cause of undrainable nodes is Pod Disruption Budgets (PDBs), but other issues, such as pod termination grace period is exceeding the remaining per-node drain timeout or pod is still being in a running state, can also cause undrainable nodes.",
"enum": [
"Schedule",
"Cordon"
],
"x-ms-enum": {
"name": "UndrainableNodeBehavior",
"modelAsString": true,
"values": [
{
"value": "Cordon",
"description": "AKS will cordon the blocked nodes and replace them with surge nodes during upgrade. The blocked nodes will be cordoned and replaced by surge nodes. The blocked nodes will have label 'kubernetes.azure.com/upgrade-status:Quarantined'. A surge node will be retained for each blocked node. A best-effort attempt will be made to delete all other surge nodes. If there are enough surge nodes to replace blocked nodes, then the upgrade operation and the managed cluster will be in failed state. Otherwise, the upgrade operation and the managed cluster will be in canceled state."
},
{
"value": "Schedule",
"description": "AKS will mark the blocked nodes schedulable, but the blocked nodes are not upgraded. A best-effort attempt will be made to delete all surge nodes. The upgrade operation and the managed cluster will be in failed state if there are any blocked nodes."
}
]
}
}
},
"description": "Settings for upgrading an agentpool"
Expand Down