-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Account Key Type and CogServices SKU Location #29025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced May 8, 2024
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
NotReadyForARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
labels
May 8, 2024
matferrari-msft
added
BreakingChange-Approved-BugFix
Changes are to correct the REST API definition to correctly describe service behavior
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
and removed
NotReadyForARMReview
labels
May 8, 2024
razvanbadea-msft
added
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
May 24, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
May 24, 2024
It is not used in the GA Swagger, no. It is used in the preview swagger. We had planned to support the resource type that used this definition in the GA swagger, but this was changed by PMs. |
matferrari-msft
removed
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Jun 4, 2024
openapi-pipeline-app
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jun 4, 2024
rkmanda
reviewed
Jun 9, 2024
...source-manager/Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json
Outdated
Show resolved
Hide resolved
rkmanda
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rkmanda
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
Jun 9, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jun 9, 2024
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Jun 11, 2024
* Account Key Type * Account key Preview Spec * "Sku Updates" * Remove Endpoint Type from Schema * Add x-ms-secret to account key property --------- Co-authored-by: Matthew Ferrari <124112629+matferrari-msft@users.noreply.github.com> Co-authored-by: Matthew Ferrari <matferrari@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Approved-BugFix
Changes are to correct the REST API definition to correctly describe service behavior
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.