Update jobs.json to latest generated swagger file as well as it's updated examples #2909

johnpaulkee · 2018-04-19T20:29:07Z

Summary

Updated sql readme.md to include jobs.json where necessary (will need confirmation if this is correctly placed)

Regenerated swagger to include job step and target executions, sku name and capacity support in agent createOrUpdate and get, as well as filter for top executions.

Job examples were updated to reflect correct json request and response paramters for agent and target group.

Review checklist

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

( I ran this: oav validate-spec jobs.json --azure-validator and it gave no errors were found )

AutorestCI · 2018-04-19T20:32:27Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2285

azuresdkciprbot · 2018-04-19T20:35:09Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 26 Error(s): 0
After the PR: Warning(s): 29 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-04-19T20:36:16Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#9

AutorestCI · 2018-04-19T20:36:28Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1858

AutorestCI · 2018-04-19T20:42:04Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2715

hovsepm · 2018-04-19T23:31:38Z

  "id": "1026",
  "code": "TypeChanged",
  "message": "The new version has a different type 'integer' than the previous one 'string'.",
  "jsonref": "#/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Sql~1servers~1{serverName}~1jobAgents~1{jobAgentName}~1executions/get/$skip",
  "json-path": "#/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/jobAgents/{jobAgentName}/executions/get/$skip",
  "type": "Error"

You are introducing breaking changes to all the generated client SDKs. Should this be combined with API version bump PR?

johnpaulkee · 2018-04-19T23:43:34Z

@hovsepm I think it's fine to keep this breaking change, but I think before we merge this PR I'll wait for @jaredmoo to sign off on this too since he's almost back from vacation.

jaredmoo · 2018-04-20T18:04:56Z

This API is not yet published in the SDK, so there is technically no breaking change here.

jaredmoo

Looks great, just undo readme.md plz

jaredmoo · 2018-04-20T18:07:06Z

specification/sql/resource-manager/readme.md

@@ -75,6 +75,7 @@ input-file:
 - Microsoft.Sql/preview/2017-03-01-preview/serverAutomaticTuning.json
 - Microsoft.Sql/preview/2017-03-01-preview/serverDnsAliases.json
 - Microsoft.Sql/preview/2017-03-01-preview/restorePoints.json
+- Microsoft.Sql/preview/2017-03-01-preview/jobs.json


Please don't add to readme.md until we are ready to publish SDK.

…e.md until ready to publish sdk

johnpaulkee · 2018-04-20T19:41:32Z

Undid readme.md, updating title to remove do not merge.

jaredmoo

Thanks!

azuresdkciprbot · 2018-04-20T19:46:26Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 26 Error(s): 0
After the PR: Warning(s): 26 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hovsepm · 2018-04-24T00:23:29Z

@johnpaulkee we will need ARM to sign off on the entire swagger spec. When are you planning to undergo API review?

jaredmoo · 2018-04-24T00:31:29Z

It has been reviewed internally by email and already lit up, but I don't think @ravbhatnagar has explicitly approved on github.

hovsepm · 2018-04-24T17:59:09Z

@ravbhatnagar could you take a look to the entire swagger? We never got a sign-off from ARM.

ravbhatnagar · 2018-04-25T22:46:26Z

specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/jobs.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/jobAgents/{jobAgentName}/jobs/{jobName}/executions/{jobExecutionId}/steps/{stepName}": {


GET on /targets or /steps returns the same entity - JobExecution?

Returns JobStepExecutions for /steps and JobTargetExecutions for /targets.
Returned model is similar, except TargetExecutions includes StepName and TargetId which helps identify which target this step (script) was run on.

ravbhatnagar · 2018-04-26T22:13:22Z

Signing off!

hovsepm · 2018-04-26T23:14:20Z

@johnpaulkee @jaredmoo Please add the readme.md changes back and keep this PR open until your service will be deployed and SDK's could be generated.

hovsepm · 2018-04-26T23:16:36Z

Also please fix linter error - https://travis-ci.org/Azure/azure-rest-api-specs/jobs/369280805

hovsepm · 2018-04-26T23:25:59Z

Please fix sample issues reported in sample validation - https://travis-ci.org/Azure/azure-rest-api-specs/jobs/369280815

jaredmoo · 2018-04-27T00:34:03Z

The linter error is expected. Operation API is defined in a different file (operations.json)

The Missing required property: password model errors are all bugs in validator. "Password" is a required write-only property and it is intentionally null in responses.

The tablename errors (e.g. https://travis-ci.org/Azure/azure-rest-api-specs/jobs/369280815#L900 ) might be legit. @johnpaulkee I'll let you check it out.

jaredmoo · 2018-04-27T00:40:29Z

Filed Azure/oav#239 for the OAV false positive.

…into v2_jobs_swagger

johnpaulkee · 2018-05-17T19:03:53Z

I believe I fixed the job step output example issues. Waiting on the build validation to confirm.
Also updated readme.md to include jobs.json.
@jaredmoo can you confirm if readme.md is correct?

johnpaulkee · 2018-05-17T19:05:55Z

I've also removed [Do not merge] from the title as we're intending on checking this in since we're getting close to public preview and we've received ARM sign off.

jaredmoo

Minor comments. Thanks!

jaredmoo · 2018-05-17T19:07:11Z

specification/sql/resource-manager/readme.md

@@ -51,6 +51,8 @@ Differences in v3 (compared to v2):
   - `+2017-10-01-preview/capabilities.json`
   - `+2017-10-01-preview/databases.json`
   - `+2017-10-01-preview/elasticPools.json`
+ - New SQL database agent APIs


This should not be a difference between v3 and v2, because jobs.json is in all composite version (v3, v2, v1)

In other words: please delete the new line 54 & 55 :)

You got it :)

jaredmoo · 2018-05-17T19:08:24Z

specification/sql/resource-manager/readme.md

@@ -287,6 +292,7 @@ input-file:
 - Microsoft.Sql/preview/2017-03-01-preview/serverAutomaticTuning.json
 - Microsoft.Sql/preview/2017-03-01-preview/serverDnsAliases.json
 - Microsoft.Sql/preview/2017-03-01-preview/restorePoints.json
+- Microsoft.Sql/preview/2017-03-01-preview/jobs.json


please keep in alphabetical order (in all the sections you added to)

Will update to be in alphabetical order.

…in it's 2017-03-01-preview regions as well as removed comment for difference between v3 and v2

johnpaulkee · 2018-05-17T20:16:21Z

Updated based on feedback from @jaredmoo.
@hovsepm when you get a chance can you review once more?
We're ready to publish this :)

azuresdkci assigned hovsepm Apr 19, 2018

azuresdkci requested a review from hovsepm April 19, 2018 20:30

AutorestCI mentioned this pull request Apr 19, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Update jobs.json to latest generated swagger file as well as it's updated examples Azure/azure-sdk-for-python#2433

Closed

AutorestCI mentioned this pull request Apr 19, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Update jobs.json to latest generated swagger file as well as it's updated examples AutorestCI/azure-libraries-for-java#95

Merged

AutorestCI mentioned this pull request Apr 19, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Update jobs.json to latest generated swagger file as well as it's updated examples Azure/azure-sdk-for-node#2764

Merged

jaredmoo suggested changes Apr 20, 2018

View reviewed changes

Updates to jobs.json as well as examples, this time keeping out readm…

734f2e9

…e.md until ready to publish sdk

johnpaulkee changed the title ~~[DO NOT MERGE] Update jobs.json to latest generated swagger file as well as it's updated examples~~ Update jobs.json to latest generated swagger file as well as it's updated examples Apr 20, 2018

jaredmoo approved these changes Apr 20, 2018

View reviewed changes

hovsepm added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 24, 2018

hovsepm added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 24, 2018

ravbhatnagar reviewed Apr 25, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 26, 2018

johnpaulkee changed the title ~~Update jobs.json to latest generated swagger file as well as it's updated examples~~ [Do not merge - Waiting for public preview] Update jobs.json to latest generated swagger file as well as it's updated examples Apr 27, 2018

John Paul Kee added 2 commits May 17, 2018 10:27

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

457eb46

…into v2_jobs_swagger

Updated readme.md to include jobs.json. Fixed job step output examples

748aec0

johnpaulkee changed the title ~~[Do not merge - Waiting for public preview] Update jobs.json to latest generated swagger file as well as it's updated examples~~ Update jobs.json to latest generated swagger file as well as it's updated examples May 17, 2018

AutorestCI mentioned this pull request May 17, 2018

[AutoPR sql/resource-manager] [Do not merge - Waiting for public preview] Update jobs.json to latest generated swagger file as well as it's updated examples Azure/azure-sdk-for-go#1855

Merged

jaredmoo approved these changes May 17, 2018

View reviewed changes

Fixing readme.md based on feedback. Ordered jobs.json alphabetically …

a74684b

…in it's 2017-03-01-preview regions as well as removed comment for difference between v3 and v2

hovsepm removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 17, 2018

hovsepm approved these changes May 17, 2018

View reviewed changes

hovsepm merged commit cf93d01 into Azure:master May 17, 2018

johnpaulkee mentioned this pull request May 18, 2018

Introduce public preview SQL Database Agent .NET SDK Azure/azure-sdk-for-net#4340

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update jobs.json to latest generated swagger file as well as it's updated examples #2909

Update jobs.json to latest generated swagger file as well as it's updated examples #2909

johnpaulkee commented Apr 19, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 19, 2018 •

edited

Loading

azuresdkciprbot commented Apr 19, 2018

AutorestCI commented Apr 19, 2018 •

edited

Loading

AutorestCI commented Apr 19, 2018 •

edited

Loading

AutorestCI commented Apr 19, 2018 •

edited

Loading

hovsepm commented Apr 19, 2018

johnpaulkee commented Apr 19, 2018

jaredmoo commented Apr 20, 2018

jaredmoo left a comment

jaredmoo Apr 20, 2018

johnpaulkee commented Apr 20, 2018

jaredmoo left a comment

azuresdkciprbot commented Apr 20, 2018

hovsepm commented Apr 24, 2018

jaredmoo commented Apr 24, 2018

hovsepm commented Apr 24, 2018

ravbhatnagar Apr 25, 2018

johnpaulkee Apr 26, 2018

ravbhatnagar commented Apr 26, 2018

hovsepm commented Apr 26, 2018

hovsepm commented Apr 26, 2018

hovsepm commented Apr 26, 2018

jaredmoo commented Apr 27, 2018

jaredmoo commented Apr 27, 2018

johnpaulkee commented May 17, 2018

johnpaulkee commented May 17, 2018

jaredmoo left a comment

jaredmoo May 17, 2018

jaredmoo May 17, 2018

johnpaulkee May 17, 2018

jaredmoo May 17, 2018

johnpaulkee May 17, 2018

johnpaulkee commented May 17, 2018

Update jobs.json to latest generated swagger file as well as it's updated examples #2909

Update jobs.json to latest generated swagger file as well as it's updated examples #2909

Conversation

johnpaulkee commented Apr 19, 2018 • edited by azuresdkci Loading

Summary

Review checklist

PR information

Quality of Swagger

AutorestCI commented Apr 19, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkciprbot commented Apr 19, 2018

AutorestCI commented Apr 19, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 19, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Apr 19, 2018 • edited Loading

Automation for azure-sdk-for-node

hovsepm commented Apr 19, 2018

johnpaulkee commented Apr 19, 2018

jaredmoo commented Apr 20, 2018

jaredmoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnpaulkee commented Apr 20, 2018

jaredmoo left a comment

Choose a reason for hiding this comment

azuresdkciprbot commented Apr 20, 2018

hovsepm commented Apr 24, 2018

jaredmoo commented Apr 24, 2018

hovsepm commented Apr 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravbhatnagar commented Apr 26, 2018

hovsepm commented Apr 26, 2018

hovsepm commented Apr 26, 2018

hovsepm commented Apr 26, 2018

jaredmoo commented Apr 27, 2018

jaredmoo commented Apr 27, 2018

johnpaulkee commented May 17, 2018

johnpaulkee commented May 17, 2018

jaredmoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnpaulkee commented May 17, 2018

johnpaulkee commented Apr 19, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 19, 2018 •

edited

Loading

AutorestCI commented Apr 19, 2018 •

edited

Loading

AutorestCI commented Apr 19, 2018 •

edited

Loading

AutorestCI commented Apr 19, 2018 •

edited

Loading